Carl-Daniel Hailfinger | a84835a | 2010-01-07 03:24:05 +0000 | [diff] [blame] | 1 | /* |
| 2 | * This file is part of the flashrom project. |
| 3 | * |
| 4 | * Copyright (C) 2000 Silicon Integrated System Corporation |
| 5 | * Copyright (C) 2004 Tyan Corp <yhlu@tyan.com> |
| 6 | * Copyright (C) 2005-2008 coresystems GmbH |
| 7 | * Copyright (C) 2008,2009,2010 Carl-Daniel Hailfinger |
| 8 | * |
| 9 | * This program is free software; you can redistribute it and/or modify |
| 10 | * it under the terms of the GNU General Public License as published by |
| 11 | * the Free Software Foundation; either version 2 of the License, or |
| 12 | * (at your option) any later version. |
| 13 | * |
| 14 | * This program is distributed in the hope that it will be useful, |
| 15 | * but WITHOUT ANY WARRANTY; without even the implied warranty of |
| 16 | * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the |
| 17 | * GNU General Public License for more details. |
| 18 | * |
| 19 | * You should have received a copy of the GNU General Public License |
| 20 | * along with this program; if not, write to the Free Software |
| 21 | * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA |
| 22 | */ |
| 23 | |
Carl-Daniel Hailfinger | 831e8f4 | 2010-05-30 22:24:40 +0000 | [diff] [blame] | 24 | #include <stdio.h> |
Carl-Daniel Hailfinger | a84835a | 2010-01-07 03:24:05 +0000 | [diff] [blame] | 25 | #include <fcntl.h> |
Carl-Daniel Hailfinger | a84835a | 2010-01-07 03:24:05 +0000 | [diff] [blame] | 26 | #include <sys/stat.h> |
| 27 | #include <string.h> |
| 28 | #include <stdlib.h> |
| 29 | #include <getopt.h> |
| 30 | #include "flash.h" |
| 31 | #include "flashchips.h" |
Carl-Daniel Hailfinger | 5b997c3 | 2010-07-27 22:41:39 +0000 | [diff] [blame] | 32 | #include "programmer.h" |
Carl-Daniel Hailfinger | a84835a | 2010-01-07 03:24:05 +0000 | [diff] [blame] | 33 | |
Carl-Daniel Hailfinger | ad3cc55 | 2010-07-03 11:02:10 +0000 | [diff] [blame] | 34 | static void cli_classic_usage(const char *name) |
Carl-Daniel Hailfinger | a84835a | 2010-01-07 03:24:05 +0000 | [diff] [blame] | 35 | { |
Stefan Tauner | b226cb1 | 2012-11-24 18:59:39 +0000 | [diff] [blame] | 36 | printf("Please note that the command line interface for flashrom has changed between\n" |
| 37 | "0.9.5 and 0.9.6 and will change again before flashrom 1.0.\n\n"); |
| 38 | |
| 39 | printf("Usage: %s [-h|-R|-L|" |
Carl-Daniel Hailfinger | 7112772 | 2010-05-31 15:27:27 +0000 | [diff] [blame] | 40 | #if CONFIG_PRINT_WIKI == 1 |
Stefan Tauner | b226cb1 | 2012-11-24 18:59:39 +0000 | [diff] [blame] | 41 | "-z|" |
Carl-Daniel Hailfinger | a84835a | 2010-01-07 03:24:05 +0000 | [diff] [blame] | 42 | #endif |
Stefan Tauner | b226cb1 | 2012-11-24 18:59:39 +0000 | [diff] [blame] | 43 | "-p <programmername>[:<parameters>] [-c <chipname>]\n" |
| 44 | "[-E|(-r|-w|-v) <file>] [-l <layoutfile> [-i <imagename>]...] [-n] [-f]]\n" |
| 45 | "[-V[V[V]]] [-o <logfile>]\n\n", name); |
Carl-Daniel Hailfinger | 8841d3e | 2010-05-15 15:04:37 +0000 | [diff] [blame] | 46 | |
Stefan Tauner | b226cb1 | 2012-11-24 18:59:39 +0000 | [diff] [blame] | 47 | printf(" -h | --help print this help text\n" |
| 48 | " -R | --version print version (release)\n" |
| 49 | " -r | --read <file> read flash and save to <file>\n" |
| 50 | " -w | --write <file> write <file> to flash\n" |
| 51 | " -v | --verify <file> verify flash against <file>\n" |
| 52 | " -E | --erase erase flash memory\n" |
| 53 | " -V | --verbose more verbose output\n" |
| 54 | " -c | --chip <chipname> probe only for specified flash chip\n" |
| 55 | " -f | --force force specific operations (see man page)\n" |
| 56 | " -n | --noverify don't auto-verify\n" |
| 57 | " -l | --layout <layoutfile> read ROM layout from <layoutfile>\n" |
| 58 | " -i | --image <name> only flash image <name> from flash layout\n" |
| 59 | " -o | --output <logfile> log output to <logfile>\n" |
| 60 | " -L | --list-supported print supported devices\n" |
Carl-Daniel Hailfinger | 7112772 | 2010-05-31 15:27:27 +0000 | [diff] [blame] | 61 | #if CONFIG_PRINT_WIKI == 1 |
Stefan Tauner | b226cb1 | 2012-11-24 18:59:39 +0000 | [diff] [blame] | 62 | " -z | --list-supported-wiki print supported devices in wiki syntax\n" |
Carl-Daniel Hailfinger | 8841d3e | 2010-05-15 15:04:37 +0000 | [diff] [blame] | 63 | #endif |
Stefan Tauner | b226cb1 | 2012-11-24 18:59:39 +0000 | [diff] [blame] | 64 | " -p | --programmer <name>[:<param>] specify the programmer device. One of\n"); |
| 65 | list_programmers_linebreak(4, 80, 0); |
| 66 | printf(".\n\nYou can specify one of -h, -R, -L, " |
Carl-Daniel Hailfinger | 7112772 | 2010-05-31 15:27:27 +0000 | [diff] [blame] | 67 | #if CONFIG_PRINT_WIKI == 1 |
Carl-Daniel Hailfinger | 8841d3e | 2010-05-15 15:04:37 +0000 | [diff] [blame] | 68 | "-z, " |
| 69 | #endif |
| 70 | "-E, -r, -w, -v or no operation.\n" |
Stefan Tauner | b226cb1 | 2012-11-24 18:59:39 +0000 | [diff] [blame] | 71 | "If no operation is specified, flashrom will only probe for flash chips.\n"); |
Carl-Daniel Hailfinger | 8841d3e | 2010-05-15 15:04:37 +0000 | [diff] [blame] | 72 | } |
| 73 | |
Carl-Daniel Hailfinger | ad3cc55 | 2010-07-03 11:02:10 +0000 | [diff] [blame] | 74 | static void cli_classic_abort_usage(void) |
Carl-Daniel Hailfinger | 8841d3e | 2010-05-15 15:04:37 +0000 | [diff] [blame] | 75 | { |
Uwe Hermann | 2db77a0 | 2010-06-04 17:07:39 +0000 | [diff] [blame] | 76 | printf("Please run \"flashrom --help\" for usage info.\n"); |
Carl-Daniel Hailfinger | a84835a | 2010-01-07 03:24:05 +0000 | [diff] [blame] | 77 | exit(1); |
| 78 | } |
| 79 | |
Carl-Daniel Hailfinger | 901a3ba | 2012-05-14 22:54:58 +0000 | [diff] [blame] | 80 | static int check_filename(char *filename, char *type) |
| 81 | { |
| 82 | if (!filename || (filename[0] == '\0')) { |
| 83 | fprintf(stderr, "Error: No %s file specified.\n", type); |
| 84 | return 1; |
| 85 | } |
| 86 | /* Not an error, but maybe the user intended to specify a CLI option instead of a file name. */ |
| 87 | if (filename[0] == '-') |
| 88 | fprintf(stderr, "Warning: Supplied %s file name starts with -\n", type); |
| 89 | return 0; |
| 90 | } |
| 91 | |
Uwe Hermann | 394ee78 | 2011-08-20 14:14:22 +0000 | [diff] [blame] | 92 | int main(int argc, char *argv[]) |
Carl-Daniel Hailfinger | a84835a | 2010-01-07 03:24:05 +0000 | [diff] [blame] | 93 | { |
| 94 | unsigned long size; |
| 95 | /* Probe for up to three flash chips. */ |
Carl-Daniel Hailfinger | 5a7cb84 | 2012-08-25 01:17:58 +0000 | [diff] [blame] | 96 | const struct flashchip *chip = NULL; |
| 97 | struct flashctx flashes[3] = {{0}}; |
Carl-Daniel Hailfinger | 63fd902 | 2011-12-14 22:25:15 +0000 | [diff] [blame] | 98 | struct flashctx *fill_flash; |
Carl-Daniel Hailfinger | a84835a | 2010-01-07 03:24:05 +0000 | [diff] [blame] | 99 | const char *name; |
Carl-Daniel Hailfinger | c40cff7 | 2011-12-20 00:19:29 +0000 | [diff] [blame] | 100 | int namelen, opt, i, j; |
Carl-Daniel Hailfinger | b428e97 | 2012-02-16 20:31:25 +0000 | [diff] [blame] | 101 | int startchip = -1, chipcount = 0, option_index = 0, force = 0; |
Carl-Daniel Hailfinger | 7112772 | 2010-05-31 15:27:27 +0000 | [diff] [blame] | 102 | #if CONFIG_PRINT_WIKI == 1 |
Carl-Daniel Hailfinger | a84835a | 2010-01-07 03:24:05 +0000 | [diff] [blame] | 103 | int list_supported_wiki = 0; |
| 104 | #endif |
Carl-Daniel Hailfinger | 082c8b5 | 2011-08-15 19:54:20 +0000 | [diff] [blame] | 105 | int read_it = 0, write_it = 0, erase_it = 0, verify_it = 0; |
| 106 | int dont_verify_it = 0, list_supported = 0, operation_specified = 0; |
Carl-Daniel Hailfinger | 2e68160 | 2011-09-08 00:00:29 +0000 | [diff] [blame] | 107 | enum programmer prog = PROGRAMMER_INVALID; |
Carl-Daniel Hailfinger | 082c8b5 | 2011-08-15 19:54:20 +0000 | [diff] [blame] | 108 | int ret = 0; |
Carl-Daniel Hailfinger | a84835a | 2010-01-07 03:24:05 +0000 | [diff] [blame] | 109 | |
Carl-Daniel Hailfinger | 1c15548 | 2012-06-06 09:17:06 +0000 | [diff] [blame] | 110 | static const char optstring[] = "r:Rw:v:nVEfc:l:i:p:Lzho:"; |
Mathias Krause | a60faab | 2011-01-17 07:50:42 +0000 | [diff] [blame] | 111 | static const struct option long_options[] = { |
Uwe Hermann | 91f4afa | 2011-07-28 08:13:25 +0000 | [diff] [blame] | 112 | {"read", 1, NULL, 'r'}, |
| 113 | {"write", 1, NULL, 'w'}, |
| 114 | {"erase", 0, NULL, 'E'}, |
| 115 | {"verify", 1, NULL, 'v'}, |
| 116 | {"noverify", 0, NULL, 'n'}, |
| 117 | {"chip", 1, NULL, 'c'}, |
Uwe Hermann | 91f4afa | 2011-07-28 08:13:25 +0000 | [diff] [blame] | 118 | {"verbose", 0, NULL, 'V'}, |
| 119 | {"force", 0, NULL, 'f'}, |
| 120 | {"layout", 1, NULL, 'l'}, |
| 121 | {"image", 1, NULL, 'i'}, |
| 122 | {"list-supported", 0, NULL, 'L'}, |
| 123 | {"list-supported-wiki", 0, NULL, 'z'}, |
| 124 | {"programmer", 1, NULL, 'p'}, |
| 125 | {"help", 0, NULL, 'h'}, |
| 126 | {"version", 0, NULL, 'R'}, |
Carl-Daniel Hailfinger | 1c15548 | 2012-06-06 09:17:06 +0000 | [diff] [blame] | 127 | {"output", 1, NULL, 'o'}, |
Uwe Hermann | 91f4afa | 2011-07-28 08:13:25 +0000 | [diff] [blame] | 128 | {NULL, 0, NULL, 0}, |
Carl-Daniel Hailfinger | a84835a | 2010-01-07 03:24:05 +0000 | [diff] [blame] | 129 | }; |
| 130 | |
| 131 | char *filename = NULL; |
Carl-Daniel Hailfinger | 4628445 | 2012-01-11 02:10:11 +0000 | [diff] [blame] | 132 | char *layoutfile = NULL; |
Carl-Daniel Hailfinger | 1c15548 | 2012-06-06 09:17:06 +0000 | [diff] [blame] | 133 | char *logfile = NULL; |
Carl-Daniel Hailfinger | a84835a | 2010-01-07 03:24:05 +0000 | [diff] [blame] | 134 | char *tempstr = NULL; |
Carl-Daniel Hailfinger | ad3cc55 | 2010-07-03 11:02:10 +0000 | [diff] [blame] | 135 | char *pparam = NULL; |
Carl-Daniel Hailfinger | a84835a | 2010-01-07 03:24:05 +0000 | [diff] [blame] | 136 | |
| 137 | print_version(); |
Carl-Daniel Hailfinger | 8841d3e | 2010-05-15 15:04:37 +0000 | [diff] [blame] | 138 | print_banner(); |
Carl-Daniel Hailfinger | a84835a | 2010-01-07 03:24:05 +0000 | [diff] [blame] | 139 | |
| 140 | if (selfcheck()) |
| 141 | exit(1); |
| 142 | |
| 143 | setbuf(stdout, NULL); |
Carl-Daniel Hailfinger | 8841d3e | 2010-05-15 15:04:37 +0000 | [diff] [blame] | 144 | /* FIXME: Delay all operation_specified checks until after command |
| 145 | * line parsing to allow --help overriding everything else. |
| 146 | */ |
Carl-Daniel Hailfinger | a84835a | 2010-01-07 03:24:05 +0000 | [diff] [blame] | 147 | while ((opt = getopt_long(argc, argv, optstring, |
| 148 | long_options, &option_index)) != EOF) { |
| 149 | switch (opt) { |
| 150 | case 'r': |
| 151 | if (++operation_specified > 1) { |
| 152 | fprintf(stderr, "More than one operation " |
| 153 | "specified. Aborting.\n"); |
Uwe Hermann | 2db77a0 | 2010-06-04 17:07:39 +0000 | [diff] [blame] | 154 | cli_classic_abort_usage(); |
Carl-Daniel Hailfinger | a84835a | 2010-01-07 03:24:05 +0000 | [diff] [blame] | 155 | } |
Carl-Daniel Hailfinger | 8841d3e | 2010-05-15 15:04:37 +0000 | [diff] [blame] | 156 | filename = strdup(optarg); |
Carl-Daniel Hailfinger | a84835a | 2010-01-07 03:24:05 +0000 | [diff] [blame] | 157 | read_it = 1; |
| 158 | break; |
| 159 | case 'w': |
| 160 | if (++operation_specified > 1) { |
| 161 | fprintf(stderr, "More than one operation " |
| 162 | "specified. Aborting.\n"); |
Uwe Hermann | 2db77a0 | 2010-06-04 17:07:39 +0000 | [diff] [blame] | 163 | cli_classic_abort_usage(); |
Carl-Daniel Hailfinger | a84835a | 2010-01-07 03:24:05 +0000 | [diff] [blame] | 164 | } |
Carl-Daniel Hailfinger | 8841d3e | 2010-05-15 15:04:37 +0000 | [diff] [blame] | 165 | filename = strdup(optarg); |
Carl-Daniel Hailfinger | a84835a | 2010-01-07 03:24:05 +0000 | [diff] [blame] | 166 | write_it = 1; |
| 167 | break; |
| 168 | case 'v': |
| 169 | //FIXME: gracefully handle superfluous -v |
| 170 | if (++operation_specified > 1) { |
| 171 | fprintf(stderr, "More than one operation " |
| 172 | "specified. Aborting.\n"); |
Uwe Hermann | 2db77a0 | 2010-06-04 17:07:39 +0000 | [diff] [blame] | 173 | cli_classic_abort_usage(); |
Carl-Daniel Hailfinger | a84835a | 2010-01-07 03:24:05 +0000 | [diff] [blame] | 174 | } |
| 175 | if (dont_verify_it) { |
| 176 | fprintf(stderr, "--verify and --noverify are" |
| 177 | "mutually exclusive. Aborting.\n"); |
Uwe Hermann | 2db77a0 | 2010-06-04 17:07:39 +0000 | [diff] [blame] | 178 | cli_classic_abort_usage(); |
Carl-Daniel Hailfinger | a84835a | 2010-01-07 03:24:05 +0000 | [diff] [blame] | 179 | } |
Carl-Daniel Hailfinger | 8841d3e | 2010-05-15 15:04:37 +0000 | [diff] [blame] | 180 | filename = strdup(optarg); |
Carl-Daniel Hailfinger | a84835a | 2010-01-07 03:24:05 +0000 | [diff] [blame] | 181 | verify_it = 1; |
| 182 | break; |
| 183 | case 'n': |
| 184 | if (verify_it) { |
| 185 | fprintf(stderr, "--verify and --noverify are" |
| 186 | "mutually exclusive. Aborting.\n"); |
Uwe Hermann | 2db77a0 | 2010-06-04 17:07:39 +0000 | [diff] [blame] | 187 | cli_classic_abort_usage(); |
Carl-Daniel Hailfinger | a84835a | 2010-01-07 03:24:05 +0000 | [diff] [blame] | 188 | } |
| 189 | dont_verify_it = 1; |
| 190 | break; |
| 191 | case 'c': |
| 192 | chip_to_probe = strdup(optarg); |
| 193 | break; |
| 194 | case 'V': |
Carl-Daniel Hailfinger | 1c15548 | 2012-06-06 09:17:06 +0000 | [diff] [blame] | 195 | verbose_screen++; |
| 196 | if (verbose_screen > MSG_DEBUG2) |
| 197 | verbose_logfile = verbose_screen; |
Carl-Daniel Hailfinger | a84835a | 2010-01-07 03:24:05 +0000 | [diff] [blame] | 198 | break; |
| 199 | case 'E': |
| 200 | if (++operation_specified > 1) { |
| 201 | fprintf(stderr, "More than one operation " |
| 202 | "specified. Aborting.\n"); |
Uwe Hermann | 2db77a0 | 2010-06-04 17:07:39 +0000 | [diff] [blame] | 203 | cli_classic_abort_usage(); |
Carl-Daniel Hailfinger | a84835a | 2010-01-07 03:24:05 +0000 | [diff] [blame] | 204 | } |
| 205 | erase_it = 1; |
| 206 | break; |
Carl-Daniel Hailfinger | a84835a | 2010-01-07 03:24:05 +0000 | [diff] [blame] | 207 | case 'f': |
| 208 | force = 1; |
| 209 | break; |
| 210 | case 'l': |
Carl-Daniel Hailfinger | 4628445 | 2012-01-11 02:10:11 +0000 | [diff] [blame] | 211 | if (layoutfile) { |
| 212 | fprintf(stderr, "Error: --layout specified " |
| 213 | "more than once. Aborting.\n"); |
Uwe Hermann | 2db77a0 | 2010-06-04 17:07:39 +0000 | [diff] [blame] | 214 | cli_classic_abort_usage(); |
Carl-Daniel Hailfinger | 4628445 | 2012-01-11 02:10:11 +0000 | [diff] [blame] | 215 | } |
| 216 | layoutfile = strdup(optarg); |
Carl-Daniel Hailfinger | a84835a | 2010-01-07 03:24:05 +0000 | [diff] [blame] | 217 | break; |
| 218 | case 'i': |
| 219 | tempstr = strdup(optarg); |
Louis Yung-Chieh Lo | 9bcf268 | 2011-12-25 09:12:16 +0000 | [diff] [blame] | 220 | if (register_include_arg(tempstr)) |
Carl-Daniel Hailfinger | d566014 | 2011-07-15 23:47:45 +0000 | [diff] [blame] | 221 | cli_classic_abort_usage(); |
Carl-Daniel Hailfinger | a84835a | 2010-01-07 03:24:05 +0000 | [diff] [blame] | 222 | break; |
| 223 | case 'L': |
Carl-Daniel Hailfinger | 8841d3e | 2010-05-15 15:04:37 +0000 | [diff] [blame] | 224 | if (++operation_specified > 1) { |
| 225 | fprintf(stderr, "More than one operation " |
| 226 | "specified. Aborting.\n"); |
Uwe Hermann | 2db77a0 | 2010-06-04 17:07:39 +0000 | [diff] [blame] | 227 | cli_classic_abort_usage(); |
Carl-Daniel Hailfinger | 8841d3e | 2010-05-15 15:04:37 +0000 | [diff] [blame] | 228 | } |
Carl-Daniel Hailfinger | a84835a | 2010-01-07 03:24:05 +0000 | [diff] [blame] | 229 | list_supported = 1; |
| 230 | break; |
Carl-Daniel Hailfinger | a84835a | 2010-01-07 03:24:05 +0000 | [diff] [blame] | 231 | case 'z': |
Carl-Daniel Hailfinger | 7112772 | 2010-05-31 15:27:27 +0000 | [diff] [blame] | 232 | #if CONFIG_PRINT_WIKI == 1 |
Carl-Daniel Hailfinger | 8841d3e | 2010-05-15 15:04:37 +0000 | [diff] [blame] | 233 | if (++operation_specified > 1) { |
| 234 | fprintf(stderr, "More than one operation " |
| 235 | "specified. Aborting.\n"); |
Uwe Hermann | 2db77a0 | 2010-06-04 17:07:39 +0000 | [diff] [blame] | 236 | cli_classic_abort_usage(); |
Carl-Daniel Hailfinger | 8841d3e | 2010-05-15 15:04:37 +0000 | [diff] [blame] | 237 | } |
Carl-Daniel Hailfinger | a84835a | 2010-01-07 03:24:05 +0000 | [diff] [blame] | 238 | list_supported_wiki = 1; |
Carl-Daniel Hailfinger | 8841d3e | 2010-05-15 15:04:37 +0000 | [diff] [blame] | 239 | #else |
| 240 | fprintf(stderr, "Error: Wiki output was not compiled " |
| 241 | "in. Aborting.\n"); |
Uwe Hermann | 2db77a0 | 2010-06-04 17:07:39 +0000 | [diff] [blame] | 242 | cli_classic_abort_usage(); |
Carl-Daniel Hailfinger | a84835a | 2010-01-07 03:24:05 +0000 | [diff] [blame] | 243 | #endif |
Carl-Daniel Hailfinger | 8841d3e | 2010-05-15 15:04:37 +0000 | [diff] [blame] | 244 | break; |
Carl-Daniel Hailfinger | a84835a | 2010-01-07 03:24:05 +0000 | [diff] [blame] | 245 | case 'p': |
Carl-Daniel Hailfinger | 2e68160 | 2011-09-08 00:00:29 +0000 | [diff] [blame] | 246 | if (prog != PROGRAMMER_INVALID) { |
| 247 | fprintf(stderr, "Error: --programmer specified " |
| 248 | "more than once. You can separate " |
| 249 | "multiple\nparameters for a programmer " |
| 250 | "with \",\". Please see the man page " |
| 251 | "for details.\n"); |
| 252 | cli_classic_abort_usage(); |
| 253 | } |
| 254 | for (prog = 0; prog < PROGRAMMER_INVALID; prog++) { |
| 255 | name = programmer_table[prog].name; |
Carl-Daniel Hailfinger | a84835a | 2010-01-07 03:24:05 +0000 | [diff] [blame] | 256 | namelen = strlen(name); |
| 257 | if (strncmp(optarg, name, namelen) == 0) { |
| 258 | switch (optarg[namelen]) { |
| 259 | case ':': |
Carl-Daniel Hailfinger | ad3cc55 | 2010-07-03 11:02:10 +0000 | [diff] [blame] | 260 | pparam = strdup(optarg + namelen + 1); |
| 261 | if (!strlen(pparam)) { |
| 262 | free(pparam); |
| 263 | pparam = NULL; |
Carl-Daniel Hailfinger | 2702376 | 2010-04-28 15:22:14 +0000 | [diff] [blame] | 264 | } |
Carl-Daniel Hailfinger | a84835a | 2010-01-07 03:24:05 +0000 | [diff] [blame] | 265 | break; |
| 266 | case '\0': |
| 267 | break; |
| 268 | default: |
| 269 | /* The continue refers to the |
| 270 | * for loop. It is here to be |
| 271 | * able to differentiate between |
| 272 | * foo and foobar. |
| 273 | */ |
| 274 | continue; |
| 275 | } |
| 276 | break; |
| 277 | } |
| 278 | } |
Carl-Daniel Hailfinger | 2e68160 | 2011-09-08 00:00:29 +0000 | [diff] [blame] | 279 | if (prog == PROGRAMMER_INVALID) { |
Carl-Daniel Hailfinger | 4e3391f | 2012-07-22 12:01:43 +0000 | [diff] [blame] | 280 | fprintf(stderr, "Error: Unknown programmer \"%s\". Valid choices are:\n", |
| 281 | optarg); |
| 282 | list_programmers_linebreak(0, 80, 0); |
Stefan Tauner | b226cb1 | 2012-11-24 18:59:39 +0000 | [diff] [blame] | 283 | msg_ginfo(".\n"); |
Uwe Hermann | 2db77a0 | 2010-06-04 17:07:39 +0000 | [diff] [blame] | 284 | cli_classic_abort_usage(); |
Carl-Daniel Hailfinger | a84835a | 2010-01-07 03:24:05 +0000 | [diff] [blame] | 285 | } |
| 286 | break; |
| 287 | case 'R': |
| 288 | /* print_version() is always called during startup. */ |
Carl-Daniel Hailfinger | 8841d3e | 2010-05-15 15:04:37 +0000 | [diff] [blame] | 289 | if (++operation_specified > 1) { |
| 290 | fprintf(stderr, "More than one operation " |
| 291 | "specified. Aborting.\n"); |
Uwe Hermann | 2db77a0 | 2010-06-04 17:07:39 +0000 | [diff] [blame] | 292 | cli_classic_abort_usage(); |
Carl-Daniel Hailfinger | 8841d3e | 2010-05-15 15:04:37 +0000 | [diff] [blame] | 293 | } |
Carl-Daniel Hailfinger | a84835a | 2010-01-07 03:24:05 +0000 | [diff] [blame] | 294 | exit(0); |
| 295 | break; |
| 296 | case 'h': |
Carl-Daniel Hailfinger | 8841d3e | 2010-05-15 15:04:37 +0000 | [diff] [blame] | 297 | if (++operation_specified > 1) { |
| 298 | fprintf(stderr, "More than one operation " |
| 299 | "specified. Aborting.\n"); |
Uwe Hermann | 2db77a0 | 2010-06-04 17:07:39 +0000 | [diff] [blame] | 300 | cli_classic_abort_usage(); |
Carl-Daniel Hailfinger | 8841d3e | 2010-05-15 15:04:37 +0000 | [diff] [blame] | 301 | } |
Carl-Daniel Hailfinger | a84835a | 2010-01-07 03:24:05 +0000 | [diff] [blame] | 302 | cli_classic_usage(argv[0]); |
Carl-Daniel Hailfinger | 8841d3e | 2010-05-15 15:04:37 +0000 | [diff] [blame] | 303 | exit(0); |
| 304 | break; |
Carl-Daniel Hailfinger | 1c15548 | 2012-06-06 09:17:06 +0000 | [diff] [blame] | 305 | case 'o': |
| 306 | #ifdef STANDALONE |
| 307 | fprintf(stderr, "Log file not supported in standalone mode. Aborting.\n"); |
| 308 | cli_classic_abort_usage(); |
| 309 | #else /* STANDALONE */ |
| 310 | logfile = strdup(optarg); |
| 311 | if (logfile[0] == '\0') { |
| 312 | fprintf(stderr, "No log filename specified.\n"); |
| 313 | cli_classic_abort_usage(); |
| 314 | } |
| 315 | #endif /* STANDALONE */ |
| 316 | break; |
Carl-Daniel Hailfinger | 8841d3e | 2010-05-15 15:04:37 +0000 | [diff] [blame] | 317 | default: |
Uwe Hermann | 2db77a0 | 2010-06-04 17:07:39 +0000 | [diff] [blame] | 318 | cli_classic_abort_usage(); |
Carl-Daniel Hailfinger | a84835a | 2010-01-07 03:24:05 +0000 | [diff] [blame] | 319 | break; |
| 320 | } |
| 321 | } |
| 322 | |
Carl-Daniel Hailfinger | d566014 | 2011-07-15 23:47:45 +0000 | [diff] [blame] | 323 | if (optind < argc) { |
| 324 | fprintf(stderr, "Error: Extra parameter found.\n"); |
| 325 | cli_classic_abort_usage(); |
| 326 | } |
| 327 | |
Carl-Daniel Hailfinger | 901a3ba | 2012-05-14 22:54:58 +0000 | [diff] [blame] | 328 | if ((read_it | write_it | verify_it) && check_filename(filename, "image")) { |
| 329 | cli_classic_abort_usage(); |
| 330 | } |
| 331 | if (layoutfile && check_filename(layoutfile, "layout")) { |
| 332 | cli_classic_abort_usage(); |
Carl-Daniel Hailfinger | a84835a | 2010-01-07 03:24:05 +0000 | [diff] [blame] | 333 | } |
| 334 | |
Carl-Daniel Hailfinger | 1c15548 | 2012-06-06 09:17:06 +0000 | [diff] [blame] | 335 | #ifndef STANDALONE |
| 336 | if (logfile && check_filename(logfile, "log")) |
| 337 | cli_classic_abort_usage(); |
| 338 | if (logfile && open_logfile(logfile)) |
| 339 | return 1; |
| 340 | #endif /* !STANDALONE */ |
| 341 | |
Carl-Daniel Hailfinger | 7112772 | 2010-05-31 15:27:27 +0000 | [diff] [blame] | 342 | #if CONFIG_PRINT_WIKI == 1 |
Carl-Daniel Hailfinger | a84835a | 2010-01-07 03:24:05 +0000 | [diff] [blame] | 343 | if (list_supported_wiki) { |
| 344 | print_supported_wiki(); |
Carl-Daniel Hailfinger | 901a3ba | 2012-05-14 22:54:58 +0000 | [diff] [blame] | 345 | goto out; |
Carl-Daniel Hailfinger | a84835a | 2010-01-07 03:24:05 +0000 | [diff] [blame] | 346 | } |
| 347 | #endif |
| 348 | |
Carl-Daniel Hailfinger | 901a3ba | 2012-05-14 22:54:58 +0000 | [diff] [blame] | 349 | if (list_supported) { |
Niklas Söderlund | ede2fa4 | 2012-10-23 13:06:46 +0000 | [diff] [blame] | 350 | if (print_supported()) |
| 351 | ret = 1; |
Carl-Daniel Hailfinger | 901a3ba | 2012-05-14 22:54:58 +0000 | [diff] [blame] | 352 | goto out; |
| 353 | } |
Carl-Daniel Hailfinger | 4628445 | 2012-01-11 02:10:11 +0000 | [diff] [blame] | 354 | |
Carl-Daniel Hailfinger | 1c15548 | 2012-06-06 09:17:06 +0000 | [diff] [blame] | 355 | #ifndef STANDALONE |
| 356 | start_logging(); |
| 357 | #endif /* !STANDALONE */ |
| 358 | |
| 359 | print_buildinfo(); |
Carl-Daniel Hailfinger | 901a3ba | 2012-05-14 22:54:58 +0000 | [diff] [blame] | 360 | msg_gdbg("Command line (%i args):", argc - 1); |
| 361 | for (i = 0; i < argc; i++) { |
| 362 | msg_gdbg(" %s", argv[i]); |
| 363 | } |
| 364 | msg_gdbg("\n"); |
| 365 | |
| 366 | if (layoutfile && read_romlayout(layoutfile)) { |
| 367 | ret = 1; |
| 368 | goto out; |
| 369 | } |
| 370 | if (process_include_args()) { |
| 371 | ret = 1; |
| 372 | goto out; |
| 373 | } |
Carl-Daniel Hailfinger | 63fd902 | 2011-12-14 22:25:15 +0000 | [diff] [blame] | 374 | /* Does a chip with the requested name exist in the flashchips array? */ |
Carl-Daniel Hailfinger | 2702376 | 2010-04-28 15:22:14 +0000 | [diff] [blame] | 375 | if (chip_to_probe) { |
Carl-Daniel Hailfinger | 5a7cb84 | 2012-08-25 01:17:58 +0000 | [diff] [blame] | 376 | for (chip = flashchips; chip && chip->name; chip++) |
| 377 | if (!strcmp(chip->name, chip_to_probe)) |
Carl-Daniel Hailfinger | 2702376 | 2010-04-28 15:22:14 +0000 | [diff] [blame] | 378 | break; |
Carl-Daniel Hailfinger | 5a7cb84 | 2012-08-25 01:17:58 +0000 | [diff] [blame] | 379 | if (!chip || !chip->name) { |
Carl-Daniel Hailfinger | 901a3ba | 2012-05-14 22:54:58 +0000 | [diff] [blame] | 380 | msg_cerr("Error: Unknown chip '%s' specified.\n", chip_to_probe); |
| 381 | msg_gerr("Run flashrom -L to view the hardware supported in this flashrom version.\n"); |
| 382 | ret = 1; |
| 383 | goto out; |
Carl-Daniel Hailfinger | 2702376 | 2010-04-28 15:22:14 +0000 | [diff] [blame] | 384 | } |
Carl-Daniel Hailfinger | 5a7cb84 | 2012-08-25 01:17:58 +0000 | [diff] [blame] | 385 | /* Keep chip around for later usage in case a forced read is requested. */ |
Carl-Daniel Hailfinger | 2702376 | 2010-04-28 15:22:14 +0000 | [diff] [blame] | 386 | } |
Carl-Daniel Hailfinger | 8841d3e | 2010-05-15 15:04:37 +0000 | [diff] [blame] | 387 | |
Carl-Daniel Hailfinger | 4e3391f | 2012-07-22 12:01:43 +0000 | [diff] [blame] | 388 | if (prog == PROGRAMMER_INVALID) { |
Stefan Tauner | fd0d413 | 2012-09-25 21:24:55 +0000 | [diff] [blame] | 389 | if (CONFIG_DEFAULT_PROGRAMMER != PROGRAMMER_INVALID) { |
| 390 | prog = CONFIG_DEFAULT_PROGRAMMER; |
| 391 | msg_pinfo("Using default programmer \"%s\".\n", |
| 392 | programmer_table[CONFIG_DEFAULT_PROGRAMMER].name); |
| 393 | } else { |
| 394 | msg_perr("Please select a programmer with the --programmer parameter.\n" |
Stefan Tauner | b226cb1 | 2012-11-24 18:59:39 +0000 | [diff] [blame] | 395 | "Previously this was not necessary because there was a default set.\n" |
| 396 | #if CONFIG_INTERNAL == 1 |
| 397 | "To choose the mainboard of this computer use 'internal'. " |
| 398 | #endif |
Stefan Tauner | fd0d413 | 2012-09-25 21:24:55 +0000 | [diff] [blame] | 399 | "Valid choices are:\n"); |
| 400 | list_programmers_linebreak(0, 80, 0); |
Stefan Tauner | b226cb1 | 2012-11-24 18:59:39 +0000 | [diff] [blame] | 401 | msg_ginfo(".\n"); |
Stefan Tauner | fd0d413 | 2012-09-25 21:24:55 +0000 | [diff] [blame] | 402 | ret = 1; |
| 403 | goto out; |
| 404 | } |
Carl-Daniel Hailfinger | 4e3391f | 2012-07-22 12:01:43 +0000 | [diff] [blame] | 405 | } |
Carl-Daniel Hailfinger | 2e68160 | 2011-09-08 00:00:29 +0000 | [diff] [blame] | 406 | |
Carl-Daniel Hailfinger | 4988420 | 2010-05-22 07:10:46 +0000 | [diff] [blame] | 407 | /* FIXME: Delay calibration should happen in programmer code. */ |
| 408 | myusec_calibrate_delay(); |
| 409 | |
Carl-Daniel Hailfinger | 2e68160 | 2011-09-08 00:00:29 +0000 | [diff] [blame] | 410 | if (programmer_init(prog, pparam)) { |
Carl-Daniel Hailfinger | 901a3ba | 2012-05-14 22:54:58 +0000 | [diff] [blame] | 411 | msg_perr("Error: Programmer initialization failed.\n"); |
Carl-Daniel Hailfinger | d566014 | 2011-07-15 23:47:45 +0000 | [diff] [blame] | 412 | ret = 1; |
| 413 | goto out_shutdown; |
Carl-Daniel Hailfinger | a84835a | 2010-01-07 03:24:05 +0000 | [diff] [blame] | 414 | } |
Carl-Daniel Hailfinger | c40cff7 | 2011-12-20 00:19:29 +0000 | [diff] [blame] | 415 | tempstr = flashbuses_to_text(get_buses_supported()); |
Carl-Daniel Hailfinger | 5a7cb84 | 2012-08-25 01:17:58 +0000 | [diff] [blame] | 416 | msg_pdbg("The following protocols are supported: %s.\n", tempstr); |
Carl-Daniel Hailfinger | eaacd2d | 2011-11-09 23:40:00 +0000 | [diff] [blame] | 417 | free(tempstr); |
Carl-Daniel Hailfinger | a84835a | 2010-01-07 03:24:05 +0000 | [diff] [blame] | 418 | |
Carl-Daniel Hailfinger | c40cff7 | 2011-12-20 00:19:29 +0000 | [diff] [blame] | 419 | for (j = 0; j < registered_programmer_count; j++) { |
| 420 | startchip = 0; |
Michael Karcher | 222bf10 | 2011-12-22 23:27:03 +0000 | [diff] [blame] | 421 | while (chipcount < ARRAY_SIZE(flashes)) { |
Carl-Daniel Hailfinger | 5a7cb84 | 2012-08-25 01:17:58 +0000 | [diff] [blame] | 422 | startchip = probe_flash(®istered_programmers[j], startchip, &flashes[chipcount], 0); |
Carl-Daniel Hailfinger | c40cff7 | 2011-12-20 00:19:29 +0000 | [diff] [blame] | 423 | if (startchip == -1) |
| 424 | break; |
| 425 | chipcount++; |
| 426 | startchip++; |
| 427 | } |
Carl-Daniel Hailfinger | a84835a | 2010-01-07 03:24:05 +0000 | [diff] [blame] | 428 | } |
| 429 | |
Carl-Daniel Hailfinger | 4c82318 | 2011-05-04 00:39:50 +0000 | [diff] [blame] | 430 | if (chipcount > 1) { |
Carl-Daniel Hailfinger | 5a7cb84 | 2012-08-25 01:17:58 +0000 | [diff] [blame] | 431 | msg_cinfo("Multiple flash chips were detected: \"%s\"", flashes[0].chip->name); |
Stefan Tauner | 716e098 | 2011-07-25 20:38:52 +0000 | [diff] [blame] | 432 | for (i = 1; i < chipcount; i++) |
Carl-Daniel Hailfinger | 5a7cb84 | 2012-08-25 01:17:58 +0000 | [diff] [blame] | 433 | msg_cinfo(", \"%s\"", flashes[i].chip->name); |
Carl-Daniel Hailfinger | 901a3ba | 2012-05-14 22:54:58 +0000 | [diff] [blame] | 434 | msg_cinfo("\nPlease specify which chip to use with the -c <chipname> option.\n"); |
Carl-Daniel Hailfinger | d566014 | 2011-07-15 23:47:45 +0000 | [diff] [blame] | 435 | ret = 1; |
| 436 | goto out_shutdown; |
Carl-Daniel Hailfinger | 4c82318 | 2011-05-04 00:39:50 +0000 | [diff] [blame] | 437 | } else if (!chipcount) { |
Carl-Daniel Hailfinger | 901a3ba | 2012-05-14 22:54:58 +0000 | [diff] [blame] | 438 | msg_cinfo("No EEPROM/flash device found.\n"); |
Carl-Daniel Hailfinger | a84835a | 2010-01-07 03:24:05 +0000 | [diff] [blame] | 439 | if (!force || !chip_to_probe) { |
Carl-Daniel Hailfinger | 901a3ba | 2012-05-14 22:54:58 +0000 | [diff] [blame] | 440 | msg_cinfo("Note: flashrom can never write if the flash chip isn't found " |
| 441 | "automatically.\n"); |
Carl-Daniel Hailfinger | a84835a | 2010-01-07 03:24:05 +0000 | [diff] [blame] | 442 | } |
| 443 | if (force && read_it && chip_to_probe) { |
Carl-Daniel Hailfinger | b428e97 | 2012-02-16 20:31:25 +0000 | [diff] [blame] | 444 | struct registered_programmer *pgm; |
| 445 | int compatible_programmers = 0; |
Carl-Daniel Hailfinger | 901a3ba | 2012-05-14 22:54:58 +0000 | [diff] [blame] | 446 | msg_cinfo("Force read (-f -r -c) requested, pretending the chip is there:\n"); |
Carl-Daniel Hailfinger | b428e97 | 2012-02-16 20:31:25 +0000 | [diff] [blame] | 447 | /* This loop just counts compatible controllers. */ |
| 448 | for (j = 0; j < registered_programmer_count; j++) { |
| 449 | pgm = ®istered_programmers[j]; |
Carl-Daniel Hailfinger | 5a7cb84 | 2012-08-25 01:17:58 +0000 | [diff] [blame] | 450 | /* chip is still set from the chip_to_probe earlier in this function. */ |
| 451 | if (pgm->buses_supported & chip->bustype) |
Carl-Daniel Hailfinger | b428e97 | 2012-02-16 20:31:25 +0000 | [diff] [blame] | 452 | compatible_programmers++; |
| 453 | } |
Carl-Daniel Hailfinger | 5a7cb84 | 2012-08-25 01:17:58 +0000 | [diff] [blame] | 454 | if (!compatible_programmers) { |
| 455 | msg_cinfo("No compatible controller found for the requested flash chip.\n"); |
| 456 | ret = 1; |
| 457 | goto out_shutdown; |
| 458 | } |
Carl-Daniel Hailfinger | b428e97 | 2012-02-16 20:31:25 +0000 | [diff] [blame] | 459 | if (compatible_programmers > 1) |
Carl-Daniel Hailfinger | 901a3ba | 2012-05-14 22:54:58 +0000 | [diff] [blame] | 460 | msg_cinfo("More than one compatible controller found for the requested flash " |
| 461 | "chip, using the first one.\n"); |
Carl-Daniel Hailfinger | b428e97 | 2012-02-16 20:31:25 +0000 | [diff] [blame] | 462 | for (j = 0; j < registered_programmer_count; j++) { |
| 463 | pgm = ®istered_programmers[j]; |
| 464 | startchip = probe_flash(pgm, 0, &flashes[0], 1); |
| 465 | if (startchip != -1) |
| 466 | break; |
| 467 | } |
Carl-Daniel Hailfinger | 4c82318 | 2011-05-04 00:39:50 +0000 | [diff] [blame] | 468 | if (startchip == -1) { |
Carl-Daniel Hailfinger | 5a7cb84 | 2012-08-25 01:17:58 +0000 | [diff] [blame] | 469 | // FIXME: This should never happen! Ask for a bug report? |
Carl-Daniel Hailfinger | 901a3ba | 2012-05-14 22:54:58 +0000 | [diff] [blame] | 470 | msg_cinfo("Probing for flash chip '%s' failed.\n", chip_to_probe); |
Carl-Daniel Hailfinger | d566014 | 2011-07-15 23:47:45 +0000 | [diff] [blame] | 471 | ret = 1; |
| 472 | goto out_shutdown; |
Carl-Daniel Hailfinger | a84835a | 2010-01-07 03:24:05 +0000 | [diff] [blame] | 473 | } |
Carl-Daniel Hailfinger | 901a3ba | 2012-05-14 22:54:58 +0000 | [diff] [blame] | 474 | msg_cinfo("Please note that forced reads most likely contain garbage.\n"); |
| 475 | ret = read_flash_to_file(&flashes[0], filename); |
| 476 | goto out_shutdown; |
Carl-Daniel Hailfinger | a84835a | 2010-01-07 03:24:05 +0000 | [diff] [blame] | 477 | } |
Carl-Daniel Hailfinger | d566014 | 2011-07-15 23:47:45 +0000 | [diff] [blame] | 478 | ret = 1; |
| 479 | goto out_shutdown; |
Stefan Tauner | 1d94763 | 2011-09-11 22:08:58 +0000 | [diff] [blame] | 480 | } else if (!chip_to_probe) { |
| 481 | /* repeat for convenience when looking at foreign logs */ |
Carl-Daniel Hailfinger | 5a7cb84 | 2012-08-25 01:17:58 +0000 | [diff] [blame] | 482 | tempstr = flashbuses_to_text(flashes[0].chip->bustype); |
Stefan Tauner | 1d94763 | 2011-09-11 22:08:58 +0000 | [diff] [blame] | 483 | msg_gdbg("Found %s flash chip \"%s\" (%d kB, %s).\n", |
Carl-Daniel Hailfinger | 5a7cb84 | 2012-08-25 01:17:58 +0000 | [diff] [blame] | 484 | flashes[0].chip->vendor, flashes[0].chip->name, flashes[0].chip->total_size, tempstr); |
Stefan Tauner | 1d94763 | 2011-09-11 22:08:58 +0000 | [diff] [blame] | 485 | free(tempstr); |
Carl-Daniel Hailfinger | a84835a | 2010-01-07 03:24:05 +0000 | [diff] [blame] | 486 | } |
| 487 | |
Carl-Daniel Hailfinger | 4c82318 | 2011-05-04 00:39:50 +0000 | [diff] [blame] | 488 | fill_flash = &flashes[0]; |
Carl-Daniel Hailfinger | a84835a | 2010-01-07 03:24:05 +0000 | [diff] [blame] | 489 | |
Carl-Daniel Hailfinger | 5a7cb84 | 2012-08-25 01:17:58 +0000 | [diff] [blame] | 490 | check_chip_supported(fill_flash->chip); |
Carl-Daniel Hailfinger | a84835a | 2010-01-07 03:24:05 +0000 | [diff] [blame] | 491 | |
Carl-Daniel Hailfinger | 5a7cb84 | 2012-08-25 01:17:58 +0000 | [diff] [blame] | 492 | size = fill_flash->chip->total_size * 1024; |
| 493 | if (check_max_decode(fill_flash->pgm->buses_supported & fill_flash->chip->bustype, size) && (!force)) { |
Carl-Daniel Hailfinger | 901a3ba | 2012-05-14 22:54:58 +0000 | [diff] [blame] | 494 | msg_cerr("Chip is too big for this programmer (-V gives details). Use --force to override.\n"); |
Carl-Daniel Hailfinger | d566014 | 2011-07-15 23:47:45 +0000 | [diff] [blame] | 495 | ret = 1; |
| 496 | goto out_shutdown; |
Carl-Daniel Hailfinger | a84835a | 2010-01-07 03:24:05 +0000 | [diff] [blame] | 497 | } |
| 498 | |
| 499 | if (!(read_it | write_it | verify_it | erase_it)) { |
Carl-Daniel Hailfinger | 901a3ba | 2012-05-14 22:54:58 +0000 | [diff] [blame] | 500 | msg_ginfo("No operations were specified.\n"); |
Carl-Daniel Hailfinger | d566014 | 2011-07-15 23:47:45 +0000 | [diff] [blame] | 501 | goto out_shutdown; |
Carl-Daniel Hailfinger | a84835a | 2010-01-07 03:24:05 +0000 | [diff] [blame] | 502 | } |
| 503 | |
| 504 | /* Always verify write operations unless -n is used. */ |
| 505 | if (write_it && !dont_verify_it) |
| 506 | verify_it = 1; |
| 507 | |
Carl-Daniel Hailfinger | 9ad4255 | 2010-09-15 10:20:16 +0000 | [diff] [blame] | 508 | /* FIXME: We should issue an unconditional chip reset here. This can be |
| 509 | * done once we have a .reset function in struct flashchip. |
| 510 | * Give the chip time to settle. |
| 511 | */ |
| 512 | programmer_delay(100000); |
Carl-Daniel Hailfinger | 901a3ba | 2012-05-14 22:54:58 +0000 | [diff] [blame] | 513 | ret |= doit(fill_flash, force, filename, read_it, write_it, erase_it, verify_it); |
| 514 | /* Note: doit() already calls programmer_shutdown(). */ |
| 515 | goto out; |
Carl-Daniel Hailfinger | d566014 | 2011-07-15 23:47:45 +0000 | [diff] [blame] | 516 | |
| 517 | out_shutdown: |
| 518 | programmer_shutdown(); |
Carl-Daniel Hailfinger | 901a3ba | 2012-05-14 22:54:58 +0000 | [diff] [blame] | 519 | out: |
Carl-Daniel Hailfinger | 1c15548 | 2012-06-06 09:17:06 +0000 | [diff] [blame] | 520 | #ifndef STANDALONE |
| 521 | ret |= close_logfile(); |
| 522 | #endif /* !STANDALONE */ |
Carl-Daniel Hailfinger | d566014 | 2011-07-15 23:47:45 +0000 | [diff] [blame] | 523 | return ret; |
Carl-Daniel Hailfinger | a84835a | 2010-01-07 03:24:05 +0000 | [diff] [blame] | 524 | } |