Gitiles
Code Review Sign In
review.sourcearcade.org / flashprog / 3d7b1e3b5c04304d3680bd950e7672f6336b01d6
commit3d7b1e3b5c04304d3680bd950e7672f6336b01d6[log] [tgz]
authorNico Huber <nico.h@gmx.de>Sat Dec 22 00:53:14 2018 +0100
committerNico Huber <nico.h@gmx.de>Tue Apr 02 16:42:53 2019 +0000
treef316ba1bd2474850ff3267ff1acbbb2b9c7336cd
parent0cacb11c6252b6e1f4f0a2a33b47717ff22995d9 [diff]
Fix verification with sparse layouts

The full verification step was not accounting for sparse layouts.
Instead of the old contents, combine_image_by_layout() implicitly
assumed the new contents for unspecified regions.

Change-Id: I44e0cea621f2a3d4dc70fa7e93c52ed95e54014a
Signed-off-by: Nico Huber <nico.h@gmx.de>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/30370
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Philipp Deppenwiese <zaolin.daisuki@gmail.com>
3 files changed
tree: f316ba1bd2474850ff3267ff1acbbb2b9c7336cd
  1. Documentation/
  2. util/
  3. .gitattributes
  4. .gitignore
  5. 82802ab.c
  6. amd_imc.c
  7. archtest.c
  8. at45db.c
  9. atahpt.c
  10. atapromise.c
  11. atavia.c
  12. bitbang_spi.c
  13. board_enable.c
  14. buspirate_spi.c
  15. cbtable.c
  16. ch341a_spi.c
  17. chipdrivers.h
  18. chipset_enable.c
  19. cli_classic.c
  20. cli_common.c
  21. cli_output.c
  22. COPYING
  23. coreboot_tables.h
  24. custom_baud.c
  25. custom_baud.h
  26. dediprog.c
  27. developerbox_spi.c
  28. digilent_spi.c
  29. dmi.c
  30. Doxyfile
  31. drkaiser.c
  32. dummyflasher.c
  33. edi.c
  34. edi.h
  35. en29lv640b.c
  36. endiantest.c
  37. ene.h
  38. flash.h
  39. flashchips.c
  40. flashchips.h
  41. flashrom.8.tmpl
  42. flashrom.c
  43. fmap.c
  44. fmap.h
  45. ft2232_spi.c
  46. gfxnvidia.c
  47. helpers.c
  48. hwaccess.c
  49. hwaccess.h
  50. ich_descriptors.c
  51. ich_descriptors.h
  52. ichspi.c
  53. internal.c
  54. it8212.c
  55. it85spi.c
  56. it87spi.c
  57. jedec.c
  58. jlink_spi.c
  59. layout.c
  60. layout.h
  61. libflashrom.c
  62. libflashrom.h
  63. linux_mtd.c
  64. linux_spi.c
  65. Makefile
  66. mcp6x_spi.c
  67. mstarddc_spi.c
  68. nic3com.c
  69. nicintel.c
  70. nicintel_eeprom.c
  71. nicintel_spi.c
  72. nicnatsemi.c
  73. nicrealtek.c
  74. ogp_spi.c
  75. opaque.c
  76. os.h
  77. pcidev.c
  78. physmap.c
  79. pickit2_spi.c
  80. platform.h
  81. pony_spi.c
  82. print.c
  83. print_wiki.c
  84. processor_enable.c
  85. programmer.c
  86. programmer.h
  87. rayer_spi.c
  88. README
  89. satamv.c
  90. satasii.c
  91. sb600spi.c
  92. serial.c
  93. serprog.c
  94. serprog.h
  95. sfdp.c
  96. spi.c
  97. spi.h
  98. spi25.c
  99. spi25_statusreg.c
  100. sst28sf040.c
  101. sst49lfxxxc.c
  102. sst_fwhub.c
  103. stm50.c
  104. udelay.c
  105. usbblaster_spi.c
  106. usbdev.c
  107. w29ee011.c
  108. w39.c
  109. wbsio_spi.c