Add a few FIXME comments to the generic SPI code
Corresponding to flashrom svn r814.
Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
diff --git a/spi.c b/spi.c
index a2b26c5..43dc4bf 100644
--- a/spi.c
+++ b/spi.c
@@ -807,6 +807,7 @@
int result;
struct spi_command cmds[] = {
{
+ /* FIXME: WRSR requires either EWSR or WREN depending on chip type. */
.writecnt = JEDEC_EWSR_OUTSIZE,
.writearr = (const unsigned char[]){ JEDEC_EWSR },
.readcnt = 0,
@@ -1059,6 +1060,7 @@
fprintf(stderr, "ERASE FAILED!\n");
return -1;
}
+ /* FIXME: This will fail on ICH/VIA SPI. */
result = spi_write_enable();
if (result)
return result;