Gitiles
Code Review Sign In
review.sourcearcade.org / flashprog / ab922779e34fae2e25000614ddd285c8a7994ca0
commitab922779e34fae2e25000614ddd285c8a7994ca0[log] [tgz]
authorCarl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>Tue Jul 13 00:04:52 2010 +0000
committerCarl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>Tue Jul 13 00:04:52 2010 +0000
tree1b6200a4cae2469118f434f59e4d7f74f85f9102
parent550f5c836c1c79a430af8d9275aedebc9c35eb8b [diff]
Fix out-of-bounds ICH FREG permission printing

A bit was masked, but not shifted, and that led to worst-case accesses
of index 24 in an array with 4 members.

I've improved readability in the variable declaration block as well.

Thanks to Stephen Kou for reporting the bug.

Corresponding to flashrom svn r1076.

Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
Acked-by: Stephen Kou <stephen@hyarros.com>
1 file changed
tree: 1b6200a4cae2469118f434f59e4d7f74f85f9102
  1. 82802ab.c
  2. atahpt.c
  3. bitbang_spi.c
  4. board_enable.c
  5. buspirate_spi.c
  6. cbtable.c
  7. chipdrivers.h
  8. chipset_enable.c
  9. cli_classic.c
  10. cli_output.c
  11. COPYING
  12. coreboot_tables.h
  13. dediprog.c
  14. dmi.c
  15. drkaiser.c
  16. dummyflasher.c
  17. flash.h
  18. flashchips.c
  19. flashchips.h
  20. flashrom.8
  21. flashrom.c
  22. ft2232_spi.c
  23. gfxnvidia.c
  24. hwaccess.c
  25. hwaccess.h
  26. ichspi.c
  27. internal.c
  28. it87spi.c
  29. jedec.c
  30. layout.c
  31. m29f400bt.c
  32. Makefile
  33. nic3com.c
  34. nicnatsemi.c
  35. nicrealtek.c
  36. pcidev.c
  37. physmap.c
  38. pm49fl00x.c
  39. print.c
  40. print_wiki.c
  41. processor_enable.c
  42. programmer.c
  43. README
  44. satasii.c
  45. sb600spi.c
  46. serial.c
  47. serprog-protocol.txt
  48. serprog.c
  49. sharplhf00l04.c
  50. spi.c
  51. spi.h
  52. spi25.c
  53. sst28sf040.c
  54. sst49lfxxxc.c
  55. sst_fwhub.c
  56. stm50flw0x0x.c
  57. udelay.c
  58. w29ee011.c
  59. w39v040c.c
  60. w39v080fa.c
  61. wbsio_spi.c