commit 93e1625f9fb5f1080c40685488d006b2982062d7
author Richard Hughes <richard@hughsie.com> Wed Dec 19 11:54:47 2018 +0000
committer Nico Huber <nico.h@gmx.de> Sun Feb 03 18:31:45 2019 +0000
tree 810e5b2807d6f5c102059e2b8a99a91a17c8f9c7
parent d82be7b2be34fb3273781e72f5d8e52a3103b961

Fix several -Wold-style-declaration warnings

Change-Id: Iffe5e652779a13ee7f64696fb5df4a781fe9a632
Signed-off-by: Richard Hughes <richard@hughsie.com>
Reviewed-on: https://review.coreboot.org/c/30404
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>

board_enable.c

diff --git a/board_enable.c b/board_enable.c
index 9d45813..00809f7 100644
--- a/board_enable.c
+++ b/board_enable.c
@@ -2585,7 +2585,7 @@
  * Match boards on PCI IDs and subsystem IDs.
  * Second set of IDs can be either main+subsystem IDs, main IDs or no IDs.
  */
-const static struct board_match *board_match_pci_ids(enum board_match_phase phase)
+static const struct board_match *board_match_pci_ids(enum board_match_phase phase)
 {
 	const struct board_match *board = board_matches;
 

flashrom.c

diff --git a/flashrom.c b/flashrom.c
index 7129a51..cb2da46 100644
--- a/flashrom.c
+++ b/flashrom.c
@@ -455,10 +455,10 @@
 #define SHUTDOWN_MAXFN 32
 static int shutdown_fn_count = 0;
 /** @private */
-struct shutdown_func_data {
+static struct shutdown_func_data {
 	int (*func) (void *data);
 	void *data;
-} static shutdown_fn[SHUTDOWN_MAXFN];
+} shutdown_fn[SHUTDOWN_MAXFN];
 /* Initialize to 0 to make sure nobody registers a shutdown function before
  * programmer init.
  */

ichspi.c

diff --git a/ichspi.c b/ichspi.c
index 9eb24a9..2144208 100644
--- a/ichspi.c
+++ b/ichspi.c
@@ -676,7 +676,7 @@
  *   - at least one program opcode (BYTE_PROGRAM, AAI_WORD_PROGRAM, ...?)
  *   - necessary preops? (EWSR, WREN, ...?)
  */
-static int ich_missing_opcodes()
+static int ich_missing_opcodes(void)
 {
 	uint8_t ops[] = {
 		JEDEC_READ,

nicintel_spi.c

diff --git a/nicintel_spi.c b/nicintel_spi.c
index 4d20c40..f31a2f9 100644
--- a/nicintel_spi.c
+++ b/nicintel_spi.c
@@ -218,7 +218,7 @@
 	return 0;
 }
 
-static int nicintel_spi_i210_enable_flash()
+static int nicintel_spi_i210_enable_flash(void)
 {
 	uint32_t tmp;