commit 0c39ddbd42d86e1b4672d8ffc9d1f961ed1a53d9
author Nico Huber <nico.h@gmx.de> Fri Mar 06 22:17:33 2026 +0100
committer Nico Huber <nico.h@gmx.de> Sun Jun 28 09:29:37 2026 +0000
tree 0451059810d70eeefc00b14ff70e8ccb7132012d
parent be42cf24728907ace7db5c572b097288485dca5c

flashchips: Drop spurious address masks from parallel chips

These chip entries are all untested. According to their datasheets,
they all ignore additional address bits when receiving commands. In
case of x16 chips (w/ address shift), the 2AA masks were wrong any-
way, as we mask after the shifting.

Change-Id: Ie7ae3c78353cc9d01bc627209481cb5d8f7afffb
Signed-off-by: Nico Huber <nico.h@gmx.de>
Reviewed-on: https://review.sourcearcade.org/c/flashprog/+/432
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>

flashchips.c

diff --git a/flashchips.c b/flashchips.c
index bd07239..acb1d09 100644
--- a/flashchips.c
+++ b/flashchips.c
@@ -200,7 +200,7 @@
 		.id.model	= AMD_AM29F016D,
 		.total_size	= 2 * 1024,
 		.page_size	= 64 * 1024,
-		.feature_bits	= FEATURE_ADDR_2AA | FEATURE_SHORT_RESET,
+		.feature_bits	= FEATURE_SHORT_RESET,
 		.tested		= TEST_UNTESTED,
 		.probe		= probe_jedec,
 		.probe_timing	= TIMING_ZERO,
@@ -7334,7 +7334,7 @@
 		.id.model	= FUJITSU_MBM29F400BC,
 		.total_size	= 512,
 		.page_size	= 64 * 1024,
-		.feature_bits	= FEATURE_ADDR_SHIFTED | FEATURE_ADDR_2AA | FEATURE_EITHER_RESET,
+		.feature_bits	= FEATURE_ADDR_SHIFTED | FEATURE_EITHER_RESET,
 		.tested		= TEST_UNTESTED,
 		.probe		= probe_jedec,
 		.probe_timing	= 10, // FIXME: check datasheet. Using the 10 us from probe_m29f400bt
@@ -7369,7 +7369,7 @@
 		.id.model	= FUJITSU_MBM29F400TC,
 		.total_size	= 512,
 		.page_size	= 64 * 1024,
-		.feature_bits	= FEATURE_ADDR_SHIFTED | FEATURE_ADDR_AAA | FEATURE_EITHER_RESET,
+		.feature_bits	= FEATURE_ADDR_SHIFTED | FEATURE_EITHER_RESET,
 		.tested		= TEST_UNTESTED,
 		.probe		= probe_jedec,
 		.probe_timing	= 10, // FIXME: check datasheet. Using the 10 us from probe_m29f400bt
@@ -20802,7 +20802,7 @@
 		.id.model	= ST_M29F400BB,
 		.total_size	= 512,
 		.page_size	= 64 * 1024,
-		.feature_bits	= FEATURE_ADDR_SHIFTED | FEATURE_ADDR_2AA | FEATURE_EITHER_RESET,
+		.feature_bits	= FEATURE_ADDR_SHIFTED | FEATURE_EITHER_RESET,
 		.tested		= TEST_UNTESTED,
 		.probe		= probe_jedec,
 		.probe_timing	= 10, // FIXME: check datasheet. Using the 10 us from probe_m29f400bt
@@ -20838,7 +20838,7 @@
 		.id.model	= ST_M29F400BT,
 		.total_size	= 512,
 		.page_size	= 64 * 1024,
-		.feature_bits	= FEATURE_ADDR_SHIFTED | FEATURE_ADDR_2AA | FEATURE_EITHER_RESET,
+		.feature_bits	= FEATURE_ADDR_SHIFTED | FEATURE_EITHER_RESET,
 		.tested		= TEST_UNTESTED,
 		.probe		= probe_jedec,
 		.probe_timing	= 10, // FIXME: check datasheet. Using the 10 us from probe_m29f400bt