commit e096913f65384c87d64ce6bd645df2a73cae258f
author Jeremy Compostella <jeremy.compostella@intel.com> Tue Aug 15 09:29:01 2023 -0700
committer Nico Huber <nico.h@gmx.de> Wed Aug 23 10:47:49 2023 +0000
tree 0f5d5aa4e522efdc4ac0637e8e7094881c81fea4
parent a4be8a21b0e2c752da0042c79aae5942418f53e2

connector_info: Fix HDMI/DVI default bytes per color setting

According to the Programming Reference Manual and more specificaly
`TRANS_DDI_FUNC_CTL' register description, a bytes per colors value of
6 (or 10) is not supported by HDMI.

We indeed noticed that if we use a HDMI monitor on the first HDMI port
of a board without eDP, the monitor does not accept the configuration.

This patch ensures that we do not use a default BPC of 6 if the port
is HDMI.

Change-Id: I55e9e63a4da6c6764bae0f1b19132f14fd865cea
Signed-off-by: Jeremy Compostella <jeremy.compostella@intel.com>
Reviewed-on: https://review.coreboot.org/c/libgfxinit/+/77227
Tested-by: Nico Huber <nico.h@gmx.de>
Reviewed-by: Nico Huber <nico.h@gmx.de>

common/hw-gfx-gma-connector_info.adb

diff --git a/common/hw-gfx-gma-connector_info.adb b/common/hw-gfx-gma-connector_info.adb
index 79c42a0..47292f6 100644
--- a/common/hw-gfx-gma-connector_info.adb
+++ b/common/hw-gfx-gma-connector_info.adb
@@ -105,7 +105,7 @@
    is
    begin
       return
-        (if Port_Cfg.Port = DIGI_A or
+        (if (Port_Cfg.Port = DIGI_A and Port_Cfg.Display /= HDMI) or
            (Port_Cfg.Is_FDI and Port_Cfg.PCH_Port = PCH_LVDS) or
            Port_Cfg.Port = LVDS
          then 6