dp_info: Refactor debug output for DP settings

Shuffle things around to let the caller decide when to output the
settings. This removes spurious "DP" outputs for FDI configuration
which reuses the DP_Info infrastructure.

Change-Id: I9e6d6946002ef758b6c31f7de797dc6d329cae74
Signed-off-by: Nico Huber <nico.huber@secunet.com>
Reviewed-on: https://review.coreboot.org/18116
Tested-by: Nico Huber <nico.h@gmx.de>
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-by: Patrick Georgi <pgeorgi@google.com>
diff --git a/common/hw-gfx-dp_info.ads b/common/hw-gfx-dp_info.ads
index 4f8ef02..aa10c4c 100644
--- a/common/hw-gfx-dp_info.ads
+++ b/common/hw-gfx-dp_info.ads
@@ -1,5 +1,5 @@
 --
--- Copyright (C) 2015 secunet Security Networks AG
+-- Copyright (C) 2015-2017 secunet Security Networks AG
 --
 -- This program is free software; you can redistribute it and/or modify
 -- it under the terms of the GNU General Public License as published by
@@ -91,6 +91,11 @@
       Mode        : in     Mode_Type;
       Success     :    out Boolean);
 
+   pragma Warnings
+     (GNATprove, Off, "subprogram ""Dump_Link_Setting"" has no effect",
+      Reason => "It's only used for debugging");
+   procedure Dump_Link_Setting (Link : DP_Link);
+
    ----------------------------------------------------------------------------
 
    M_N_Max : constant := 2 ** 24 - 1;