gma: Split `Internal` port type into `eDP` & `LVDS`
We used to have a single type `Internal`, in the GMA interface, to
represent the port for any internal panel. This seemed suitable as
all mainboard targets used the additional panel logic (power se-
quencing, backlight) only with either one of the eDP and LVDS ports.
However, the hardware allows to combine the panel logic also with
other ports. And some of the regular DP ports are even mentioned as
alternatives to the dedicated eDP port.
As a first step towards supporting such less common combinations,
we get rid of the single `Internal` type. All the panel logic still
assumes that either the dedicated eDP or the LVDS port is used for
an internal display. We introduce `Internal_Port_Type` to represent
eDP and LVDS, for this. But it should vanish, once the panel logic
is adapted.
Change-Id: Iadf3c11bd35d085cf47a961e800b0d96b79f62f5
Signed-off-by: Nico Huber <nico.huber@secunet.com>
Reviewed-on: https://review.coreboot.org/c/libgfxinit/+/38239
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Tested-by: Nico Huber <nico.h@gmx.de>
diff --git a/common/hw-gfx-gma.adb b/common/hw-gfx-gma.adb
index 0fe360d..d0f296e 100644
--- a/common/hw-gfx-gma.adb
+++ b/common/hw-gfx-gma.adb
@@ -57,7 +57,8 @@
type Port_Name_Array is array (Port_Type) of Port_Name;
Port_Names : constant Port_Name_Array :=
(Disabled => "Disabled",
- Internal => "Internal",
+ LVDS => "LVDS ",
+ eDP => "eDP ",
DP1 => "DP1 ",
DP2 => "DP2 ",
DP3 => "DP3 ",
@@ -178,7 +179,7 @@
("Enabled port " & Port_Names (Pipe_Cfg.Port)));
else
Wait_For_HPD (Pipe_Cfg.Port) := True;
- if Pipe_Cfg.Port = Internal then
+ if Pipe_Cfg.Port in Internal_Port_Type then
Panel.Off;
end if;
end if;
@@ -236,7 +237,7 @@
Cur_Config.Mode /= New_Config.Mode
or else
(Config.Use_PDW_For_EDP_Scaling and then
- (Cur_Config.Port = Internal and
+ (Cur_Config.Port = eDP and
Requires_Scaling (Cur_Config) /= Requires_Scaling (New_Config)))
or else
(Config.Has_GMCH_PFIT_CONTROL and then