gma broxton: Fill in port PLL configuration
PLL parameter selection is a much simplified version of what's done in
i915 on Linux. We just assume the error in the resulting clock of a
valid parameter tuple is always small enough. Trying to speak mathe-
matically, since the only calculated parameter M2 is given as a frac-
tion of 2^22, the error should stay below 2^-22.
As the PLLs are tied to specific DDI ports, they won't ever be shared
among ports and the allocation boils down to just configuring the PLL.
Change-Id: I206675506f1dbbb57d65bfdc308de1891ccbf61a
Signed-off-by: Nico Huber <nico.huber@secunet.com>
Reviewed-on: https://review.coreboot.org/18423
Tested-by: Nico Huber <nico.h@gmx.de>
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
diff --git a/common/broxton/hw-gfx-gma-plls.ads b/common/broxton/hw-gfx-gma-plls.ads
index 195b2f3..d79d378 100644
--- a/common/broxton/hw-gfx-gma-plls.ads
+++ b/common/broxton/hw-gfx-gma-plls.ads
@@ -33,14 +33,12 @@
PLL : out T;
Success : out Boolean);
- pragma Warnings (GNATprove, Off, "subprogram ""*"" has no effect");
procedure Free (PLL : T);
procedure All_Off;
- pragma Warnings (GNATprove, On, "subprogram ""*"" has no effect");
- pragma Warnings (GNATprove, Off, "unused variable ""PLL""");
- function Register_Value (PLL : T) return Word32;
- pragma Warnings (GNATprove, On, "unused variable ""PLL""");
+ -- Just an interface stub since PLLs are tied to the port.
+ type Word_Array is array (T) of Word32;
+ Register_Value : constant Word_Array := (others => 0);
end HW.GFX.GMA.PLLs;