gma hsw+: Treat DDI E and PCH DAC disabling separately
We only use DDI E for analog VGA outputs through the PCH DAC. DDI E
might be configured differently, though, by a previously running dri-
ver, so we have to treat the two entities seperately on the All_Off()
path.
Change-Id: I603ecd29c48af43bc21acaadbedaeae451acbcf3
Signed-off-by: Nico Huber <nico.h@gmx.de>
Reviewed-on: https://review.coreboot.org/20822
Reviewed-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
diff --git a/common/hw-gfx-gma-config.ads.template b/common/hw-gfx-gma-config.ads.template
index 98259ff..5bd8eb0 100644
--- a/common/hw-gfx-gma-config.ads.template
+++ b/common/hw-gfx-gma-config.ads.template
@@ -180,7 +180,7 @@
Valid_Port : Valid_Per_Port renames Valid_Port_GPU (CPU);
Last_Digital_Port : constant Digital_Port :=
- (if Has_DDI_D then DIGI_D else DIGI_C);
+ (if Has_DDI_E then DIGI_E else DIGI_C);
----------------------------------------------------------------------------
@@ -190,11 +190,8 @@
when Ironlake .. Ivybridge => FDI_Per_Port'
(Internal => Internal_Display = LVDS,
others => True),
- when Haswell => FDI_Per_Port'
- (Analog => True,
- others => False),
- when Broadwell => FDI_Per_Port'
- (Analog => CPU_Var = Normal,
+ when Haswell .. Broadwell => FDI_Per_Port'
+ (Analog => Has_PCH_DAC,
others => False),
when others => FDI_Per_Port'
(others => False));