)]}' { "log": [ { "commit": "6e98544eae90e2c99fe4b485179b6c1bdcf48729", "tree": "98a8126b8b65b806bf735d1220c43305cb3b9579", "parents": [ "671c0f006770588881ea5162a2bcc79001356fa7" ], "author": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Sun Jun 16 20:22:41 2019 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Sun Jan 29 12:29:02 2023 +0000" }, "message": "layout: Make `struct layout_include_args` private to `layout.c`\n\nChange-Id: Icbfee68e85429fe41db1cad6b99f25e9f30cd672\nSigned-off-by: Nico Huber \u003cnico.h@gmx.de\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/33545\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-by: Anastasia Klimchuk \u003caklm@chromium.org\u003e\nOriginal-Reviewed-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nOriginal-Reviewed-by: Peter Marheine \u003cpmarheine@chromium.org\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/72219\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "671c0f006770588881ea5162a2bcc79001356fa7", "tree": "acba42f4e71562450455acc083c1b3d5fc46ce74", "parents": [ "49258610ebd4cec764c2d01e8fdf713b7067c96a" ], "author": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Sun Jun 16 20:17:19 2019 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Sun Jan 29 12:29:02 2023 +0000" }, "message": "layout: Drop `count` parameter of flashrom_layout_new()\n\nChange-Id: I22c180c9971068b1ae101845ce88484c6842b852\nSigned-off-by: Nico Huber \u003cnico.h@gmx.de\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/33544\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-by: Anastasia Klimchuk \u003caklm@chromium.org\u003e\nOriginal-Reviewed-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/72218\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "49258610ebd4cec764c2d01e8fdf713b7067c96a", "tree": "7571215cc452fa492d6c4d9db4628f54726e3ce3", "parents": [ "74d09d47dbb0b3c1fbdaf3a052bb02148f24300c" ], "author": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Sat Jun 15 21:41:21 2019 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Sun Jan 29 12:29:02 2023 +0000" }, "message": "layout: Use linked list for `struct romentry`\n\nThis gets rid of the entry limit and hopefully makes future layout\nhandling easier. We start by making `struct flashrom_layout` private\nto `layout.c`.\n\nChange-Id: I60a0aa1007ebcd5eb401db116f835d129b3e9732\nSigned-off-by: Nico Huber \u003cnico.h@gmx.de\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/33521\nOriginal-Reviewed-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/72217\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "74d09d47dbb0b3c1fbdaf3a052bb02148f24300c", "tree": "6f35cd53aca59e5db99e1e2d116f6f8a8e681ce1", "parents": [ "8edcd1509ddabcbfba5c251475663213b7bd0472" ], "author": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Sun Jun 16 03:27:26 2019 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Sun Jan 29 12:29:02 2023 +0000" }, "message": "Pass layout directly to verify_by_layout()\n\nIt used the current layout from the flash context, before. This made\nit necessary to replace the pointer on-the-fly. Passing the layout\ndirectly, works without that stunt.\n\nChange-Id: Id496deec85c18bdfe968df6a798b626eb9cfbed5\nSigned-off-by: Nico Huber \u003cnico.h@gmx.de\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/33520\nOriginal-Reviewed-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nOriginal-Reviewed-by: Anastasia Klimchuk \u003caklm@chromium.org\u003e\nOriginal-Reviewed-by: Peter Marheine \u003cpmarheine@chromium.org\u003e\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/72216\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "8edcd1509ddabcbfba5c251475663213b7bd0472", "tree": "cafbba68169f0e55925009ada471b89df4b3172f", "parents": [ "5bd990c2ab8ceb263d598a2348d7020ce774784f" ], "author": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Sun Jun 16 03:22:58 2019 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Sun Jan 29 12:29:02 2023 +0000" }, "message": "layout: Introduce get_default_layout()\n\nContaining an included, full-flash-chip sized default region.\nThis allows us to query the default layout specifically, also\nif an additional layout is attached to the flash context.\n\nChange-Id: Ia343e9775ec5bdc3fea5cdb6b347298515996e34\nSigned-off-by: Nico Huber \u003cnico.h@gmx.de\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/33519\nOriginal-Reviewed-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-by: Anastasia Klimchuk \u003caklm@chromium.org\u003e\nOriginal-Reviewed-by: Peter Marheine \u003cpmarheine@chromium.org\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/72215\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "5bd990c2ab8ceb263d598a2348d7020ce774784f", "tree": "0ee2bdd6b6aa9af15becf68d7afd4142df0bf99c", "parents": [ "92e0b62fc37a6d89975ced41f5ec3c3715404f33" ], "author": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Sun Jun 16 19:46:46 2019 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Sun Jan 29 12:29:02 2023 +0000" }, "message": "layout: Introduce flashrom_layout_new()\n\nIt initializes an empty layout. Currently the maximum number of entries\nhas to be specified, which will vanish once we use dynamic allocation\nper entry.\n\nWe replace the two special cases `single_layout` and `ich_layout` with\ndynamically allocated layouts. As a result, we have to take care to\nrelease the `default_layout` in a flashctx once we are done with it.\n\nChange-Id: I2ae7246493ff592e631cce924777925c7825e398\nSigned-off-by: Nico Huber \u003cnico.h@gmx.de\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/33543\nOriginal-Reviewed-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/72214\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "92e0b62fc37a6d89975ced41f5ec3c3715404f33", "tree": "9a9426d80db30846f31b2de2788df143fe75aa2d", "parents": [ "3a97fd5d46fe4d0f6f1be7a99123fd80645fe736" ], "author": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Sat Jun 15 15:55:11 2019 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Sun Jan 29 12:29:02 2023 +0000" }, "message": "layout: Introduce flashrom_layout_add_region()\n\nAdds a region to an existing layout, as long as there is space.\n\nChange-Id: I50d473d0d5d1fb38bd6f9ae3d7127e9ea66a94e1\nSigned-off-by: Nico Huber \u003cnico.h@gmx.de\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/33517\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-by: Anastasia Klimchuk \u003caklm@chromium.org\u003e\nOriginal-Reviewed-by: Peter Marheine \u003cpmarheine@chromium.org\u003e\nOriginal-Reviewed-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/72213\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "3a97fd5d46fe4d0f6f1be7a99123fd80645fe736", "tree": "ebe7f7e1c92890374084f03ebaeee0efb99f5ea9", "parents": [ "354766b2fcc53d621a2c9f9c0b9f5f4c71ca0c8b" ], "author": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Sat Jun 15 15:44:39 2019 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Sun Jan 29 12:29:02 2023 +0000" }, "message": "layout: Add `capacity` field\n\nUse it to keep track of the size of the `entries` array. An interim\nsolution until we have dynamic allocation.\n\nChange-Id: Ib5f431bc0a72a79a53fa1376c3417942b19dd3a0\nSigned-off-by: Nico Huber \u003cnico.h@gmx.de\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/33516\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-by: Anastasia Klimchuk \u003caklm@chromium.org\u003e\nOriginal-Reviewed-by: Peter Marheine \u003cpmarheine@chromium.org\u003e\nOriginal-Reviewed-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/72212\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "354766b2fcc53d621a2c9f9c0b9f5f4c71ca0c8b", "tree": "53fe1cc24c4d9087452abd045fd2a3a271b9eb45", "parents": [ "346d54dda7dcbb1281a869641a2b35b45096bce5" ], "author": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Sun Jun 16 19:28:35 2019 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Sun Jan 29 12:29:02 2023 +0000" }, "message": "layout: Introduce layout_next()\n\nAlso, a `layout.c` internal version mutable_layout_next() that\nallows to modify layout entries.\n\nUse the new functions where applicable and the code is not\ndropped later in this train, and also to compare the layouts\nin flashrom_layout_read_from_ifd() in depth.\n\nflashrom-stable: Dropped _layout_entry_by_name()\n\nChange-Id: I284958471c61344d29d92c95d88475065a9ca9aa\nSigned-off-by: Nico Huber \u003cnico.h@gmx.de\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/33542\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-by: Anastasia Klimchuk \u003caklm@chromium.org\u003e\nOriginal-Reviewed-by: Peter Marheine \u003cpmarheine@chromium.org\u003e\nOriginal-Reviewed-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/72211\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "346d54dda7dcbb1281a869641a2b35b45096bce5", "tree": "912b4cf499128134575aa4f86a8b14a610334b6f", "parents": [ "d8f8c993a0b3622f3ec01b384448bae1187b3000" ], "author": { "name": "Anastasia Klimchuk", "email": "aklm@chromium.org", "time": "Thu Jun 10 09:57:51 2021 +1000" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Sun Jan 29 12:29:02 2023 +0000" }, "message": "buspirate_spi.c: Drop bp_ prefix for spi data struct members\n\nThe name of the struct type already contains bp_ prefix, so\nprefix doesn\u0027t need to be repeated in members name.\n\nChange-Id: Ia463e3f58497e4b10be072bdd29244f4868098e7\nSigned-off-by: Anastasia Klimchuk \u003caklm@chromium.org\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/54886\nOriginal-Reviewed-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nOriginal-Reviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/72210\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "d8f8c993a0b3622f3ec01b384448bae1187b3000", "tree": "4ef921b3210b299af7d60cf4549bc3b57943a7bf", "parents": [ "4e9e99cca942890576b154b90571fe86cbba3058" ], "author": { "name": "Anastasia Klimchuk", "email": "aklm@chromium.org", "time": "Thu May 06 07:47:04 2021 +1000" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Sun Jan 29 12:29:02 2023 +0000" }, "message": "buspirate_spi.c: Refactor singleton states into reentrant pattern\n\nMove global singleton states into a struct and store within\nthe spi_master data field for the life-time of the driver.\n\nThis is one of the steps on the way to move spi_master data\nmemory management behind the initialisation API, for more\ncontext see other patches under the same topic \"register_master_api\".\n\nChange-Id: I418bbfff15fb126b042fbc9be09dbf59f4d243b8\nSigned-off-by: Anastasia Klimchuk \u003caklm@chromium.org\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/52958\nOriginal-Reviewed-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nOriginal-Reviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/72209\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "4e9e99cca942890576b154b90571fe86cbba3058", "tree": "8db6babbfc9dee54ea6485067fb93b46bcb7450b", "parents": [ "c6ff17bc79f7d6019295c1e3ec5973d2f53f8009" ], "author": { "name": "Nico Huber", "email": "nico.huber@secunet.com", "time": "Wed Jun 09 18:08:48 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Sun Jan 29 12:29:02 2023 +0000" }, "message": "dummyflasher: Replace another case of `sizeof(struct ...)`\n\nUsing the pointer\u0027s type instead ensures that we get the right size even\nif code changes in the future.\n\nChange-Id: If88ba394095f86c598dcc5cf1751e1c23b132d04\nSigned-off-by: Nico Huber \u003cnico.huber@secunet.com\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/55358\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-by: Anastasia Klimchuk \u003caklm@chromium.org\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/72208\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\n" }, { "commit": "c6ff17bc79f7d6019295c1e3ec5973d2f53f8009", "tree": "046085819074716e50b364eea081ac59d485c221", "parents": [ "b131342f07e526e35cac4bae8f0c5c7c6dffdcf8" ], "author": { "name": "Anastasia Klimchuk", "email": "aklm@chromium.org", "time": "Mon May 24 09:55:03 2021 +1000" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Sun Jan 29 12:29:02 2023 +0000" }, "message": "serprog.c: Separate shutdown from failed init cleanup\n\nShutdown function was covering two different jobs here: 1) the actual\nshutdown which is run at the end of the driver\u0027s lifecycle and\n2) cleanup in cases when initialisation failed. Now, shutdown is only\ndoing its main job (#1), and the driver itself is doing cleanup\nwhen init fails (#2).\n\nThe good thing is that now resources are released/closed immediately\nin cases when init fails (vs shutdown function which was run at some\npoint later), and the driver leaves clean space after itself if init\nfails.\n\nAnd very importantly this unlocks API change which plans to move\nregister_shutdown inside register master API, see\nhttps://review.coreboot.org/c/flashrom/+/51761\n\nChange-Id: Idf4ed62c19667e18cc807913180c48cb8c978805\nSigned-off-by: Anastasia Klimchuk \u003caklm@chromium.org\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/54861\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/72207\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "b131342f07e526e35cac4bae8f0c5c7c6dffdcf8", "tree": "83a8b24277cced0cc8cad56b5e518b0f59cdcd82", "parents": [ "f7504a954460f14565cb052c6cef1c9f57988acd" ], "author": { "name": "Edward O\u0027Callaghan", "email": "quasisec@google.com", "time": "Thu May 20 20:27:59 2021 +1000" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Sun Jan 29 12:29:02 2023 +0000" }, "message": "dummyflasher.c: Move \u0027spi_write_256_chunksize\u0027 into emu_data\n\nMove \u0027spi_write_256_chunksize\u0027 out of global scope and\ninto the emu_data reentrent struct.\n\nChange-Id: I633f4df4bd47e661cd69801f21910b667899d505\nSigned-off-by: Edward O\u0027Callaghan \u003cquasisec@google.com\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/54721\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/72206\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "f7504a954460f14565cb052c6cef1c9f57988acd", "tree": "5ce18791eb60743c39d3c365ff2caa463acc8367", "parents": [ "a7389154d56492548c2c1865081c25cc297d967f" ], "author": { "name": "Edward O\u0027Callaghan", "email": "quasisec@google.com", "time": "Thu May 20 20:21:13 2021 +1000" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Sun Jan 29 12:29:02 2023 +0000" }, "message": "dummyflasher.c: Make entry struct names consistent\n\nJust make spi_master_dummyflasher and par_master_dummyflasher\nidentifiers consistently named for easier parsing.\n\nChange-Id: Ib8ade96c47b4e4d358ba1fe34d06f22de326c60a\nSigned-off-by: Edward O\u0027Callaghan \u003cquasisec@google.com\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/54720\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/72205\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "a7389154d56492548c2c1865081c25cc297d967f", "tree": "4c3693e28ee0b86303a47eb5110f537b7e330296", "parents": [ "842b4ee5857614b64f685be914916f6c9b322d91" ], "author": { "name": "Anastasia Klimchuk", "email": "aklm@chromium.org", "time": "Fri May 21 09:45:53 2021 +1000" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Sun Jan 29 12:29:02 2023 +0000" }, "message": "programmer: Make use of new register_par_master() API\n\nPass pointers to dynamically allocated data to register_par_master().\nThis way we can avoid a mutable global.\n\nChange-Id: I76572e43d01f8a5e1aa73b1b9e8a187465ed8fef\nSigned-off-by: Anastasia Klimchuk \u003caklm@chromium.org\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/54172\nOriginal-Reviewed-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/72204\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "842b4ee5857614b64f685be914916f6c9b322d91", "tree": "f342bbf421abbc732f912a6fc0d48961ac6f28a3", "parents": [ "21b20218a6128c1880eceb634101df176b56692d" ], "author": { "name": "Anastasia Klimchuk", "email": "aklm@chromium.org", "time": "Thu May 13 12:56:51 2021 +1000" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Sun Jan 29 12:29:02 2023 +0000" }, "message": "programmer: Make use of new register_opaque_master() API\n\nPass pointers to dynamically allocated data to\nregister_opaque_master(). This way we can avoid a mutable global.\n\nChange-Id: I160810cd67f782131962e96fc6d20e2987fb0390\nSigned-off-by: Anastasia Klimchuk \u003caklm@chromium.org\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/54171\nOriginal-Reviewed-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nOriginal-Reviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/72203\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "21b20218a6128c1880eceb634101df176b56692d", "tree": "84402bf4e4ac933b023ac6e1c56f4a693ef522bc", "parents": [ "b91a203091fc43824bc57f3c8e2db0bcc311da59" ], "author": { "name": "Anastasia Klimchuk", "email": "aklm@chromium.org", "time": "Thu May 13 12:28:47 2021 +1000" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Sun Jan 29 12:29:02 2023 +0000" }, "message": "programmer: Smoothen register_opaque_master() API\n\nIt was impossible to register a const struct opaque_master that would\npoint to dynamically allocated `data`. Fix that so that we won\u0027t\nhave to create more mutable globals.\n\nChange-Id: Id3adb4cf04ae04dbe87ddb96f30871cb5f7c8ff0\nSigned-off-by: Anastasia Klimchuk \u003caklm@chromium.org\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/54170\nOriginal-Reviewed-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nOriginal-Reviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/72202\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "b91a203091fc43824bc57f3c8e2db0bcc311da59", "tree": "8fffff062afae6b9ce853c69a6636bc33bcabbbc", "parents": [ "03f3a6d13e8bd62ef84ef6a4a6f21d6fb8b2a7b8" ], "author": { "name": "Anastasia Klimchuk", "email": "aklm@chromium.org", "time": "Fri May 21 09:40:58 2021 +1000" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Sun Jan 29 12:29:02 2023 +0000" }, "message": "programmer: Smoothen register_par_master API\n\nIt was impossible to register a const struct par_master that would\npoint to dynamically allocated `data`. Fix that so that we won\u0027t\nhave to create more mutable globals.\n\nChange-Id: I95bc92f6c54c5bcdac1c522ca87054aaffed0f40\nSigned-off-by: Anastasia Klimchuk \u003caklm@chromium.org\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/54169\nOriginal-Reviewed-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/72201\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "03f3a6d13e8bd62ef84ef6a4a6f21d6fb8b2a7b8", "tree": "0fc0ec55b781d30d58a9b2fbc4b2e0c1ec83aab2", "parents": [ "5e08e3e829e3f736e18cef7b8f4a8929c9e06257" ], "author": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Tue May 11 17:53:34 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Sun Jan 29 12:29:02 2023 +0000" }, "message": "programmer: Make use of new register_spi_master() API\n\nPass pointers to dynamically allocated data to register_spi_master().\nThis way we can avoid some mutable globals.\n\nflashrom-stable: Updated `dirtyjtag_spi` and `dediprog`\n that were added/refactored earlier.\n\nChange-Id: Id7821f1db3284b7b5b3d0abfd878b979c53870a1\nSigned-off-by: Nico Huber \u003cnico.h@gmx.de\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/54067\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/72200\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "5e08e3e829e3f736e18cef7b8f4a8929c9e06257", "tree": "cfe9483275582e2ff2a50628824cf8e842c1feef", "parents": [ "6c33185c81f4aab0d048be7c4b68dca1a91800c2" ], "author": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Tue May 11 17:38:14 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Sun Jan 29 12:29:02 2023 +0000" }, "message": "programmer: Smoothen register_spi_master() API\n\nIt was impossible to register a const struct spi_master that would\npoint to dynamically allocated `data`. Fix that so that we won\u0027t\nhave to create more mutable globals.\n\nChange-Id: I0c753b3db050fb87d4bbe2301a7ead854f28456f\nSigned-off-by: Nico Huber \u003cnico.h@gmx.de\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/54066\nOriginal-Reviewed-by: Anastasia Klimchuk \u003caklm@chromium.org\u003e\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/72179\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "6c33185c81f4aab0d048be7c4b68dca1a91800c2", "tree": "ed241371d6704ef905abf5fbf4f1a044b1f9505b", "parents": [ "3b32edb1c2ccb1dcc89b76fa3a77e164e08eb62d" ], "author": { "name": "Nikolai Artemiev", "email": "nartemiev@google.com", "time": "Sun May 09 11:37:38 2021 +1000" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Sun Jan 22 00:55:18 2023 +0000" }, "message": "linux_mtd: drop \u0027mtd_\u0027 prefix from variable/field names\n\nChange-Id: I2503c98e9111d1fecd911473f65eeea7031cfdc3\nSigned-off-by: Nikolai Artemiev \u003cnartemiev@google.com\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/53953\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/72178\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\n" }, { "commit": "3b32edb1c2ccb1dcc89b76fa3a77e164e08eb62d", "tree": "532efcb9169cc979ef18befc17f00c1237a2c043", "parents": [ "47e7d47f6684a61d960474a6162523fb90006009" ], "author": { "name": "Nikolai Artemiev", "email": "nartemiev@google.com", "time": "Sat May 08 19:00:06 2021 +1000" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Sun Jan 22 00:55:18 2023 +0000" }, "message": "linux_mtd: move global state into programmer data field\n\nTested: builds, reading /dev/mtd0 on Oak succeeds\n\nChange-Id: I5ce6900e4892ed5687cfddb245dfe5461a3e2e84\nSigned-off-by: Nikolai Artemiev \u003cnartemiev@google.com\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/53947\nOriginal-Reviewed-by: Anastasia Klimchuk \u003caklm@chromium.org\u003e\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/72177\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\n" }, { "commit": "47e7d47f6684a61d960474a6162523fb90006009", "tree": "b2639f85b5802fe748442eaa349926ab0def3cfd", "parents": [ "1c9c73a61a4d69392a253d1af3f0aec608af6484" ], "author": { "name": "Anastasia Klimchuk", "email": "aklm@chromium.org", "time": "Fri Apr 30 14:10:04 2021 +1000" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Sun Jan 22 00:55:18 2023 +0000" }, "message": "pickit2_spi.c: Refactor singleton states into reentrant pattern\n\nMove global singleton states into a struct and store within\nthe spi_master data field for the life-time of the driver.\n\nThis is one of the steps on the way to move spi_master data\nmemory management behind the initialisation API, for more\ncontext see other patches under the same topic \"register_master_api\".\n\nChange-Id: Ibacc4738bee02c371c41583d321e0337128ad18a\nSigned-off-by: Anastasia Klimchuk \u003caklm@chromium.org\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/52774\nOriginal-Reviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nOriginal-Reviewed-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/72176\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\n" }, { "commit": "1c9c73a61a4d69392a253d1af3f0aec608af6484", "tree": "87c68d3855eba59c189b42b4eaf2943545942375", "parents": [ "340b20faae9680f7abb28129c30990074fdc73d2" ], "author": { "name": "Anastasia Klimchuk", "email": "aklm@chromium.org", "time": "Fri Apr 30 11:25:44 2021 +1000" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Sun Jan 22 00:55:18 2023 +0000" }, "message": "pickit2_spi.c: Separate shutdown from failed init cleanup\n\nShutdown function was covering two different jobs here: 1) the actual\nshutdown which is run at the end of the driver\u0027s lifecycle and\n2) cleanup in cases when initialisation failed. Now, shutdown is only\ndoing its main job (#1), and the driver itself is doing cleanup\nwhen init fails (#2).\n\nThe good thing is that now resources are released/closed immediately\nin cases when init fails (vs shutdown function which was run at some\npoint later), and the driver leaves clean space after itself if init\nfails.\n\nAnd very importantly this unlocks API change which plans to move\nregister_shutdown inside register master API, see\nhttps://review.coreboot.org/c/flashrom/+/51761\n\nChange-Id: I1b672b33169a7a1b6ceab190ad3f48c2f35c3a1f\nSigned-off-by: Anastasia Klimchuk \u003caklm@chromium.org\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/52773\nOriginal-Reviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/72175\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\n" }, { "commit": "340b20faae9680f7abb28129c30990074fdc73d2", "tree": "bfb2cad38f0eb24b21c0cd5cb4133f3dc45e8967", "parents": [ "e4a9791b04627b4fcb0540cf5e2e60d9c4737128" ], "author": { "name": "Anastasia Klimchuk", "email": "aklm@chromium.org", "time": "Tue Apr 27 16:13:32 2021 +1000" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Sun Jan 22 00:55:18 2023 +0000" }, "message": "hwaccess.h: Split hwaccess.h and extract hwaccess_x86_io.h out of it\n\nThe change makes it possible to mock functions from hwaccess_x86_io.h\nin tests by replacing this header with a different one when built\nfor a test environment. The rest of hwaccess.h is fine and works\nfor the test environment.\n\nTested: make clean \u0026\u0026 make CONFIG_EVERYTHING\u003dyes VERSION\u003dnone\nBuild flashrom before and after this patch, flashrom binary\nis the same (diff flashrom_before flashrom_after shows no diffs)\n\nChange-Id: Idd04c7b36b24e9da339348a015df4f43a03744f7\nSigned-off-by: Anastasia Klimchuk \u003caklm@chromium.org\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/52499\nOriginal-Reviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/72174\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\n" }, { "commit": "e4a9791b04627b4fcb0540cf5e2e60d9c4737128", "tree": "1e32867b9214ce906b091f9e352c7337ee6d648e", "parents": [ "2a329665800a7f2c74414bff75f225a9e28eda47" ], "author": { "name": "Anastasia Klimchuk", "email": "aklm@chromium.org", "time": "Mon Apr 26 10:58:16 2021 +1000" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Sun Jan 22 00:55:18 2023 +0000" }, "message": "jlink_spi.c: Drop jaylink_ prefix for spi data struct members\n\nSince jaylink context and jaylink device handle are not global\nvariables anymore, but members of the struct jlink_spi_data,\njaylink_ prefix can be dropped from members names and moved to\nstruct variable name. Follow up on 52560.\n\nChange-Id: If6e68e0dabb6bfad1088ff975445961294bbc03d\nSigned-off-by: Anastasia Klimchuk \u003caklm@chromium.org\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/52661\nOriginal-Tested-by: Nico Huber \u003cnico.h@gmx.de\u003e\nOriginal-Reviewed-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nOriginal-Reviewed-by: Miklós Márton \u003cmartonmiklosqdev@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/72173\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\n" }, { "commit": "2a329665800a7f2c74414bff75f225a9e28eda47", "tree": "f08085ba0490871e9192ff1e25cf21f610a46ec8", "parents": [ "9e698f9063289d4cd291311f037f0818242059f0" ], "author": { "name": "Anastasia Klimchuk", "email": "aklm@chromium.org", "time": "Mon Apr 19 11:12:01 2021 +1000" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Sun Jan 22 00:55:18 2023 +0000" }, "message": "linux_spi.c: Drop some unnecessary initialisations and checks\n\nIn previous patches 52283, 52284, 52285 there were some unresolved\ncomments left, resolving [and replying to] all of that here.\n\nTested: builds and ninja test from 51487\n\nChange-Id: I27a718b515fc474f63b3e61be58a6f9302527559\nSigned-off-by: Anastasia Klimchuk \u003caklm@chromium.org\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/52492\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/72172\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\n" }, { "commit": "9e698f9063289d4cd291311f037f0818242059f0", "tree": "c3c53bb69ed2355d9099a7e80c63ec41e97b2dc4", "parents": [ "00c2e8023a845b87716256d9e00503a416ef559b" ], "author": { "name": "Anastasia Klimchuk", "email": "aklm@chromium.org", "time": "Wed Apr 21 12:21:49 2021 +1000" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Sun Jan 22 00:55:18 2023 +0000" }, "message": "jlink_spi.c: Refactor singleton states into reentrant pattern\n\nMove global singleton states into a struct and store within\nthe spi_master data field for the life-time of the driver.\n\nThis is one of the steps on the way to move spi_master data\nmemory management behind the initialisation API, for more\ncontext see other patches under the same topic \"register_master_api\".\n\nChange-Id: If13ad0c979ccf62ca4ccbd479d471c657895ef59\nSigned-off-by: Anastasia Klimchuk \u003caklm@chromium.org\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/52560\nOriginal-Reviewed-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-by: Miklós Márton \u003cmartonmiklosqdev@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/72171\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\n" }, { "commit": "00c2e8023a845b87716256d9e00503a416ef559b", "tree": "060fa28e3695327d74be59d73ff939ad06433822", "parents": [ "84f0392cce072ad52fa178869594fcf0bbf58647" ], "author": { "name": "Anastasia Klimchuk", "email": "aklm@chromium.org", "time": "Wed Apr 14 09:52:36 2021 +1000" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Sun Jan 22 00:55:18 2023 +0000" }, "message": "jlink_spi.c: Separate shutdown from failed init cleanup\n\nShutdown function was covering two different jobs here:\n1) the actual shutdown which is run at the end of the driver\u0027s\nlifecycle and 2) cleanup in cases when initialisation failed.\nNow, shutdown is only doing its main job (#1), and the driver\nitself is doing cleanup when init fails (#2).\n\nThe good thing is that now resources are released/closed immediately\nin cases when init fails (vs shutdown function which was run at some\npoint later), and the driver leaves clean space after itself\nif init fails.\n\nAnd very importantly this unlocks API change which plans to move\nregister_shutdown inside register master API, see this\nhttps://review.coreboot.org/c/flashrom/+/51761\n\nChange-Id: I71f64ed38154af670d4d28b8c7914d87fbc75679\nSigned-off-by: Anastasia Klimchuk \u003caklm@chromium.org\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/52308\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/72170\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\n" }, { "commit": "84f0392cce072ad52fa178869594fcf0bbf58647", "tree": "4ad9368cba17dbdde5a43a93ee23d80fc0a02a23", "parents": [ "f876c0fd309cd7c2293ca4579f482bb28148f63c" ], "author": { "name": "Anastasia Klimchuk", "email": "aklm@chromium.org", "time": "Tue Apr 13 11:26:25 2021 +1000" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Sun Jan 22 00:55:18 2023 +0000" }, "message": "linux_spi.c: Refactor singleton states into reentrant pattern\n\nMove global singleton states into a struct and store within\nthe spi_master data field for the life-time of the driver.\n\nThis is one of the steps on the way to move spi_master data\nmemory management behind the initialisation API, for more\ncontext see other patches under the same topic \"register_master_api\".\n\nChange-Id: I93408c2ca846fca6a1c7eda7180862c51bd48078\nSigned-off-by: Anastasia Klimchuk \u003caklm@chromium.org\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/52285\nOriginal-Reviewed-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/72169\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\n" }, { "commit": "f876c0fd309cd7c2293ca4579f482bb28148f63c", "tree": "03319f9840dc35d9273aa71c435971855bee30f9", "parents": [ "c19ef9b30bfbace8b50985af104c35ffad7e576f" ], "author": { "name": "Anastasia Klimchuk", "email": "aklm@chromium.org", "time": "Tue Apr 13 10:15:26 2021 +1000" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Sun Jan 22 00:55:18 2023 +0000" }, "message": "linux_spi.c: Separate shutdown from failed init cleanup\n\nShutdown function was covering two different jobs here:\n1) the actual shutdown which is run at the end of the driver\u0027s\nlifecycle and 2) cleanup in cases when initialisation failed.\nNow, shutdown is only doing its main job (#1), and the driver\nitself is doing cleanup when init fails (#2).\n\nThe good thing is that now resources are released/closed immediately\nin cases when init fails (vs shutdown function which was run at some\npoint later), and the driver leaves clean space after itself if init fails.\n\nAnd very importantly this unlocks API change which plans to move\nregister_shutdown inside register master API, see this\nhttps://review.coreboot.org/c/flashrom/+/51761\n\nChange-Id: I1c8da2878cd0e85a1e43ba9b4b8e6f3d9f38ae5c\nSigned-off-by: Anastasia Klimchuk \u003caklm@chromium.org\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/52284\nOriginal-Reviewed-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/72168\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\n" }, { "commit": "c19ef9b30bfbace8b50985af104c35ffad7e576f", "tree": "f3c9b4fe5d1cd0d9cf6dafba7386a289ea3807d9", "parents": [ "8577756804bcb21acb715b8c301eb71997f05b4a" ], "author": { "name": "Anastasia Klimchuk", "email": "aklm@chromium.org", "time": "Mon Apr 12 16:52:58 2021 +1000" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Sun Jan 22 00:55:18 2023 +0000" }, "message": "linux_spi.c: Extract get_max_kernel_buf_size() as a function\n\nTo get max_kernel_buf_size is a piece of logic on its own, it opens\nresources and closes resources, also has some local variables only\nfor this task. Extracting get_max_kernel_buf_size() as a separate\nfunction simplifies init flow and allows to remove global state from linux_spi\n(see next patches in this chain).\n\nChange-Id: I4b8c5775fb8f4b0dff702fcc0fb258221254c659\nSigned-off-by: Anastasia Klimchuk \u003caklm@chromium.org\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/52283\nOriginal-Reviewed-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/72167\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\n" }, { "commit": "8577756804bcb21acb715b8c301eb71997f05b4a", "tree": "4618e519b2d1d640c0da7db72497a7a82bd6940b", "parents": [ "d1fbc465c6625b1f84378c603c335f6f794a0ee1" ], "author": { "name": "Jack Rosenthal", "email": "jrosenth@chromium.org", "time": "Fri Apr 09 10:03:14 2021 -0600" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Sun Jan 22 00:55:18 2023 +0000" }, "message": "cli_classic: prevent corruption of flash when stdout/stderr is closed\n\nWhile it\u0027s not posixly-correct, it\u0027s possible that a user, script, or\napplication may attempt to start flashrom with stdout or stderr\nclosed. It\u0027s possible that we\u0027ll get a file descriptor of 1 or 2 when\nopening a flash device (such as Linux MTD), and flashrom will send\ngarbage debug logs to the flash:\n\n # bash -c \"exec \u003e\u0026- flashrom ...\"\n\n Observed corruption:\n 43 40 45 42 45 44 00 00 00 00 00 00 01 00 00 00 |C@EBED..........|\n 00 02 00 00 63 65 73 73 66 75 6c 6c 79 0a 46 6f |....cessfully.Fo|\n 75 6e 64 20 50 72 6f 67 72 61 6d 6d 65 72 20 66 |und Programmer f|\n 6c 61 73 68 20 63 68 69 70 20 22 4f 70 61 71 75 |lash chip \"Opaqu|\n 65 20 66 6c 61 73 68 20 63 68 69 70 22 20 28 38 |e flash chip\" (8|\n 31 39 32 20 6b 42 2c 20 50 72 6f 67 72 61 6d 6d |192 kB, Programm|\n 65 72 2d 73 70 65 63 69 66 69 63 29 20 6d 61 70 |er-specific) map|\n 70 65 64 20 61 74 20 70 68 79 73 69 63 61 6c 20 |ped at physical |\n 61 64 64 72 65 73 73 20 30 78 30 30 30 30 30 30 |address 0x000000|\n 30 30 2e 0a ff ff ff ff ff ff ff ff ff ff ff ff |00..............|\n ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff ff |................|\n ...\n\nWhile for most applications, closing stdout or stderr would just lead\nto obsure bugs, for flashrom, we should have extra safety guards, as\nthis could mean that we might be bricking a device instead.\n\nAdd a basic safety check.\n\nSigned-off-by: Jack Rosenthal \u003cjrosenth@chromium.org\u003e\nChange-Id: I751c9dd88ad1d30283b94bd2185b4f8f25569c8f\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/52215\nOriginal-Reviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/72166\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\n" }, { "commit": "d1fbc465c6625b1f84378c603c335f6f794a0ee1", "tree": "14b0a8b64ecb4b2bd8f3e917c5429292fb7c0093", "parents": [ "405e72abc3d1bc7db8c7e132457d148cbc8b3dc6" ], "author": { "name": "Edward O\u0027Callaghan", "email": "quasisec@google.com", "time": "Sat Dec 19 11:57:30 2020 +1100" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Sun Jan 22 00:55:18 2023 +0000" }, "message": "chipdrivers.h: Trivial fix style of write_28sf040() signature\n\nThis is correct on the Chromium side so fix the missing space\nhere.\n\nChange-Id: I9dd27a4d8a1b87ce96b2a3f8cbe80f40c79b0354\nSigned-off-by: Edward O\u0027Callaghan \u003cquasisec@google.com\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/48744\nOriginal-Reviewed-by: Sam McNally \u003csammc@google.com\u003e\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/72165\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\n" }, { "commit": "405e72abc3d1bc7db8c7e132457d148cbc8b3dc6", "tree": "1ab726c3d9b16f04e7dc01d355e6437e6aa96b7f", "parents": [ "354c9d9f0dd4e9d163424a17329cfd2eca79c76b" ], "author": { "name": "Edward O\u0027Callaghan", "email": "quasisec@google.com", "time": "Sat Dec 19 11:21:49 2020 +1100" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Sun Jan 22 00:55:18 2023 +0000" }, "message": "layout.h,c: Use \u0027false\u0027 over \u00270\u0027 for bool type\n\nThe field member \u0027included\u0027 is of type boolean and so keep to\nusing \u0027true, false\u0027 values over numerics like \u00270\u0027. Get rid of\na unnecessary yet trivial tab at the end of layout.h while we\nare here.\n\nChange-Id: Ib594de2834175482ae5e36d9dd354ef2555c53d5\nSigned-off-by: Edward O\u0027Callaghan \u003cquasisec@google.com\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/48743\nOriginal-Reviewed-by: Sam McNally \u003csammc@google.com\u003e\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/72164\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\n" }, { "commit": "354c9d9f0dd4e9d163424a17329cfd2eca79c76b", "tree": "dcc3243ac5493f5cd3a78cfca51c40c138f0dd90", "parents": [ "30aba3419cde195bd2039920077cb433b768d1d0" ], "author": { "name": "Nikolai Artemiev", "email": "nartemiev@google.com", "time": "Thu Oct 15 13:47:56 2020 +1100" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Sun Jan 22 00:55:18 2023 +0000" }, "message": "fmap.{c,h}: update copyright year and name\n\nLooks like the year should be 2010 based on cros git history.\n\nSigned-off-by: Nikolai Artemiev \u003cnartemiev@google.com\u003e\nChange-Id: I7c27e682bd09f7b1ba0398dc231b9360aed1c26b\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/46440\nOriginal-Reviewed-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/72163\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\n" }, { "commit": "30aba3419cde195bd2039920077cb433b768d1d0", "tree": "0fbe83b8aaae5da049d4a728b63d49cf8c897a72", "parents": [ "518674c20d8dab1d6b877535b8b154079243fd32" ], "author": { "name": "Edward O\u0027Callaghan", "email": "quasisec@google.com", "time": "Fri Oct 16 12:15:08 2020 +1100" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Sun Jan 22 00:55:18 2023 +0000" }, "message": "spi25.c: Replace tab with space after \u0027\u003d\u0027 symbol\n\nTrivial, only noticed while diff\u0027ing with ChromiumOS fork.\n\nChange-Id: I247d9cb1910a9afdb0e7bfe81515d51514da6550\nSigned-off-by: Edward O\u0027Callaghan \u003cquasisec@google.com\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/46481\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/72162\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\n" }, { "commit": "518674c20d8dab1d6b877535b8b154079243fd32", "tree": "244af7cfe4453b930995f6a902ef1a9da321b9f0", "parents": [ "f7a84fdb326446478f946cd4cd7c6bbadc56e86b" ], "author": { "name": "Nikolai Artemiev", "email": "nartemiev@google.com", "time": "Wed Jun 24 18:53:03 2020 +1000" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Sun Jan 22 00:55:18 2023 +0000" }, "message": "ft2232_spi.c: align with Chrome OS flashrom\n\nBrings over various changes:\n- Use DIS_DIV_5 constant\n- Update some comments\n- Wrap long lines\n\nflashrom-stable: Kept long lines\n\nSigned-off-by: Nikolai Artemiev \u003cnartemiev@google.com\u003e\nChange-Id: I24c20e9b5d7e661d0180699bbd0d1447f6bf816f\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/42796\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/72161\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\n" }, { "commit": "f7a84fdb326446478f946cd4cd7c6bbadc56e86b", "tree": "29ee55e9cc2350a84283786a45ec79f9c7a0625c", "parents": [ "1d58a9006221f0de11a4cd7fff466b5a3c82e039" ], "author": { "name": "Daniel Campello", "email": "campello@chromium.org", "time": "Tue Mar 16 17:17:14 2021 -0600" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Fri Jan 13 17:45:11 2023 +0000" }, "message": "meson: Add print_wiki option\n\nAlign meson options to be equivalent to the Makefile as they are used in\nGentoo\u0027s ebuilds.\n\nSigned-off-by: Daniel Campello \u003ccampello@chromium.org\u003e\nChange-Id: I97d2fd687aa21533b86f9af446038bfe3da1f7d3\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/51552\nOriginal-Reviewed-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71764\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\n" }, { "commit": "1d58a9006221f0de11a4cd7fff466b5a3c82e039", "tree": "276aeba1635f6d25d305d434d74ce31ae81d7eef", "parents": [ "26c2c4d7393589f7b82edd95c5836933caa9b923" ], "author": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Tue Jan 10 18:26:12 2023 +0100" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Fri Jan 13 17:44:09 2023 +0000" }, "message": "Makefile: Update $(RELEASENAME) to `flashrom-stable-xxx`\n\nChange-Id: I4019f033787497e648f7e844677e2d0ab085323a\nSigned-off-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71800\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "26c2c4d7393589f7b82edd95c5836933caa9b923", "tree": "9d76bb192cb8c1c0bd874b6f755bc177fcec6250", "parents": [ "5f245a218d92d8f0280e4c5d8bd8c70d21e5e166" ], "author": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Tue Jan 10 17:45:38 2023 +0100" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Fri Jan 13 17:44:09 2023 +0000" }, "message": "Makefile: Add helper targets for `branch` and `tag`\n\nAdd `branch` and `tag` targets to assist maintaining a checked-in\n`versioninfo.inc`. The version, for branch and tag names, is given\nas RELEASE on the command line, e.g.\n\n $ make branch RELEASE\u003d1.0.x\n\nChange-Id: Ieaa125e5168c5ce1d1aa3bb6857c648aa0c43ede\nSigned-off-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71779\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "5f245a218d92d8f0280e4c5d8bd8c70d21e5e166", "tree": "304463eba20d13a1a4466a85e6242081b82cec7e", "parents": [ "4bcc9a3424e3b2226687723e83a7bb8256288bf4" ], "author": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Tue Jan 10 17:14:47 2023 +0100" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Fri Jan 13 17:44:09 2023 +0000" }, "message": "Makefile: Add `versioninfo` target, compare during export\n\nThere are other ways to generate a tarball beside our `tarball` make\ntarget. For instance, web-based Git UIs offer to export the tree as\nwell. Alas, such exports would lack any version information.\n\nA compromise is to check the version information in, but only on\nrelease branches. This is the first commit to add helpers to main-\ntain a checked-in `versioninfo.inc` on release branches.\n\nTo add a safety net, let the `_export` target fail if the checked-\nin `versioninfo.inc` is not up-to-date.\n\nChange-Id: I73cab7346ee470485c5f65ac499aff9cd15d98c7\nSigned-off-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71778\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "4bcc9a3424e3b2226687723e83a7bb8256288bf4", "tree": "3a00862d54e01fcc0f4ef23d4b6e1cb5a248260c", "parents": [ "5b2e5cb49f83adfb93c6c94185a4ad55a85f9ae5" ], "author": { "name": "Daniel Campello", "email": "campello@chromium.org", "time": "Wed Mar 17 18:03:28 2021 -0600" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Fri Jan 13 01:34:15 2023 +0000" }, "message": "meson: Generalise libflashrom product to link as static or dyn\n\nAllow the user to specify if they would like a static archive or a DSO\nproduced for libflashrom by way of the flag e.g. `-Ddefault_library\u003dstatic`.\n\nSigned-off-by: Daniel Campello \u003ccampello@chromium.org\u003e\nChange-Id: I77e5c298163979a0222270b3ac5d03542e5618f7\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/51616\nOriginal-Reviewed-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71767\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\n" }, { "commit": "5b2e5cb49f83adfb93c6c94185a4ad55a85f9ae5", "tree": "b01efb649d4042c7e84263777fe57e9e76201349", "parents": [ "21bcfa9ea0d27726d44fe9654580d128142ccf4f" ], "author": { "name": "Daniel Campello", "email": "campello@chromium.org", "time": "Mon Mar 29 16:55:17 2021 -0600" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Fri Jan 13 01:34:15 2023 +0000" }, "message": "meson: remove rayer_spi dependency on libpci\n\nThis change removes the build dependency on libpci for config_rayer_spi\nit also makes sure that dependency on raw_access is maintained.\n\nSigned-off-by: Daniel Campello \u003ccampello@chromium.org\u003e\nChange-Id: If7206a69d031c9bba9475a9e6769f6ef35701379\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/51929\nOriginal-Reviewed-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71766\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "21bcfa9ea0d27726d44fe9654580d128142ccf4f", "tree": "fdf007bf0aed45ffa9f3679b34d3895f7c82b361", "parents": [ "924e631e3e3b82fcb5f3b169c75a8df0908513ce" ], "author": { "name": "Samuel R. Messner", "email": "powpowd@gmail.com", "time": "Thu Feb 17 06:17:31 2022 +0100" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Fri Jan 13 01:34:15 2023 +0000" }, "message": "meson.build: Don\u0027t depend on getrevision.sh\n\n`getrevision.sh` isn\u0027t included in exported source code (including\nGitHub\u0027s auto-generated tarballs and ZIPs). Per issue #95, the build\nshouldn\u0027t depend on getrevision.sh for this reason. Previously,\nhowever, Flashrom would not build from exported source using Meson\ndue to it requiring `getrevision.sh`. This patch has Meson use the\nintended `getversion.sh` instead.\n\nSigned-off-by: Samuel R. Messner \u003cpowpowd@gmail.com\u003e\nChange-Id: Id8601155b35f0299200c27d0278606127410ff16\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/62061\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71765\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "924e631e3e3b82fcb5f3b169c75a8df0908513ce", "tree": "e86dee49e383a8a29bc1dc861afd421d194fa6f4", "parents": [ "3064943d4895274779d07525d6b146af7fa23899" ], "author": { "name": "Daniel Campello", "email": "campello@chromium.org", "time": "Wed Mar 17 09:14:11 2021 -0600" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Fri Jan 13 01:34:15 2023 +0000" }, "message": "meson: fix dependency on raw access\n\nThis is matching the following comment on Makefile:\n\n\\# This is a dirty hack, but it saves us from checking all PCI drivers and all platforms manually.\n\\# libpci may need raw memory, MSR or PCI port I/O on some platforms.\n\\# Individual drivers might have the same needs as well.\n\nThis changes fixes:\n\nld.lld: error: undefined symbol: rget_io_perms\n\u003e\u003e\u003e referenced by internal.c:243 (../flashrom-9999/internal.c:243)\n\u003e\u003e\u003e libflashrom.so.1.0.0.p/internal.c.o:(internal_init)\n\nld.lld: error: undefined symbol: mmio_writeb\n\u003e\u003e\u003e referenced by internal.c:122 (../flashrom-9999/internal.c:122)\n\u003e\u003e\u003e libflashrom.so.1.0.0.p/internal.c.o:(internal_chip_writeb)\n\nld.lld: error: undefined symbol: mmio_writew\n\u003e\u003e\u003e referenced by internal.c:128 (../flashrom-9999/internal.c:128)\n\u003e\u003e\u003e libflashrom.so.1.0.0.p/internal.c.o:(internal_chip_writew)\n\nld.lld: error: undefined symbol: mmio_writel\n\u003e\u003e\u003e referenced by internal.c:134 (../flashrom-9999/internal.c:134)\n\u003e\u003e\u003e libflashrom.so.1.0.0.p/internal.c.o:(internal_chip_writel)\n\nld.lld: error: undefined symbol: mmio_readb\n\u003e\u003e\u003e referenced by internal.c:140 (../flashrom-9999/internal.c:140)\n\u003e\u003e\u003e libflashrom.so.1.0.0.p/internal.c.o:(internal_chip_readb)\n\nld.lld: error: undefined symbol: mmio_readw\n\u003e\u003e\u003e referenced by internal.c:146 (../flashrom-9999/internal.c:146)\n\u003e\u003e\u003e libflashrom.so.1.0.0.p/internal.c.o:(internal_chip_readw)\n\nld.lld: error: undefined symbol: mmio_readl\n\u003e\u003e\u003e referenced by internal.c:152 (../flashrom-9999/internal.c:152)\n\u003e\u003e\u003e libflashrom.so.1.0.0.p/internal.c.o:(internal_chip_readl)\n\nld.lld: error: undefined symbol: mmio_readn\n\u003e\u003e\u003e referenced by internal.c:158 (../flashrom-9999/internal.c:158)\n\u003e\u003e\u003e libflashrom.so.1.0.0.p/internal.c.o:(internal_chip_readn)\n\nld.lld: error: undefined symbol: physmap\n\u003e\u003e\u003e referenced by flashrom.c:1454 (../flashrom-9999/flashrom.c:1454)\n\u003e\u003e\u003e libflashrom.so.1.0.0.p/flashrom.c.o:(probe_flash)\n\u003e\u003e\u003e referenced by flashrom.c:1454 (../flashrom-9999/flashrom.c:1454)\n\u003e\u003e\u003e libflashrom.so.1.0.0.p/flashrom.c.o:(probe_flash)\n\u003e\u003e\u003e referenced by flashrom.c\n\u003e\u003e\u003e libflashrom.so.1.0.0.p/flashrom.c.o:(programmer_table)\n\u003e\u003e\u003e referenced 2 more times\n\nld.lld: error: undefined symbol: physunmap\n\u003e\u003e\u003e referenced by flashrom.c\n\u003e\u003e\u003e libflashrom.so.1.0.0.p/flashrom.c.o:(programmer_table)\n\u003e\u003e\u003e referenced by flashrom.c\n\u003e\u003e\u003e libflashrom.so.1.0.0.p/flashrom.c.o:(programmer_table)\n\u003e\u003e\u003e referenced by flashrom.c\n\u003e\u003e\u003e libflashrom.so.1.0.0.p/flashrom.c.o:(programmer_table)\n\nflashrom-stable: Kept `need_raw_access` for `rayer_spi`, it\u0027s not PCI.\n\nChange-Id: Id3fa4ec7a735b81e989ba9fe2b53b18d0956627a\nSigned-off-by: Daniel Campello \u003ccampello@chromium.org\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/51577\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-by: Richard Hughes \u003chughsient@gmail.com\u003e\nOriginal-Reviewed-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71763\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "3064943d4895274779d07525d6b146af7fa23899", "tree": "9310d884fec055152d8fa5f087023abdef660fa7", "parents": [ "7ec2d6322c497d3c61830e4e86b7109c4a1d1165" ], "author": { "name": "Angel Pons", "email": "th3fanbus@gmail.com", "time": "Tue Jan 26 10:21:46 2021 +0100" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Fri Jan 13 01:34:15 2023 +0000" }, "message": "meson.build: Require at least meson 0.50.0\n\nThe `install` argument in `configure_file` is a feature introduced in\nmeson \u00270.50.0\u0027, but meson.build requests \u0027\u003e\u003d0.47.0\u0027. Meson complains:\n\n WARNING: Project targeting \u0027\u003e\u003d0.47.0\u0027 but tried to use feature\n introduced in \u00270.50.0\u0027: install arg in configure_file.\n\nTo correct this, adjust the `meson_version` value accordingly.\n\nChange-Id: Iadcffb7f8c720ffa8aa5f0ad62638d7b37f39934\nSigned-off-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/49924\nOriginal-Reviewed-by: Sam McNally \u003csammc@google.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71762\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "7ec2d6322c497d3c61830e4e86b7109c4a1d1165", "tree": "ce81934856665b0fe130302274a5eb6fc9cdc929", "parents": [ "566193f738b3885f05798111dd1806f5a8367952" ], "author": { "name": "Marc Schink", "email": "dev@zapb.de", "time": "Tue Dec 08 22:20:50 2020 +0100" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Fri Jan 13 01:34:15 2023 +0000" }, "message": "meson: Add missing config option for J-Link SPI\n\nSigned-off-by: Marc Schink \u003cdev@zapb.de\u003e\nChange-Id: I476c649f9db7342688560aac9ee5df056517a028\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/48478\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71761\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "566193f738b3885f05798111dd1806f5a8367952", "tree": "97079521a9dd09b887a7e7e96712b69cd1ca6eb0", "parents": [ "e2d61cd96f39b0d1da4f1bb2e73dd690a448962e" ], "author": { "name": "Rosen Penev", "email": "rosenp@gmail.com", "time": "Sat Jul 18 12:50:16 2020 -0700" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Fri Jan 13 01:34:15 2023 +0000" }, "message": "meson: fix compilation under uClibc-ng\n\nfileno requires _POSIX_C_SOURCE to only be defined.\n\nnanosleep requires _POSIX_C_SOURCE to be defined to 199309L.\n\nstrndup requires _POSIX_C_SOURCE to be defined to 200809L.\n\nChange-Id: Idb80937bb78e173eb03f2a0c0cdd8925fcd7bfa1\nSigned-off-by: Rosen Penev \u003crosenp@gmail.com\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/43599\nOriginal-Reviewed-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71760\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "e2d61cd96f39b0d1da4f1bb2e73dd690a448962e", "tree": "538163c090a66153e1fe8800ecbaefbe4c685ac3", "parents": [ "dad3a16e252142df49694e9b5db9e002e41eb9a1" ], "author": { "name": "Richard Hughes", "email": "richard@hughsie.com", "time": "Tue Jun 09 13:34:23 2020 +0100" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Fri Jan 13 01:34:15 2023 +0000" }, "message": "meson: Do not compile with -DSTANDALONE\n\nThis enables the -o option which is used to collect logs for debugging.\n\nChange-Id: If6c12c682ba72cd519e30f1f8c96552322ff75e3\nSigned-off-by: Richard Hughes \u003crichard@hughsie.com\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/42230\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-by: Matt DeVillier \u003cmatt.devillier@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71739\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "dad3a16e252142df49694e9b5db9e002e41eb9a1", "tree": "166ada4dbef3c3f2f517bfd9f7a211bf79ca715e", "parents": [ "40407b60cccd64a655647d48a80d686ddafc4b13" ], "author": { "name": "Richard Hughes", "email": "richard@hughsie.com", "time": "Mon Feb 17 09:57:01 2020 +0000" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Fri Jan 13 01:34:15 2023 +0000" }, "message": "Install the man file when using meson as a buildsystem\n\nThis fixes a regression with the Fedora package.\n\nChange-Id: I881bd5002a842072ce9dadea033c51a2668f9e7c\nSigned-off-by: Richard Hughes \u003crichard@hughsie.com\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/38939\nOriginal-Reviewed-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-by: David Hendricks \u003cdavid.hendricks@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71738\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "40407b60cccd64a655647d48a80d686ddafc4b13", "tree": "cc03a5ce347e3cbbac4b829026ed2578e194b4a8", "parents": [ "332fdabea41b542c7ab3f56d9c1d9c5fdc492d63" ], "author": { "name": "Idwer Vollering", "email": "vidwer@gmail.com", "time": "Tue Dec 08 00:24:39 2020 +0100" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Fri Jan 13 01:34:15 2023 +0000" }, "message": "cli_classic.c: fix minor cosmetic bug when support for wiki page generation is not compiled in\n\nChange-Id: I222fd7aa5d633fe81ef1894d67dcb25ba0dd8937\nSigned-off-by: Idwer Vollering \u003cvidwer@gmail.com\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/48430\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71736\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Elyes Haouas \u003cehaouas@noos.fr\u003e\n" }, { "commit": "332fdabea41b542c7ab3f56d9c1d9c5fdc492d63", "tree": "09325ad92002fdd2a6600a6215f81a6c6bc8badb", "parents": [ "c92f6876ed82488365c3ef1c59dd4669eb512527" ], "author": { "name": "Angel Pons", "email": "th3fanbus@gmail.com", "time": "Wed Dec 21 16:34:39 2022 +0100" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Fri Jan 13 01:34:15 2023 +0000" }, "message": "amd_imc.c: Fix unusual typo in log message\n\nReplace a `)` with a `.` for consistency with other log messages.\n\nChange-Id: I977990237821f6aec8f127bc3994a1f3f3a0a350\nSigned-off-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/71184\nOriginal-Reviewed-by: Felix Singer \u003cfelixsinger@posteo.net\u003e\nOriginal-Reviewed-by: Elyes Haouas \u003cehaouas@noos.fr\u003e\nOriginal-Reviewed-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71735\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Elyes Haouas \u003cehaouas@noos.fr\u003e\n" }, { "commit": "c92f6876ed82488365c3ef1c59dd4669eb512527", "tree": "b1926b71b105e94f826c646e13d85d84a295e4e5", "parents": [ "a60f641a7f8b1a4cd602eecb8ddc247e40777400" ], "author": { "name": "Angel Pons", "email": "th3fanbus@gmail.com", "time": "Tue Mar 31 15:32:10 2020 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Fri Jan 13 01:34:15 2023 +0000" }, "message": "spi25.c: Add a null check\n\nChange-Id: I5fcc23d81b8404af90768afa2954509bf334ab2c\nSigned-off-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/39974\nOriginal-Reviewed-by: HAOUAS Elyes \u003cehaouas@noos.fr\u003e\nOriginal-Reviewed-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71734\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\n" }, { "commit": "a60f641a7f8b1a4cd602eecb8ddc247e40777400", "tree": "91cb81687cbd41227f4c40ab2c07a75f210169a0", "parents": [ "721396876e9bca4307e46fe01bb9c0936e01d234" ], "author": { "name": "Angel Pons", "email": "th3fanbus@gmail.com", "time": "Tue Mar 31 15:02:02 2020 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Fri Jan 13 01:34:15 2023 +0000" }, "message": "cli_classic.c: Prevent memory leak\n\nIf the `--flash-contents` switch is specified more than once, it will\nresult in a memory leak. Therefore, allow this option only once.\n\nChange-Id: I530933c9a6431580fe4645396bb363939472a80a\nSigned-off-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/39972\nOriginal-Reviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71733\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\n" }, { "commit": "721396876e9bca4307e46fe01bb9c0936e01d234", "tree": "4109135dd8b818a0b3d49888dbb8616d7f1135f2", "parents": [ "ac90af6cdc747bfe3dc38c83c0b7272addf37659" ], "author": { "name": "Michael Niewöhner", "email": "foss@mniewoehner.de", "time": "Tue Sep 21 20:14:42 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Fri Jan 13 01:34:15 2023 +0000" }, "message": "flashrom.8: replace `svn changelog` with `git history`\n\nChange-Id: If8659dd603cbabdb8e20d89f818072986373e24f\nSigned-off-by: Michael Niewöhner \u003cfoss@mniewoehner.de\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/57811\nOriginal-Reviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71732\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\n" }, { "commit": "ac90af6cdc747bfe3dc38c83c0b7272addf37659", "tree": "ec67fd7c4d01db82b5a1ffd8c8ed36a7229108dd", "parents": [ "bb4f3b06dcfb60a6ab84750c9b149482dc5ee579" ], "author": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Sun Dec 18 00:22:47 2022 +0000" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Fri Jan 13 01:34:15 2023 +0000" }, "message": "Change references to flashrom-stable\n\nAdapt all mentions of the mailing list and also the version print.\n\nChange-Id: Ib4a3271422ee6cf4d0efb8c3fa858b66a22c0a33\nSigned-off-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/70922\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "bb4f3b06dcfb60a6ab84750c9b149482dc5ee579", "tree": "d6fb2ecdbf18b14ab226e450f298f8976cc063ca", "parents": [ "f60f64fe5aa6c3f30a994b35d614a048f026e501" ], "author": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Fri Dec 30 14:28:06 2022 +0100" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Fri Jan 13 01:34:15 2023 +0000" }, "message": "cli_common: Skip printing WP test status\n\nFirst version of flashrom-stable won\u0027t have CLI support for write\nprotection. Hence remove messages that could confuse the user.\n\nChange-Id: Ia654d3dd69be9778608d8f8762d6531893ff60d0\nSigned-off-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71557\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "f60f64fe5aa6c3f30a994b35d614a048f026e501", "tree": "5893ca00ee1a07fae312c95ee963b4a358af63e7", "parents": [ "245973b44fe9702f74894068840128d8a11eb8ee" ], "author": { "name": "Edward O\u0027Callaghan", "email": "quasisec@google.com", "time": "Sat Nov 12 12:08:01 2022 +1100" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:46:20 2023 +0000" }, "message": "flashrom.c: Position heap alloc along side check in compare_range()\n\nChange-Id: I0386ac4c09a541cb9a659b2410ce49c3292ecc6e\nSigned-off-by: Edward O\u0027Callaghan \u003cquasisec@google.com\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/69473\nOriginal-Reviewed-by: Felix Singer \u003cfelixsinger@posteo.net\u003e\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-by: Alexander Goncharov \u003cchat@joursoir.net\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71499\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\n" }, { "commit": "245973b44fe9702f74894068840128d8a11eb8ee", "tree": "f3918b3c7fba90725ab38499a1dd2fcdd530a026", "parents": [ "a31a572b44f95841c74d48e692586a46595dd928" ], "author": { "name": "Felix Singer", "email": "felixsinger@posteo.net", "time": "Fri Dec 02 03:08:27 2022 +0100" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:46:20 2023 +0000" }, "message": "cbtables.c/search_lb_records: Drop unused variable `count`\n\nClang 15 complains about it. Remove it.\n\nSigned-off-by: Felix Singer \u003cfelixsinger@posteo.net\u003e\nChange-Id: I340208f513bed57a9cc2bba880a2400352c5cc42\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/70247\nOriginal-Reviewed-by: Anastasia Klimchuk \u003caklm@chromium.org\u003e\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71498\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "a31a572b44f95841c74d48e692586a46595dd928", "tree": "72fb17517f6e6084c4443d0aa7b9332b315519af", "parents": [ "bd27581be60e7c59b3d0f814467260196c261281" ], "author": { "name": "Edward O\u0027Callaghan", "email": "quasisec@google.com", "time": "Sat Nov 12 12:05:36 2022 +1100" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:46:20 2023 +0000" }, "message": "tree/: Make heap alloc checks err msg consistent\n\nChange-Id: Id84a9f15c33781efc494ed36a1c7cec82a0333d6\nSigned-off-by: Edward O\u0027Callaghan \u003cquasisec@google.com\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/69472\nOriginal-Reviewed-by: Felix Singer \u003cfelixsinger@posteo.net\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71497\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "bd27581be60e7c59b3d0f814467260196c261281", "tree": "b444aee0a4bed45d7276377c89d57ddf852e16e3", "parents": [ "7db7059e0ebe1b655c352dec8cf99fe31cc3876b" ], "author": { "name": "Edward O\u0027Callaghan", "email": "quasisec@google.com", "time": "Mon Nov 28 11:20:44 2022 +1100" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:35:01 2023 +0000" }, "message": "internal.c: laptop_ok global state can become stale\n\nCraask and similar DUT\u0027s are erroneously probing random second chips.\n\n```\nFound chipset \"Intel Alder Lake-N\".\nEnabling flash write... SPI Configuration is locked down.\nFREG0: Flash Descriptor region (0x00000000-0x00000fff) is read-write.\nFREG1: BIOS region (0x003a0000-0x00ffffff) is read-write.\nFREG2: Management Engine region (0x00001000-0x0039ffff) is read-write.\nOK.\nFound Winbond flash chip \"W25Q128.V..M\" (16384 kB, Programmer-specific) on host.\nWarning: Setting BIOS Control at 0xdc from 0x8b to 0x89 failed.\nNew value is 0x8b.\nFound MoselVitelic flash chip \"V29C51000T\" (64 kB, Parallel) mapped at physical address 0x00000000ffff0000.\n```\n\nThis seems to be due to `laptop_ok` becoming a stale global state\nafter the first operation leading to probing on unrelated buses.\n\nTherefore unconditionally reset the global state upon entry into\nthe internal driver.\n\nTested: Craask reportly no longer finds duplicate chip.\n\nChange-Id: I2c00c351904307eeb1488c5dfaffc91d6468ee25\nSigned-off-by: Edward O\u0027Callaghan \u003cquasisec@google.com\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/70026\nOriginal-Reviewed-by: Sam McNally \u003csammc@google.com\u003e\nOriginal-Reviewed-by: Anastasia Klimchuk \u003caklm@chromium.org\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71496\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\n" }, { "commit": "7db7059e0ebe1b655c352dec8cf99fe31cc3876b", "tree": "3136dc58205030072618b10f1b42cc2f0151e51c", "parents": [ "9441c6e36f4ad152125f110ed83a6d72a97a4b02" ], "author": { "name": "Edward O\u0027Callaghan", "email": "quasisec@google.com", "time": "Sat Nov 12 12:00:24 2022 +1100" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:35:01 2023 +0000" }, "message": "flashrom.c: Drop redundant chip read validation in verify_range()\n\nThe \u0027chip_safety_check()\u0027 already validates the chip structure\nwithin \u0027prepare_flash_access()\u0027 before all subsequent chip operations\nsuch as \u0027verify_range()\u0027 and therefore the chip structure is\nguaranteed to be valid in the domain of those operations.\n\nChange-Id: Ifc57dd89715115e03d013691352463a8b3c0dc52\nSigned-off-by: Edward O\u0027Callaghan \u003cquasisec@google.com\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/69471\nOriginal-Reviewed-by: Felix Singer \u003cfelixsinger@posteo.net\u003e\nOriginal-Reviewed-by: Anastasia Klimchuk \u003caklm@chromium.org\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71495\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "9441c6e36f4ad152125f110ed83a6d72a97a4b02", "tree": "8270188dfee8ed9ea9c9a304a11c6dd4d962b2a6", "parents": [ "0c8221bb4462d7410a4667ab3526502c5eaa241d" ], "author": { "name": "Felix Singer", "email": "felixsinger@posteo.net", "time": "Fri Oct 21 12:47:11 2022 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:35:01 2023 +0000" }, "message": "Makefile: Don\u0027t install git hooks automatically\n\nThese specific git hooks are only needed when someone wants to push a\npatch to upstream and so it\u0027s not needed to run it in every make call.\nBeside that, we also don\u0027t know the environment in which this is\nexecuted and it might not be wanted.\n\nThus, add a new make target `gitconfig` and move the install command to\nit. It can be used by running `make gitconfig`.\n\nflashrom-stable: Add `gitconfig` to the `.PHONY` targets.\n\nSigned-off-by: Felix Singer \u003cfelixsinger@posteo.net\u003e\nChange-Id: Ib83568c7ff149a8ec34ad7e92720c36a89def7bd\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/68647\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nOriginal-Reviewed-by: Anastasia Klimchuk \u003caklm@chromium.org\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71494\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "0c8221bb4462d7410a4667ab3526502c5eaa241d", "tree": "f2264704cde0950882873089f8c8d16154c401a1", "parents": [ "e28d8e4e2332054fb4b7f61e8ce03f316e3a63f3" ], "author": { "name": "Angel Pons", "email": "th3fanbus@gmail.com", "time": "Thu Oct 20 21:23:33 2022 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:35:01 2023 +0000" }, "message": "chipset_enable.c: Mark Intel C246 as DEP\n\nTested reading, writing and erasing the flash chip of a Prodrive\nHermes mainboard with an Intel C246 PCH. However, since ME-enabled\nchipsets are marked as DEP instead of OK, this one shall also be.\n\nChange-Id: I07d6c4a60e468c61eba836db91e1335f4a762048\nSigned-off-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/68594\nOriginal-Reviewed-by: Felix Singer \u003cfelixsinger@posteo.net\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71493\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "e28d8e4e2332054fb4b7f61e8ce03f316e3a63f3", "tree": "dcd1df2c485d8da20c2845e584bd157e0e4f63fb", "parents": [ "6a2ebebfabff9ae72f8f03076b015a6b21bf8b90" ], "author": { "name": "Jean THOMAS", "email": "virgule@jeanthomas.me", "time": "Tue Oct 11 17:54:30 2022 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:35:01 2023 +0000" }, "message": "dirtyjtag: Add DirtyJTAG programmer\n\nAdd a new programmer driver for the DirtyJTAG project (a USB-JTAG\nfirmware for STM32 MCUs).\n\nSuccessfully tested with DirtyJTAG 1.4 running on an Olimex STM32-H103\ndevelopment board and a SST25VF020B SPI flash chip.\n\nChange-Id: Ic43e9a014ed7d04e429e73b30c9dcfdde1a78913\nSigned-off-by: Jean THOMAS \u003cvirgule@jeanthomas.me\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/67878\nOriginal-Reviewed-by: Felix Singer \u003cfelixsinger@posteo.net\u003e\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71492\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "6a2ebebfabff9ae72f8f03076b015a6b21bf8b90", "tree": "1828bbf5c718a40a07c75eee81aa6df2062ed593", "parents": [ "dd5f69301cb36a00ce28868af9df1711eaf9fc17" ], "author": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Fri Aug 26 11:36:48 2022 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:35:01 2023 +0000" }, "message": "programmer_init: Work on a mutable copy of programmer params\n\nThe signature of extract_param() was wrong all the time. It actually\nmodifies the passed, global `programmer_param` string. This only com-\npiled w/o warnings because of a deficiency of the strstr() API. It\ntakes a const string as argument but returns a mutable pointer to\na substring of it.\n\nAs we take a const parameter string in the libflashrom API and should\nnot change that, we create a copy in programmer_init() instead.\n\nNow that we free our copy of the programmer parameters at the end of\nprogrammer_init() it\u0027s more obvious that the string can only be used\nduring initialization. So also clear `programmer_param` inside\nprogrammer_init() instead of programmer_shutdown().\n\nChange-Id: If6bb2e5e4312b07f756615984bd3757e92b86b0a\nSigned-off-by: Nico Huber \u003cnico.h@gmx.de\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/67094\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nOriginal-Reviewed-by: Thomas Heijligen \u003csrc@posteo.de\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71491\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "dd5f69301cb36a00ce28868af9df1711eaf9fc17", "tree": "21534da755e110c1dfc63b37dd03e5ba6d72cd3a", "parents": [ "2fb53b1f30ae7c811e3bfcf9fc96b8db9182e61f" ], "author": { "name": "Felix Singer", "email": "felixsinger@posteo.net", "time": "Fri Aug 19 03:33:27 2022 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:35:01 2023 +0000" }, "message": "dmi.c: Retype variable `anchored` with bool\n\nUse the bool type instead of an integer for the variable `anchored`,\nsince this represents its purpose much better.\n\nSigned-off-by: Felix Singer \u003cfelixsinger@posteo.net\u003e\nChange-Id: I5bedaf47cdd2fd5d152f69b6b02aab69fd1285c6\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/66903\nOriginal-Reviewed-by: Anastasia Klimchuk \u003caklm@chromium.org\u003e\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71490\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "2fb53b1f30ae7c811e3bfcf9fc96b8db9182e61f", "tree": "17ce3c1dc60eae86942d8e9302f7c173acfa6304", "parents": [ "d68a0ece50b2250ba25be67d27e8606247d5306c" ], "author": { "name": "Felix Singer", "email": "felixsinger@posteo.net", "time": "Fri Aug 19 03:29:32 2022 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:35:01 2023 +0000" }, "message": "dummyflasher.c: Retype appropriate variables and attributes with bool\n\nUse the bool type instead of an integer for appropriate variables and\nattributes, since this represents their purpose much better.\n\nSigned-off-by: Felix Singer \u003cfelixsinger@posteo.net\u003e\nChange-Id: I712b1ef7e1ad74d3e004dcf36c82898c88072c63\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/66901\nOriginal-Reviewed-by: Anastasia Klimchuk \u003caklm@chromium.org\u003e\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71489\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "d68a0ece50b2250ba25be67d27e8606247d5306c", "tree": "97d0a03f0b60954a0463ed2d1be9fc3237a867fb", "parents": [ "085572812789076e05faffd677264470dcea14c6" ], "author": { "name": "Felix Singer", "email": "felixsinger@posteo.net", "time": "Fri Aug 19 03:23:35 2022 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:35:01 2023 +0000" }, "message": "ich_descriptors.c: Retype variable `has_forbidden_opcode` with bool\n\nUse the bool type instead of an integer for the variable\n`has_forbidden_opcode`, since this represents its purpose much better.\n\nSigned-off-by: Felix Singer \u003cfelixsinger@posteo.net\u003e\nChange-Id: I6214956e377547b894fc76237832b6f7b2db41dd\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/66899\nOriginal-Reviewed-by: Anastasia Klimchuk \u003caklm@chromium.org\u003e\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71488\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "085572812789076e05faffd677264470dcea14c6", "tree": "8c3f0e3c0afe36319ec98f0a1f1ba5e631b5c990", "parents": [ "7b83f3c2e3e201faf63c04b8ec2477eb3ebe9577" ], "author": { "name": "Felix Singer", "email": "felixsinger@posteo.net", "time": "Fri Aug 19 03:19:06 2022 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:35:01 2023 +0000" }, "message": "fmap.c: Retype appropriate variables with bool\n\nUse the bool type instead of an integer for appropriate variables, since\nthis represents their purpose much better.\n\nSigned-off-by: Felix Singer \u003cfelixsinger@posteo.net\u003e\nChange-Id: I323d40cabe9c580057d870e742b3b55942c78321\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/66896\nOriginal-Reviewed-by: Anastasia Klimchuk \u003caklm@chromium.org\u003e\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71487\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "7b83f3c2e3e201faf63c04b8ec2477eb3ebe9577", "tree": "1e0857735df89e5508adbc7240d7c253081d2cfc", "parents": [ "d1ab7d2bb0c4ea7be2e251caa564ab91d27ee7ea" ], "author": { "name": "Felix Singer", "email": "felixsinger@posteo.net", "time": "Fri Aug 19 03:16:19 2022 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:35:01 2023 +0000" }, "message": "ft2232_spi.c: Retype variable `clock_5x` with bool\n\nUse the bool type instead of an integer for the variable `clock_5x`,\nsince this represents its purpose much better.\n\nSigned-off-by: Felix Singer \u003cfelixsinger@posteo.net\u003e\nChange-Id: Ie3005f9dcb2dcfe63261c52a36d865d175a0a75c\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/66895\nOriginal-Reviewed-by: Anastasia Klimchuk \u003caklm@chromium.org\u003e\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71486\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "d1ab7d2bb0c4ea7be2e251caa564ab91d27ee7ea", "tree": "905816b92fb3759fcb82767cb94b49d6e0f02594", "parents": [ "8cfc7377ffa880659660b344e97333986aba9130" ], "author": { "name": "Felix Singer", "email": "felixsinger@posteo.net", "time": "Fri Aug 19 03:03:47 2022 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:35:01 2023 +0000" }, "message": "tree: Retype variable `laptop_ok` with bool\n\nUse the bool type instead of an integer for the variable `laptop_ok`,\nsince this represents its purpose much better.\n\nSigned-off-by: Felix Singer \u003cfelixsinger@posteo.net\u003e\nChange-Id: I5d9fc3516bc2d29f11b056e35b3e5e324ce93423\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/66891\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-by: Anastasia Klimchuk \u003caklm@chromium.org\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71485\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "8cfc7377ffa880659660b344e97333986aba9130", "tree": "3ab74fbb322c79a63fed60c20077c42332408280", "parents": [ "980d6b8d712d26711dcd5a71007e4626c7198cd5" ], "author": { "name": "Felix Singer", "email": "felixsinger@posteo.net", "time": "Fri Aug 19 03:10:29 2022 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:35:01 2023 +0000" }, "message": "ichspi.c: Retype appropriate variables with bool\n\nUse the bool type instead of an integer for appropriate variables, since\nthis represents their purpose much better.\n\nSigned-off-by: Felix Singer \u003cfelixsinger@posteo.net\u003e\nChange-Id: If7eeacc44921f52aa593ab1302f17a5c5190f830\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/66892\nOriginal-Reviewed-by: Anastasia Klimchuk \u003caklm@chromium.org\u003e\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71484\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "980d6b8d712d26711dcd5a71007e4626c7198cd5", "tree": "38e926243e6a10734971066fd1602d373fd04784", "parents": [ "f25447e5724bd8664338b69b12399f101abed76b" ], "author": { "name": "Felix Singer", "email": "felixsinger@posteo.net", "time": "Fri Aug 19 02:48:15 2022 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:35:01 2023 +0000" }, "message": "tree: Retype variable `programmer_may_write` with bool\n\nUse the bool type instead of an integer for the variable\n`programmer_may_write`, since this represents its purpose much better.\n\nSigned-off-by: Felix Singer \u003cfelixsinger@posteo.net\u003e\nChange-Id: I69958527ae018a92f1c42734a7990d0c532dee0c\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/66885\nOriginal-Reviewed-by: Anastasia Klimchuk \u003caklm@chromium.org\u003e\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71483\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "f25447e5724bd8664338b69b12399f101abed76b", "tree": "98ffb81be1bf94c2f82dfe01a1441944c2b8be04", "parents": [ "2e003a0c9c0ce45fc7a34b68728227f1a83793ad" ], "author": { "name": "Felix Singer", "email": "felixsinger@posteo.net", "time": "Fri Aug 19 02:44:28 2022 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:35:01 2023 +0000" }, "message": "flashrom.c: Retype appropriate variables with bool\n\nUse the bool type instead of an integer for appropriate variables, since\nthis represents their purpose much better.\n\nSigned-off-by: Felix Singer \u003cfelixsinger@posteo.net\u003e\nChange-Id: I6629f391284c8f1266e4ba66c9976f3df43955d4\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/66883\nOriginal-Reviewed-by: Anastasia Klimchuk \u003caklm@chromium.org\u003e\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71482\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "2e003a0c9c0ce45fc7a34b68728227f1a83793ad", "tree": "15e9940fd1e3553643ba3ce7a7658de6f8369454", "parents": [ "815eb796ae636641db4c7bc74d867d31b2be4a6c" ], "author": { "name": "Felix Singer", "email": "felixsinger@posteo.net", "time": "Fri Aug 19 02:36:28 2022 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:35:01 2023 +0000" }, "message": "82802ab.c: Retype appropriate variables with bool\n\nUse the bool type instead of an integer for appropriate variables, since\nthis represents their purpose much better.\n\nSigned-off-by: Felix Singer \u003cfelixsinger@posteo.net\u003e\nChange-Id: I5dfd9ed4856c37dd70706b2dd71fbb9a8acbdf4c\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/66879\nOriginal-Reviewed-by: Anastasia Klimchuk \u003caklm@chromium.org\u003e\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71481\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "815eb796ae636641db4c7bc74d867d31b2be4a6c", "tree": "840ea6f02d716d4d54c3c5f3831dc8db39f5da27", "parents": [ "cf6b70883ea79aac874901184009a048bc46ec45" ], "author": { "name": "Felix Singer", "email": "felixsinger@posteo.net", "time": "Fri Aug 19 01:02:42 2022 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:35:01 2023 +0000" }, "message": "serprog.c: Retype variable `have_device` with bool\n\nUse the bool type instead of an integer for the variable `have_device`,\nsince this represents its purpose much better.\n\nSigned-off-by: Felix Singer \u003cfelixsinger@posteo.net\u003e\nChange-Id: Ia12f1503ae3f7be20a065f22b4ab84c4140cd23e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/66878\nOriginal-Reviewed-by: Anastasia Klimchuk \u003caklm@chromium.org\u003e\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71480\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "cf6b70883ea79aac874901184009a048bc46ec45", "tree": "23c4e7584b0f5e744066ec548126b71b6629f902", "parents": [ "316ef019e04c402423bb4602aa9f5f231062b175" ], "author": { "name": "Felix Singer", "email": "felixsinger@posteo.net", "time": "Thu Aug 18 23:57:31 2022 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:35:01 2023 +0000" }, "message": "buspirate_spi.c: Retype appropriate variables with bool\n\nUse the bool type instead of integer for appropriate variables, since\nthis represents their purpose much better.\n\nSigned-off-by: Felix Singer \u003cfelixsinger@posteo.net\u003e\nChange-Id: I245616168796f2c7fe99388688b0f606bd3405bf\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/66868\nOriginal-Reviewed-by: Anastasia Klimchuk \u003caklm@chromium.org\u003e\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71479\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "316ef019e04c402423bb4602aa9f5f231062b175", "tree": "b99fb0f75c7c1943edcea0f1505f20d0a78b4594", "parents": [ "494fa833effc2de065a7beede123d1aa0d02afcb" ], "author": { "name": "Alexander Goncharov", "email": "chat@joursoir.net", "time": "Sun Aug 07 12:08:49 2022 +0300" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:35:01 2023 +0000" }, "message": "nicintel_eeprom: handle errors using goto for i210\u0027s shutdown\n\nThis patch prepares the programmer to move global singleton states\ninto a struct.\n\nTOPIC\u003dregister_master_api\n\nChange-Id: Idb4f75fa92966a0fffd83dd0e297f5f51f6c0bd3\nSigned-off-by: Alexander Goncharov \u003cchat@joursoir.net\u003e\nTicket: https://ticket.coreboot.org/issues/391\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/66491\nOriginal-Reviewed-by: Thomas Heijligen \u003csrc@posteo.de\u003e\nOriginal-Reviewed-by: Felix Singer \u003cfelixsinger@posteo.net\u003e\nOriginal-Reviewed-by: Anastasia Klimchuk \u003caklm@chromium.org\u003e\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71478\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "494fa833effc2de065a7beede123d1aa0d02afcb", "tree": "99f6f93765e54509e3ee9d2d16868ad6ac322185", "parents": [ "d42f1f65b023a4845feb1f7022eb8f2081a39b3d" ], "author": { "name": "direstraits96", "email": "56371107+direstraits96@users.noreply.github.com", "time": "Wed Feb 16 02:26:51 2022 +0000" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:35:01 2023 +0000" }, "message": "Add support for motherboard Jetway P4MDPT\n\nAdd support for motherboard Jetway P4MDPT. According to the author of\nthis patch, reading and writing works.\n\nFound on https://github.com/flashrom/flashrom/pull/241.\n\nChange-Id: I494863389d2afdb745d5c83a99cd955e6a5c334d\nSigned-off-by: Felix Singer \u003cfelixsinger@posteo.net\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/63919\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nOriginal-Reviewed-by: Thomas Heijligen \u003csrc@posteo.de\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71477\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "d42f1f65b023a4845feb1f7022eb8f2081a39b3d", "tree": "4c2b2af39bf959103a37efb8daa6c59270029927", "parents": [ "88e87c568678ab36c997c1c807d97b3b1e7091e6" ], "author": { "name": "Adrien Destugues", "email": "adrien.destugues@opensource.viveris.fr", "time": "Tue Aug 10 11:48:18 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:35:01 2023 +0000" }, "message": "nic3com: mark PCI id 9006 as supported\n\nAccording to the author of this patch, this has been tested and it\nworked.\n\nFound on https://github.com/flashrom/flashrom/pull/219.\n\nChange-Id: I88712d81b291c7ef4212bf19e284d270219fa908\nSigned-off-by: Felix Singer \u003cfelixsinger@posteo.net\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/63920\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nOriginal-Reviewed-by: Thomas Heijligen \u003csrc@posteo.de\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71476\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "88e87c568678ab36c997c1c807d97b3b1e7091e6", "tree": "fdd492a475759d50abca6c1fa5b61a7970bee032", "parents": [ "927c1f036fc6b3d9b6cb84c5cacc8e78ec7d28cc" ], "author": { "name": "Thomas Heijligen", "email": "thomas.heijligen@secunet.com", "time": "Fri Aug 05 17:56:20 2022 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:35:01 2023 +0000" }, "message": "tree: Check properly if libusb is initialized\n\nThe dediprog, developerbox_spi and stlinkv3_spi programmers only check\nif the libusb_context is not NULL after the initialization. But\nfollowing the API documentation from libusb, the context is undefined\nunless the init function returns 0. Fix this by checking the return\nvalue instead of the libusb_context to see if the initialization was\nsuccessful.\n\nhttps://libusb.sourceforge.io/api-1.0/group__libusb__lib.html\n\nChange-Id: Ia45ccd3fa2239dfccd821be46a09c86426cb22e5\nSigned-off-by: Thomas Heijligen \u003cthomas.heijligen@secunet.com\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/66460\nOriginal-Reviewed-by: Felix Singer \u003cfelixsinger@posteo.net\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71475\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "927c1f036fc6b3d9b6cb84c5cacc8e78ec7d28cc", "tree": "1393274311640dca4be11768ae87d71dfc9aec52", "parents": [ "48c3f1844888d7175106d2bd98262353e985e3cb" ], "author": { "name": "Edward O\u0027Callaghan", "email": "quasisec@google.com", "time": "Tue Aug 02 11:31:16 2022 +1000" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:35:01 2023 +0000" }, "message": "include/ich_descriptors.h: Add missing include\n\nAvoid transitively including the bool type for the ich_descriptor\nfunctionality.\n\nChange-Id: I2d9eb833ca9198c0586543d3f0074893aac5c6fb\nSigned-off-by: Edward O\u0027Callaghan \u003cquasisec@google.com\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/66348\nOriginal-Reviewed-by: Matei Dibu \u003cmatdibu@protonmail.com\u003e\nOriginal-Reviewed-by: Thomas Heijligen \u003csrc@posteo.de\u003e\nOriginal-Reviewed-by: Felix Singer \u003cfelixsinger@posteo.net\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71474\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "48c3f1844888d7175106d2bd98262353e985e3cb", "tree": "19bd3d2df41fea256e2e3068c4e5d8f5abb7981b", "parents": [ "d07c4a40d376c77cab0073ec8bca6724c7c291d5" ], "author": { "name": "Felix Singer", "email": "felixsinger@posteo.net", "time": "Fri Jul 29 03:16:19 2022 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:35:01 2023 +0000" }, "message": "pickit2_spi.c: Use a variable to store the total packetsize\n\nInstead of calculating the total packetsize multiple times, use a\nvariable instead.\n\nSigned-off-by: Felix Singer \u003cfelixsinger@posteo.net\u003e\nChange-Id: I714054669e16dcf531a57174f9522b3af72d2754\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/66251\nOriginal-Reviewed-by: Anastasia Klimchuk \u003caklm@chromium.org\u003e\nOriginal-Reviewed-by: Thomas Heijligen \u003csrc@posteo.de\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71473\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "d07c4a40d376c77cab0073ec8bca6724c7c291d5", "tree": "c4faf094b38ef81f91744ddba8f22ac84a5b7230", "parents": [ "75d6ec647ca0d398fb7ec33b7293e5f57294834e" ], "author": { "name": "Felix Singer", "email": "felixsinger@posteo.net", "time": "Fri Jul 29 03:09:02 2022 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:35:01 2023 +0000" }, "message": "pickit2_spi.c: Replace hard-coded value with define in msg_perr()\n\nSigned-off-by: Felix Singer \u003cfelixsinger@posteo.net\u003e\nChange-Id: Ia3fa89285d8761e51078afa486df50a7b8247fc5\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/66250\nOriginal-Reviewed-by: Anastasia Klimchuk \u003caklm@chromium.org\u003e\nOriginal-Reviewed-by: Thomas Heijligen \u003csrc@posteo.de\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71472\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "75d6ec647ca0d398fb7ec33b7293e5f57294834e", "tree": "0e6a9138d2bfe506b7f8bef0e9a22870833baace", "parents": [ "9beddb69184fa60473b0ba5b0d6ccadfde6157d3" ], "author": { "name": "Angel Pons", "email": "th3fanbus@gmail.com", "time": "Sat Jul 16 12:12:50 2022 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:35:01 2023 +0000" }, "message": "pickit2_spi.c: Add `pickit2_interrupt_transfer()` helper\n\nIntroduce the `pickit2_interrupt_transfer()` helper function to simplify\ncalls to the `libusb_interrupt_transfer()` function, as the last three\narguments are always the same: two constants and an unused output value.\n\nChange-Id: I7ff704243b63a7ea2872fbc6e596190573dc13f6\nSigned-off-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/65915\nOriginal-Reviewed-by: Felix Singer \u003cfelixsinger@posteo.net\u003e\nOriginal-Tested-by: Thomas Heijligen \u003csrc@posteo.de\u003e\nOriginal-Reviewed-by: Thomas Heijligen \u003csrc@posteo.de\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71471\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "9beddb69184fa60473b0ba5b0d6ccadfde6157d3", "tree": "f374e82af2aad56c96e9841a8f55fbaee90bd456", "parents": [ "24e1bbbbc48ae4ab51eed508d8e5288ad009193b" ], "author": { "name": "Miklós Márton", "email": "martonmiklosqdev@gmail.com", "time": "Tue Jun 21 23:34:35 2022 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:35:01 2023 +0000" }, "message": "stlinkv3_spi: add support for more product variants\n\nST released further STLINK-V3 variants with different PIDs:\n- STLINK-V3E\n- STLINK-V3S\n- STLINK-V3 With dual VCP\n- STLINK-V3 Without MSD\n\nTested with STLINK-V3S and STLINK-V3 With dual VCP\n\nCredits goes to the stlink project for collecting the the PID list:\nhttps://github.com/stlink-org/stlink/blob/develop/src/stlink-lib/\nusb.h#L22\n\nChange-Id: Ic9ad03316b7005aa35e6f2f710c86f48befd38f2\nSigned-off-by: Miklós Márton \u003cmartonmiklosqdev@gmail.com\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/65302\nOriginal-Reviewed-by: Thomas Heijligen \u003csrc@posteo.de\u003e\nOriginal-Reviewed-by: Felix Singer \u003cfelixsinger@posteo.net\u003e\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71470\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "24e1bbbbc48ae4ab51eed508d8e5288ad009193b", "tree": "eae17460b9eab81a921725bd47434b885d857257", "parents": [ "5dc7d949366c84833d9bf84e0ff3bf7c347c9273" ], "author": { "name": "Jacek Naglak", "email": "jnaglak@tlen.pl", "time": "Wed May 18 02:25:13 2022 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:35:01 2023 +0000" }, "message": "ft2232_spi.c: Add support for kt-link jtag interface\n\nChange tested writing, reading and erasing spi flashes\npinout:\n jtag - spi\n 1 vcc - vcc, wp#, hold#\n 4 gnd - gnd\n 5 tdi - si\n 7 tms - cs#\n 9 tck - sck\n13 tdo - so\nConnect pins 9 and 12 in EXT connector for 3.3V power.\n\nSigned-off-by: Jacek Naglak \u003cjnaglak@tlen.pl\u003e\nChange-Id: Id58c675bc410ec3ef6d58603d13efc9ca53bb87c\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/64440\nOriginal-Reviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nOriginal-Reviewed-by: Felix Singer \u003cfelixsinger@posteo.net\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71469\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "5dc7d949366c84833d9bf84e0ff3bf7c347c9273", "tree": "731e7610e4c796f23ce6d55465265a5f481a4407", "parents": [ "2ab6bba5602a8a2f7e0a99cc94ccc9fe6a412723" ], "author": { "name": "Pete Smith", "email": "zailawee@protonmail.com", "time": "Wed May 11 10:01:25 2022 +0000" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:35:01 2023 +0000" }, "message": "it87spi.c: Enable probing of IT8686E\n\nEnable probing for IT8686E allowing to use the `dualbiosindex`\nparameter. Dumped and verified both firmwares. Tested on GIGABYTE\nGA-H270N-WIFI.\n\nSigned-off-by: Pete Smith \u003czailawee@protonmail.com\u003e\nChange-Id: I5a1780275a92089c2d91c5da1c472f6d8bc39a56\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/64254\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-by: Thomas Heijligen \u003csrc@posteo.de\u003e\nOriginal-Reviewed-by: Arthur Heymans \u003carthur@aheymans.xyz\u003e\nOriginal-Reviewed-by: Felix Singer \u003cfelixsinger@posteo.net\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71468\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "2ab6bba5602a8a2f7e0a99cc94ccc9fe6a412723", "tree": "65cb4b8a6c7de64b6dbf1a41cc333ac4259831a1", "parents": [ "43040f297e68cd4d826d58f57566581ef902d179" ], "author": { "name": "Edward O\u0027Callaghan", "email": "quasisec@google.com", "time": "Fri Jun 24 16:48:09 2022 +1000" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:35:01 2023 +0000" }, "message": "it85spi: EOL support\n\nThis code was originally introduced by ITE for now exceedingly old\nChromebooks. The code has had very little attention to maintain it,\nunlikely tested for a long time and now seems to be just a technical\nburden to the flashrom project.\n\nIf someone is later interested it could be resurrected for reference\nfrom git history. However, it needs quite a bit of work to bring it back\ninto maintainable order.\n\nTested: tree builds under meson+make and unit tests pass.\n\nChange-Id: I5e8cafd73db837941c518f0e2d72d8192274fd79\nSigned-off-by: Edward O\u0027Callaghan \u003cquasisec@google.com\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/65378\nOriginal-Reviewed-by: Stefan Reinauer \u003cstefan.reinauer@coreboot.org\u003e\nOriginal-Reviewed-by: Anastasia Klimchuk \u003caklm@chromium.org\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71467\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "43040f297e68cd4d826d58f57566581ef902d179", "tree": "a8357aba5a8dbfd43f3e7949c865f2682bf5962d", "parents": [ "4203a47a102e2622f404ee6567b240882d584116" ], "author": { "name": "Thomas Heijligen", "email": "thomas.heijligen@secunet.com", "time": "Thu Jun 23 14:38:35 2022 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:35:01 2023 +0000" }, "message": "tree: indent struct *_master consistently with tabs\n\nUse `\u003ctab\u003e.key\u003ctab\u003e*\u003d \u003cvalue\u003e,`\n\nTEST: `make VERSION\u003d0 MAN_DATE\u003d0` returns the same flashrom binary\nbefore and after the patch\n\nChange-Id: I1c45ea9804ca09e040d7ac98255042f58b01f8ef\nSigned-off-by: Thomas Heijligen \u003cthomas.heijligen@secunet.com\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/65363\nOriginal-Reviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nOriginal-Reviewed-by: Felix Singer \u003cfelixsinger@posteo.net\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71466\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "4203a47a102e2622f404ee6567b240882d584116", "tree": "57656409f88916ec1c9c70cfcfb20007406ccf10", "parents": [ "bbccdb275537493ec252362fc5fb792a879ae3d7" ], "author": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Sat May 28 17:28:05 2022 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:35:01 2023 +0000" }, "message": "dummyflasher: Add emulation for S25FL128L\n\nUsed to test WRSR_EXT2/3 support.\n\nSigned-off-by: Nico Huber \u003cnico.h@gmx.de\u003e\nChange-Id: Ic3cbea87218c973331b9b83e809e7d438407bc13\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/64748\nOriginal-Reviewed-by: Thomas Heijligen \u003csrc@posteo.de\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71464\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "bbccdb275537493ec252362fc5fb792a879ae3d7", "tree": "3666bfc60d97ba51abcaa3c6c7d62be23c449cdc", "parents": [ "58cf5197a6f89fd146ce0fbc340d67ef7cbe191c" ], "author": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Sat May 28 16:48:26 2022 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:35:01 2023 +0000" }, "message": "spi25_statusreg: Allow WRSR_EXT for Status Register 3 (dummy part)\n\nSpansion flash chips S25FL128L and S25FL256L use the WRSR instruction to\nwrite more than 2 registers. So align SR2 and SR3 support: The current\nFEATURE_WRSR_EXT is renamed to FEATURE_WRSR_EXT2 and FEATURE_WRSR_EXT3\nis added. Also, WRSR3 needs a separate flag now.\n\nVerified that FEATURE_WRSR_EXT2 still works using the `dummy_flasher`.\n\nflashrom-stable:\nOriginal patch was split, this is the `dummy_flasher.c` part.\n\nChange-Id: I81153cb758b9fc29b803959683ad7acf8fb771e4\nSigned-off-by: Nico Huber \u003cnico.h@gmx.de\u003e\nOriginal-Change-Id: Ibdfc6eb3d2cfecbf8da0493d067031ddb079a094\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/64746\nOriginal-Reviewed-by: Nikolai Artemiev \u003cnartemiev@google.com\u003e\nOriginal-Reviewed-by: Arthur Heymans \u003carthur@aheymans.xyz\u003e\nOriginal-Reviewed-by: Thomas Heijligen \u003csrc@posteo.de\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71463\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "58cf5197a6f89fd146ce0fbc340d67ef7cbe191c", "tree": "f2bf0a793fbcfec3ac486bf1b4e30f90649d9364", "parents": [ "c50f4aed20b6d0d455cc0a1622ef683e5fcac2ce" ], "author": { "name": "Tasos Sahanidis", "email": "tasos@tasossah.com", "time": "Wed Apr 20 09:30:42 2022 +0300" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:35:01 2023 +0000" }, "message": "board_enable: Add ASUS P5W DH Deluxe\n\nFlashrom can now write to the onboard SST49LF008 flash\n\nSigned-off-by: Tasos Sahanidis \u003ctasos@tasossah.com\u003e\nChange-Id: Iea4f858cb45c60a6180de07c8361a8a831635dfd\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/63736\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-by: Thomas Heijligen \u003csrc@posteo.de\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71462\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "c50f4aed20b6d0d455cc0a1622ef683e5fcac2ce", "tree": "078e3e4c51d02b4af427eda32fb249dc2b4db95e", "parents": [ "a1805097309f7d230f3596550fc673b109d5b19d" ], "author": { "name": "Alexander Goncharov", "email": "chat@joursoir.net", "time": "Fri Jun 17 08:32:47 2022 +0300" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:35:01 2023 +0000" }, "message": "atavia: fix BYTE_OFFSET\u0027s macro argument value\n\nA macro value has to use a correct argument name.\n\nChange-Id: I666204ec92c6df625b34ca721b3e1af78772bccf\nSigned-off-by: Alexander Goncharov \u003cchat@joursoir.net\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/65193\nOriginal-Reviewed-by: Felix Singer \u003cfelixsinger@posteo.net\u003e\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71461\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "a1805097309f7d230f3596550fc673b109d5b19d", "tree": "1a2772c9df3563a3ec5dc167dd900501b665744e", "parents": [ "2fc70dcfe988928e97e69e98d91e7e3999ecd352" ], "author": { "name": "Edward O\u0027Callaghan", "email": "quasisec@google.com", "time": "Mon May 16 11:10:36 2022 +1000" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:35:01 2023 +0000" }, "message": "flashrom.c: Make need_erase() helper static local\n\nThe need_erase() helper is only used within flashrom.c\n\nChange-Id: Ic0946bb109fca2fc18e15eefa11cccea284ded0b\nSigned-off-by: Edward O\u0027Callaghan \u003cquasisec@google.com\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/64369\nOriginal-Reviewed-by: Arthur Heymans \u003carthur@aheymans.xyz\u003e\nOriginal-Reviewed-by: Thomas Heijligen \u003csrc@posteo.de\u003e\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71460\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "2fc70dcfe988928e97e69e98d91e7e3999ecd352", "tree": "b9d2b757606242debe22d8107fbae41c668937a9", "parents": [ "27835eaf1a0384293dcd1f3ad6ad506d919f3b43" ], "author": { "name": "Sergii Dmytruk", "email": "sergii.dmytruk@3mdeb.com", "time": "Mon Nov 08 01:38:52 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:35:01 2023 +0000" }, "message": "dummyflasher: enforce write protection for W25Q128FV\n\nStart taking bits related to write protection into account.\n\nAlso add \"hwwp\" parameter for dummy programmer that sets state of WP\npin (not inverted value).\n\nTested: use command-line interface to run WP-related commands\n\ndummyflasher doesn\u0027t store state of the chip between runs and flashrom\nallows running only one command, so testing WP in this way is limited.\nHowever, WP options can be combined with other operations and are\nexecuted prior to them, so certain scenarios can be checked.\n\nList possible ranges:\n flashrom -p dummy:emulate\u003dW25Q128FV,hwwp\u003dyes --wp-list\n\nSet a particular range and check status is correct:\n flashrom -p dummy:emulate\u003dW25Q128FV,hwwp\u003dyes \\\n --wp-enable \\\n --wp-range\u003d0x00100000,0x00f00000 \\\n --wp-status\n\nEnable write protection and try erasing/writing (erasing here):\n # this fails\n flashrom -p dummy:emulate\u003dW25Q128FV,hwwp\u003dyes \\\n --wp-range\u003d0,0x00c00000 \\\n --wp-enable \\\n --erase\n\nWrite protecting empty range has no effect:\n # this succeeds\n flashrom -p dummy:emulate\u003dW25Q128FV,hwwp\u003dyes \\\n --wp-range\u003d0,0 \\\n --wp-enable \\\n --erase\n\nDisabling WP is possible if hwwp is off:\n # this fails\n flashrom -p dummy:emulate\u003dW25Q128FV,spi_status\u003d0x80,hwwp\u003dyes \\\n --wp-disable\n # this succeeds\n flashrom -p dummy:emulate\u003dW25Q128FV,spi_status\u003d0x80,hwwp\u003dno \\\n --wp-disable\n\nChange-Id: I9fd1417f941186391bd213bd355530143c8f04a0\nSigned-off-by: Sergii Dmytruk \u003csergii.dmytruk@3mdeb.com\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/59074\nOriginal-Reviewed-by: Anastasia Klimchuk \u003caklm@chromium.org\u003e\nOriginal-Reviewed-by: Thomas Heijligen \u003csrc@posteo.de\u003e\nOriginal-Reviewed-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71459\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "27835eaf1a0384293dcd1f3ad6ad506d919f3b43", "tree": "6f2043a3506fa43952717d16dffdcc0829987638", "parents": [ "59151a4b508e2b8037bc18f46232f6ca0ee90ea2" ], "author": { "name": "Sergii Dmytruk", "email": "sergii.dmytruk@3mdeb.com", "time": "Mon Nov 08 00:06:33 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:35:01 2023 +0000" }, "message": "dummyflasher: emulate SR2 and SR3 for W25Q128FV\n\nEnable emulation of SR2 and SR3 for W25Q128FV and provide logic for\nupdating them (masks of read-only bits that can\u0027t be set from outside).\n\nTested: check how input value affects status registers of emulated chip\n\nflashrom -V -p dummy:emulate\u003dW25Q128FV,spi_status\u003d0x12 |\n grep -A3 \u0027Initial status registers\u0027\nflashrom -V -p dummy:emulate\u003dW25Q128FV,spi_status\u003d0x1234 |\n grep -A3 \u0027Initial status registers\u0027\nflashrom -V -p dummy:emulate\u003dW25Q128FV,spi_status\u003d0x123456 |\n grep -A3 \u0027Initial status registers\u0027\n\nChange-Id: I79f9b4a0b604663d3288ad70dcbe3ea4075dede5\nSigned-off-by: Sergii Dmytruk \u003csergii.dmytruk@3mdeb.com\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/59073\nOriginal-Reviewed-by: Anastasia Klimchuk \u003caklm@chromium.org\u003e\nOriginal-Reviewed-by: Thomas Heijligen \u003csrc@posteo.de\u003e\nOriginal-Reviewed-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71458\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" } ], "next": "59151a4b508e2b8037bc18f46232f6ca0ee90ea2" }