)]}' { "log": [ { "commit": "29c6834b22a39017725d5dacb69befb4b52fcc5f", "tree": "1ec976b16d33c5002c205fce3571d845a41cb548", "parents": [ "a54f5a41e65c9ae26b067b7062bb0cbad56bcc93" ], "author": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Sun Jun 27 14:34:16 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "Makefile: Enable bitbang_spi based on its dependency list\n\nChange-Id: I2a22667cfe14e4c5816b3bce13de632941690d17\nSigned-off-by: Nico Huber \u003cnico.h@gmx.de\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/55880\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71412\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "a54f5a41e65c9ae26b067b7062bb0cbad56bcc93", "tree": "f293e04a563f32b8328a8426851c76912a1b2c8e", "parents": [ "8945b815f16be92615875c881cbfcaa80f72ccb5" ], "author": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Sun Jun 27 14:27:41 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "Makefile: Disable libusb/libpci programmers via dependency lists\n\nChange-Id: Ic2e56059a5cd7bd9f3d74d27866ded97e86d6ef1\nSigned-off-by: Nico Huber \u003cnico.h@gmx.de\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/55879\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71411\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "8945b815f16be92615875c881cbfcaa80f72ccb5", "tree": "69ae0d2e6875af66c59d5677b087a57e0ebcabcc", "parents": [ "dc8e54ad9d86d227bdeb8462e2154833ded38cce" ], "author": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Sun Jun 27 14:24:53 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "Makefile: Deflate per-architecture handling of unsupported programmers\n\nChange-Id: Ia54d9e7a2602af6e8725851d01758985b36c8461\nSigned-off-by: Nico Huber \u003cnico.h@gmx.de\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/55878\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71410\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "dc8e54ad9d86d227bdeb8462e2154833ded38cce", "tree": "92133471fd7940fb648eaa85bea8823686a90b8e", "parents": [ "713310385794e1f0d28d5879f736bde325426e1c" ], "author": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Sun Jun 27 14:17:34 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "Makefile: Deflate handling of Linux-only programmers\n\nAlso one case that doesn\u0027t work on Android.\n\nChange-Id: I17381172f8df213bbddccedec2ef288326e49ecf\nSigned-off-by: Nico Huber \u003cnico.h@gmx.de\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/55877\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71409\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "713310385794e1f0d28d5879f736bde325426e1c", "tree": "da7d5390a3e8fec6cec5dada6e56966b060c5232", "parents": [ "ca6217827f3ed1223db6b29dcc5b3088e3858a8e" ], "author": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Sun Jun 27 14:00:39 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "Makefile: Deflate handling of unsupported programmers for libpayload\n\nChange-Id: I78ab1e3217aa6362b4c3525763e15140aa4c204f\nSigned-off-by: Nico Huber \u003cnico.h@gmx.de\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/55876\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71408\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "ca6217827f3ed1223db6b29dcc5b3088e3858a8e", "tree": "1165991476d9c93f37f168dec8d80a33156935ff", "parents": [ "ba6819647e2b1367d073c10afe5c2d23f7af5b5d" ], "author": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Sun Jun 27 13:53:49 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "Makefile: Deflate handling of unsupported programmers for MinGW\n\nChange-Id: I20c17471f7b059e91b215fca833b767a003a9888\nSigned-off-by: Nico Huber \u003cnico.h@gmx.de\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/55875\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71407\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "ba6819647e2b1367d073c10afe5c2d23f7af5b5d", "tree": "a968cb8210ab0536ec4fb8317e736f68f8cab979", "parents": [ "afca7ac5a4c109bd008f3d6c9d989d334756802f" ], "author": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Sun Jun 27 13:39:23 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "Makefile: Deflate handling of unsupported programmers for DJGPP\n\nChange-Id: I86988aa7ef1d2d4189be3d25b9aea4e7ddaec9af\nSigned-off-by: Nico Huber \u003cnico.h@gmx.de\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/55874\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71406\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "afca7ac5a4c109bd008f3d6c9d989d334756802f", "tree": "7b26dff7600ae7077d0fe411e22cae13585b9bb4", "parents": [ "7f898975400404d7ea738a053fede5da128d2a84" ], "author": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Sun Jun 27 13:35:21 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "Makefile: Add macro to disable unsupported programmers\n\n`mark_unsupported` disables all programmers passed as arguments and\nadds them to the UNSUPPORTED_FEATURES list. It\u0027s conveniently used\nwith our dependency lists, e.g.\n\n $(call mark_unsupported,$(NEEDS_LIBUSB1) $(NEEDS_LIBFTDI))\n\nChange-Id: I6c9b66dfa89ec3d71675576d03fcebfdea30ce7b\nSigned-off-by: Nico Huber \u003cnico.h@gmx.de\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/55873\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71405\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "7f898975400404d7ea738a053fede5da128d2a84", "tree": "21822e2d478d394391a1704a50cecd867d128db5", "parents": [ "09e82e227554c9a6ff73386beeece0d9f851ac04" ], "author": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Sun Jun 27 13:30:50 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "Makefile: Gather lists of dependencies by feature/lib\n\nFor each feature or library that we treat as dependency, list which\nprogrammers depend on it.\n\nChange-Id: I6929181f18213e1434cbbc7ba2d2b0b04bd46a6a\nSigned-off-by: Nico Huber \u003cnico.h@gmx.de\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/55872\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71404\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "09e82e227554c9a6ff73386beeece0d9f851ac04", "tree": "7fd4a24965b992f26412a1698b2f05e2be671fc0", "parents": [ "83d52074fdbbe27ccf7b426dc9762a756f00fd77" ], "author": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Sun Jun 27 14:31:37 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "Makefile: Move $(NEED_LIBFTDI) block to similar ones\n\nChange-Id: I27eae3803a114f332a6f0713cf9bc90163030e1b\nSigned-off-by: Nico Huber \u003cnico.h@gmx.de\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/55871\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71403\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "83d52074fdbbe27ccf7b426dc9762a756f00fd77", "tree": "00f88445d915b5ee0a93f6c3ad06c6d27f7f1543", "parents": [ "81965f3c5acc663fab9efdaa0a48a814bcadad4e" ], "author": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Sun Jun 27 00:07:13 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "Makefile: Move NI845X_SPI default to the other defaults\n\nChange-Id: I0317eb1190eae366a142d9410bee4110edc06e3d\nSigned-off-by: Nico Huber \u003cnico.h@gmx.de\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/55870\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71402\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "81965f3c5acc663fab9efdaa0a48a814bcadad4e", "tree": "b4a30b0b936db08f7147b6c93f0f6840ae25bf79", "parents": [ "72a9dc0db4e6aa2a520f17015ecde93595286fbf" ], "author": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jun 17 23:25:35 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "ich_descriptors: Normalize chipset detection\n\nNormalize the fallback paths:\n* Always end with the newest, assumed compatible chipset.\n* Perform tighter checks when it\u0027s about warnings only.\n* If two chipsets seem compatible, always return the same\n (this is currently the case for 8/9 series and 300/400\n series which we can\u0027t distinguish).\n\nChange-Id: Ic5a5fee870202173b3a9813b03ec261e8ee45155\nSigned-off-by: Nico Huber \u003cnico.h@gmx.de\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/55651\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-by: Michał Żygowski \u003cmichal.zygowski@3mdeb.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71401\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "72a9dc0db4e6aa2a520f17015ecde93595286fbf", "tree": "b21529ac872a096419da8784630e4f73b22753f3", "parents": [ "3ad9aad483029c8b4c7c9f0b8dd362faf1c12ef3" ], "author": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jun 17 22:47:00 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "ich_descriptors: Don\u0027t base chipset detection on `freq_read`\n\nOnly warn if the `freq_read` setting looks odd but don\u0027t override\nour previous guess. The `freq_read` check was taken from `ifdtool`\nbut seems less reliable than our own detection scheme.\n\nChange-Id: I658d76ec2567d1d660a18d0b0ae71c744e603e8f\nSigned-off-by: Nico Huber \u003cnico.h@gmx.de\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/55650\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-by: Michał Żygowski \u003cmichal.zygowski@3mdeb.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71400\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "3ad9aad483029c8b4c7c9f0b8dd362faf1c12ef3", "tree": "74ad9724b0ab7db87fe06ba4323a16707107bf61", "parents": [ "66e04562f48cfb1f2266c316c81693ea73371a60" ], "author": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jun 17 22:05:00 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "ich_descriptors: Revise detection for chipsets w/ ICCRIBA\n\nDetection based on ICCRIBA and FMSBA became a little messy lately.\nHowever, there\u0027s a new static difference: Since 300 series (Cannon\nPoint), there is an MDTBA field in FLUMAP1 that has always been 0\n(reserved) before. Taking this into account, we can relax the checks\non ICCRIBA.\n\nChange-Id: I587ad1abe390843d4a9e74431b6fc4b63f8ba512\nSigned-off-by: Nico Huber \u003cnico.h@gmx.de\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/55647\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-by: Michał Żygowski \u003cmichal.zygowski@3mdeb.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71399\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "66e04562f48cfb1f2266c316c81693ea73371a60", "tree": "0c991211a974da842919497034e6a58f45131989", "parents": [ "ee6d548becb29d4fce00a6f7dbe0c39e1e7be160" ], "author": { "name": "Anastasia Klimchuk", "email": "aklm@chromium.org", "time": "Mon Jun 28 17:03:52 2021 +1000" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "dediprog: Separate shutdown from failed init cleanup\n\nShutdown function was covering two different jobs here: 1) the actual\nshutdown which is run at the end of the driver\u0027s lifecycle and\n2) cleanup in cases when initialisation failed. Now, shutdown is only\ndoing its main job (#1), and the driver itself is doing cleanup\nwhen init fails (#2).\n\nThe good thing is that now resources are released/closed immediately\nin cases when init fails (vs shutdown function which was run at some\npoint later), and the driver leaves clean space after itself if init\nfails.\n\nAnd very importantly this unlocks API change which plans to move\nregister_shutdown inside register master API, see\nhttps://review.coreboot.org/c/flashrom/+/51761\n\nChange-Id: I3273da907614a042d50090338c337dfd64695354\nSigned-off-by: Anastasia Klimchuk \u003caklm@chromium.org\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/55887\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71398\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "ee6d548becb29d4fce00a6f7dbe0c39e1e7be160", "tree": "940405142f24dcbcfd59f931a433fed297be48e7", "parents": [ "38450ce384c8e6e05f34a0bd0246fcb919259222" ], "author": { "name": "Anastasia Klimchuk", "email": "aklm@chromium.org", "time": "Thu Jun 24 16:25:43 2021 +1000" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "buspirate_spi: Use non-zero return value from buspirate_sendrecv\n\nReturn values for buspirate_sendrecv come from serialport_write\nand serialport_read, and those return 1s for any error. No need\nto explicity assign ret \u003d 1, because it is already 1 for error.\n\nFollow up on commit 751afa88a7f22487069665c5d206ae490f158231\nwhere this idea was suggested.\n\nChange-Id: I31fd70f607dc965d5cac1cd0116faa447dbc177a\nSigned-off-by: Anastasia Klimchuk \u003caklm@chromium.org\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/55818\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71397\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "38450ce384c8e6e05f34a0bd0246fcb919259222", "tree": "bd65541fb29514f558217ed719e769be977aeddf", "parents": [ "fda5f1f18d8e104cf9898f38a111f5d24dc9e31c" ], "author": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Sun Jun 16 20:07:28 2019 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "libflashrom: Free `chip` instance upon flashctx teardown\n\nChange-Id: I761d7e167a43e5bf08b5b3d269b0a476e3d343c5\nSigned-off-by: Nico Huber \u003cnico.h@gmx.de\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/33546\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-by: Anastasia Klimchuk \u003caklm@chromium.org\u003e\nOriginal-Reviewed-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71396\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "fda5f1f18d8e104cf9898f38a111f5d24dc9e31c", "tree": "139173f9b3d2266c08adad116859ccc5729a79d7", "parents": [ "4c40a794b2cbe43f7b4e6533f6301fd2053e056c" ], "author": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Sun Jun 20 16:46:31 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "ft2232_spi: Revise error message\n\nReword the message and drop the error string from libftdi. It is\nalready printed in send_buf().\n\nChange-Id: I125ae9ec0d5487fc26d588a7fd6c54da4ebd0d70\nSigned-off-by: Nico Huber \u003cnico.h@gmx.de\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/55697\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-by: Anastasia Klimchuk \u003caklm@chromium.org\u003e\nOriginal-Reviewed-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71395\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "4c40a794b2cbe43f7b4e6533f6301fd2053e056c", "tree": "0731a507e097a3efad890a6f97eff7af69c59558", "parents": [ "cf88068581f75029314e1068626ab63795b52dd2" ], "author": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Sun Jun 20 16:38:57 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "ft2232_spi: Normalize error paths in ft2232_shutdown()\n\nWe missed to `free(spi_data)` on one path. It also seems odd to leak\nthe return code of a locally used library into our common infrastruc-\nture, so normalize all error paths to return 1.\n\nChange-Id: I5158d06127a9a8934b083e48b69d29c4d5a11831\nSigned-off-by: Nico Huber \u003cnico.h@gmx.de\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/55696\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-by: Anastasia Klimchuk \u003caklm@chromium.org\u003e\nOriginal-Reviewed-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71394\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "cf88068581f75029314e1068626ab63795b52dd2", "tree": "181f0a32f0615cdce48b11f68181d8d777f6cb0c", "parents": [ "13b33bcf57f6dc3ea4edafc9dda34f3155d2dbbf" ], "author": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Sun Jun 20 15:59:57 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "ft2232_spi: Revise comments about output pin states\n\nThe meaning of the variables is easy to misunderstand as some\nstates are merely implicit: All output pins that are not set\nin the `cs_bits` mask will be constantly driven low. This may\nbe sheer coincidence as all programmers that need additional\npins driven use active-low signals to enable buffers.\n\nWhile other pins stay low, *all* pins set in the `cs_bits`\nmask are supposed to be toggled during SPI transactions.\n\nAlso drop some irritating dead code and try to explain things\nin a comment.\n\nChange-Id: I2b84ede01759c80f69d5ad17e43783d09ecd1107\nSigned-off-by: Nico Huber \u003cnico.h@gmx.de\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/55695\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71393\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "13b33bcf57f6dc3ea4edafc9dda34f3155d2dbbf", "tree": "c1ae50591e65a1084b34115b142bf3871e5e3093", "parents": [ "fc16212c44a72ee8b67525020ca2e68ffc162733" ], "author": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Sun Jun 20 13:20:33 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "ft2232_spi: Drop ft2232_spi_send_command()\n\nNow that ft2232_spi_send_multicommand() is implemented, we don\u0027t need\nthe single-command version anymore.\n\nChange-Id: I2e7fa1046e260f490b881a33e02ad73d16f0a30c\nSigned-off-by: Nico Huber \u003cnico.h@gmx.de\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/55684\nOriginal-Reviewed-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71392\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "fc16212c44a72ee8b67525020ca2e68ffc162733", "tree": "122f3ec3a34932b6485c84dfcaf4f5037dfb610e", "parents": [ "db9be31735c8d4e018fefc615c83e570f49dbb7a" ], "author": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Sun Jun 20 13:09:30 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "ft2232_spi: Don\u0027t lower write data chunksize\n\nThis \"chunk size\" limits the amount of data that is passed to libusb\nat once. If we had exceeded the chunk size, libftdi would have split\nthe data into individual, synchronous bulk transfers. But the chunk\nsize was actually chosen to avoid this. So without any known effect,\nsetting the chunk size is useless. Drop it.\n\nChange-Id: I779e24dc3f3379a98ddce02c3765062ac3241884\nSigned-off-by: Nico Huber \u003cnico.h@gmx.de\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/55683\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71391\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "db9be31735c8d4e018fefc615c83e570f49dbb7a", "tree": "1cb60f3310af75dcc24633626bfcde1e4091ab07", "parents": [ "98bdcb46de824e6671671ed83465cec3087f69ba" ], "author": { "name": "Simon Buhrow", "email": "simon.buhrow@sieb-meyer.de", "time": "Fri Apr 09 14:48:39 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "ft2232_spi.c: Implement spi_send_multicommand()\n\nEvery ftdi_write_data() call is quite time consuming as the ftdi-chips\nseems to take always 2-3ms to respond. This leads to what the comment\nalready says: Minimize USB transfers by packing as many commands as\npossible together. So I packed the WREN command together with the\nfollowing operation which can be program or erase operation.\n\nThis saves about 1 minute when programming a 128MBit Flash within a\nvirtualized setup.\n\nSigned-off-by: Simon Buhrow \u003csimon.buhrow@posteo.de\u003e\nChange-Id: Ie4a07499ec5ef0af23818593f45dc427285a9e8a\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/40477\nOriginal-Reviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71390\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "98bdcb46de824e6671671ed83465cec3087f69ba", "tree": "08c53170c94b115596d4ca58b0e839cdc9a03ff3", "parents": [ "7dcb6f33d0e97154b3533917fad3dea0dad676bc" ], "author": { "name": "Jeremy Kerr", "email": "jk@codeconstruct.com.au", "time": "Sun May 23 17:58:06 2021 +0800" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "buspirate: Add psus option\n\nThis change adds a \u0027psus\u003d\u003con|off\u003e\u0027 option, to control the external Vcc\nstate of the bus pirate, allowing hardware where the SPI flash chip is\npowered by the 3V3/5V lines directly.\n\nChange-Id: I8a7d4b40c0f7f04f6976f6757f05b61f2c9958f9\nSigned-off-by: Jeremy Kerr \u003cjk@codeconstruct.com.au\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/54887\nOriginal-Reviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71389\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "7dcb6f33d0e97154b3533917fad3dea0dad676bc", "tree": "05d10b7288a928f72f231c29fc07d58bbb7ed066", "parents": [ "1535db44bdc06e6cf52defc519af86197ca414e5" ], "author": { "name": "Anastasia Klimchuk", "email": "aklm@chromium.org", "time": "Mon May 24 15:12:10 2021 +1000" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "buspirate_spi.c: Separate shutdown from failed init cleanup\n\nShutdown function was covering two different jobs here: 1) the actual\nshutdown which is run at the end of the driver\u0027s lifecycle and\n2) cleanup in cases when initialisation failed. Now, shutdown is only\ndoing its main job (#1), and the driver itself is doing cleanup\nwhen init fails (#2).\n\nThe good thing is that now resources are released/closed immediately\nin cases when init fails (vs shutdown function which was run at some\npoint later), and the driver leaves clean space after itself if init\nfails.\n\nAnd very importantly this unlocks API change which plans to move\nregister_shutdown inside register master API, see\nhttps://review.coreboot.org/c/flashrom/+/51761\n\nChange-Id: I04d57e2552d23a1a4a906c68539f0ccefc13e8a0\nSigned-off-by: Anastasia Klimchuk \u003caklm@chromium.org\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/52877\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nOriginal-Reviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71388\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "1535db44bdc06e6cf52defc519af86197ca414e5", "tree": "a7dc07bfbbf2236cab7941ebb5e7909fae124de9", "parents": [ "8a03c90f41a6ca79c7bf183ad07e2b30702bfd46" ], "author": { "name": "Thomas Heijligen", "email": "thomas.heijligen@secunet.de", "time": "Mon Jun 14 13:20:09 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "programmer.h: sort programmer entries alphabetically\n\nChange-Id: Ie419eac2719aceb3aea803fac8ce85de294c88e5\nSigned-off-by: Thomas Heijligen \u003cthomas.heijligen@secunet.de\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/55495\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71387\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "8a03c90f41a6ca79c7bf183ad07e2b30702bfd46", "tree": "9acfb7f68e05f0d7166357ab6f37c07adea669a3", "parents": [ "83b01c8a0f67143594a3befbb2668775e1d28aba" ], "author": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jun 17 21:23:29 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "ich_descriptors: Refactor read_ich_descriptors_from_dump()\n\nProcess the \"upper map\" early as it doesn\u0027t depend on the descriptor\ngeneration. This way, we can use it to guess the generation.\n\nChange-Id: Ia2786b762ccefdce31b63397119bd89879e887ff\nSigned-off-by: Nico Huber \u003cnico.h@gmx.de\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/55646\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71386\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "83b01c8a0f67143594a3befbb2668775e1d28aba", "tree": "d9ae99bfbeef9e73b47177ef9d606cb82f2fd7bf", "parents": [ "964007ad72a8a9be9c462ff4e03d73c0d9f7c577" ], "author": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jun 17 21:20:09 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "ich_descriptors: Drop some unnecessary `else` after `return`\n\nChange-Id: Id739bc12832e3b441e8e7e1dcdcc4c05b260d7ad\nSigned-off-by: Nico Huber \u003cnico.h@gmx.de\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/55645\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-by: Michał Żygowski \u003cmichal.zygowski@3mdeb.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71385\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "964007ad72a8a9be9c462ff4e03d73c0d9f7c577", "tree": "8125ec38d11a6c72f4d45a0dfdacfdaa50527936", "parents": [ "40d3233e17e07f7616702b9968468816f4db9520" ], "author": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jun 17 21:12:47 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "ich_descriptors: Revise descriptor messages\n\nCorrect \"firmware descriptor\" to \"flash descriptor\". And also\nmove the check for peculiar descriptors and the message into an\ninline function.\n\nChange-Id: I7f15780e03d2fa17ca6d8328275cae5af13ae424\nSigned-off-by: Nico Huber \u003cnico.h@gmx.de\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/55644\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-by: Michał Żygowski \u003cmichal.zygowski@3mdeb.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71384\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "40d3233e17e07f7616702b9968468816f4db9520", "tree": "b6b11594742374e50aee4b6afe45a4492c7fa904", "parents": [ "ab69629daab4c091870b3f7d27f80085a415b286" ], "author": { "name": "Thomas Heijligen", "email": "thomas.heijligen@secunet.de", "time": "Thu Jun 10 15:17:53 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "programmer.h: remove compile guard from programmer drivers\n\nThe definition of external structs doesn\u0027t have to be guarded.\nSee discussion under review.coreboot.org/52946.\n\nChange-Id: I01e6a785269c3e0bd648eeaee217a7a855ab0853\nSigned-off-by: Thomas Heijligen \u003cthomas.heijligen@secunet.de\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/55387\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-by: Anastasia Klimchuk \u003caklm@chromium.org\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71383\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "ab69629daab4c091870b3f7d27f80085a415b286", "tree": "8f03b87d3480fd91f5dbbc5bc80c14633706bdbe", "parents": [ "3795c9d43d0b6ea71fb7ec499f6fdbb5e5bf0960" ], "author": { "name": "Nico Huber", "email": "nico.huber@secunet.com", "time": "Wed Jun 09 18:10:07 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "dummyflasher: Re-arrange includes\n\nGather library includes at the top.\n\nChange-Id: Ib20a3245cae3206dca1d8f88f705ac3628473f43\nSigned-off-by: Nico Huber \u003cnico.huber@secunet.com\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/55359\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-by: Anastasia Klimchuk \u003caklm@chromium.org\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71382\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "3795c9d43d0b6ea71fb7ec499f6fdbb5e5bf0960", "tree": "95c8c787f2e7010cd2c293767b8ffe94b7f259f1", "parents": [ "84e9c913082ce2d243593e3659ec3a0af22ea9cd" ], "author": { "name": "Thomas Heijligen", "email": "thomas.heijligen@secunet.de", "time": "Tue Jun 01 16:25:52 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "enum programmer: not needed anymore. Remove\n\nChange-Id: I53cdb160616911a4beea6b5e8e56d582621818a4\nSigned-off-by: Thomas Heijligen \u003cthomas.heijligen@secunet.de\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/55124\nOriginal-Reviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nOriginal-Reviewed-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71381\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "84e9c913082ce2d243593e3659ec3a0af22ea9cd", "tree": "1d753a41959b8fef39bbe9d4f61032b5142ec299", "parents": [ "acd9c948b1fbea6dc79560cd12042898f82c3636" ], "author": { "name": "Thomas Heijligen", "email": "thomas.heijligen@secunet.de", "time": "Tue Jun 01 16:22:14 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "CONFIG_DEFAULT_PROGRAMMER_NAME: Use programmer name instead of enum\n\nCONFIG_DEFAULT_PROGRAMER_NAME replaces CONFIG_DEFAULT_PROGRAMMER.\nIt uses the name of the programmer for identification.\nmake CONFIG_DEFAULT_PROGRAMER_NAME\u003ddummy and\nmeson -Ddefault_programmer_name\u003ddummy will extend to\nCONFIG_DEFAULT_PROGRAMER_NAME\u003d\u0026programmer_dummy in the code.\n\nChange-Id: I976447787c6f6bfbdc0145d80d61e1ddcf97ac33\nSigned-off-by: Thomas Heijligen \u003cthomas.heijligen@secunet.de\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/55123\nOriginal-Reviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71380\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "acd9c948b1fbea6dc79560cd12042898f82c3636", "tree": "1cf8deb4c7dda694f8a666ba42451faf6461f162", "parents": [ "e0e93cf59fe2fb45f1e325e0dcc939cc054cbfa8" ], "author": { "name": "Thomas Heijligen", "email": "thomas.heijligen@secunet.de", "time": "Tue Jun 01 14:51:13 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "cli_classic: replace enum programmer with programmer_entry*\n\nChange-Id: I4c45f278addeea0d486a316435e8dc15d93cbd70\nSigned-off-by: Thomas Heijligen \u003cthomas.heijligen@secunet.de\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/55122\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71379\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "e0e93cf59fe2fb45f1e325e0dcc939cc054cbfa8", "tree": "38f1faaae8d2a12dba5a80bad703e3d2c8d68c9e", "parents": [ "9163b814032c566b224ee8e58742448a99a3b73d" ], "author": { "name": "Thomas Heijligen", "email": "thomas.heijligen@secunet.de", "time": "Tue Jun 01 14:37:12 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "programmer_init: use struct programmer_entry*\n\nChange-Id: Iacf0f25abc94a84c5d52c8d69a3e8640817b060a\nSigned-off-by: Thomas Heijligen \u003cthomas.heijligen@secunet.de\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/55121\nOriginal-Reviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71378\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "9163b814032c566b224ee8e58742448a99a3b73d", "tree": "8f25a2a94f5dbd3d31e57a0470e8cbe0947e9d9f", "parents": [ "c7e5b8b4880984db47491bbf7a01ed7c7d470075" ], "author": { "name": "Thomas Heijligen", "email": "thomas.heijligen@secunet.de", "time": "Tue Jun 01 14:25:01 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "flashrom.c: replace enum programmer with size_t\n\nUsing size_t since programmer_table_size uses ARRAY_SIZE which returns\nsize_t.\n\nChange-Id: Id2ad9630fbc41e98d182768b553788e069fa5095\nSigned-off-by: Thomas Heijligen \u003cthomas.heijligen@secunet.de\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/55120\nOriginal-Reviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71377\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "c7e5b8b4880984db47491bbf7a01ed7c7d470075", "tree": "b8a0a67add5427260d6f69ff9f634600ea0f8117", "parents": [ "79088ab06fe92e2b898ddbb682782e06159e87f7" ], "author": { "name": "Thomas Heijligen", "email": "thomas.heijligen@secunet.de", "time": "Tue Jun 01 14:21:41 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "flashrom.c: replace enum programmer with struct programmer_entry*\n\nChange-Id: I478c56354d5f482010bfe1560489700bc889717a\nSigned-off-by: Thomas Heijligen \u003cthomas.heijligen@secunet.de\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/55119\nOriginal-Reviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71376\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "79088ab06fe92e2b898ddbb682782e06159e87f7", "tree": "9d0b0bdaed216e2520e022672d4dab536fc7cd24", "parents": [ "d45cb595e031ea6917f154f01eda3b234226f4f0" ], "author": { "name": "Thomas Heijligen", "email": "thomas.heijligen@secunet.de", "time": "Tue Jun 01 13:57:42 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "print.c: use static string for internal programmer name\n\nChange-Id: If2cf95c71425efdd864457e213dd34b929fe8805\nSigned-off-by: Thomas Heijligen \u003cthomas.heijligen@secunet.de\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/55118\nOriginal-Reviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71375\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "d45cb595e031ea6917f154f01eda3b234226f4f0", "tree": "2073712010f8c8e680ba82fa6d75e59f1edceab6", "parents": [ "cc853d84ed2f8ecafc1f6daa443f8baa4c871805" ], "author": { "name": "Thomas Heijligen", "email": "thomas.heijligen@secunet.de", "time": "Wed May 19 14:12:18 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "programmer_table: replace PROGRAMMER_INVALID with programmer_table_size\n\nChange-Id: Icaaeefe001de604df9d7fdd06f05a5ed39fdbd84\nSigned-off-by: Thomas Heijligen \u003cthomas.heijligen@secunet.de\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/55117\nOriginal-Reviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71374\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "cc853d84ed2f8ecafc1f6daa443f8baa4c871805", "tree": "8e5f3e0b7a75d272a109e20af5aeeeec11dfebf7", "parents": [ "7e1345602641114c8eeb5cfef992bf1da8d7fa6a" ], "author": { "name": "Thomas Heijligen", "email": "thomas.heijligen@secunet.de", "time": "Tue May 04 15:32:17 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "programmer_table: move each entry to the associated programmer source\n\nChange-Id: I3d02bd789f0299e936eb86819b3b15b5ea2bb921\nSigned-off-by: Thomas Heijligen \u003cthomas.heijligen@secunet.de\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/52946\nOriginal-Reviewed-by: Anastasia Klimchuk \u003caklm@chromium.org\u003e\nOriginal-Reviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71373\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "7e1345602641114c8eeb5cfef992bf1da8d7fa6a", "tree": "ce19124575cfd893449c754800c757d096dd3130", "parents": [ "690a944066619ff9d450d71cdcfe2e0bcb1120f3" ], "author": { "name": "Angel Pons", "email": "th3fanbus@gmail.com", "time": "Mon Jun 07 13:29:13 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "treewide: Drop unnecessary uses of memset/memcpy\n\nSimply provide an initialiser or use a direct assignment instead.\n\nChange-Id: I07385375cd8eec8a95874001b402b2c17ec09e09\nSigned-off-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/55267\nOriginal-Reviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71372\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "690a944066619ff9d450d71cdcfe2e0bcb1120f3", "tree": "e8da9e733570d6ebb25251f2362f17af5c59d626", "parents": [ "c40ca200100fe6fc451ab7f9bdf9751af1899d02" ], "author": { "name": "Angel Pons", "email": "th3fanbus@gmail.com", "time": "Mon Jun 07 12:33:53 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "treewide: Drop most cases of `sizeof(struct ...)`\n\nSpelling out the struct type name hurts readability and introduces\nopportunities for bugs to happen when the pointer variable type is\nchanged but the corresponding sizeof is (are) not.\n\nTested: `make CONFIG_EVERYTHING\u003dyes CONFIG_JLINK_SPI\u003dno VERSION\u003dnone -j`\nwith and without this patch; the flashrom executable does not change.\n\nflashrom-stable: Applied partially.\n\nChange-Id: Icc0b60ca6ef9f5ece6ed2a0e03600bb6ccd7dcc6\nSigned-off-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/55266\nOriginal-Reviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nOriginal-Reviewed-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71371\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "c40ca200100fe6fc451ab7f9bdf9751af1899d02", "tree": "595754e4ac3f84de465c9e3b1dee95d10a12db28", "parents": [ "633d6db1b5718305cf4daf87cf4a93d17bc3821e" ], "author": { "name": "Angel Pons", "email": "th3fanbus@gmail.com", "time": "Mon Jun 07 12:08:27 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "dummyflasher.c: Drop useless macros\n\nThe `EMULATE_CHIP` and `EMULATE_SPI_CHIP` macros are unconditionally\ndefined as `1`, with no way to change their values. Since this means\nthat the code never gets build-tested using other values, drop these\nnoisy macros.\n\nTested: Build with `make distclean \u0026\u0026 make VERSION\u003dnone -j` with and\n without this patch, the flashrom executable does not change.\n\nChange-Id: If46e1c37c3b04b28b4ba1f82c9b3def1e549368f\nSigned-off-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/55265\nOriginal-Reviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nOriginal-Reviewed-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nOriginal-Reviewed-by: Namyoon Woo \u003cnamyoon@google.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71370\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\n" }, { "commit": "633d6db1b5718305cf4daf87cf4a93d17bc3821e", "tree": "59ec962a28ab34ea99554db9b44ec804fead7e2d", "parents": [ "bbfacffca88042d7f85d910b732bf88253573c76" ], "author": { "name": "Thomas Heijligen", "email": "thomas.heijligen@secunet.de", "time": "Wed Mar 31 19:09:44 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "programmer_table: convert entries to pointers\n\nAllows us to move the individual entries into their respective\ndriver files.\n\nChange-Id: Ifbb0ee4db5a85b1cd2afeafe4dca838579f79878\nSigned-off-by: Thomas Heijligen \u003cthomas.heijligen@secunet.de\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/52945\nOriginal-Reviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71369\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "bbfacffca88042d7f85d910b732bf88253573c76", "tree": "afcd64ef5cffb9b33c7b9c4e1048574d9b1c1116", "parents": [ "d0fcce2507d7a5ada93902cc7522ee06e91c4872" ], "author": { "name": "Thomas Heijligen", "email": "thomas.heijligen@secunet.de", "time": "Wed Mar 31 20:40:01 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "programmer_table: move array content to an own file\n\nChange-Id: I8e6d704e845ee4152c8676dd19dff0934fff007b\nSigned-off-by: Thomas Heijligen \u003cthomas.heijligen@secunet.de\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/52944\nOriginal-Reviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71368\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "d0fcce2507d7a5ada93902cc7522ee06e91c4872", "tree": "52643af250240e68608a311a51b54cd8cc4b91fb", "parents": [ "b7076368df57398d36146d0234f924b0be9db881" ], "author": { "name": "Thomas Heijligen", "email": "thomas.heijligen@secunet.de", "time": "Wed May 19 13:53:34 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "programmer_table: add table size constant\n\nMakes the array size known to other compilation units.\n\nChange-Id: Idacb4b7b0dd98af8bc7cbecf567d33daafb4b24d\nSigned-off-by: Thomas Heijligen \u003cthomas.heijligen@secunet.de\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/55116\nOriginal-Reviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nOriginal-Reviewed-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nOriginal-Reviewed-by: Anastasia Klimchuk \u003caklm@chromium.org\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71367\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "b7076368df57398d36146d0234f924b0be9db881", "tree": "5c866a82c797eb7749c1603c42f66ab73d564c92", "parents": [ "3c55c79c7fd8adcf1503921392aba99cb8569638" ], "author": { "name": "Thomas Heijligen", "email": "thomas.heijligen@secunet.de", "time": "Wed May 19 13:05:36 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "programmer_table: remove null termination\n\nThe {0} object at the end of programmer_table which corresponds\nto PROGRAMMER_INVALID has no use in current code.\n\nChange-Id: Ib63c2d2941f23a0788e26e5a5feb25d8669acb42\nSigned-off-by: Thomas Heijligen \u003cthomas.heijligen@secunet.de\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/55115\nOriginal-Reviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71366\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "3c55c79c7fd8adcf1503921392aba99cb8569638", "tree": "c1f0254bfa72d301449ef2983c65d2b03081fdeb", "parents": [ "69d09ba2898d4457acd5fe53a43beb927706c905" ], "author": { "name": "Anastasia Klimchuk", "email": "aklm@chromium.org", "time": "Mon May 31 09:42:36 2021 +1000" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "dummyflasher.c: Fix data leak in params processing error paths\n\nThis patch extracts params processing into a separate function. Now\nall error paths of params processing return 1 back to init function\nwhich frees data.\n\nAnd there was just one more error path in init function where\nfree(data) needed to be added.\n\nThis is a follow up on commit 3b8fe0f8e907c0ba9f7c7935e950f3e1538d427f\nwhich moves global state into spi_master data.\n\nA good side-effect of the change is: init function becomes easier\nto read.\n\nTested: ninja test\n\nChange-Id: I04f55f77bb4703f1d88b2191c45a22be3c97bf87\nSigned-off-by: Anastasia Klimchuk \u003caklm@chromium.org\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/54748\nOriginal-Reviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71365\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\n" }, { "commit": "69d09ba2898d4457acd5fe53a43beb927706c905", "tree": "116c280707ce77fda950a18f12b5254fa785f9d7", "parents": [ "c24846407041eae3617e5480f62fcdad867fb0a2" ], "author": { "name": "Ivan V", "email": "root@pcm720.me", "time": "Thu May 27 01:04:38 2021 +0300" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "platform: Fix endianness detection for Apple Silicon Macs\n\nBuilding flashrom on Apple Silicon Macs fails with\n\"Unable to determine endianness\" error. It seems that current\nendianness detection fails on macOS due to a combination of\nthree issues:\n1. On macOS, neither GCC nor Clang have __ARMEL__ macros used\nby architecture-specific detection;\n2. Generic detection fails because Apple uses LITTLE_ENDIAN,\nBIG_ENDIAN and BYTE_ORDER macros instead of __BYTE_ORDER and\n__LITTLE_ENDIAN;\n3. In platform.h, __LITTLE_ENDIAN__ and __BIG_ENDIAN__ macros\nare checked only for PowerPC architecture.\n\nThis error can be fixed by appending __LITTLE_ENDIAN__ and\n__BIG_ENDIAN__ to conditions in IS_ARM branch. I\u0027ve considered\nmultiple approaches, but this one seems the cleanest to me.\n\nSigned-off-by: Ivan V \u003croot@pcm720.me\u003e\nChange-Id: Ifdb1523ee2c7023e657cfd7b823b091d5deef513\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/54964\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71364\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "c24846407041eae3617e5480f62fcdad867fb0a2", "tree": "867a1c772ddac1444ede4b609b1a500693204230", "parents": [ "328898a911438ab4e133610e0c901d00264624eb" ], "author": { "name": "Angel Pons", "email": "th3fanbus@gmail.com", "time": "Tue May 25 13:03:24 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "dummyflasher.c: Prevent use-after-free bug\n\nThe memory for the `status` string is aliased by the `endptr` pointer.\nMoreover, `errno` could have been modified by the call to `free()`.\nTherefore, only free the former when there are no more uses of either.\n\nChange-Id: I1b56834004fe18918213a7df0a09a8a7ecb56985\nSigned-off-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/54909\nOriginal-Reviewed-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nOriginal-Reviewed-by: Anastasia Klimchuk \u003caklm@chromium.org\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71363\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "328898a911438ab4e133610e0c901d00264624eb", "tree": "1f700788e8861ef176d67bb4c7615f7d4cb05c5b", "parents": [ "02b9ae240f7f7ea4a8f7c723c128a415a384ce02" ], "author": { "name": "Angel Pons", "email": "th3fanbus@gmail.com", "time": "Tue May 25 12:56:18 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "dummyflasher.c: Move `flashchip_contents` allocation\n\nPlace `flashchip_contents` allocation next to the code that initialises\nthe newly-allocated buffer. This also avoids leaking it if the handling\nof `spi_status` fails.\n\nChange-Id: Ie907ac88dfe4ca018c97d9ce6ce042b4ffacf36a\nSigned-off-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/54908\nOriginal-Reviewed-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nOriginal-Reviewed-by: Anastasia Klimchuk \u003caklm@chromium.org\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71362\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "02b9ae240f7f7ea4a8f7c723c128a415a384ce02", "tree": "0b2ba5caa5cbcefb2b802d7d0cb9bf7e1507282a", "parents": [ "f02db806eb522a748de702b96d08a8785e74df5d" ], "author": { "name": "Angel Pons", "email": "th3fanbus@gmail.com", "time": "Tue May 25 12:46:43 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "dummyflasher.c: Don\u0027t leak `emu_persistent_image`\n\nEnsure `emu_persistent_image` doesn\u0027t end up leaking memory.\n\nChange-Id: I76529973cefcc6a1472681e1f4da8239fcbf07a6\nSigned-off-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/54905\nOriginal-Reviewed-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71361\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "f02db806eb522a748de702b96d08a8785e74df5d", "tree": "32400c650ef78ee97340acae6c53599d7602671a", "parents": [ "c785f88929c6802e8e3715b04c2be394f680ce95" ], "author": { "name": "Anastasia Klimchuk", "email": "aklm@chromium.org", "time": "Mon May 24 10:07:56 2021 +1000" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "serprog.c: Use braces in both branches of conditional statement\n\nAs per the coding style, if one branch of a conditional statement\nneeds braces, all other branches need to have braces as well.\n\nChange-Id: I4fdccbd66f0351af98811bf7c2d8e15f0a99d852\nSigned-off-by: Anastasia Klimchuk \u003caklm@chromium.org\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/54862\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71360\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "c785f88929c6802e8e3715b04c2be394f680ce95", "tree": "db5a108e2a39fdbf98375ada8e1a5a9f279f3bc1", "parents": [ "9425022c7bc1b002beeb9c7c7841e8fe16458fba" ], "author": { "name": "Edward O\u0027Callaghan", "email": "quasisec@google.com", "time": "Sun May 23 22:14:36 2021 +1000" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "dummyflasher.c: Replace atoi() with strtoul()\n\nflashrom-stable: Squashed fixup\n\nChange-Id: Ib9e66016a2f4ce2d13b833c261f900cab80916b7\nSpotted-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nSigned-off-by: Edward O\u0027Callaghan \u003cquasisec@google.com\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/54854\nOriginal-Reviewed-by: Sam McNally \u003csammc@google.com\u003e\nOriginal-Reviewed-by: Anastasia Klimchuk \u003caklm@chromium.org\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71359\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "9425022c7bc1b002beeb9c7c7841e8fe16458fba", "tree": "e523b701a57fbe3798f726680258545fcd285a77", "parents": [ "3fa321d784f21bc3654b563bc11d63cde1f65218" ], "author": { "name": "Edward O\u0027Callaghan", "email": "quasisec@google.com", "time": "Thu May 20 20:34:02 2021 +1000" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "dummyflasher.c: Move \u0027flashchip_contents\u0027 into emu_data\n\nMove \u0027flashchip_contents\u0027 out of global scope and\ninto the emu_data reentrent struct.\n\nChange-Id: I11dfe713dd2fecfd3981ab50e31c9215d00bc787\nSigned-off-by: Edward O\u0027Callaghan \u003cquasisec@google.com\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/54722\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-by: Anastasia Klimchuk \u003caklm@chromium.org\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71358\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "3fa321d784f21bc3654b563bc11d63cde1f65218", "tree": "65df68524c5a825a6d8b3035f15de4b0919ca36e", "parents": [ "67aaed75e4f92ec61d265e8f0d7f05ed6fd23c68" ], "author": { "name": "Edward O\u0027Callaghan", "email": "quasisec@google.com", "time": "Mon May 17 20:01:27 2021 +1000" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "dummyflasher.c: Use BUS_NONSPI where appropriate\n\nThe BUS_NONSPI is short-hand and is intended to be\nthe collection, therefore use it.\n\nChange-Id: I368e8865c446d9b9ffd580c90eac034850dd53d8\nSigned-off-by: Edward O\u0027Callaghan \u003cquasisec@google.com\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/54356\nOriginal-Reviewed-by: Anastasia Klimchuk \u003caklm@chromium.org\u003e\nOriginal-Reviewed-by: Sam McNally \u003csammc@google.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71357\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "67aaed75e4f92ec61d265e8f0d7f05ed6fd23c68", "tree": "b5108cccfab0b492c8c536c16ad31d5f2a7dbafe", "parents": [ "1c7297fdbb34c6d211a31b4071c232d7e053289a" ], "author": { "name": "Anastasia Klimchuk", "email": "aklm@chromium.org", "time": "Fri May 14 14:01:34 2021 +1000" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "stlinkv3_spi.c: Clean up properly on all init error paths\n\nIf register_spi_master() fails, going to init exit cleanup is not\nneeded because at that point shutdown function has already been\nregistered and it does the job.\n\nChange-Id: I9fabf48068635593bc86006c9642d8569eee8447\nSigned-off-by: Anastasia Klimchuk \u003caklm@chromium.org\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/54190\nOriginal-Reviewed-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nOriginal-Reviewed-by: Miklós Márton \u003cmartonmiklosqdev@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71356\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "1c7297fdbb34c6d211a31b4071c232d7e053289a", "tree": "141678ce4577d4743df0808f550b43329c7fd884", "parents": [ "4db0fdfdcb59f94e41c0967375c899e2d274e113" ], "author": { "name": "Angel Pons", "email": "th3fanbus@gmail.com", "time": "Mon May 17 10:50:40 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "chipset_enable.c: Add Gemini Lake eSPI PCI device ID\n\nTaken from coreboot `PCI_DEVICE_ID_INTEL_GLK_ESPI` macro, untested.\n\nChange-Id: Ie34527e56edcba4982f17b8e0aef0fc4280a52bc\nSigned-off-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/54354\nOriginal-Reviewed-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nOriginal-Reviewed-by: Sam McNally \u003csammc@google.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71355\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "4db0fdfdcb59f94e41c0967375c899e2d274e113", "tree": "5866347a6c5e63477f8e05cc32443085319c2df3", "parents": [ "771bb7952a91722d2d9f100e19b0566f06298126" ], "author": { "name": "Angel Pons", "email": "th3fanbus@gmail.com", "time": "Fri Jul 10 17:04:10 2020 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "Add Gemini Lake support\n\nThe SPI hardware is pretty much unchanged from Apollo Lake. However, the\nIFD differs significantly enough to require special handling.\n\nSigned-off-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nChange-Id: Ib5dcdf204166f44a8531c19b5f363b851d2ccd77\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/54276\nOriginal-Reviewed-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71354\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "771bb7952a91722d2d9f100e19b0566f06298126", "tree": "dd32d8135b2780a15ae4dc17a3ac6234e664717c", "parents": [ "17d16032d68931361a2a20de243ac95752f3292a" ], "author": { "name": "Angel Pons", "email": "th3fanbus@gmail.com", "time": "Sun May 02 15:09:20 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "nicintel_eeprom.c: Mark 8086:1531 as tested\n\nReading, erasing and writing works on an i210 NIC of an Asus Z10PA-D8.\n\nChange-Id: I9cabea5dfb9424b9c30d82840089506f2bd943da\nSigned-off-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/52825\nOriginal-Reviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nOriginal-Reviewed-by: Anastasia Klimchuk \u003caklm@chromium.org\u003e\nOriginal-Reviewed-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71353\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "17d16032d68931361a2a20de243ac95752f3292a", "tree": "b867e11a84bc543352163e6852ebc758accab958", "parents": [ "a32d47f14886376e71d84f224c7580f1be1b58e8" ], "author": { "name": "Patrick Rudolph", "email": "patrick.rudolph@9elements.com", "time": "Wed Aug 26 10:02:08 2020 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "dediprog: Add 4BA support on SF600 protocol version 3\n\nTested on SF600 protocol 3 V:7.2.45\nFixes the error message:\n\"4-byte address requested but master can\u0027t handle 4-byte addresses.\"\n\nChange-Id: I2d91f940eb246b928a9d386eefb4195f9ccf1bb5\nSigned-off-by: Patrick Rudolph \u003cpatrick.rudolph@9elements.com\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/44811\nOriginal-Reviewed-by: Arthur Heymans \u003carthur@aheymans.xyz\u003e\nOriginal-Reviewed-by: David Hendricks \u003cdavid.hendricks@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71352\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "a32d47f14886376e71d84f224c7580f1be1b58e8", "tree": "16452af658e4d7e1284a5dd5cca233bba7c32ea9", "parents": [ "8eaef7d9d3e189fcffd0afbe55c8ddbadcc524f8" ], "author": { "name": "Patrick Rudolph", "email": "patrick.rudolph@9elements.com", "time": "Wed Aug 26 07:58:16 2020 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "dediprog: Disable SPI_MASTER_NO_4BA_MODES for additional devices\n\nThe SPI_MASTER_NO_4BA_MODES is for SPI master not keeping the flash\npowered between programming commands. Tests on the following devices\nshowed that the power is stable accross commands:\n\n* SF100 protocol 2 V:6.5.03\n* SF600 protocol 3 V:7.2.45\n\nChange-Id: Iee0ba972245b9317ef86345432fec5fc32614888\nSigned-off-by: Patrick Rudolph \u003cpatrick.rudolph@9elements.com\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/44776\nOriginal-Reviewed-by: David Hendricks \u003cdavid.hendricks@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71351\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "8eaef7d9d3e189fcffd0afbe55c8ddbadcc524f8", "tree": "ed8ade2bb6610993a27aa9b240d5cbdfd7ecc42d", "parents": [ "b499b67d1b112141792a71ad9119d51dd9052684" ], "author": { "name": "Daniel Campello", "email": "campello@chromium.org", "time": "Thu Apr 15 10:36:04 2021 -0600" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "flashrom.c: allow - as filename for stdin\n\nAllows - as filename for -w/-v options. It is sometimes useful to\nscript flashrom and allowing it to work with pipes allows for more\nflexibility in this specific use-case.\n\nSigned-off-by: Daniel Campello \u003ccampello@chromium.org\u003e\nChange-Id: I97889cfdf7ba9a257e182c4ee2b20075cfa58d4d\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/52383\nOriginal-Reviewed-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71350\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "b499b67d1b112141792a71ad9119d51dd9052684", "tree": "e1477a95f0987cdaf6a4a9f1c774d7bbb7f9773b", "parents": [ "bc0285c9b3e6faa8538cb0d2a1d50c158a955919" ], "author": { "name": "Angel Pons", "email": "th3fanbus@gmail.com", "time": "Thu Apr 22 17:08:00 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "chipset_enable.c: Add IDs for H310C and B365 PCHs\n\nThe device ID for H310C can be found in Intel document 335192-004, but\nthe device ID for B365 is not there. Other sites list these IDs:\n\nhttps://linux-hardware.org/index.php?id\u003dpci:8086-a2ca-1462-7c09 (H310C)\nhttps://linux-hardware.org/index.php?id\u003dpci:8086-a2cc-1849-a2cc (B365)\n\nBoth of these PCHs have been tested as well.\n\nChange-Id: If9f0a49a0f1821e5592213e07962ee48654cdc07\nOriginal-Tested-by: Timofey Komarov \u003chappycorsair@yandex.ru\u003e\nSigned-off-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/52605\nOriginal-Reviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71349\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "bc0285c9b3e6faa8538cb0d2a1d50c158a955919", "tree": "af7580298b29c029ef14f10b837388c16ee3c5a9", "parents": [ "d493baaa0c21c3b3f648b0349104978f4f589a33" ], "author": { "name": "Gaggery Tsai", "email": "gaggery.tsai@intel.com", "time": "Thu Dec 12 11:52:03 2019 -0800" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "chipset_enable.c: Add CMP-H IDs\n\nThis patch adds CMP-H support. They are HM470, WM490, QM480,\nW480, H470, Z490 and Q470.\n\nTested: build flashrom and run on CML-S with CMP-H\n flashrom -p internal -w ./coreboot.rom\n reboot and check the code is flashed correctly\n\nSigned-off-by: Gaggery Tsai \u003cgaggery.tsai@intel.com\u003e\nChange-Id: Ic7f04fc5cbe3422cbd219c46586c32fc847c921f\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/37677\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-by: Tim Crawford \u003ctcrawford@system76.com\u003e\nOriginal-Reviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71348\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "d493baaa0c21c3b3f648b0349104978f4f589a33", "tree": "0ff6e28d593d487cc3b6da1265827b8d740c76fc", "parents": [ "0be623c3d88bef4c37d546e0970b0e8ac890be24" ], "author": { "name": "Evgeny Zinoviev", "email": "me@ch1p.io", "time": "Sat Mar 06 21:14:39 2021 +0300" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "chipset_enable: Mark QS67 as DEP\n\nTested on MacBook Air 4,2.\n\nChange-Id: Ia31c9d336d6ffe441323616174018b0f6a8897bd\nSigned-off-by: Evgeny Zinoviev \u003cme@ch1p.io\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/51320\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71347\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "0be623c3d88bef4c37d546e0970b0e8ac890be24", "tree": "6dfe2fa44b28201b924886ab746c92dc688a5b31", "parents": [ "44cfbb06284d4118d34fdbfc2cb1fd9b0de60462" ], "author": { "name": "Angel Pons", "email": "th3fanbus@gmail.com", "time": "Sat Apr 17 17:08:44 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "Use singular they to refer to \"the user\" in comments\n\nChange-Id: I726006fe2c1780361bdf6f9a1ddd84da0733642d\nSigned-off-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/52472\nOriginal-Reviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71346\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "44cfbb06284d4118d34fdbfc2cb1fd9b0de60462", "tree": "b79675d6ec8fca1a1abae236fbe59fd65023df60", "parents": [ "acb24d435a4d2f523f7814adfd69b4aa7d8a97a2" ], "author": { "name": "Angel Pons", "email": "th3fanbus@gmail.com", "time": "Sat Apr 17 17:07:34 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:07:04 2023 +0000" }, "message": "ft2232_spi.c: Fix typo in comment\n\nhis ---\u003e this\n\nChange-Id: Ibcc04a1581b3ba0dcd86e6f900c146823ebcd84a\nSigned-off-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/52471\nOriginal-Reviewed-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71345\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "acb24d435a4d2f523f7814adfd69b4aa7d8a97a2", "tree": "e85be0c48ced47bd090665f5ac5759a5a70420cd", "parents": [ "281ed26f700e14ec823230c999b93caaaa07463d" ], "author": { "name": "Edward O\u0027Callaghan", "email": "quasisec@google.com", "time": "Thu Apr 15 13:44:39 2021 +1000" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:07:04 2023 +0000" }, "message": "flashrom.c: Fix up stale FIXME comment when doit() was removed\n\nOnce upon a time flashrom had a entry point function called\ndoit(). Excise the last mention of it here so that we may\nnever mention it again.\n\nChange-Id: I40d815b7154456c323b4230cd3fed2cc2e8e3641\nSigned-off-by: Edward O\u0027Callaghan \u003cquasisec@google.com\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/52365\nOriginal-Reviewed-by: Anastasia Klimchuk \u003caklm@chromium.org\u003e\nOriginal-Reviewed-by: Paul Menzel \u003cpaulepanter@mailbox.org\u003e\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71344\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\n" }, { "commit": "281ed26f700e14ec823230c999b93caaaa07463d", "tree": "e2f84318a036875033ca7800f7119cc6af6f93d7", "parents": [ "e8106ba746046693fb8d3d2371ef2e07b221f085" ], "author": { "name": "Angel Pons", "email": "th3fanbus@gmail.com", "time": "Fri Apr 16 10:55:03 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:07:04 2023 +0000" }, "message": "jlink_spi.c: Correct some log messages\n\nFix a few typos and a copy-paste error in log messages.\n\nChange-Id: Ic69503f60a59aa0f4b991eaa2a7be40a7d9c1301\nSigned-off-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/52412\nOriginal-Reviewed-by: Miklós Márton \u003cmartonmiklosqdev@gmail.com\u003e\nOriginal-Reviewed-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71343\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "e8106ba746046693fb8d3d2371ef2e07b221f085", "tree": "c3023d7fd1804ae111d56e4d6857ce9371a02005", "parents": [ "7630390672170718d6114f1439705d03765ac036" ], "author": { "name": "Anastasia Klimchuk", "email": "aklm@chromium.org", "time": "Mon Apr 12 10:05:57 2021 +1000" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:07:04 2023 +0000" }, "message": "ft2232_spi.c: Refactor singleton states into reentrant pattern\n\nMove global singleton states into a struct and store within\nthe spi_master data field for the life-time of the driver.\n\nThis is one of the steps on the way to move spi_master data\nmemory management behind the initialisation API, for more\ncontext see other patches under the same topic \"register_master_api\".\n\nflashrom-stable:\n* Fix resource leaking\n* Fix return value on failed register_shutdown()\n* Re-add `ftdic` pointer to reduce diff noise\n* Drop redundant `c` from `ftdic_context`\n\nChange-Id: I67518a58b4f35e0edaf06ac09c9374bdf06db0df\nSigned-off-by: Anastasia Klimchuk \u003caklm@chromium.org\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/52256\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71342\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\n" }, { "commit": "7630390672170718d6114f1439705d03765ac036", "tree": "266da495f6b51660caaa5110c45abe49d96a6715", "parents": [ "198bef39367088df36c88ecf93bd3b900a597735" ], "author": { "name": "Sam McNally", "email": "sammc@chromium.org", "time": "Thu Mar 11 11:41:46 2021 +1100" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:07:04 2023 +0000" }, "message": "chipset_enable.c: Add PCI ID for Comet Lake U Base\n\nTested: `flashrom -r` on a kindred chromebook with a Celeron 5205U.\n\nChange-Id: I627dcacdad167343287ac0ec26b47505c2f823ee\nSigned-off-by: Sam McNally \u003csammc@chromium.org\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/51401\nOriginal-Reviewed-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71341\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\n" }, { "commit": "198bef39367088df36c88ecf93bd3b900a597735", "tree": "d4310f2f5618c92bd7dbada59a5015ed6a8d38f7", "parents": [ "9eeae3328682feadb663490eafaa26ee15cc0003" ], "author": { "name": "Jacob Garber", "email": "jgarber1@ualberta.ca", "time": "Sat Feb 20 10:51:56 2021 -0700" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:07:04 2023 +0000" }, "message": "chipset_enable: Mark Intel C216 as DEP\n\nTested reading and writing internal flash on HP Z220 SFF.\n\nSigned-off-by: Jacob Garber \u003cjgarber1@ualberta.ca\u003e\nChange-Id: I97538577c32e6c40374c414f005eb3165ed2e11d\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/50986\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71340\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\n" }, { "commit": "9eeae3328682feadb663490eafaa26ee15cc0003", "tree": "01c6f2c16821ad69a320ccdba9bd3657fbf4a80a", "parents": [ "460c1c0462af16d04002deb0833aee3f3e42ff81" ], "author": { "name": "Aaron Durbin", "email": "adurbin@chromium.org", "time": "Wed Sep 27 01:02:08 2017 -0600" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:07:04 2023 +0000" }, "message": "cbtable.c: don\u0027t assume high addresses can fully map 1 MiB\n\nForward port the downstream `commit b17e9e41838`.\n\nWhen using a forwarding table entry for finding the coreboot table\ndon\u0027t assume one has access to a full 1 MiB where the forwarding\ntable entry points to. The reason is that the 1 MiB may cover address\nregions that have differing cacheability type. As such the kernel will\ncomplain and the mapping will fail. Instead, check the header first then\nmap in the bytes that it indicates after sanity validation. That way\nthere is no attempt at requesting an invalid mapping that spans different\nmemory cacheability attributes.\n\nV.2: Incorperate Nico\u0027s and Angels comments from upstream.\n\nTested: Can successfully run \u0027flashrom -p host --wp-status\u0027 on kahlee\n without generating PAT errors.\n\nflashrom-stable:\n* Squashed fixup\n* Don\u0027t continue if re-mapping failed\n* Restored still valid FIXME comment\n\nOriginal-Change-Id: Ic6c5832b069300cced66e11f4ca4a0bbc6e496de\nOriginal-Signed-off-by: Aaron Durbin \u003cadurbin@chromium.org\u003e\nOriginal-Reviewed-on: https://chromium-review.googlesource.com/685608\nOriginal-Reviewed-by: Martin Roth \u003cmartinroth@chromium.org\u003e\nOriginal-Reviewed-by: Justin TerAvest \u003cteravest@chromium.org\u003e\n\nChange-Id: I43705c19dd7c816098d03f528bde6f180c4c8f24\nSigned-off-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/37240\nOriginal-Reviewed-by: Sam McNally \u003csammc@google.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71339\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\n" }, { "commit": "460c1c0462af16d04002deb0833aee3f3e42ff81", "tree": "7d00272d317ad120809076e08db86c75b518c641", "parents": [ "0b1fb92b5e6e3a057709ab3b82032f81f2b564ec" ], "author": { "name": "Alan Green", "email": "avg@google.com", "time": "Fri Jan 08 09:36:45 2021 +1100" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:07:04 2023 +0000" }, "message": "ft2232_spi.c: release I/Os on shutdown\n\nReset FTDI I/O pins to high-Z (input) when shutting down. This allows\nother devices to use the SPI bus without having to disconnect the\nprogrammer.\n\nThis change will introduce a backward incompatibility in the case where\na user is relying on the state of FTDI outputs post-programming (eg. to\ndisallow another device from driving CS low).\n\nHowever, there are likely more cases where releasing the SPI bus is the\ncorrect thing to do.\n\nSigned-off-by: Alan Green \u003cavg@google.com\u003e\nChange-Id: I9fae55e532595752983f55fac2298f81699dbe5b\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/49632\nOriginal-Reviewed-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71338\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\n" }, { "commit": "0b1fb92b5e6e3a057709ab3b82032f81f2b564ec", "tree": "3609203b1b63c9c38c3b32a6e87a4e95344b39f4", "parents": [ "c14e3f6bd806c193741bb17815ad8d5d98b7ee38" ], "author": { "name": "Alan Green", "email": "avg@google.com", "time": "Fri Jan 08 09:08:54 2021 +1100" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:07:04 2023 +0000" }, "message": "programmer: remove unused noop_shutdown function\n\nFunction appears to be vestigial.\n\nflashrom-stable: Squashed fixup\n\nSigned-off-by: Alan Green \u003cavg@google.com\u003e\nChange-Id: I1b67223aed8be54b60771aa1b2d498836ed28060\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/49631\nOriginal-Reviewed-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71337\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\n" }, { "commit": "c14e3f6bd806c193741bb17815ad8d5d98b7ee38", "tree": "dc737e8fb1f25b064f82491a6806f4ce613b5f69", "parents": [ "1cea5c3c7958409245c43ce2df6e8e09795fe6c3" ], "author": { "name": "Martin Lucina", "email": "martin@lucina.net", "time": "Fri Dec 18 14:11:04 2020 +0000" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:07:04 2023 +0000" }, "message": "Makefile: Add a DISABLE_CLOCK_GETTIME option\n\nAllows to force-disable the use of clock_gettime() at build time,\nfalling back to busy-looping for udelay. This is useful when building\nfor systems which are known to lie about the resolution of\nclock_gettime(), such as Linux guests running under the Muen Separation\nKernel.\n\nChange-Id: I645a5d3f29ffdbd24a58127ab73d7d8755304f45\nSigned-off-by: Martin Lucina \u003cmartin@lucina.net\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/48796\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71335\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\n" }, { "commit": "1cea5c3c7958409245c43ce2df6e8e09795fe6c3", "tree": "d4d950cae311075b6d1227da709c6278ae57d631", "parents": [ "abb34fee66dc5255ac0ae770eb3d7f1c28f7b792" ], "author": { "name": "Miriam Polzer", "email": "mpolzer@google.com", "time": "Wed Dec 23 17:28:38 2020 +0100" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:07:04 2023 +0000" }, "message": "Add missing platform.h includes\n\nInclude platform.h in all files using its macros.\n\nSigned-off-by: Miriam Polzer \u003cmpolzer@google.com\u003e\nChange-Id: If17a3d58c02222f61b4e0335879eeed1638b583c\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/48880\nOriginal-Reviewed-by: Idwer Vollering \u003cvidwer@gmail.com\u003e\nOriginal-Reviewed-by: David Hendricks \u003cdavid.hendricks@gmail.com\u003e\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71334\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\n" }, { "commit": "abb34fee66dc5255ac0ae770eb3d7f1c28f7b792", "tree": "af60db80459aba40d14cc08af031149c95ec598e", "parents": [ "2bb6792361f66a78473212d4dcddfe69d7b88aad" ], "author": { "name": "Angel Pons", "email": "th3fanbus@gmail.com", "time": "Sun Dec 06 23:09:13 2020 +0100" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:07:04 2023 +0000" }, "message": "chipset_enable.c: Mark Intel H110 as DEP\n\nTested reading, writing and erasing the internal flash chip using an HP\n280 G2 SFF mainboard with an Intel H110 PCH. However, since ME-enabled\nchipsets are marked as DEP instead of OK, this one shall also be.\n\nChange-Id: I5deac6e43a43ee9748aaa7dadae50065613488b1\nSigned-off-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/48384\nOriginal-Reviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nOriginal-Reviewed-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71333\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "2bb6792361f66a78473212d4dcddfe69d7b88aad", "tree": "95924eefb318626978a4ee525f56ce2d123dfeac", "parents": [ "0a84d0d6950fef06ea0c0b0d220f9a97d2a958f0" ], "author": { "name": "Nikolai Artemiev", "email": "nartemiev@google.com", "time": "Tue Nov 03 17:19:52 2020 +1100" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:07:04 2023 +0000" }, "message": "chipset_enable.c: mark \"Broadwell U Base\" as DEP\n\nTested probe/read/erase/write operations succeed with cros\nflashrom on rikku chromebox. Marking as DEP to follow\nconvention for ME-enabled chipsets.\n\nTested: Applied patch to cros flashrom and verified that\n`flashrom -VV` no longer prints a chipset warning on rikku\n\nChange-Id: I0b4d1dd2b271537faea15856442fe183d9de3318\nSigned-off-by: Nikolai Artemiev \u003cnartemiev@google.com\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/47218\nOriginal-Reviewed-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71332\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\n" }, { "commit": "0a84d0d6950fef06ea0c0b0d220f9a97d2a958f0", "tree": "71dd9f05f2cd069305f7d2cb1877ad5ba9f8ed5d", "parents": [ "3b3fc9344d6cfd29007545826ecaf1e483b4bed4" ], "author": { "name": "Edward O\u0027Callaghan", "email": "quasisec@google.com", "time": "Tue Nov 24 18:05:02 2020 +1100" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:07:04 2023 +0000" }, "message": "programmer.h,c: Drop dead noop_chip_writeb() fn\n\nDrop dead code.\n\nTested: `git grep noop_chip_writeb`\n\nChange-Id: I160406df903b3b0a49a5ff3ec78a030e10fa60a0\nSigned-off-by: Edward O\u0027Callaghan \u003cquasisec@google.com\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/47894\nOriginal-Reviewed-by: Sam McNally \u003csammc@google.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71331\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\n" }, { "commit": "3b3fc9344d6cfd29007545826ecaf1e483b4bed4", "tree": "e249fbe857aee081ed4cdd2bf35feafac056673f", "parents": [ "55f6564524189f99097b3c6525b1b339a72cd063" ], "author": { "name": "Angel Pons", "email": "th3fanbus@gmail.com", "time": "Fri Nov 20 10:05:29 2020 +0100" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:07:04 2023 +0000" }, "message": "chipset_enable.c: Mark Intel Q67 as DEP\n\nTested reading, writing and erasing the internal flash chip using an HP\nElite 8200 mainboard with an Intel Q67 PCH. However, since ME-enabled\nchipsets are marked as DEP instead of OK, this one shall also be.\n\nChange-Id: I2bd431c5c72824654b6b5b840f9af55dfe9d3554\nSigned-off-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/47797\nOriginal-Reviewed-by: Frans Hendriks \u003cfhendriks@eltan.com\u003e\nOriginal-Reviewed-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71330\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "55f6564524189f99097b3c6525b1b339a72cd063", "tree": "640e378ca1287a26f1a91ff4c0f088a84a7fa6bf", "parents": [ "0ad11992be40c7e1e9b8a1f45a48a3e5362f6f7c" ], "author": { "name": "Edward O\u0027Callaghan", "email": "quasisec@google.com", "time": "Mon Nov 02 14:43:10 2020 +1100" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:07:04 2023 +0000" }, "message": "chipset_enable.c: Add Intel pch7 did\u003d0x1e4{1,2,3} support\n\nModified to be pch7 over pch6 as per-coreboot and review\ncomments.\n\nChange-Id: Ic69dc024e9af0c43d6b3a8213a5dc5d2f898c447\nSigned-off-by: Edward O\u0027Callaghan \u003cquasisec@google.com\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/47090\nOriginal-Reviewed-by: Sam McNally \u003csammc@google.com\u003e\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71329\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\n" }, { "commit": "0ad11992be40c7e1e9b8a1f45a48a3e5362f6f7c", "tree": "01063d16c206556797a4f021ade86691faa4acb8", "parents": [ "52916f678b35fe0e8f821b76218068ee5735a96e" ], "author": { "name": "Edward O\u0027Callaghan", "email": "quasisec@google.com", "time": "Wed Oct 28 16:05:18 2020 +1100" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:07:04 2023 +0000" }, "message": "Makefile: Fix typo NEED_LIBUSB0 -\u003e NEED_LIBUSB1\n\nChange-Id: I5a402d9530f73419d8317d94a8d6f745d09675ea\nSigned-off-by: Edward O\u0027Callaghan \u003cquasisec@google.com\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/46869\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71328\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\n" }, { "commit": "52916f678b35fe0e8f821b76218068ee5735a96e", "tree": "6f6beca13f3faefd9581829cac90c7e0b2bff0fd", "parents": [ "317c67b37ba66f50c810938deacbc2e9ce5e11ac" ], "author": { "name": "Edward O\u0027Callaghan", "email": "quasisec@google.com", "time": "Fri Oct 09 13:00:17 2020 +1100" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:07:04 2023 +0000" }, "message": "it87spi.c: Fix layering violation of default_spi_read\n\ndefault_spi_read() calls spi_read_chunked() with the correct\nmax_read value of 3 set in the spi master struct.\n\nChange-Id: I199c81e1ba501e86dbfb7cf18e2d1556e30db62e\nSigned-off-by: Edward O\u0027Callaghan \u003cquasisec@google.com\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/46233\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-by: Sam McNally \u003csammc@google.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71327\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\n" }, { "commit": "317c67b37ba66f50c810938deacbc2e9ce5e11ac", "tree": "ccf7dd8441b93636b503a60ab5342ffb809652e5", "parents": [ "4f29bb799b4672eebcc0bdfc6fb544b2b5544b6f" ], "author": { "name": "Edward O\u0027Callaghan", "email": "quasisec@google.com", "time": "Fri Oct 09 12:56:53 2020 +1100" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:07:04 2023 +0000" }, "message": "dediprog.c: Fix layering violation of default_spi_read\n\ndefault_spi_read() calls spi_read_chunked() with the correct\nmax_read value of 16 set in the spi master struct.\n\nChange-Id: Ic0897f74056e3d723a33c063ed0bd8cb6e88ba45\nSigned-off-by: Edward O\u0027Callaghan \u003cquasisec@google.com\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/46232\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-by: Sam McNally \u003csammc@google.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71326\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\n" }, { "commit": "4f29bb799b4672eebcc0bdfc6fb544b2b5544b6f", "tree": "8a27542cc468d103319c7c36afe894f57870f59a", "parents": [ "c753c40971c1481943e8a18dc24b33037e2a579d" ], "author": { "name": "Matt DeVillier", "email": "matt.devillier@gmail.com", "time": "Wed Aug 12 12:48:06 2020 -0500" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:07:04 2023 +0000" }, "message": "Add support for Comet Lake-U/400-series PCH\n\nAdd enum CHIPSET_400_SERIES_COMET_POINT and treat it identically\nto CHIPSET_300_SERIES_CANNON_POINT.\n\nAdd PCI IDs for Comet Lake, CML-U Premium and classify as CHIPSET_400_SERIES_COMET_POINT.\n\nTest: read/write unlocked CML-U board\n\nflashrom-stable:\nAs suggested above, treat it the same as 300 series. But don\u0027t add a\nnew enum.\n\nChange-Id: I43b4ad1eecfed16fec59863e46d4e997fbe45f1b\nSigned-off-by: Matt DeVillier \u003cmatt.devillier@gmail.com\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/44420\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-by: Felix Singer \u003cfelixsinger@posteo.net\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71325\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\n" }, { "commit": "c753c40971c1481943e8a18dc24b33037e2a579d", "tree": "63d730f2195ac8f19740b9f2ed4cce9592790049", "parents": [ "13f90e64821fb8af412c7d692c72d2663dc9ce04" ], "author": { "name": "Lachlan Bishop", "email": "lxb@google.com", "time": "Thu Sep 10 14:57:05 2020 +1000" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:07:04 2023 +0000" }, "message": "dummyflasher.c: Factor out global state\n\nMoves global state into spi_master data.\n\nflashrom-stable: Squashed many fixups\n\nChange-Id: I972b085875f1277d9ff33326669d2676a3bcd3aa\nSigned-off-by: Lachlan Bishop \u003clxb@google.com\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/45230\nOriginal-Reviewed-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71323\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\n" }, { "commit": "13f90e64821fb8af412c7d692c72d2663dc9ce04", "tree": "9093a2c7001756fb3d5fde006f6fddfbb1664867", "parents": [ "e19a41b5411c1a693ad81e9b138ac7d474bad495" ], "author": { "name": "Edward O\u0027Callaghan", "email": "quasisec@google.com", "time": "Wed Jan 06 14:10:52 2021 +1100" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:07:04 2023 +0000" }, "message": "tree/: Drop const from opaque data ptr in master definitions [alt]\n\nThe opaque data pointer need not necessarily have constant\ndata for the life-time of the specific master. This is because\nthe data field purpose is for the master to use as it sees fit\nfor managing its own internal state and therefore we should not\nconstrain this as being RO data at init time.\n\nflashrom-stable:\nAdd cast in bitbang_spi to avoid compiler warning.\n\nChange-Id: I686c3c79547e35d48f3fd0b524fc98c176dcea6e\nSigned-off-by: Edward O\u0027Callaghan \u003cquasisec@google.com\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/49131\nOriginal-Reviewed-by: Sam McNally \u003csammc@google.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71336\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\n" }, { "commit": "e19a41b5411c1a693ad81e9b138ac7d474bad495", "tree": "5d906d491859296f784ec0255beebabf07242077", "parents": [ "3531123fda54237b096ec67a932ce2ff8f544a1f" ], "author": { "name": "Jonathan Zhang", "email": "jonzhang@fb.com", "time": "Wed Aug 19 12:19:06 2020 -0700" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:07:04 2023 +0000" }, "message": "allow 0x34 as ICCRIBA for CHIPSET_C620_SERIES_LEWISBURG\n\nIntel C621A Lewisburg PCH belongs to C620 series, it has 0x34 as ICCRIBA.\n\nFix guess_ich_chipset_from_content() accordingly.\n\nPrint status info of read_ich_descriptors_from_dump() to facilitate\ndebugging upon failure.\n\nTested: run flashrom successfully from OCP Yosemite V3 DeltaLake server.\n\nChange-Id: I363aaccfb90e0a127c0f0bb0072e9e85c210b669\nSigned-off-by: Jonathan Zhang \u003cjonzhang@fb.com\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/44621\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71322\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\n" }, { "commit": "3531123fda54237b096ec67a932ce2ff8f544a1f", "tree": "e497c4992beedcbb1727f0aff43ce7463be4ec16", "parents": [ "1592fe589725cccbc72db60fdb1858b6edb7432c" ], "author": { "name": "Namyoon Woo", "email": "namyoon@google.com", "time": "Fri Aug 28 07:56:00 2020 -0700" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:07:04 2023 +0000" }, "message": "dummyflasher.c: Only write back emulated image if modified\n\nWhen the image is not modified, there is no point in writing it back.\nIn fact we may not have file permissions to do so.\n\nSigned-off-by: Namyoon Woo \u003cnamyoon@google.com\u003e\nChange-Id: I3bf2d7edb28a9a1e5406b67a88a0ee6e07db83e3\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/44907\nOriginal-Reviewed-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71321\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\n" }, { "commit": "1592fe589725cccbc72db60fdb1858b6edb7432c", "tree": "caf214baffdfd692575632e27eec9c20b128f780", "parents": [ "c218a053aafbedc985ba448d9a1430116d38ad9b" ], "author": { "name": "Jacob Garber", "email": "jgarber1@ualberta.ca", "time": "Fri Aug 28 12:48:32 2020 -0600" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:07:04 2023 +0000" }, "message": "chipset_enable: Mark Intel Q77 as DEP\n\nTested reading and writing internal flash on Dell Optiplex 9010 SFF.\n\nSigned-off-by: Jacob Garber \u003cjgarber1@ualberta.ca\u003e\nChange-Id: I4717959be1b79aa986f1276589d01ce7475bda8f\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/44910\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-by: Paul Menzel \u003cpaulepanter@users.sourceforge.net\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71320\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\n" }, { "commit": "c218a053aafbedc985ba448d9a1430116d38ad9b", "tree": "ab4cc37bd2680e2c5c0337c1e580801ec7e009b0", "parents": [ "9f0641960c4b3a4d71d5876b12e9c1e354bec139" ], "author": { "name": "Jonathan Zhang", "email": "jonzhang@fb.com", "time": "Wed Aug 19 12:16:40 2020 -0700" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:07:04 2023 +0000" }, "message": "add PCI IDs for additional c620 series PCH chips\n\nAdd PCI IDs for C621A, C627A and C629A.\n\nChange-Id: I636becd9f08bdf604c6af81ce396049655353b04\nSigned-off-by: Jonathan Zhang \u003cjonzhang@fb.com\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/44620\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71319\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\n" }, { "commit": "9f0641960c4b3a4d71d5876b12e9c1e354bec139", "tree": "8149dd59cba3645b9ea66faae3f2f1168f10f6b3", "parents": [ "5c639b32004925ae89ac6eb654344bad21cea9ef" ], "author": { "name": "Luka Kovacic", "email": "luka.kovacic@sartura.hr", "time": "Thu Jul 30 13:31:15 2020 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:07:04 2023 +0000" }, "message": "chipset_enable.c: Add support for Intel C620 Series Chipset SPI Controller\n\nSupport for the Intel C620 Series Chipset SPI Controller (rev 04) is added\nto enable SPI flash access on the following platform:\n\n- Intel Xeon D-2187NT\n\nSupport for this controller was shortly tested on the platform above.\nThe flash is recognized, some regions of the flash are locked.\n\nSigned-off-by: Luka Kovacic \u003cluka.kovacic@sartura.hr\u003e\nOriginal-Tested-by: Jakov Petrina \u003cjakov.petrina@sartura.hr\u003e\nCc: Luka Perkov \u003cluka.perkov@sartura.hr\u003e\nChange-Id: If39d9bb1acd4029f802a44a2940dd23f66ba09b1\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/44162\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71318\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\n" }, { "commit": "5c639b32004925ae89ac6eb654344bad21cea9ef", "tree": "d50bdf03700e78463ae850cbfe62186fb240672a", "parents": [ "dba5fa76c7e65ebe1b90da6a7a1ed223768ea9e5" ], "author": { "name": "Miklós Márton", "email": "martonmiklosqdev@gmail.com", "time": "Sun Jul 26 10:40:46 2020 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:07:04 2023 +0000" }, "message": "stlinkv3_spi.c: Improve printed messages\n\nAdd missing line ends, and add a note about the first version of the\nupdater which contains the necessary V3 bridge feature.\n\nChange-Id: Ib45efa37b192489bdfe26f1f0fd1d81035a08c70\nSigned-off-by: Miklós Márton \u003cmartonmiklosqdev@gmail.com\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/43900\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71317\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\n" }, { "commit": "dba5fa76c7e65ebe1b90da6a7a1ed223768ea9e5", "tree": "198fd4dd36bc595c2a0c68485a22d76a245ed353", "parents": [ "1f967c8acf61e2cc0d5e53c50bae11513a16755c" ], "author": { "name": "David Hendricks", "email": "david.hendricks@gmail.com", "time": "Sun Jul 19 13:02:03 2020 -0700" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:07:04 2023 +0000" }, "message": "endiantest: Fix #if expression\n\nWithout this, `gcc -E endiantest.c` can fail and return the incorrect\nendiannes as well as exiting with non-zero. Here is the actual error\nshown in the output:\n\nendiantest.c:2:31: error: #if with no expression\n #if __FLASHROM_LITTLE_ENDIAN__\n\nI was able to reproduce this using gcc-6.3.0 and clang-4.0.1, but\nnewer compilers didn\u0027t have this issue.\n\nChange-Id: Iba2febd861471ec821a494336e800c2564984332\nSigned-off-by: David Hendricks \u003cdavid.hendricks@gmail.com\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/43598\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71316\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\n" }, { "commit": "1f967c8acf61e2cc0d5e53c50bae11513a16755c", "tree": "3a38c1422300513fe68cbeafbd76603290abcd23", "parents": [ "7a6bce62a7b178c141a4dfc5e73b6b9ad80db84e" ], "author": { "name": "Jan Samek", "email": "jan.samek@siemens.com", "time": "Wed Jan 08 12:35:14 2020 +0100" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:07:04 2023 +0000" }, "message": "chipset_enable: add PCI ID for APL-I (Broxton)\n\nChange-Id: I48dba541b5893551f47f3d5ed422eb1dc36f5324\nSigned-off-by: Jan Samek \u003cjan.samek@siemens.com\u003e\nSigned-off-by: Henning Schild \u003chenning.schild@siemens.com\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/42805\nOriginal-Reviewed-by: Paul Menzel \u003cpaulepanter@users.sourceforge.net\u003e\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71315\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\n" }, { "commit": "7a6bce62a7b178c141a4dfc5e73b6b9ad80db84e", "tree": "c7655661e4f347e2f5a3fa3b2ce21e0bbd17b675", "parents": [ "c3685189816e538f5db89e68d1151c5601dc9e52" ], "author": { "name": "David Hendricks", "email": "david.hendricks@gmail.com", "time": "Thu Jul 02 09:36:50 2020 -0700" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:07:04 2023 +0000" }, "message": "serial: Fix file read/write error handling for Windows\n\nFile read/write semantics are different between POSIX and Windows. In\nparticular Windows file read/write functions return a boolean type to\nindicate success or failure, while the POSIX equivalents return a\nsigned integer indicating number of bytes read if successful or -1 if\nnot.\n\nThis attempts to correct some error handling paths for Windows and\navoid invalid comparisons that were causing compilation issues.\n\nReported on https://github.com/flashrom/flashrom/issues/149\n\nChange-Id: Ib179d51ede2dbd38f54f3641bfe90340a6a87e31\nSigned-off-by: David Hendricks \u003cdavid.hendricks@gmail.com\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/43051\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71314\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\n" }, { "commit": "c3685189816e538f5db89e68d1151c5601dc9e52", "tree": "bf6fe43212d9ad0af8723df929570d6cd141d1e8", "parents": [ "cdb290e40cf977b7eb2d21b125f6117ad554dfde" ], "author": { "name": "David Hendricks", "email": "david.hendricks@gmail.com", "time": "Tue Jun 23 17:36:09 2020 -0700" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:07:04 2023 +0000" }, "message": "dediprog: Correct REQTYPE_OTHER_OUT macro\n\nIt\u0027s not used anywhere, but it should be correct if we continue to\nkeep it in.\n\nChange-Id: I8a6941c2906dda2c5aac5e0af3364fd2ac5773f3\nSigned-off-by: David Hendricks \u003cdavid.hendricks@gmail.com\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/42763\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71313\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\n" }, { "commit": "cdb290e40cf977b7eb2d21b125f6117ad554dfde", "tree": "31d9eac835dafbea1ef954428d29b03895b4758e", "parents": [ "9148620a0d53bb8216d25f12be95b304786eeb9e" ], "author": { "name": "David Hendricks", "email": "david.hendricks@gmail.com", "time": "Tue Jun 23 14:16:26 2020 -0700" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:07:04 2023 +0000" }, "message": "tree: Remove unneeded semicolons after loops\n\nTrivial cleanup\n\nChange-Id: Id93a019a39b765c70b1a4eaeb25d9b582c3e4141\nSigned-off-by: David Hendricks \u003cdavid.hendricks@gmail.com\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/42742\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71312\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\n" } ], "next": "9148620a0d53bb8216d25f12be95b304786eeb9e" }