)]}' { "log": [ { "commit": "24e1bbbbc48ae4ab51eed508d8e5288ad009193b", "tree": "eae17460b9eab81a921725bd47434b885d857257", "parents": [ "5dc7d949366c84833d9bf84e0ff3bf7c347c9273" ], "author": { "name": "Jacek Naglak", "email": "jnaglak@tlen.pl", "time": "Wed May 18 02:25:13 2022 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:35:01 2023 +0000" }, "message": "ft2232_spi.c: Add support for kt-link jtag interface\n\nChange tested writing, reading and erasing spi flashes\npinout:\n jtag - spi\n 1 vcc - vcc, wp#, hold#\n 4 gnd - gnd\n 5 tdi - si\n 7 tms - cs#\n 9 tck - sck\n13 tdo - so\nConnect pins 9 and 12 in EXT connector for 3.3V power.\n\nSigned-off-by: Jacek Naglak \u003cjnaglak@tlen.pl\u003e\nChange-Id: Id58c675bc410ec3ef6d58603d13efc9ca53bb87c\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/64440\nOriginal-Reviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nOriginal-Reviewed-by: Felix Singer \u003cfelixsinger@posteo.net\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71469\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "5dc7d949366c84833d9bf84e0ff3bf7c347c9273", "tree": "731e7610e4c796f23ce6d55465265a5f481a4407", "parents": [ "2ab6bba5602a8a2f7e0a99cc94ccc9fe6a412723" ], "author": { "name": "Pete Smith", "email": "zailawee@protonmail.com", "time": "Wed May 11 10:01:25 2022 +0000" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:35:01 2023 +0000" }, "message": "it87spi.c: Enable probing of IT8686E\n\nEnable probing for IT8686E allowing to use the `dualbiosindex`\nparameter. Dumped and verified both firmwares. Tested on GIGABYTE\nGA-H270N-WIFI.\n\nSigned-off-by: Pete Smith \u003czailawee@protonmail.com\u003e\nChange-Id: I5a1780275a92089c2d91c5da1c472f6d8bc39a56\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/64254\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-by: Thomas Heijligen \u003csrc@posteo.de\u003e\nOriginal-Reviewed-by: Arthur Heymans \u003carthur@aheymans.xyz\u003e\nOriginal-Reviewed-by: Felix Singer \u003cfelixsinger@posteo.net\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71468\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "2ab6bba5602a8a2f7e0a99cc94ccc9fe6a412723", "tree": "65cb4b8a6c7de64b6dbf1a41cc333ac4259831a1", "parents": [ "43040f297e68cd4d826d58f57566581ef902d179" ], "author": { "name": "Edward O\u0027Callaghan", "email": "quasisec@google.com", "time": "Fri Jun 24 16:48:09 2022 +1000" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:35:01 2023 +0000" }, "message": "it85spi: EOL support\n\nThis code was originally introduced by ITE for now exceedingly old\nChromebooks. The code has had very little attention to maintain it,\nunlikely tested for a long time and now seems to be just a technical\nburden to the flashrom project.\n\nIf someone is later interested it could be resurrected for reference\nfrom git history. However, it needs quite a bit of work to bring it back\ninto maintainable order.\n\nTested: tree builds under meson+make and unit tests pass.\n\nChange-Id: I5e8cafd73db837941c518f0e2d72d8192274fd79\nSigned-off-by: Edward O\u0027Callaghan \u003cquasisec@google.com\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/65378\nOriginal-Reviewed-by: Stefan Reinauer \u003cstefan.reinauer@coreboot.org\u003e\nOriginal-Reviewed-by: Anastasia Klimchuk \u003caklm@chromium.org\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71467\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "43040f297e68cd4d826d58f57566581ef902d179", "tree": "a8357aba5a8dbfd43f3e7949c865f2682bf5962d", "parents": [ "4203a47a102e2622f404ee6567b240882d584116" ], "author": { "name": "Thomas Heijligen", "email": "thomas.heijligen@secunet.com", "time": "Thu Jun 23 14:38:35 2022 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:35:01 2023 +0000" }, "message": "tree: indent struct *_master consistently with tabs\n\nUse `\u003ctab\u003e.key\u003ctab\u003e*\u003d \u003cvalue\u003e,`\n\nTEST: `make VERSION\u003d0 MAN_DATE\u003d0` returns the same flashrom binary\nbefore and after the patch\n\nChange-Id: I1c45ea9804ca09e040d7ac98255042f58b01f8ef\nSigned-off-by: Thomas Heijligen \u003cthomas.heijligen@secunet.com\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/65363\nOriginal-Reviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nOriginal-Reviewed-by: Felix Singer \u003cfelixsinger@posteo.net\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71466\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "4203a47a102e2622f404ee6567b240882d584116", "tree": "57656409f88916ec1c9c70cfcfb20007406ccf10", "parents": [ "bbccdb275537493ec252362fc5fb792a879ae3d7" ], "author": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Sat May 28 17:28:05 2022 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:35:01 2023 +0000" }, "message": "dummyflasher: Add emulation for S25FL128L\n\nUsed to test WRSR_EXT2/3 support.\n\nSigned-off-by: Nico Huber \u003cnico.h@gmx.de\u003e\nChange-Id: Ic3cbea87218c973331b9b83e809e7d438407bc13\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/64748\nOriginal-Reviewed-by: Thomas Heijligen \u003csrc@posteo.de\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71464\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "bbccdb275537493ec252362fc5fb792a879ae3d7", "tree": "3666bfc60d97ba51abcaa3c6c7d62be23c449cdc", "parents": [ "58cf5197a6f89fd146ce0fbc340d67ef7cbe191c" ], "author": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Sat May 28 16:48:26 2022 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:35:01 2023 +0000" }, "message": "spi25_statusreg: Allow WRSR_EXT for Status Register 3 (dummy part)\n\nSpansion flash chips S25FL128L and S25FL256L use the WRSR instruction to\nwrite more than 2 registers. So align SR2 and SR3 support: The current\nFEATURE_WRSR_EXT is renamed to FEATURE_WRSR_EXT2 and FEATURE_WRSR_EXT3\nis added. Also, WRSR3 needs a separate flag now.\n\nVerified that FEATURE_WRSR_EXT2 still works using the `dummy_flasher`.\n\nflashrom-stable:\nOriginal patch was split, this is the `dummy_flasher.c` part.\n\nChange-Id: I81153cb758b9fc29b803959683ad7acf8fb771e4\nSigned-off-by: Nico Huber \u003cnico.h@gmx.de\u003e\nOriginal-Change-Id: Ibdfc6eb3d2cfecbf8da0493d067031ddb079a094\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/64746\nOriginal-Reviewed-by: Nikolai Artemiev \u003cnartemiev@google.com\u003e\nOriginal-Reviewed-by: Arthur Heymans \u003carthur@aheymans.xyz\u003e\nOriginal-Reviewed-by: Thomas Heijligen \u003csrc@posteo.de\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71463\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "58cf5197a6f89fd146ce0fbc340d67ef7cbe191c", "tree": "f2bf0a793fbcfec3ac486bf1b4e30f90649d9364", "parents": [ "c50f4aed20b6d0d455cc0a1622ef683e5fcac2ce" ], "author": { "name": "Tasos Sahanidis", "email": "tasos@tasossah.com", "time": "Wed Apr 20 09:30:42 2022 +0300" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:35:01 2023 +0000" }, "message": "board_enable: Add ASUS P5W DH Deluxe\n\nFlashrom can now write to the onboard SST49LF008 flash\n\nSigned-off-by: Tasos Sahanidis \u003ctasos@tasossah.com\u003e\nChange-Id: Iea4f858cb45c60a6180de07c8361a8a831635dfd\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/63736\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-by: Thomas Heijligen \u003csrc@posteo.de\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71462\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "c50f4aed20b6d0d455cc0a1622ef683e5fcac2ce", "tree": "078e3e4c51d02b4af427eda32fb249dc2b4db95e", "parents": [ "a1805097309f7d230f3596550fc673b109d5b19d" ], "author": { "name": "Alexander Goncharov", "email": "chat@joursoir.net", "time": "Fri Jun 17 08:32:47 2022 +0300" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:35:01 2023 +0000" }, "message": "atavia: fix BYTE_OFFSET\u0027s macro argument value\n\nA macro value has to use a correct argument name.\n\nChange-Id: I666204ec92c6df625b34ca721b3e1af78772bccf\nSigned-off-by: Alexander Goncharov \u003cchat@joursoir.net\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/65193\nOriginal-Reviewed-by: Felix Singer \u003cfelixsinger@posteo.net\u003e\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71461\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "a1805097309f7d230f3596550fc673b109d5b19d", "tree": "1a2772c9df3563a3ec5dc167dd900501b665744e", "parents": [ "2fc70dcfe988928e97e69e98d91e7e3999ecd352" ], "author": { "name": "Edward O\u0027Callaghan", "email": "quasisec@google.com", "time": "Mon May 16 11:10:36 2022 +1000" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:35:01 2023 +0000" }, "message": "flashrom.c: Make need_erase() helper static local\n\nThe need_erase() helper is only used within flashrom.c\n\nChange-Id: Ic0946bb109fca2fc18e15eefa11cccea284ded0b\nSigned-off-by: Edward O\u0027Callaghan \u003cquasisec@google.com\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/64369\nOriginal-Reviewed-by: Arthur Heymans \u003carthur@aheymans.xyz\u003e\nOriginal-Reviewed-by: Thomas Heijligen \u003csrc@posteo.de\u003e\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71460\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "2fc70dcfe988928e97e69e98d91e7e3999ecd352", "tree": "b9d2b757606242debe22d8107fbae41c668937a9", "parents": [ "27835eaf1a0384293dcd1f3ad6ad506d919f3b43" ], "author": { "name": "Sergii Dmytruk", "email": "sergii.dmytruk@3mdeb.com", "time": "Mon Nov 08 01:38:52 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:35:01 2023 +0000" }, "message": "dummyflasher: enforce write protection for W25Q128FV\n\nStart taking bits related to write protection into account.\n\nAlso add \"hwwp\" parameter for dummy programmer that sets state of WP\npin (not inverted value).\n\nTested: use command-line interface to run WP-related commands\n\ndummyflasher doesn\u0027t store state of the chip between runs and flashrom\nallows running only one command, so testing WP in this way is limited.\nHowever, WP options can be combined with other operations and are\nexecuted prior to them, so certain scenarios can be checked.\n\nList possible ranges:\n flashrom -p dummy:emulate\u003dW25Q128FV,hwwp\u003dyes --wp-list\n\nSet a particular range and check status is correct:\n flashrom -p dummy:emulate\u003dW25Q128FV,hwwp\u003dyes \\\n --wp-enable \\\n --wp-range\u003d0x00100000,0x00f00000 \\\n --wp-status\n\nEnable write protection and try erasing/writing (erasing here):\n # this fails\n flashrom -p dummy:emulate\u003dW25Q128FV,hwwp\u003dyes \\\n --wp-range\u003d0,0x00c00000 \\\n --wp-enable \\\n --erase\n\nWrite protecting empty range has no effect:\n # this succeeds\n flashrom -p dummy:emulate\u003dW25Q128FV,hwwp\u003dyes \\\n --wp-range\u003d0,0 \\\n --wp-enable \\\n --erase\n\nDisabling WP is possible if hwwp is off:\n # this fails\n flashrom -p dummy:emulate\u003dW25Q128FV,spi_status\u003d0x80,hwwp\u003dyes \\\n --wp-disable\n # this succeeds\n flashrom -p dummy:emulate\u003dW25Q128FV,spi_status\u003d0x80,hwwp\u003dno \\\n --wp-disable\n\nChange-Id: I9fd1417f941186391bd213bd355530143c8f04a0\nSigned-off-by: Sergii Dmytruk \u003csergii.dmytruk@3mdeb.com\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/59074\nOriginal-Reviewed-by: Anastasia Klimchuk \u003caklm@chromium.org\u003e\nOriginal-Reviewed-by: Thomas Heijligen \u003csrc@posteo.de\u003e\nOriginal-Reviewed-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71459\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "27835eaf1a0384293dcd1f3ad6ad506d919f3b43", "tree": "6f2043a3506fa43952717d16dffdcc0829987638", "parents": [ "59151a4b508e2b8037bc18f46232f6ca0ee90ea2" ], "author": { "name": "Sergii Dmytruk", "email": "sergii.dmytruk@3mdeb.com", "time": "Mon Nov 08 00:06:33 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:35:01 2023 +0000" }, "message": "dummyflasher: emulate SR2 and SR3 for W25Q128FV\n\nEnable emulation of SR2 and SR3 for W25Q128FV and provide logic for\nupdating them (masks of read-only bits that can\u0027t be set from outside).\n\nTested: check how input value affects status registers of emulated chip\n\nflashrom -V -p dummy:emulate\u003dW25Q128FV,spi_status\u003d0x12 |\n grep -A3 \u0027Initial status registers\u0027\nflashrom -V -p dummy:emulate\u003dW25Q128FV,spi_status\u003d0x1234 |\n grep -A3 \u0027Initial status registers\u0027\nflashrom -V -p dummy:emulate\u003dW25Q128FV,spi_status\u003d0x123456 |\n grep -A3 \u0027Initial status registers\u0027\n\nChange-Id: I79f9b4a0b604663d3288ad70dcbe3ea4075dede5\nSigned-off-by: Sergii Dmytruk \u003csergii.dmytruk@3mdeb.com\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/59073\nOriginal-Reviewed-by: Anastasia Klimchuk \u003caklm@chromium.org\u003e\nOriginal-Reviewed-by: Thomas Heijligen \u003csrc@posteo.de\u003e\nOriginal-Reviewed-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71458\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "59151a4b508e2b8037bc18f46232f6ca0ee90ea2", "tree": "3b1c6092c3b9c501cba4600946725edc4399275a", "parents": [ "885917c1594fa68ddbf5213099d99167105c046b" ], "author": { "name": "Sergii Dmytruk", "email": "sergii.dmytruk@3mdeb.com", "time": "Mon Nov 08 00:05:12 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:35:01 2023 +0000" }, "message": "dummyflasher: add SR2 and SR3 emulation harness\n\nPrepare everything for emulating SR2 and SR3 for chips that have it.\n\nThis is needed for accessing SRP1 and WPS bits which are involved in\nwrite protection. The emulated register doesn\u0027t affect anything yet\nand will be tested by write-protection tests.\n\nTested: check how input value affects status registers of emulated chip\n\nflashrom -V -p dummy:emulate\u003dW25Q128FV,spi_status\u003d0x12 |\n grep \u0027Initial status register\u0027\nflashrom -V -p dummy:emulate\u003dW25Q128FV,spi_status\u003d0x1234 |\n grep \u0027Initial status register\u0027\nflashrom -V -p dummy:emulate\u003dW25Q128FV,spi_status\u003d0x123456 |\n grep \u0027Initial status register\u0027\n\nMind that at this point there are no chips that emulate more than one\nstatus register.\n\nChange-Id: I177ae3f068f03380f5b3941d9996a07205672e59\nSigned-off-by: Sergii Dmytruk \u003csergii.dmytruk@3mdeb.com\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/59072\nOriginal-Reviewed-by: Anastasia Klimchuk \u003caklm@chromium.org\u003e\nOriginal-Reviewed-by: Thomas Heijligen \u003csrc@posteo.de\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71457\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "885917c1594fa68ddbf5213099d99167105c046b", "tree": "80e44186ee8a49d049673c79ba2395958b6662bc", "parents": [ "f6c1cb1a856e67b8cf7eaf7a90b09bc3923a3718" ], "author": { "name": "aarya", "email": "aarya.chaumal@gmail.com", "time": "Thu Mar 10 09:16:44 2022 +0530" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:35:01 2023 +0000" }, "message": "serprog.c: Avoid calling memcpy with NULL pointer arguments\n\nIn function sp_stream_buffer_op, the variable parms might be NULL when\npassed to memcpy. Although, since parmlen is also 0 at that time I\ndon\u0027t think it would make much difference. Still, add a NULL check\nbefore calling memcpy to be safe.\n\nChange-Id: I850123237e328f9548ba7f77a01888be2cbc9e7b\nSigned-off-by: Aarya Chaumal \u003caarya.chaumal@gmail.com\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/62726\nOriginal-Reviewed-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nOriginal-Reviewed-by: Anastasia Klimchuk \u003caklm@chromium.org\u003e\nOriginal-Reviewed-by: Thomas Heijligen \u003csrc@posteo.de\u003e\nOriginal-Reviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71456\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "f6c1cb1a856e67b8cf7eaf7a90b09bc3923a3718", "tree": "9776b733a8f851fe90b582068baae97e64425e40", "parents": [ "137f02f887144eae222e44adb675cb299fd00337" ], "author": { "name": "Martin Roth", "email": "gaumless@gmail.com", "time": "Tue Mar 15 10:55:25 2022 -0600" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:35:01 2023 +0000" }, "message": "Global cleanup: Fix a few spelling errors\n\nJust a trivial patch to fix a few errors found by codespell.\n\nHere\u0027s the command I used:\ncodespell -S subprojects,out \\\n-L fwe,dout,tast,crate,parms,claus,nt,nd,te,truns,trun\n\nSigned-off-by: Martin Roth \u003cgaumless@gmail.com\u003e\nChange-Id: I4e3b277f220fa70dcab21912c30f1d26d9bd8749\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/62840\nOriginal-Reviewed-by: Felix Singer \u003cfelixsinger@posteo.net\u003e\nOriginal-Reviewed-by: Anastasia Klimchuk \u003caklm@chromium.org\u003e\nOriginal-Reviewed-by: Elyes Haouas \u003cehaouas@noos.fr\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71455\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "137f02f887144eae222e44adb675cb299fd00337", "tree": "28638ab1b32d38f515a7b63a6c5dd3336093990b", "parents": [ "756b6b32e2a49c487d4bbc42d370e8826b41c922" ], "author": { "name": "Marc Schink", "email": "dev@zapb.de", "time": "Sun Aug 23 16:19:44 2020 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:35:01 2023 +0000" }, "message": "jlink_spi: Add option to enable target power\n\nflashrom-stable: Adapted error paths and shutdown function.\n\nChange-Id: I026c22ae1c22541d0024f164c827909ca4a34cf4\nSigned-off-by: Marc Schink \u003cdev@zapb.de\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/48380\nOriginal-Reviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71454\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "756b6b32e2a49c487d4bbc42d370e8826b41c922", "tree": "ce4db0712ab0fba0c5bed684ca67e012a2f2807d", "parents": [ "15095dbb7b9d7f1938d43e5ff3b99054b0798803" ], "author": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Wed Dec 21 17:15:13 2022 +0000" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:35:01 2023 +0000" }, "message": "Add Intel Jasper Lake support\n\nLoosely based on commit b01d7e9f (ichspi: Add Jasper Lake support)\non flashrom master.\n\nBesides a little change in descriptor detection, no difference to\nCannon Point was found. Hence, add new PCI IDs as 300 series.\n\nChange-Id: I9c715c1a5f1ceea32dc51669453d89b315ba8ca2\nSigned-off-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71453\nReviewed-by: Matt DeVillier \u003cmatt.devillier@gmail.com\u003e\nReviewed-by: Paul Menzel \u003cpaulepanter@mailbox.org\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "15095dbb7b9d7f1938d43e5ff3b99054b0798803", "tree": "ceb67bedd9544117f89b2e06504171d2cd42c4b3", "parents": [ "0ac29566c7a4a8977875b65497904f05e5ceeb47" ], "author": { "name": "Thomas Heijligen", "email": "thomas.heijligen@secunet.com", "time": "Wed Apr 06 20:45:02 2022 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:35:01 2023 +0000" }, "message": "flashrom.c: remove unused include\n\ngetopt.h is only needed in cli_classic.c\n\nChange-Id: I09b3233a128582bc98c5af77b6c89bd49984800e\nSigned-off-by: Thomas Heijligen \u003cthomas.heijligen@secunet.com\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/63412\nOriginal-Reviewed-by: Felix Singer \u003cfelixsinger@posteo.net\u003e\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71452\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "0ac29566c7a4a8977875b65497904f05e5ceeb47", "tree": "d66b2fc87a4bb4cda966e0c9b68b3e1d4338efd8", "parents": [ "c9c7d52a98558075b0e52d8ace559e0e5b0923e4" ], "author": { "name": "aarya", "email": "aarya.chaumal@gmail.com", "time": "Sun Mar 13 15:35:12 2022 +0530" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:35:01 2023 +0000" }, "message": "ich_descriptors.c: Ensure unsigned types \u003e\u003d0 on to prevent underflow\n\nUnsigned types show undefined behaviour if they are subtracted by a\nvalue greater than their own (mostly it wraps to the max value). Using\nthis value for left shifting could be even more dangerous.\n\nflashrom-stable:\nThe actual issue here was that a static-analyzer didn\u0027t realize that\nthe second loop would only run, if ever, with `j \u003e\u003d 12`. So we made\nthat explicit.\n\nChange-Id: I5921cc571f3dca5188ca1973dba6ececbcbe2f39\nSigned-off-by: Aarya Chaumal \u003caarya.chaumal@gmail.com\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/62764\nOriginal-Reviewed-by: Anastasia Klimchuk \u003caklm@chromium.org\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71451\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "c9c7d52a98558075b0e52d8ace559e0e5b0923e4", "tree": "70e51db3189f4c7c48e4013ff2466048e8f816cb", "parents": [ "d12b6bcbb667c6c852b7d0b521bc0f2f3963f856" ], "author": { "name": "aarya", "email": "aarya.chaumal@gmail.com", "time": "Sun Mar 13 00:05:56 2022 +0530" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:35:01 2023 +0000" }, "message": "board_enable.c: Remove unnecessary assignment\n\nIn function board_asus_p3b_f there were two consecutive lines which\nmodified the value of variable b\n\n // Do something with b\n\n b\u003dINB(0x80);\n b\u003dINB(smbba);\n\n //Do something with b\n\nSince the value of b is not used after first assignment, remove the\nfirst assignment.\n\nChange-Id: I7458b416a69fd5e2aa300ca49d1352b6074ad0bc\nOriginal-Tested-by: Keith Hui \u003cbuurin@gmail.com\u003e\nSigned-off-by: Aarya Chaumal \u003caarya.chaumal@gmail.com\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/62761\nOriginal-Reviewed-by: Anastasia Klimchuk \u003caklm@chromium.org\u003e\nOriginal-Reviewed-by: Keith Hui \u003cbuurin@gmail.com\u003e\nOriginal-Reviewed-by: Felix Singer \u003cfelixsinger@posteo.net\u003e\nOriginal-Reviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71450\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "d12b6bcbb667c6c852b7d0b521bc0f2f3963f856", "tree": "a337cfd6d9e665484409922ec4f9a82a7a292676", "parents": [ "251e3cd04c311812cb81d8d96c95a392653e38c8" ], "author": { "name": "Daniel Campello", "email": "campello@chromium.org", "time": "Mon Mar 14 11:43:16 2022 -0600" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:35:01 2023 +0000" }, "message": "flashrom.8.tmpl: Clarify man entries for -w/-v/-x\n\nThis change adds follow up changes to the man page:\n - Explain (-) argument for -w/-v operations\n - Expand on region name handling of -x operation\n\nAlso updates cli_classic.c to match with --help output.\n\nflashrom-stable:\n* Fixed -v description (reads from stdin)\n* s/ B/.B/\n\nChange-Id: I0cba593da3926c8587027789f4e1e89a2329ca7f\nSigned-off-by: Daniel Campello \u003ccampello@chromium.org\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/62794\nOriginal-Reviewed-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71556\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "251e3cd04c311812cb81d8d96c95a392653e38c8", "tree": "82811c929de9540f849faaafa474e4805bebd40d", "parents": [ "29c23dd08474b2457ffd8a72ee3d8587676cd999" ], "author": { "name": "Daniel Campello", "email": "campello@chromium.org", "time": "Wed Mar 16 07:05:48 2022 -0600" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:35:01 2023 +0000" }, "message": "helpers.c: use unsigned int for bit shifts (ASAN)\n\nThis change addresses the following ASAN error detected in the chromium\ntree:\n\n * ASAN error detected:\n * ../flashrom-9999/helpers.c:28:13: runtime error: left shift of 1 by 31 places cannot be represented in type \u0027int\u0027\n * #0 0x5589a94bb284 in address_to_bits /build/amd64-generic/tmp/portage/sys-apps/flashrom-9999/work/flashrom-9999-build/../flashrom-9999/helpers.c:28:13\n *\n * SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior ../flashrom-9999/helpers.c:28:13 in\n\nTested: ./test_build.sh; FEATURES\u003dtest emerge-amd64-generic flashrom\n\nSigned-off-by: Daniel Campello \u003ccampello@chromium.org\u003e\nChange-Id: Ib595f13c29dd5c0775e074801756e4f920b4daaf\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/62862\nOriginal-Reviewed-by: Anastasia Klimchuk \u003caklm@chromium.org\u003e\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nOriginal-Reviewed-by: Paul Menzel \u003cpaulepanter@mailbox.org\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71449\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "29c23dd08474b2457ffd8a72ee3d8587676cd999", "tree": "73ccbc237df969f57ad5c9f7e044e0d4b9ca2656", "parents": [ "8efb0b337a46aaa5f2da902aa862d30e6a1305be" ], "author": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Wed Dec 21 15:25:09 2022 +0000" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:35:01 2023 +0000" }, "message": "Add Alder Lake support\n\nLoosely based on commit 11680db4 (ichspi: Add Alder Lake support)\non flashrom master.\n\nBeside a little change in descriptor detection, no difference to\nTiger Lake was found. Hence, add new PCI IDs as 500 series.\n\nChange-Id: Icc1278755ff64f03128d8faadbca85a4ff76864d\nSigned-off-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71448\nReviewed-by: Matt DeVillier \u003cmatt.devillier@gmail.com\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "8efb0b337a46aaa5f2da902aa862d30e6a1305be", "tree": "66158792850ac6baa99ae42cfc0ac628d8c880dd", "parents": [ "6fb2f6224e03c4a0688b883a01defdd0a59bb46b" ], "author": { "name": "Charles Parent", "email": "charles.parent@orolia2s.com", "time": "Mon Feb 28 14:55:58 2022 +0100" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "ft2232_spi.c: Add FTDI FT4233H\n\nChange tested to probe, read, write and erase a MT25QU256 through a\nFT4233H FTDI\n\nChange-Id: I73cee8fd2a6613a8fbc26508d99bbe67da2b4f72\nSigned-off-by: Charles Parent \u003ccharles.parent@orolia2s.com\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/62480\nOriginal-Reviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71447\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "6fb2f6224e03c4a0688b883a01defdd0a59bb46b", "tree": "6b67bcdf46f6ddfad4d9785991743cc7c962fd57", "parents": [ "8f0db7d4945d0e7c4d538337ce0dbf47c5356945" ], "author": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Feb 24 18:17:40 2022 +0100" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "libflashrom: Allow NULL-pointer argument in flashrom_flash_release()\n\nfree() allows NULL and it makes error paths easier to handle when one\njust needs to write `free(x);` without needing to care if `x` was\nallocated already. Let\u0027s follow this rule in flashrom_flash_release().\n\nChange-Id: Id119c2e4f3aa1b11313059f11aac73c3e583185c\nSigned-off-by: Nico Huber \u003cnico.h@gmx.de\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/62340\nOriginal-Reviewed-by: Nikolai Artemiev \u003cnartemiev@google.com\u003e\nOriginal-Reviewed-by: Felix Singer \u003cfelixsinger@posteo.net\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71446\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "8f0db7d4945d0e7c4d538337ce0dbf47c5356945", "tree": "bd7af29d6e036f189ee3f9a3a7033adc5da39dc9", "parents": [ "d3e8fd9dd50f45028d9cd987c649229c78b0e5e1" ], "author": { "name": "Julius Werner", "email": "jwerner@chromium.org", "time": "Mon Feb 14 17:07:39 2022 -0800" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "libflashrom/fmap: Don\u0027t use off_t for flash offsets\n\noff_t is a special POSIX type that is used to represent file offsets in\ncertain APIs (e.g. lseek(), mmap()), and should not be reused to\nrepresent anything else (such as flash offsets). In particular, the\nwidth of the type may change based on the definition of the\n_FILE_OFFSET_BITS macro. Using such a type at the libflashrom interface\nis particularly dangerous, because if a program is built with a\ndifferent _FILE_OFFSET_BITS value than libflashrom, the resulting ABI\ncorruption will cause very very nasty and confusing bugs. This patch\nreplaces all instances of off_t that are not related to file offsets\nwith (s)size_t.\n\nTested: `elogtool list` on cherry.\n\nSigned-off-by: Julius Werner \u003cjwerner@chromium.org\u003e\nChange-Id: I68a386973f79ea634f63dfcd7d95a63400e1fdee\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/61943\nOriginal-Reviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nOriginal-Reviewed-by: Nikolai Artemiev \u003cnartemiev@google.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71445\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "d3e8fd9dd50f45028d9cd987c649229c78b0e5e1", "tree": "bc2932802bae29104495956ca3c9a4d3c4d64246", "parents": [ "e57d4e49fd2556f0fe267833d35cc57b7e252c06" ], "author": { "name": "Werner Zeh", "email": "werner.zeh@siemens.com", "time": "Tue Jan 25 07:02:49 2022 +0100" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "ich_descriptors.c Invert the meaning of \u0027dual_output\u0027 bit\n\nIn the Flash Component description register (FLCOMP) bit 30 reports the\ncapability of using dual output for fast read operation on the flash\ncomponent. According to various SPI Programming Guides (checked for\nPanther Point, Lewisburg C620, Apollo Lake and Elkhart Lake) the dual\noutput is enabled when this bit is set and disabled if not. Currently the\nlogic displays it the other way around when parsing the descriptor.\n\nThis patch changes this so now if bit 30 in FLCOMP is not set, dual read\nsupport for fast read operation is shown as disabled.\n\nChange-Id: If6282ac8326ab0b92e9c70c09dba0299bf0deb6f\nSigned-off-by: Werner Zeh \u003cwerner.zeh@siemens.com\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/61362\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71444\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "e57d4e49fd2556f0fe267833d35cc57b7e252c06", "tree": "ef260430367f0d2025fd6c5c12c101f37639613e", "parents": [ "672bdcfd4ffeb065b7056042769e3cc512d87c06" ], "author": { "name": "Werner Zeh", "email": "werner.zeh@siemens.com", "time": "Mon Jan 03 09:44:29 2022 +0100" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "Add Elkhart Lake support\n\nElkhart Lake has a chipset called Mule Creek Canyon which is quite\ncompatible with 300 series chipsets. There are a few differences though,\ne.g. different encoding for the SPI clock values for read and write in\nthe FLCOMP register. In addition Elkhart Lake has a new PCI device ID\nfor the SPI controller which is added, too.\n\nTested: Read and flash complete flash on Siemens MC EHL1\n\nChange-Id: I711e39a3ec9cd7098389231eaa1cb864d615a475\nSigned-off-by: Werner Zeh \u003cwerner.zeh@siemens.com\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/60711\nOriginal-Reviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71443\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "672bdcfd4ffeb065b7056042769e3cc512d87c06", "tree": "70ad68d799865d833ceab9dbca9259488be8be06", "parents": [ "4f9cd8bf947580bc87d947956aff9e28766405ce" ], "author": { "name": "Edward O\u0027Callaghan", "email": "quasisec@google.com", "time": "Wed Feb 02 17:15:05 2022 +1100" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "fmap.c: Avoid undefined behaviour with fmap_lsearch([len:\u003d0])\n\nCalling libflashrom entry-points that internally dispatch to\nfmap_lsearch() can result in a integer overflow. Therefore\nvalidate the length paramter before attempting to use it.\n\nTested: `make`\n\nChange-Id: Ifb408c55c3b69ddff453dcc704b7389298050473\nSigned-off-by: Edward O\u0027Callaghan \u003cquasisec@google.com\u003e\nSpotted-by: Julius Werner \u003cjwerner@chromium.org\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/61545\nOriginal-Reviewed-by: Julius Werner \u003cjwerner@chromium.org\u003e\nOriginal-Reviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71442\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "4f9cd8bf947580bc87d947956aff9e28766405ce", "tree": "bdd63b1889c1df94ae072904b18eb21d4d300b3f", "parents": [ "fafc3d8048d9e26b708323805868d127eeecc12e" ], "author": { "name": "Rick Altherr", "email": "rick@oxidecomputer.com", "time": "Mon Dec 13 17:10:00 2021 -0800" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "dediprog: wait for spi bulk read xfers to finish\n\ndediprog_bulk_read_poll()\u0027s finish argument allows it to be used in two\ndistinct cases: where dediprog_bulk_read_poll will be called as part of\na loop (finish\u003d0) and where dediprog_bulk_read_poll should wait for all\noutstanding transfers to finish (finish\u003d1). In both cases,\ndediprog_bulk_read_poll() calls libusb to process events with a 10\nsecond timeout.\n\nAfter dediprog_spi_bulk_read() has queued the last transfers, it calls\ndediprog_bulk_read_poll() with finish\u003d0 when it should be finish\u003d1.\nfinish\u003d0 just happens to work because frequently the transfers finish in\nthe 10 second timeout.\n\nSigned-off-by: Rick Altherr \u003crick@oxidecomputer.com\u003e\nChange-Id: If7cb541742c8620358c8e04275d8316131b2d1ab\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/60087\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71441\nReviewed-by: Rick Altherr \u003ckc8apf@kc8apf.net\u003e\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "fafc3d8048d9e26b708323805868d127eeecc12e", "tree": "dfe8d02595cde3456708d263a01033ba9754efac", "parents": [ "6ae640b1f33464969d401e00b44b3b5157f1ce09" ], "author": { "name": "Tim Crawford", "email": "tcrawford@system76.com", "time": "Wed Nov 17 06:23:25 2021 -0700" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "chipset_enable.c: Add TGP-H IDs\n\nAdd IDs for: H510, B560, H570, Q570, Z590, W580, HM570, QM570, WM590\n\nTested on system76/oryp8 (HM570). flashrom is able to read the image\nusing the internal programmer.\n\nChange-Id: I96f63253d42578151f99dcbb42347afecc03f49d\nSigned-off-by: Tim Crawford \u003ctcrawford@system76.com\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/57533\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-by: Benjamin Doron \u003cbenjamin.doron00@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71440\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "6ae640b1f33464969d401e00b44b3b5157f1ce09", "tree": "d8a5dd7c6fde8db17b2e14fb73577ef5f3c22adc", "parents": [ "69c324a7d4015c3ca4ba8d39a1c42670369f5afb" ], "author": { "name": "Edward O\u0027Callaghan", "email": "quasisec@google.com", "time": "Wed Nov 17 14:24:04 2021 +1100" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "flashrom.c: Validate before allocate in verify_range()\n\nSimplify a goto away for free\u0027ing a buffer by validating\nbefore attempting to allocate.\n\nChange-Id: Iae886f203d1c59ae9a89421f7483a4ec3f747256\nSigned-off-by: Edward O\u0027Callaghan \u003cquasisec@google.com\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/59372\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-by: Anastasia Klimchuk \u003caklm@chromium.org\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71439\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "69c324a7d4015c3ca4ba8d39a1c42670369f5afb", "tree": "c24c0bbe9512d67ed1daa9f919beeea00672441e", "parents": [ "5c9f542bf8ce514c628c59e42e35fbcb615d8937" ], "author": { "name": "melvyn2", "email": "melvyn2@brcok.tk", "time": "Sat Oct 30 16:02:22 2021 -0700" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "chipset_enable.c: Mark Intel Z390 as DEP\n\nTested read/write on GIGABYTE Z390 AORUS MASTER, incl. ME region with\nme_cleaner.\n\nChange-Id: If14d45c144bb32a1d1046185d4476ea29e4d0912\nSigned-off-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nSigned-off-by: melvyn2 \u003cmelvyn2@brcok.tk\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/58774\nOriginal-Reviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71438\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "5c9f542bf8ce514c628c59e42e35fbcb615d8937", "tree": "bcc2215bccd5a34f07460ff0f680aa7fba224744", "parents": [ "cce1e5b8636ebef59dd509680594e17b0a207857" ], "author": { "name": "Michał Żygowski", "email": "michal.zygowski@3mdeb.com", "time": "Wed Jun 16 15:13:54 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "Add Tiger Lake U Premium support\n\nTiger Lake has very low ICCRIBA (TGL\u003d0x11, CNL\u003d0x34 and CML\u003d0x34) and\ndetects as unknown chipset compatible with 300 series chipset. Add a\nnew enum CHIPSET_500_SERIES_TIGER_POINT and treat it identically to\nCHIPSET_400_SERIES_COMET_POINT. There are some exceptions though,\nICCRIBA is no longer present n descriptor content so a new union has\nbeen defined for new fields and used in descriptor guessing.\nfreq_read field is not present on Tiger Lake, moreover in CannonPoint\nand Comet Point this field is used as eSPI/EC frequency, so a new\nfunction to print read frequency has ben added. Finally Tiger lake\nboot straps include eSPI, so a new bus has been added for the new\nstraps.\n\nTested: Flash BIOS region on Intel i5-1135G7\n\nSigned-off-by: Michał Żygowski \u003cmichal.zygowski@3mdeb.com\u003e\nChange-Id: I28f3b6fe9f8ce9e976a6808683f46b6f4ec72bdd\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/55578\nOriginal-Reviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71437\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "cce1e5b8636ebef59dd509680594e17b0a207857", "tree": "5f50e5444c3d46b785af7e086ff60159bdf72250", "parents": [ "fa959bacf06a1db31cc82b5d601cc208faf11859" ], "author": { "name": "Thomas Heijligen", "email": "thomas.heijligen@secunet.com", "time": "Tue Nov 02 20:33:35 2021 +0100" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "hwaccess.c: move function declarations from programmer.h to hwaccess.h\n\nMove declarations for functions implemented in hwaccess.c from\nprogrammer.h to hwaccess.h.\n\nChange-Id: I075fd86211c766ae3d5f29c76adbd7c5b9bdbd80\nSigned-off-by: Thomas Heijligen \u003cthomas.heijligen@secunet.com\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/58865\nOriginal-Reviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71436\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "fa959bacf06a1db31cc82b5d601cc208faf11859", "tree": "ceec0521602a491188ae7df029b62691c7060b58", "parents": [ "bb37973298b95a28d36fa83017148cbe28971a94" ], "author": { "name": "Simon Buhrow", "email": "simon.buhrow@sieb-meyer.de", "time": "Fri Oct 29 08:28:51 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "flashrom.c: Delete obsolete comment\n\nChange-Id: Ibd53fe34c05f87d7ecc0d6eee6463f9da3a174d4\nSigned-off-by: Simon Buhrow \u003csimon.buhrow@posteo.de\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/58742\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71435\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "bb37973298b95a28d36fa83017148cbe28971a94", "tree": "aaba12f6600f5fb215f69985c096cc6d662b7335", "parents": [ "100be2cd19fe0024df82e64b52e24d3fd087720c" ], "author": { "name": "Thomas Heijligen", "email": "thomas.heijligen@secunet.com", "time": "Thu Oct 21 10:41:00 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "Makefile: remove NEED_LIBUSB1 from FEATURE_CFLAGS\n\nNEED_LIBUSB1 is not used outside of the Makefile. No need to pass it to\nthe compiler.\n\nChange-Id: Ie7cb3df39daf22cb954186d38ba32812b05d92f9\nSigned-off-by: Thomas Heijligen \u003cthomas.heijligen@secunet.com\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/58518\nOriginal-Reviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71434\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "100be2cd19fe0024df82e64b52e24d3fd087720c", "tree": "32d00dba126e46499c46c4316eb233bbfc95589b", "parents": [ "dd547c7de5402af4ecf0b1513a9302b95711c0eb" ], "author": { "name": "Felix Singer", "email": "felix.singer@secunet.com", "time": "Wed Oct 13 13:40:07 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "serprog: Move content of programmer specific header to C file\n\nMove the programmer specific code into serprog.c and remove its related\nheader file.\n\nChange-Id: I5c65f43db200129489d487ff948daa08bd0e92fa\nSigned-off-by: Felix Singer \u003cfelix.singer@secunet.com\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/58300\nOriginal-Reviewed-by: Thomas Heijligen \u003csrc@posteo.de\u003e\nOriginal-Reviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71433\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "dd547c7de5402af4ecf0b1513a9302b95711c0eb", "tree": "f9eb84bb9c8d273966c700b46f555e523ed6f694", "parents": [ "ece63c829acde03ed66ee00824d8b371af542333" ], "author": { "name": "Felix Singer", "email": "felix.singer@secunet.com", "time": "Wed Oct 13 13:56:38 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "gfxnvidia: Fix indents\n\nChange-Id: I18f916923d3574dd8c68019e4db3985444dd7bee\nSigned-off-by: Felix Singer \u003cfelix.singer@secunet.com\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/58301\nOriginal-Reviewed-by: Thomas Heijligen \u003csrc@posteo.de\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71432\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "ece63c829acde03ed66ee00824d8b371af542333", "tree": "5a944aff6b54520105fd6c72892743ad3968c842", "parents": [ "1da06355905f403a0206ca817ece534155b3c3c4" ], "author": { "name": "Michael Niewöhner", "email": "foss@mniewoehner.de", "time": "Tue Sep 21 20:15:32 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "ft2232_spi: reintroduce generic GPIOL control\n\nThis reintroduces a reworked version of the GPIOL pin control first\nintroduced in commit 3207844 (CB:49637), which was reverted in commit\n6518cf3 (CB:55692) due to breakage.\n\nThis change introduces a new argument `gpiolX` to allow use of the four\nGPIOL pins either as generic gpios or as additional CS# signal(s). `X`\nspecifies the GPIOL pin (0-3) to be set to one of [HLC] with the\nfollowing meaning:\n\n * H - set the pin as output high\n * L - set the pin as output low\n * C - use the pin as additional CS# signal\n\nThe third value, `C`, aims to replace the parameter `csgpiol`, that is\nnow marked as deprecated and can be removed at some point in the future.\n`gpiol` and `csgpiol` are mutually exclusive and use of both results in\nan error.\n\nMultiple pins may be set by specifying the parameter multiple times.\n\nDocumentation was updated/added accordingly.\n\nTest: All pin levels/modes have been verified to behave correctly with a\n logic analyzer.\n\nChange-Id: I3989f0f9596c090de52dca67183b1363dae59d3a\nSigned-off-by: Alan Green \u003cavg@google.com\u003e\nSigned-off-by: Michael Niewöhner \u003cfoss@mniewoehner.de\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/57810\nOriginal-Reviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71431\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\n" }, { "commit": "1da06355905f403a0206ca817ece534155b3c3c4", "tree": "a9a268f6956d6117290faa0cfa5be9f15b5d71b0", "parents": [ "b50d9eb29c61993cae7c55e39d14c42406263328" ], "author": { "name": "Michael Niewöhner", "email": "foss@mniewoehner.de", "time": "Thu Sep 23 21:25:03 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "flashrom.8: carve out `csgpiol` into its own section\n\nDocumentation for `csgpiol` was put into the generic programmer options\nsection. Move it to its own section.\n\nChange-Id: Ic7379331d36b3068eacde5a983b4ccb3afc56c51\nSigned-off-by: Michael Niewöhner \u003cfoss@mniewoehner.de\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/57893\nOriginal-Reviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71430\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "b50d9eb29c61993cae7c55e39d14c42406263328", "tree": "0f504b5eab82e2932a98cb2f2ac0018f7a3257b1", "parents": [ "f0c03fb87d75a3be3a10dcd6abfc24a193dd2f93" ], "author": { "name": "Michael Niewöhner", "email": "foss@mniewoehner.de", "time": "Tue Sep 21 19:43:04 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "ft2232_spi: prevent use of reserved pins on some programmers\n\nOn some programmers an output buffer needs to be enabled by pulling a\ngpio high/low. This gpio can not be used for `csgpiol`. Prevent this by\nprinting an error.\n\nChange-Id: Ied450fa5ef358153adefec3beabc63a62c9f60cd\nSigned-off-by: Michael Niewöhner \u003cfoss@mniewoehner.de\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/57809\nOriginal-Reviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71429\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "f0c03fb87d75a3be3a10dcd6abfc24a193dd2f93", "tree": "7a49430da020ee693a00653c0c0e052175185a0c", "parents": [ "116d56d2265cbe97bd5b97f008c0c6ef3cadce63" ], "author": { "name": "Angel Pons", "email": "th3fanbus@gmail.com", "time": "Mon Jun 21 13:01:45 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "nicintel_spi.c: Implement `set_sck_set_mosi` and `set_sck_get_miso`\n\nTested on a 8086:1533 (i210 GbE), reads still return the same data.\nThis cuts the time to read a Winbond W25Q80.V (1 MiB, SPI) from 66\nseconds down to 48 seconds, i.e. a 37.5% increase in speed.\n\nflashrom-stable: backported to use globals\n\nChange-Id: I52a0ae5ff331ee2ed41652eb5c2ed7ebe7253d74\nSigned-off-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/49267\nOriginal-Reviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71428\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "116d56d2265cbe97bd5b97f008c0c6ef3cadce63", "tree": "bd88f18ce3bb89f4f2da3a0e43d55fbf45ad7f6c", "parents": [ "4b918a132c00c8a7075cab9a21e74f90e37ff489" ], "author": { "name": "Angel Pons", "email": "th3fanbus@gmail.com", "time": "Mon Mar 22 11:28:00 2021 +0100" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "dediprog.c: Split up compound conditional and swap two operations\n\nregister_spi_master now becomes the last operation in init function,\nwhich is consistent with other spi masters.\n\nIn addition, the patch fixes propagation of register_spi_master return\nvalues, which is also consistent with other spi masters.\n\nTested: ninja test\n\nChange-Id: Ib7e0179da39279e32a8497466b044b69ec836da8\nSigned-off-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nSigned-off-by: Anastasia Klimchuk \u003caklm@chromium.org\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/51706\nOriginal-Reviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71427\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "4b918a132c00c8a7075cab9a21e74f90e37ff489", "tree": "f556fb1d401cbf199b573bfd1755300008922c2f", "parents": [ "140c1261b202aa0e1bf7fff55d6e96cf6bf44d0a" ], "author": { "name": "Thomas Heijligen", "email": "thomas.heijligen@secunet.de", "time": "Sun Sep 26 13:42:39 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "internal.c: unify the macro for x86 only code\n\nThe #if defined(__i386__) || defined(__x86_64__) guard is commonly used\nfor x86 only code across flashrom.\nOnly platform.h and hwaccess.* use the IS_X86 macro.\n\nChange-Id: I94a599431f58666189c8cd601286e9b30c8bf62b\nSigned-off-by: Thomas Heijligen \u003cthomas.heijligen@secunet.de\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/57942\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-by: Felix Singer \u003cfelixsinger@posteo.net\u003e\nOriginal-Reviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71426\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "140c1261b202aa0e1bf7fff55d6e96cf6bf44d0a", "tree": "510192d64f21244426e821c146ee369a8e68c5a3", "parents": [ "c2b303bba8bbb99bda6fee0383def382bb4db24d" ], "author": { "name": "Thomas Heijligen", "email": "thomas.heijligen@secunet.de", "time": "Mon Sep 27 15:12:26 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "custom_baud: move Linux specific code into own file\n\nHandle system specific code in an own file like i2c_helper_linux.c.\nThe build system decides when to build it.\n\nChange-Id: I0744e769dcc6000483e7256105903a87e927ee77\nSigned-off-by: Thomas Heijligen \u003cthomas.heijligen@secunet.de\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/57990\nOriginal-Reviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71425\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "c2b303bba8bbb99bda6fee0383def382bb4db24d", "tree": "16ca0b80f727be7feb6d41ee12d52f98dc307985", "parents": [ "7d973885e5c323ac64d5414f88289efdd4221753" ], "author": { "name": "Michael Niewöhner", "email": "foss@mniewoehner.de", "time": "Tue Sep 21 18:03:29 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "ft2232_spi: clarify the comment about gpio configuration\n\nThe comment explaining gpio levels might be easily misunderstood when\nthe reader misses the word `output`. Add an explicit description of\nhandling of the GPIOL* pins to avoid that and make things even more\nclear.\n\nChange-Id: Iaceec889a65ead8cdde917f61b2a9695d440f781\nSigned-off-by: Michael Niewöhner \u003cfoss@mniewoehner.de\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/57808\nOriginal-Reviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71424\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "7d973885e5c323ac64d5414f88289efdd4221753", "tree": "0a505688f6931ea8605b8fdf7f821c6c0b845716", "parents": [ "b31f7ac1a04c9c90256723531aa36001d5399a0a" ], "author": { "name": "Anastasia Klimchuk", "email": "aklm@chromium.org", "time": "Wed Jul 14 09:33:50 2021 +1000" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "dediprog.c: Drop dediprog_ prefix for spi data struct members\n\nThe name of the struct type already contains dp_ prefix, so\nprefix doesn\u0027t need to be repeated in members name.\n\nTested: builds and ninja test\n\nChange-Id: I688d50926b78a6c3f1c5a8ba4ef88a0d5b495bd0\nSigned-off-by: Anastasia Klimchuk \u003caklm@chromium.org\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/56415\nOriginal-Reviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71423\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "b31f7ac1a04c9c90256723531aa36001d5399a0a", "tree": "8010942dbcc00249755853d5cf4be5071df4d5f1", "parents": [ "eec477f1a6f4ba718e713438532c81d9a9b7db72" ], "author": { "name": "Anastasia Klimchuk", "email": "aklm@chromium.org", "time": "Mon Jul 12 14:18:37 2021 +1000" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "dediprog.c: Refactor singleton states into reentrant pattern\n\nMove global singleton states into a struct and store within\nthe spi_master data field for the life-time of the driver.\n\nThis is one of the steps on the way to move spi_master data\nmemory management behind the initialisation API, for more\ncontext see other patches under the same topic \"register_master_api\".\n\nTested: builds and ninja test\n\nflashrom-stable: backported to old master API\n\nChange-Id: I72085e750af97b94dfa94f2ebf2a134e41a2ec8d\nSigned-off-by: Anastasia Klimchuk \u003caklm@chromium.org\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/56414\nOriginal-Reviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71422\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "eec477f1a6f4ba718e713438532c81d9a9b7db72", "tree": "ee51926458b3f9fcc18fc81a74f6fc3be2fc90a5", "parents": [ "a4e63e7957c5eb41d9e0dc237949102795494f31" ], "author": { "name": "Sophie van Soest", "email": "sophie@entropie.rocks", "time": "Sun Jul 04 13:54:26 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "chipset_enable.c: Mark Z97 as DEP\n\nTested on GIGABYTE GA-Z97-HD3.\n\nSigned-off-by: Sophie van Soest \u003csophie@entropie.rocks\u003e\nChange-Id: I73bdd9afefae8e7c013d400e17a15e56d84322f4\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/56060\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-by: Michael Niewöhner \u003cfoss@mniewoehner.de\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71421\nReviewed-by: Michael Niewöhner \u003cfoss@mniewoehner.de\u003e\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "a4e63e7957c5eb41d9e0dc237949102795494f31", "tree": "92d1708f56f2a4c8faeff9729f4d6dee08a1bc63", "parents": [ "3bf7cfba9fca9b18d4ad5b843399bc00a3be1f49" ], "author": { "name": "Miklós Márton", "email": "martonmiklosqdev@gmail.com", "time": "Tue Aug 17 22:53:40 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "ni845x_spi: add missing const specifier to the spi_transmit function\n\nChange-Id: I2c14361283b2da3725d9ba2cae0e1007e6be3d66\nSigned-off-by: Miklós Márton \u003cmartonmiklosqdev@gmail.com\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/57003\nOriginal-Reviewed-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-by: Anastasia Klimchuk \u003caklm@chromium.org\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71420\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\n" }, { "commit": "3bf7cfba9fca9b18d4ad5b843399bc00a3be1f49", "tree": "cc4c65492591a94835ad9a0c9617084ec8ab006e", "parents": [ "66565a7953b27a55cd963bb4f608c08f7d5237f0" ], "author": { "name": "Jonathan Zhang", "email": "jonzhang@fb.com", "time": "Mon Aug 30 23:25:06 2021 -0700" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "Add support for Intel Emmitsburg PCH\n\nThis patch does the following:\n- Add PCIe ID for Intel Emmitsburg PCH\n- Based on ICH descriptor content, choose CHIPSET_C620_SERIES_LEWISBURG\n if ISL/PSL is 80.\n\nTested: tried on a server with Intel Emmitsburg PCH, flash update\nwas successful. This server, however, does not have flash chip\ninstalled, it instead has em100 emulator connected.\n\nChange-Id: I2a1bb7467e693d1583aa885fa0e277075edd4a3e\nSigned-off-by: Jonathan Zhang \u003cjonzhang@fb.com\u003e\nSigned-off-by: David Hendricks \u003cddaveh@amazon.com\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/54965\nOriginal-Reviewed-by: Christian Walter \u003cchristian.walter@9elements.com\u003e\nOriginal-Reviewed-by: Johnny Lin \u003cJohnny_Lin@wiwynn.com\u003e\nOriginal-Reviewed-by: Tim Chu \u003cTim.Chu@quantatw.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71419\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\n" }, { "commit": "66565a7953b27a55cd963bb4f608c08f7d5237f0", "tree": "69f52540e49bbb94456a1961a308b3ab133c78f9", "parents": [ "fea5aa13d2845835f798c4709ee074433568d714" ], "author": { "name": "David Hendricks", "email": "ddaveh@amazon.com", "time": "Mon Sep 20 21:56:40 2021 -0700" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "ich_descriptors: Add explicit checks for all chipsets\n\nThis partially undoes changes made in commit cd9b7b427\n(ich_descriptors: Normalize chipset detection) to re-add explicit\nmatching of each chipset with one or more strap length values.\n\nSince ranges are checked explicitly, the `warn_if` parameter to\nwarn_peculiar_desc() is no longer necessary and is removed.\n\nChange-Id: Ica49477492876810a6fa212768b1ab9e8c12001f\nSigned-off-by: David Hendricks \u003cddaveh@amazon.com\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/57793\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71418\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "fea5aa13d2845835f798c4709ee074433568d714", "tree": "d442defee69eb841cb08ef8e0572473d80c4c15e", "parents": [ "27fdfd751ee0d4ed919a23d934b9271568377fa6" ], "author": { "name": "Miklós Márton", "email": "martonmiklosqdev@gmail.com", "time": "Tue Jul 27 14:29:16 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "ni845x_spi: handle PROGRAMFILES(X86) env var properly\n\nThe PROGRAMFILES(X86) envvar contains brackets which\ncould not be interpreted by the Makefile\u0027s interpreter.\nA sed based tweak have been added to extract the variable\nvalue from the env command output. The prefixed include\nand linker path with this (now correctly extracted) prefix\nonly added to the compilation flags if it differ from the\nPROGRAMFILES variable.\n\nChange-Id: I397619a5038567d649a417ce6b9d8ac9e1c8c67b\nSigned-off-by: Miklós Márton \u003cmartonmiklosqdev@gmail.com\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/56636\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71417\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "27fdfd751ee0d4ed919a23d934b9271568377fa6", "tree": "fe26d2ce85d796031e89178efc59cc7b2e59a4e1", "parents": [ "9fc8e258914a1e891fd4025a3d50edfa8153a141" ], "author": { "name": "Anastasia Klimchuk", "email": "aklm@chromium.org", "time": "Tue Aug 03 10:41:50 2021 +1000" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "nicintel_eeprom: Delete extra parentheses from if condition\n\nChange-Id: I068bd227668a79f14e38e703a5a49db18d5de8c7\nSigned-off-by: Anastasia Klimchuk \u003caklm@chromium.org\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/56820\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71416\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "9fc8e258914a1e891fd4025a3d50edfa8153a141", "tree": "9636cc3c6b8dd8408740e0c6f0beb7905a98bf4f", "parents": [ "d75e1b1fda75e3573140912cb0af246ccf86c8ee" ], "author": { "name": "Harry Johnson", "email": "johnsonh@waymo.com", "time": "Thu Jul 08 14:28:39 2021 -0700" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "ft2232_spi: Add FTDI search by description.\n\nThis adds to the search-by-serial functionality with\nsearch-by-description (product string). This is useful when e.g. one has\nmultiple FTDIs in a system and wants the serial numbers to reflect the\nsystem-level serial number, and the description to reflect the\nsubcomponent names.\n\nTested manually by running with both serial and description searches, on\na machine with multiple FTDIs plugged in. Ensured that when two devices\nwith the same vid/pid/serial number are plugged in, description can\nbe used to differentiate.\n\nVerifed no-description, no-serial, one FTDI plugged in base case works.\n\nOriginal version of this code used the original single \"arg\" char*, but\non further thought, this wasn\u0027t worth the readability and functionality\nlosses. The new version with arg2 gets rid of several lines of code, the\ngotos, and adds the ability to filter by both description and serial\nsimultaneously.\n\nChange-Id: Ib4be23247995710900175f5f16e38db577ef08fa\nSigned-off-by: Harry Johnson \u003cjohnsonh@waymo.com\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/56164\nOriginal-Reviewed-by: Anastasia Klimchuk \u003caklm@chromium.org\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71415\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "d75e1b1fda75e3573140912cb0af246ccf86c8ee", "tree": "0b20aa11090ab199fe70055e964f78aa5a0fe096", "parents": [ "f55ca20fcf7fcc8a8c95d034c7126217a117e88e" ], "author": { "name": "Edward O\u0027Callaghan", "email": "quasisec@google.com", "time": "Wed Jul 14 15:06:04 2021 +1000" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "flashrom.c: Make extract_param() static local\n\nThe function is only ever used within flashrom.c.\n\nChange-Id: I81f1cdb9df98c151201390edeb69c74defe7881f\nSigned-off-by: Edward O\u0027Callaghan \u003cquasisec@google.com\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/56295\nOriginal-Reviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nOriginal-Reviewed-by: Anastasia Klimchuk \u003caklm@chromium.org\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71414\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\n" }, { "commit": "f55ca20fcf7fcc8a8c95d034c7126217a117e88e", "tree": "4c2723b04c1b441112907430b76690beda41fb2c", "parents": [ "29c6834b22a39017725d5dacb69befb4b52fcc5f" ], "author": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Sun Jun 27 14:36:06 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "Makefile: Use dependency lists to generate NEED_\u003clibrary\u003e vars\n\nChange-Id: I30e6430a7e833a7f74eb973fb55bf1947ae2d87b\nSigned-off-by: Nico Huber \u003cnico.h@gmx.de\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/55881\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71413\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "29c6834b22a39017725d5dacb69befb4b52fcc5f", "tree": "1ec976b16d33c5002c205fce3571d845a41cb548", "parents": [ "a54f5a41e65c9ae26b067b7062bb0cbad56bcc93" ], "author": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Sun Jun 27 14:34:16 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "Makefile: Enable bitbang_spi based on its dependency list\n\nChange-Id: I2a22667cfe14e4c5816b3bce13de632941690d17\nSigned-off-by: Nico Huber \u003cnico.h@gmx.de\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/55880\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71412\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "a54f5a41e65c9ae26b067b7062bb0cbad56bcc93", "tree": "f293e04a563f32b8328a8426851c76912a1b2c8e", "parents": [ "8945b815f16be92615875c881cbfcaa80f72ccb5" ], "author": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Sun Jun 27 14:27:41 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "Makefile: Disable libusb/libpci programmers via dependency lists\n\nChange-Id: Ic2e56059a5cd7bd9f3d74d27866ded97e86d6ef1\nSigned-off-by: Nico Huber \u003cnico.h@gmx.de\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/55879\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71411\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "8945b815f16be92615875c881cbfcaa80f72ccb5", "tree": "69ae0d2e6875af66c59d5677b087a57e0ebcabcc", "parents": [ "dc8e54ad9d86d227bdeb8462e2154833ded38cce" ], "author": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Sun Jun 27 14:24:53 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "Makefile: Deflate per-architecture handling of unsupported programmers\n\nChange-Id: Ia54d9e7a2602af6e8725851d01758985b36c8461\nSigned-off-by: Nico Huber \u003cnico.h@gmx.de\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/55878\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71410\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "dc8e54ad9d86d227bdeb8462e2154833ded38cce", "tree": "92133471fd7940fb648eaa85bea8823686a90b8e", "parents": [ "713310385794e1f0d28d5879f736bde325426e1c" ], "author": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Sun Jun 27 14:17:34 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "Makefile: Deflate handling of Linux-only programmers\n\nAlso one case that doesn\u0027t work on Android.\n\nChange-Id: I17381172f8df213bbddccedec2ef288326e49ecf\nSigned-off-by: Nico Huber \u003cnico.h@gmx.de\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/55877\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71409\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "713310385794e1f0d28d5879f736bde325426e1c", "tree": "da7d5390a3e8fec6cec5dada6e56966b060c5232", "parents": [ "ca6217827f3ed1223db6b29dcc5b3088e3858a8e" ], "author": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Sun Jun 27 14:00:39 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "Makefile: Deflate handling of unsupported programmers for libpayload\n\nChange-Id: I78ab1e3217aa6362b4c3525763e15140aa4c204f\nSigned-off-by: Nico Huber \u003cnico.h@gmx.de\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/55876\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71408\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "ca6217827f3ed1223db6b29dcc5b3088e3858a8e", "tree": "1165991476d9c93f37f168dec8d80a33156935ff", "parents": [ "ba6819647e2b1367d073c10afe5c2d23f7af5b5d" ], "author": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Sun Jun 27 13:53:49 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "Makefile: Deflate handling of unsupported programmers for MinGW\n\nChange-Id: I20c17471f7b059e91b215fca833b767a003a9888\nSigned-off-by: Nico Huber \u003cnico.h@gmx.de\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/55875\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71407\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "ba6819647e2b1367d073c10afe5c2d23f7af5b5d", "tree": "a968cb8210ab0536ec4fb8317e736f68f8cab979", "parents": [ "afca7ac5a4c109bd008f3d6c9d989d334756802f" ], "author": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Sun Jun 27 13:39:23 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "Makefile: Deflate handling of unsupported programmers for DJGPP\n\nChange-Id: I86988aa7ef1d2d4189be3d25b9aea4e7ddaec9af\nSigned-off-by: Nico Huber \u003cnico.h@gmx.de\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/55874\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71406\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "afca7ac5a4c109bd008f3d6c9d989d334756802f", "tree": "7b26dff7600ae7077d0fe411e22cae13585b9bb4", "parents": [ "7f898975400404d7ea738a053fede5da128d2a84" ], "author": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Sun Jun 27 13:35:21 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "Makefile: Add macro to disable unsupported programmers\n\n`mark_unsupported` disables all programmers passed as arguments and\nadds them to the UNSUPPORTED_FEATURES list. It\u0027s conveniently used\nwith our dependency lists, e.g.\n\n $(call mark_unsupported,$(NEEDS_LIBUSB1) $(NEEDS_LIBFTDI))\n\nChange-Id: I6c9b66dfa89ec3d71675576d03fcebfdea30ce7b\nSigned-off-by: Nico Huber \u003cnico.h@gmx.de\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/55873\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71405\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "7f898975400404d7ea738a053fede5da128d2a84", "tree": "21822e2d478d394391a1704a50cecd867d128db5", "parents": [ "09e82e227554c9a6ff73386beeece0d9f851ac04" ], "author": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Sun Jun 27 13:30:50 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "Makefile: Gather lists of dependencies by feature/lib\n\nFor each feature or library that we treat as dependency, list which\nprogrammers depend on it.\n\nChange-Id: I6929181f18213e1434cbbc7ba2d2b0b04bd46a6a\nSigned-off-by: Nico Huber \u003cnico.h@gmx.de\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/55872\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71404\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "09e82e227554c9a6ff73386beeece0d9f851ac04", "tree": "7fd4a24965b992f26412a1698b2f05e2be671fc0", "parents": [ "83d52074fdbbe27ccf7b426dc9762a756f00fd77" ], "author": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Sun Jun 27 14:31:37 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "Makefile: Move $(NEED_LIBFTDI) block to similar ones\n\nChange-Id: I27eae3803a114f332a6f0713cf9bc90163030e1b\nSigned-off-by: Nico Huber \u003cnico.h@gmx.de\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/55871\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71403\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "83d52074fdbbe27ccf7b426dc9762a756f00fd77", "tree": "00f88445d915b5ee0a93f6c3ad06c6d27f7f1543", "parents": [ "81965f3c5acc663fab9efdaa0a48a814bcadad4e" ], "author": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Sun Jun 27 00:07:13 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "Makefile: Move NI845X_SPI default to the other defaults\n\nChange-Id: I0317eb1190eae366a142d9410bee4110edc06e3d\nSigned-off-by: Nico Huber \u003cnico.h@gmx.de\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/55870\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71402\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "81965f3c5acc663fab9efdaa0a48a814bcadad4e", "tree": "b4a30b0b936db08f7147b6c93f0f6840ae25bf79", "parents": [ "72a9dc0db4e6aa2a520f17015ecde93595286fbf" ], "author": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jun 17 23:25:35 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "ich_descriptors: Normalize chipset detection\n\nNormalize the fallback paths:\n* Always end with the newest, assumed compatible chipset.\n* Perform tighter checks when it\u0027s about warnings only.\n* If two chipsets seem compatible, always return the same\n (this is currently the case for 8/9 series and 300/400\n series which we can\u0027t distinguish).\n\nChange-Id: Ic5a5fee870202173b3a9813b03ec261e8ee45155\nSigned-off-by: Nico Huber \u003cnico.h@gmx.de\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/55651\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-by: Michał Żygowski \u003cmichal.zygowski@3mdeb.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71401\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "72a9dc0db4e6aa2a520f17015ecde93595286fbf", "tree": "b21529ac872a096419da8784630e4f73b22753f3", "parents": [ "3ad9aad483029c8b4c7c9f0b8dd362faf1c12ef3" ], "author": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jun 17 22:47:00 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "ich_descriptors: Don\u0027t base chipset detection on `freq_read`\n\nOnly warn if the `freq_read` setting looks odd but don\u0027t override\nour previous guess. The `freq_read` check was taken from `ifdtool`\nbut seems less reliable than our own detection scheme.\n\nChange-Id: I658d76ec2567d1d660a18d0b0ae71c744e603e8f\nSigned-off-by: Nico Huber \u003cnico.h@gmx.de\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/55650\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-by: Michał Żygowski \u003cmichal.zygowski@3mdeb.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71400\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "3ad9aad483029c8b4c7c9f0b8dd362faf1c12ef3", "tree": "74ad9724b0ab7db87fe06ba4323a16707107bf61", "parents": [ "66e04562f48cfb1f2266c316c81693ea73371a60" ], "author": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jun 17 22:05:00 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "ich_descriptors: Revise detection for chipsets w/ ICCRIBA\n\nDetection based on ICCRIBA and FMSBA became a little messy lately.\nHowever, there\u0027s a new static difference: Since 300 series (Cannon\nPoint), there is an MDTBA field in FLUMAP1 that has always been 0\n(reserved) before. Taking this into account, we can relax the checks\non ICCRIBA.\n\nChange-Id: I587ad1abe390843d4a9e74431b6fc4b63f8ba512\nSigned-off-by: Nico Huber \u003cnico.h@gmx.de\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/55647\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-by: Michał Żygowski \u003cmichal.zygowski@3mdeb.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71399\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "66e04562f48cfb1f2266c316c81693ea73371a60", "tree": "0c991211a974da842919497034e6a58f45131989", "parents": [ "ee6d548becb29d4fce00a6f7dbe0c39e1e7be160" ], "author": { "name": "Anastasia Klimchuk", "email": "aklm@chromium.org", "time": "Mon Jun 28 17:03:52 2021 +1000" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "dediprog: Separate shutdown from failed init cleanup\n\nShutdown function was covering two different jobs here: 1) the actual\nshutdown which is run at the end of the driver\u0027s lifecycle and\n2) cleanup in cases when initialisation failed. Now, shutdown is only\ndoing its main job (#1), and the driver itself is doing cleanup\nwhen init fails (#2).\n\nThe good thing is that now resources are released/closed immediately\nin cases when init fails (vs shutdown function which was run at some\npoint later), and the driver leaves clean space after itself if init\nfails.\n\nAnd very importantly this unlocks API change which plans to move\nregister_shutdown inside register master API, see\nhttps://review.coreboot.org/c/flashrom/+/51761\n\nChange-Id: I3273da907614a042d50090338c337dfd64695354\nSigned-off-by: Anastasia Klimchuk \u003caklm@chromium.org\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/55887\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71398\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "ee6d548becb29d4fce00a6f7dbe0c39e1e7be160", "tree": "940405142f24dcbcfd59f931a433fed297be48e7", "parents": [ "38450ce384c8e6e05f34a0bd0246fcb919259222" ], "author": { "name": "Anastasia Klimchuk", "email": "aklm@chromium.org", "time": "Thu Jun 24 16:25:43 2021 +1000" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "buspirate_spi: Use non-zero return value from buspirate_sendrecv\n\nReturn values for buspirate_sendrecv come from serialport_write\nand serialport_read, and those return 1s for any error. No need\nto explicity assign ret \u003d 1, because it is already 1 for error.\n\nFollow up on commit 751afa88a7f22487069665c5d206ae490f158231\nwhere this idea was suggested.\n\nChange-Id: I31fd70f607dc965d5cac1cd0116faa447dbc177a\nSigned-off-by: Anastasia Klimchuk \u003caklm@chromium.org\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/55818\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71397\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "38450ce384c8e6e05f34a0bd0246fcb919259222", "tree": "bd65541fb29514f558217ed719e769be977aeddf", "parents": [ "fda5f1f18d8e104cf9898f38a111f5d24dc9e31c" ], "author": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Sun Jun 16 20:07:28 2019 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "libflashrom: Free `chip` instance upon flashctx teardown\n\nChange-Id: I761d7e167a43e5bf08b5b3d269b0a476e3d343c5\nSigned-off-by: Nico Huber \u003cnico.h@gmx.de\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/33546\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-by: Anastasia Klimchuk \u003caklm@chromium.org\u003e\nOriginal-Reviewed-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71396\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "fda5f1f18d8e104cf9898f38a111f5d24dc9e31c", "tree": "139173f9b3d2266c08adad116859ccc5729a79d7", "parents": [ "4c40a794b2cbe43f7b4e6533f6301fd2053e056c" ], "author": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Sun Jun 20 16:46:31 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "ft2232_spi: Revise error message\n\nReword the message and drop the error string from libftdi. It is\nalready printed in send_buf().\n\nChange-Id: I125ae9ec0d5487fc26d588a7fd6c54da4ebd0d70\nSigned-off-by: Nico Huber \u003cnico.h@gmx.de\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/55697\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-by: Anastasia Klimchuk \u003caklm@chromium.org\u003e\nOriginal-Reviewed-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71395\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "4c40a794b2cbe43f7b4e6533f6301fd2053e056c", "tree": "0731a507e097a3efad890a6f97eff7af69c59558", "parents": [ "cf88068581f75029314e1068626ab63795b52dd2" ], "author": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Sun Jun 20 16:38:57 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "ft2232_spi: Normalize error paths in ft2232_shutdown()\n\nWe missed to `free(spi_data)` on one path. It also seems odd to leak\nthe return code of a locally used library into our common infrastruc-\nture, so normalize all error paths to return 1.\n\nChange-Id: I5158d06127a9a8934b083e48b69d29c4d5a11831\nSigned-off-by: Nico Huber \u003cnico.h@gmx.de\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/55696\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-by: Anastasia Klimchuk \u003caklm@chromium.org\u003e\nOriginal-Reviewed-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71394\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "cf88068581f75029314e1068626ab63795b52dd2", "tree": "181f0a32f0615cdce48b11f68181d8d777f6cb0c", "parents": [ "13b33bcf57f6dc3ea4edafc9dda34f3155d2dbbf" ], "author": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Sun Jun 20 15:59:57 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "ft2232_spi: Revise comments about output pin states\n\nThe meaning of the variables is easy to misunderstand as some\nstates are merely implicit: All output pins that are not set\nin the `cs_bits` mask will be constantly driven low. This may\nbe sheer coincidence as all programmers that need additional\npins driven use active-low signals to enable buffers.\n\nWhile other pins stay low, *all* pins set in the `cs_bits`\nmask are supposed to be toggled during SPI transactions.\n\nAlso drop some irritating dead code and try to explain things\nin a comment.\n\nChange-Id: I2b84ede01759c80f69d5ad17e43783d09ecd1107\nSigned-off-by: Nico Huber \u003cnico.h@gmx.de\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/55695\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71393\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "13b33bcf57f6dc3ea4edafc9dda34f3155d2dbbf", "tree": "c1ae50591e65a1084b34115b142bf3871e5e3093", "parents": [ "fc16212c44a72ee8b67525020ca2e68ffc162733" ], "author": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Sun Jun 20 13:20:33 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "ft2232_spi: Drop ft2232_spi_send_command()\n\nNow that ft2232_spi_send_multicommand() is implemented, we don\u0027t need\nthe single-command version anymore.\n\nChange-Id: I2e7fa1046e260f490b881a33e02ad73d16f0a30c\nSigned-off-by: Nico Huber \u003cnico.h@gmx.de\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/55684\nOriginal-Reviewed-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71392\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "fc16212c44a72ee8b67525020ca2e68ffc162733", "tree": "122f3ec3a34932b6485c84dfcaf4f5037dfb610e", "parents": [ "db9be31735c8d4e018fefc615c83e570f49dbb7a" ], "author": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Sun Jun 20 13:09:30 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "ft2232_spi: Don\u0027t lower write data chunksize\n\nThis \"chunk size\" limits the amount of data that is passed to libusb\nat once. If we had exceeded the chunk size, libftdi would have split\nthe data into individual, synchronous bulk transfers. But the chunk\nsize was actually chosen to avoid this. So without any known effect,\nsetting the chunk size is useless. Drop it.\n\nChange-Id: I779e24dc3f3379a98ddce02c3765062ac3241884\nSigned-off-by: Nico Huber \u003cnico.h@gmx.de\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/55683\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71391\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "db9be31735c8d4e018fefc615c83e570f49dbb7a", "tree": "1cb60f3310af75dcc24633626bfcde1e4091ab07", "parents": [ "98bdcb46de824e6671671ed83465cec3087f69ba" ], "author": { "name": "Simon Buhrow", "email": "simon.buhrow@sieb-meyer.de", "time": "Fri Apr 09 14:48:39 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "ft2232_spi.c: Implement spi_send_multicommand()\n\nEvery ftdi_write_data() call is quite time consuming as the ftdi-chips\nseems to take always 2-3ms to respond. This leads to what the comment\nalready says: Minimize USB transfers by packing as many commands as\npossible together. So I packed the WREN command together with the\nfollowing operation which can be program or erase operation.\n\nThis saves about 1 minute when programming a 128MBit Flash within a\nvirtualized setup.\n\nSigned-off-by: Simon Buhrow \u003csimon.buhrow@posteo.de\u003e\nChange-Id: Ie4a07499ec5ef0af23818593f45dc427285a9e8a\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/40477\nOriginal-Reviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71390\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "98bdcb46de824e6671671ed83465cec3087f69ba", "tree": "08c53170c94b115596d4ca58b0e839cdc9a03ff3", "parents": [ "7dcb6f33d0e97154b3533917fad3dea0dad676bc" ], "author": { "name": "Jeremy Kerr", "email": "jk@codeconstruct.com.au", "time": "Sun May 23 17:58:06 2021 +0800" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "buspirate: Add psus option\n\nThis change adds a \u0027psus\u003d\u003con|off\u003e\u0027 option, to control the external Vcc\nstate of the bus pirate, allowing hardware where the SPI flash chip is\npowered by the 3V3/5V lines directly.\n\nChange-Id: I8a7d4b40c0f7f04f6976f6757f05b61f2c9958f9\nSigned-off-by: Jeremy Kerr \u003cjk@codeconstruct.com.au\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/54887\nOriginal-Reviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71389\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "7dcb6f33d0e97154b3533917fad3dea0dad676bc", "tree": "05d10b7288a928f72f231c29fc07d58bbb7ed066", "parents": [ "1535db44bdc06e6cf52defc519af86197ca414e5" ], "author": { "name": "Anastasia Klimchuk", "email": "aklm@chromium.org", "time": "Mon May 24 15:12:10 2021 +1000" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "buspirate_spi.c: Separate shutdown from failed init cleanup\n\nShutdown function was covering two different jobs here: 1) the actual\nshutdown which is run at the end of the driver\u0027s lifecycle and\n2) cleanup in cases when initialisation failed. Now, shutdown is only\ndoing its main job (#1), and the driver itself is doing cleanup\nwhen init fails (#2).\n\nThe good thing is that now resources are released/closed immediately\nin cases when init fails (vs shutdown function which was run at some\npoint later), and the driver leaves clean space after itself if init\nfails.\n\nAnd very importantly this unlocks API change which plans to move\nregister_shutdown inside register master API, see\nhttps://review.coreboot.org/c/flashrom/+/51761\n\nChange-Id: I04d57e2552d23a1a4a906c68539f0ccefc13e8a0\nSigned-off-by: Anastasia Klimchuk \u003caklm@chromium.org\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/52877\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nOriginal-Reviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71388\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "1535db44bdc06e6cf52defc519af86197ca414e5", "tree": "a7dc07bfbbf2236cab7941ebb5e7909fae124de9", "parents": [ "8a03c90f41a6ca79c7bf183ad07e2b30702bfd46" ], "author": { "name": "Thomas Heijligen", "email": "thomas.heijligen@secunet.de", "time": "Mon Jun 14 13:20:09 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "programmer.h: sort programmer entries alphabetically\n\nChange-Id: Ie419eac2719aceb3aea803fac8ce85de294c88e5\nSigned-off-by: Thomas Heijligen \u003cthomas.heijligen@secunet.de\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/55495\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71387\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "8a03c90f41a6ca79c7bf183ad07e2b30702bfd46", "tree": "9acfb7f68e05f0d7166357ab6f37c07adea669a3", "parents": [ "83b01c8a0f67143594a3befbb2668775e1d28aba" ], "author": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jun 17 21:23:29 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "ich_descriptors: Refactor read_ich_descriptors_from_dump()\n\nProcess the \"upper map\" early as it doesn\u0027t depend on the descriptor\ngeneration. This way, we can use it to guess the generation.\n\nChange-Id: Ia2786b762ccefdce31b63397119bd89879e887ff\nSigned-off-by: Nico Huber \u003cnico.h@gmx.de\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/55646\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71386\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "83b01c8a0f67143594a3befbb2668775e1d28aba", "tree": "d9ae99bfbeef9e73b47177ef9d606cb82f2fd7bf", "parents": [ "964007ad72a8a9be9c462ff4e03d73c0d9f7c577" ], "author": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jun 17 21:20:09 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "ich_descriptors: Drop some unnecessary `else` after `return`\n\nChange-Id: Id739bc12832e3b441e8e7e1dcdcc4c05b260d7ad\nSigned-off-by: Nico Huber \u003cnico.h@gmx.de\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/55645\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-by: Michał Żygowski \u003cmichal.zygowski@3mdeb.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71385\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "964007ad72a8a9be9c462ff4e03d73c0d9f7c577", "tree": "8125ec38d11a6c72f4d45a0dfdacfdaa50527936", "parents": [ "40d3233e17e07f7616702b9968468816f4db9520" ], "author": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jun 17 21:12:47 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "ich_descriptors: Revise descriptor messages\n\nCorrect \"firmware descriptor\" to \"flash descriptor\". And also\nmove the check for peculiar descriptors and the message into an\ninline function.\n\nChange-Id: I7f15780e03d2fa17ca6d8328275cae5af13ae424\nSigned-off-by: Nico Huber \u003cnico.h@gmx.de\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/55644\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-by: Michał Żygowski \u003cmichal.zygowski@3mdeb.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71384\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "40d3233e17e07f7616702b9968468816f4db9520", "tree": "b6b11594742374e50aee4b6afe45a4492c7fa904", "parents": [ "ab69629daab4c091870b3f7d27f80085a415b286" ], "author": { "name": "Thomas Heijligen", "email": "thomas.heijligen@secunet.de", "time": "Thu Jun 10 15:17:53 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "programmer.h: remove compile guard from programmer drivers\n\nThe definition of external structs doesn\u0027t have to be guarded.\nSee discussion under review.coreboot.org/52946.\n\nChange-Id: I01e6a785269c3e0bd648eeaee217a7a855ab0853\nSigned-off-by: Thomas Heijligen \u003cthomas.heijligen@secunet.de\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/55387\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-by: Anastasia Klimchuk \u003caklm@chromium.org\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71383\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "ab69629daab4c091870b3f7d27f80085a415b286", "tree": "8f03b87d3480fd91f5dbbc5bc80c14633706bdbe", "parents": [ "3795c9d43d0b6ea71fb7ec499f6fdbb5e5bf0960" ], "author": { "name": "Nico Huber", "email": "nico.huber@secunet.com", "time": "Wed Jun 09 18:10:07 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "dummyflasher: Re-arrange includes\n\nGather library includes at the top.\n\nChange-Id: Ib20a3245cae3206dca1d8f88f705ac3628473f43\nSigned-off-by: Nico Huber \u003cnico.huber@secunet.com\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/55359\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-by: Anastasia Klimchuk \u003caklm@chromium.org\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71382\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "3795c9d43d0b6ea71fb7ec499f6fdbb5e5bf0960", "tree": "95c8c787f2e7010cd2c293767b8ffe94b7f259f1", "parents": [ "84e9c913082ce2d243593e3659ec3a0af22ea9cd" ], "author": { "name": "Thomas Heijligen", "email": "thomas.heijligen@secunet.de", "time": "Tue Jun 01 16:25:52 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "enum programmer: not needed anymore. Remove\n\nChange-Id: I53cdb160616911a4beea6b5e8e56d582621818a4\nSigned-off-by: Thomas Heijligen \u003cthomas.heijligen@secunet.de\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/55124\nOriginal-Reviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nOriginal-Reviewed-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71381\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "84e9c913082ce2d243593e3659ec3a0af22ea9cd", "tree": "1d753a41959b8fef39bbe9d4f61032b5142ec299", "parents": [ "acd9c948b1fbea6dc79560cd12042898f82c3636" ], "author": { "name": "Thomas Heijligen", "email": "thomas.heijligen@secunet.de", "time": "Tue Jun 01 16:22:14 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "CONFIG_DEFAULT_PROGRAMMER_NAME: Use programmer name instead of enum\n\nCONFIG_DEFAULT_PROGRAMER_NAME replaces CONFIG_DEFAULT_PROGRAMMER.\nIt uses the name of the programmer for identification.\nmake CONFIG_DEFAULT_PROGRAMER_NAME\u003ddummy and\nmeson -Ddefault_programmer_name\u003ddummy will extend to\nCONFIG_DEFAULT_PROGRAMER_NAME\u003d\u0026programmer_dummy in the code.\n\nChange-Id: I976447787c6f6bfbdc0145d80d61e1ddcf97ac33\nSigned-off-by: Thomas Heijligen \u003cthomas.heijligen@secunet.de\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/55123\nOriginal-Reviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71380\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "acd9c948b1fbea6dc79560cd12042898f82c3636", "tree": "1cf8deb4c7dda694f8a666ba42451faf6461f162", "parents": [ "e0e93cf59fe2fb45f1e325e0dcc939cc054cbfa8" ], "author": { "name": "Thomas Heijligen", "email": "thomas.heijligen@secunet.de", "time": "Tue Jun 01 14:51:13 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "cli_classic: replace enum programmer with programmer_entry*\n\nChange-Id: I4c45f278addeea0d486a316435e8dc15d93cbd70\nSigned-off-by: Thomas Heijligen \u003cthomas.heijligen@secunet.de\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/55122\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71379\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "e0e93cf59fe2fb45f1e325e0dcc939cc054cbfa8", "tree": "38f1faaae8d2a12dba5a80bad703e3d2c8d68c9e", "parents": [ "9163b814032c566b224ee8e58742448a99a3b73d" ], "author": { "name": "Thomas Heijligen", "email": "thomas.heijligen@secunet.de", "time": "Tue Jun 01 14:37:12 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "programmer_init: use struct programmer_entry*\n\nChange-Id: Iacf0f25abc94a84c5d52c8d69a3e8640817b060a\nSigned-off-by: Thomas Heijligen \u003cthomas.heijligen@secunet.de\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/55121\nOriginal-Reviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71378\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "9163b814032c566b224ee8e58742448a99a3b73d", "tree": "8f25a2a94f5dbd3d31e57a0470e8cbe0947e9d9f", "parents": [ "c7e5b8b4880984db47491bbf7a01ed7c7d470075" ], "author": { "name": "Thomas Heijligen", "email": "thomas.heijligen@secunet.de", "time": "Tue Jun 01 14:25:01 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "flashrom.c: replace enum programmer with size_t\n\nUsing size_t since programmer_table_size uses ARRAY_SIZE which returns\nsize_t.\n\nChange-Id: Id2ad9630fbc41e98d182768b553788e069fa5095\nSigned-off-by: Thomas Heijligen \u003cthomas.heijligen@secunet.de\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/55120\nOriginal-Reviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71377\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "c7e5b8b4880984db47491bbf7a01ed7c7d470075", "tree": "b8a0a67add5427260d6f69ff9f634600ea0f8117", "parents": [ "79088ab06fe92e2b898ddbb682782e06159e87f7" ], "author": { "name": "Thomas Heijligen", "email": "thomas.heijligen@secunet.de", "time": "Tue Jun 01 14:21:41 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "flashrom.c: replace enum programmer with struct programmer_entry*\n\nChange-Id: I478c56354d5f482010bfe1560489700bc889717a\nSigned-off-by: Thomas Heijligen \u003cthomas.heijligen@secunet.de\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/55119\nOriginal-Reviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71376\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "79088ab06fe92e2b898ddbb682782e06159e87f7", "tree": "9d0b0bdaed216e2520e022672d4dab536fc7cd24", "parents": [ "d45cb595e031ea6917f154f01eda3b234226f4f0" ], "author": { "name": "Thomas Heijligen", "email": "thomas.heijligen@secunet.de", "time": "Tue Jun 01 13:57:42 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "print.c: use static string for internal programmer name\n\nChange-Id: If2cf95c71425efdd864457e213dd34b929fe8805\nSigned-off-by: Thomas Heijligen \u003cthomas.heijligen@secunet.de\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/55118\nOriginal-Reviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71375\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "d45cb595e031ea6917f154f01eda3b234226f4f0", "tree": "2073712010f8c8e680ba82fa6d75e59f1edceab6", "parents": [ "cc853d84ed2f8ecafc1f6daa443f8baa4c871805" ], "author": { "name": "Thomas Heijligen", "email": "thomas.heijligen@secunet.de", "time": "Wed May 19 14:12:18 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "programmer_table: replace PROGRAMMER_INVALID with programmer_table_size\n\nChange-Id: Icaaeefe001de604df9d7fdd06f05a5ed39fdbd84\nSigned-off-by: Thomas Heijligen \u003cthomas.heijligen@secunet.de\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/55117\nOriginal-Reviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71374\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "cc853d84ed2f8ecafc1f6daa443f8baa4c871805", "tree": "8e5f3e0b7a75d272a109e20af5aeeeec11dfebf7", "parents": [ "7e1345602641114c8eeb5cfef992bf1da8d7fa6a" ], "author": { "name": "Thomas Heijligen", "email": "thomas.heijligen@secunet.de", "time": "Tue May 04 15:32:17 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "programmer_table: move each entry to the associated programmer source\n\nChange-Id: I3d02bd789f0299e936eb86819b3b15b5ea2bb921\nSigned-off-by: Thomas Heijligen \u003cthomas.heijligen@secunet.de\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/52946\nOriginal-Reviewed-by: Anastasia Klimchuk \u003caklm@chromium.org\u003e\nOriginal-Reviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71373\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "7e1345602641114c8eeb5cfef992bf1da8d7fa6a", "tree": "ce19124575cfd893449c754800c757d096dd3130", "parents": [ "690a944066619ff9d450d71cdcfe2e0bcb1120f3" ], "author": { "name": "Angel Pons", "email": "th3fanbus@gmail.com", "time": "Mon Jun 07 13:29:13 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "treewide: Drop unnecessary uses of memset/memcpy\n\nSimply provide an initialiser or use a direct assignment instead.\n\nChange-Id: I07385375cd8eec8a95874001b402b2c17ec09e09\nSigned-off-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/55267\nOriginal-Reviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71372\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "690a944066619ff9d450d71cdcfe2e0bcb1120f3", "tree": "e8da9e733570d6ebb25251f2362f17af5c59d626", "parents": [ "c40ca200100fe6fc451ab7f9bdf9751af1899d02" ], "author": { "name": "Angel Pons", "email": "th3fanbus@gmail.com", "time": "Mon Jun 07 12:33:53 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "treewide: Drop most cases of `sizeof(struct ...)`\n\nSpelling out the struct type name hurts readability and introduces\nopportunities for bugs to happen when the pointer variable type is\nchanged but the corresponding sizeof is (are) not.\n\nTested: `make CONFIG_EVERYTHING\u003dyes CONFIG_JLINK_SPI\u003dno VERSION\u003dnone -j`\nwith and without this patch; the flashrom executable does not change.\n\nflashrom-stable: Applied partially.\n\nChange-Id: Icc0b60ca6ef9f5ece6ed2a0e03600bb6ccd7dcc6\nSigned-off-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/55266\nOriginal-Reviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nOriginal-Reviewed-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71371\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n" }, { "commit": "c40ca200100fe6fc451ab7f9bdf9751af1899d02", "tree": "595754e4ac3f84de465c9e3b1dee95d10a12db28", "parents": [ "633d6db1b5718305cf4daf87cf4a93d17bc3821e" ], "author": { "name": "Angel Pons", "email": "th3fanbus@gmail.com", "time": "Mon Jun 07 12:08:27 2021 +0200" }, "committer": { "name": "Nico Huber", "email": "nico.h@gmx.de", "time": "Thu Jan 05 16:15:22 2023 +0000" }, "message": "dummyflasher.c: Drop useless macros\n\nThe `EMULATE_CHIP` and `EMULATE_SPI_CHIP` macros are unconditionally\ndefined as `1`, with no way to change their values. Since this means\nthat the code never gets build-tested using other values, drop these\nnoisy macros.\n\nTested: Build with `make distclean \u0026\u0026 make VERSION\u003dnone -j` with and\n without this patch, the flashrom executable does not change.\n\nChange-Id: If46e1c37c3b04b28b4ba1f82c9b3def1e549368f\nSigned-off-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/55265\nOriginal-Reviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nOriginal-Reviewed-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nOriginal-Reviewed-by: Namyoon Woo \u003cnamyoon@google.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71370\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\n" } ], "next": "633d6db1b5718305cf4daf87cf4a93d17bc3821e" }