)]}'
{
  "commit": "de307c0d68ae46749a1dc392d983892b06f6a78a",
  "tree": "f12ef676bd45214b3cd106c77948c6ea076e1840",
  "parents": [
    "99b518611a36da843d134fc4a2a7818a642c7de4"
  ],
  "author": {
    "name": "Michael Niewöhner",
    "email": "foss@mniewoehner.de",
    "time": "Sat Dec 11 22:15:06 2021 +0100"
  },
  "committer": {
    "name": "Nico Huber",
    "email": "nico.h@gmx.de",
    "time": "Thu Jan 05 16:07:04 2023 +0000"
  },
  "message": "SFDP: make mandatory table length check work with newer SFDP revisions\n\nThe JEDEC SFDP specification JESD216A (1.5) adds five new DWORDs to the\nBasic Flash Parameter Table. Later versions of the spec add even more\nfields. This increases the table being read from 36 bytes to currently\n64 bytes and makes flashrom bail out for any SFDP version \u003e\u003d 1.5 due to\na static table length check.\n\nThis was discovered on a GigaDevice GD25B127DSIGR from 2021 with SFDP\nrevision 1.6, while another flash of the same model from 2020 with SFDP\nrevision 1.0 was detected fine by flashrom.\n\nGD25B127DSIGR - 2020 version:\n\n  Probing for Unknown SFDP-capable chip, 0 kB: SFDP revision \u003d 1.0\n  SFDP number of parameter headers is 2 (NPH \u003d 1).\n\n  SFDP parameter table header 0/1:\n    ID 0x00, version 1.0\n    Length 36 B, Parameter Table Pointer 0x000030\n\nGD25B127DSIGR - 2021 version:\n\n  Probing for Unknown SFDP-capable chip, 0 kB: SFDP revision \u003d 1.6\n  SFDP number of parameter headers is 2 (NPH \u003d 1).\n\n  SFDP parameter table header 0/1:\n    ID 0x00, version 1.6\n    Length 64 B, Parameter Table Pointer 0x000030\n\n  ...\n\n  Length of the mandatory JEDEC SFDP parameter table is wrong (64 B),\n  skipping it.\n\nThe specification says that changes of the minor SFDP revision will\nmaintain compatibility. Thus, simply check for the minimal required\ntable length, which is 16 bytes for legacy Intel pre-SFDP and 36 bytes\nfor SFDP.\n\nChange-Id: Id84cde4ebc805d68e2984e8041fbc48d7ceebe34\nSigned-off-by: Michael Niewöhner \u003cfoss@mniewoehner.de\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/60055\nOriginal-Reviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71301\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\nReviewed-by: Paul Menzel \u003cpaulepanter@mailbox.org\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "215864976099461f310bb9057c3b9cf443d92589",
      "old_mode": 33188,
      "old_path": "sfdp.c",
      "new_id": "a62612765bdeb5a93fc0971378a3d78621cfe7a3",
      "new_mode": 33188,
      "new_path": "sfdp.c"
    }
  ]
}