ich_descriptors.c: Retype variable `has_forbidden_opcode` with bool
Use the bool type instead of an integer for the variable
`has_forbidden_opcode`, since this represents its purpose much better.
Signed-off-by: Felix Singer <felixsinger@posteo.net>
Change-Id: I6214956e377547b894fc76237832b6f7b2db41dd
Original-Reviewed-on: https://review.coreboot.org/c/flashrom/+/66899
Original-Reviewed-by: Anastasia Klimchuk <aklm@chromium.org>
Original-Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71488
Reviewed-by: Nico Huber <nico.h@gmx.de>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
diff --git a/ich_descriptors.c b/ich_descriptors.c
index 3d41321..bacbbb5 100644
--- a/ich_descriptors.c
+++ b/ich_descriptors.c
@@ -31,6 +31,7 @@
#define UPPER_MAP_OFFSET (4096 - 256 - 4)
#define getVTBA(flumap) (((flumap)->FLUMAP1 << 4) & 0x00000ff0)
+#include <stdbool.h>
#include <sys/types.h>
#include <string.h>
#include "flash.h" /* for msg_* */
@@ -377,9 +378,9 @@
msg_pdbg2("Dual Output Fast Read Support: %sabled\n",
desc->component.modes.dual_output ? "en" : "dis");
- int has_forbidden_opcode = 0;
+ bool has_forbidden_opcode = false;
if (desc->component.FLILL != 0) {
- has_forbidden_opcode = 1;
+ has_forbidden_opcode = true;
msg_pdbg2("Invalid instruction 0: 0x%02x\n",
desc->component.invalid_instr0);
msg_pdbg2("Invalid instruction 1: 0x%02x\n",
@@ -391,7 +392,7 @@
}
if (has_flill1) {
if (desc->component.FLILL1 != 0) {
- has_forbidden_opcode = 1;
+ has_forbidden_opcode = true;
msg_pdbg2("Invalid instruction 4: 0x%02x\n",
desc->component.invalid_instr4);
msg_pdbg2("Invalid instruction 5: 0x%02x\n",