Gitiles
Code Review Sign In
review.sourcearcade.org / flashprog / 88e87c568678ab36c997c1c807d97b3b1e7091e6
commit88e87c568678ab36c997c1c807d97b3b1e7091e6[log] [tgz]
authorThomas Heijligen <thomas.heijligen@secunet.com>Fri Aug 05 17:56:20 2022 +0200
committerNico Huber <nico.h@gmx.de>Thu Jan 05 16:35:01 2023 +0000
treefdd492a475759d50abca6c1fa5b61a7970bee032
parent927c1f036fc6b3d9b6cb84c5cacc8e78ec7d28cc [diff]
tree: Check properly if libusb is initialized

The dediprog, developerbox_spi and stlinkv3_spi programmers only check
if the libusb_context is not NULL after the initialization. But
following the API documentation from libusb, the context is undefined
unless the init function returns 0. Fix this by checking the return
value instead of the libusb_context to see if the initialization was
successful.

https://libusb.sourceforge.io/api-1.0/group__libusb__lib.html

Change-Id: Ia45ccd3fa2239dfccd821be46a09c86426cb22e5
Signed-off-by: Thomas Heijligen <thomas.heijligen@secunet.com>
Original-Reviewed-on: https://review.coreboot.org/c/flashrom/+/66460
Original-Reviewed-by: Felix Singer <felixsinger@posteo.net>
Reviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71475
Reviewed-by: Nico Huber <nico.h@gmx.de>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
3 files changed
tree: fdd492a475759d50abca6c1fa5b61a7970bee032
  1. Documentation/
  2. util/
  3. .gitattributes
  4. .gitignore
  5. 82802ab.c
  6. amd_imc.c
  7. archtest.c
  8. at45db.c
  9. atahpt.c
  10. atapromise.c
  11. atavia.c
  12. bitbang_spi.c
  13. board_enable.c
  14. buspirate_spi.c
  15. cbtable.c
  16. ch341a_spi.c
  17. chipdrivers.h
  18. chipset_enable.c
  19. cli_classic.c
  20. cli_common.c
  21. cli_output.c
  22. COPYING
  23. coreboot_tables.h
  24. custom_baud.c
  25. custom_baud.h
  26. custom_baud_linux.c
  27. dediprog.c
  28. developerbox_spi.c
  29. digilent_spi.c
  30. dmi.c
  31. Doxyfile
  32. drkaiser.c
  33. dummyflasher.c
  34. edi.c
  35. edi.h
  36. en29lv640b.c
  37. endiantest.c
  38. ene.h
  39. flash.h
  40. flashchips.c
  41. flashchips.h
  42. flashrom.8.tmpl
  43. flashrom.c
  44. fmap.c
  45. fmap.h
  46. ft2232_spi.c
  47. gfxnvidia.c
  48. helpers.c
  49. hwaccess.c
  50. hwaccess.h
  51. ich_descriptors.c
  52. ich_descriptors.h
  53. ichspi.c
  54. internal.c
  55. it8212.c
  56. it87spi.c
  57. jedec.c
  58. jlink_spi.c
  59. layout.c
  60. layout.h
  61. libflashrom.c
  62. libflashrom.h
  63. libflashrom.map
  64. linux_mtd.c
  65. linux_spi.c
  66. Makefile
  67. mcp6x_spi.c
  68. meson.build
  69. meson_options.txt
  70. mstarddc_spi.c
  71. ni845x_spi.c
  72. nic3com.c
  73. nicintel.c
  74. nicintel_eeprom.c
  75. nicintel_spi.c
  76. nicnatsemi.c
  77. nicrealtek.c
  78. ogp_spi.c
  79. opaque.c
  80. os.h
  81. pcidev.c
  82. physmap.c
  83. pickit2_spi.c
  84. platform.h
  85. pony_spi.c
  86. print.c
  87. print_wiki.c
  88. processor_enable.c
  89. programmer.c
  90. programmer.h
  91. programmer_table.c
  92. rayer_spi.c
  93. README
  94. satamv.c
  95. satasii.c
  96. sb600spi.c
  97. serial.c
  98. serprog.c
  99. sfdp.c
  100. spi.c
  101. spi.h
  102. spi25.c
  103. spi25_statusreg.c
  104. spi95.c
  105. sst28sf040.c
  106. sst49lfxxxc.c
  107. sst_fwhub.c
  108. stlinkv3_spi.c
  109. stm50.c
  110. test_build.sh
  111. udelay.c
  112. usbblaster_spi.c
  113. usbdev.c
  114. w29ee011.c
  115. w39.c
  116. wbsio_spi.c
  117. writeprotect.c
  118. writeprotect.h
  119. writeprotect_ranges.c