tree: Retype variable `laptop_ok` with bool
Use the bool type instead of an integer for the variable `laptop_ok`,
since this represents its purpose much better.
Signed-off-by: Felix Singer <felixsinger@posteo.net>
Change-Id: I5d9fc3516bc2d29f11b056e35b3e5e324ce93423
Original-Reviewed-on: https://review.coreboot.org/c/flashrom/+/66891
Original-Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Original-Reviewed-by: Anastasia Klimchuk <aklm@chromium.org>
Reviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71485
Reviewed-by: Nico Huber <nico.h@gmx.de>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
diff --git a/board_enable.c b/board_enable.c
index 2be8486..bfdd858 100644
--- a/board_enable.c
+++ b/board_enable.c
@@ -22,6 +22,7 @@
#include <strings.h>
#include <string.h>
+#include <stdbool.h>
#include <stdlib.h>
#include "flash.h"
#include "programmer.h"
@@ -2303,7 +2304,7 @@
static int p2_whitelist_laptop(void)
{
is_laptop = 1;
- laptop_ok = 1;
+ laptop_ok = true;
msg_pdbg("Whitelisted laptop detected.\n");
return 0;
}
diff --git a/chipset_enable.c b/chipset_enable.c
index f781b16..e721661 100644
--- a/chipset_enable.c
+++ b/chipset_enable.c
@@ -810,7 +810,7 @@
/* Suppress unknown laptop warning if we booted from SPI. */
if (boot_buses & BUS_SPI)
- laptop_ok = 1;
+ laptop_ok = true;
return 0;
}
@@ -955,7 +955,7 @@
/* Suppress unknown laptop warning if we booted from SPI. */
if (!ret && (boot_buses & BUS_SPI))
- laptop_ok = 1;
+ laptop_ok = true;
_freepci_ret:
pci_free_dev(spi_dev);
@@ -1051,7 +1051,7 @@
/* Suppress unknown laptop warning if we booted from SPI. */
if (boot_buses & BUS_SPI)
- laptop_ok = 1;
+ laptop_ok = true;
return 0;
}
@@ -1640,7 +1640,7 @@
/* Suppress unknown laptop warning if we booted from SPI. */
if (!ret && want_spi)
- laptop_ok = 1;
+ laptop_ok = true;
return ret;
}
diff --git a/internal.c b/internal.c
index e630105..ca43550 100644
--- a/internal.c
+++ b/internal.c
@@ -119,7 +119,7 @@
#endif
int is_laptop = 0;
-int laptop_ok = 0;
+bool laptop_ok = false;
static void internal_chip_writeb(const struct flashctx *flash, uint8_t val,
chipaddr addr);
diff --git a/programmer.h b/programmer.h
index 24b37fb..2047b8e 100644
--- a/programmer.h
+++ b/programmer.h
@@ -271,7 +271,7 @@
int rget_io_perms(void);
#if CONFIG_INTERNAL == 1
extern int is_laptop;
-extern int laptop_ok;
+extern bool laptop_ok;
extern int force_boardenable;
extern int force_boardmismatch;
void probe_superio(void);