)]}'
{
  "commit": "c676be9e1e6ce35ae5d892315f99785ab275a816",
  "tree": "1188b181f10251a713ef7f2c16bb19caaee64767",
  "parents": [
    "3c50843d6704e9e97cdf8cecaf72cbf86ee52fa0"
  ],
  "author": {
    "name": "Anastasia Klimchuk",
    "email": "aklm@chromium.org",
    "time": "Tue Apr 26 14:53:18 2022 +1000"
  },
  "committer": {
    "name": "Nico Huber",
    "email": "nico.h@gmx.de",
    "time": "Sun Jan 29 12:29:02 2023 +0000"
  },
  "message": "meson: Treat warnings as errors\n\nMakefile treats warnings as errors, so enable the same option\nfor meson.\n\nMakefile has an option to disable \"warnings as errors\" option\nfrom command line. The same can be achieved with meson, see\nscenario 2 below.\n\nTested: I verified the following scenarious\n\n1) check that warnings treated as errors by enforcing higher\nwarning level\n`meson setup --warnlevel\u003d3 --wipe`\n`ninja test`\nshows tons of errors because warning level 3 is pedantic,\nbuild fails\n\n2) disable \"warning as errors\" option from command line\n`meson configure -Dwerror\u003dfalse`\n`ninja test`\nNow all warnings are non-blocking for build, so tests pass\n\n3) back home\n`meson configure -Dwerror\u003dtrue`\n`meson setup --warnlevel\u003d2 --wipe`\n`ninja test`\nNo warnings and tests pass\n\n4) defaults: create new directory and run meson will all default\noptions\nNo warnings, all tests pass.\n\nChange-Id: I06c72abf1c861f9b35736e02ef7f4a4fb6909b97\nSigned-off-by: Anastasia Klimchuk \u003caklm@chromium.org\u003e\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/63852\nOriginal-Reviewed-by: Thomas Heijligen \u003csrc@posteo.de\u003e\nOriginal-Reviewed-by: Peter Marheine \u003cpmarheine@chromium.org\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/72326\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "3778f4d939f1276eaa82a14e6c8fe8404c6b43df",
      "old_mode": 33188,
      "old_path": "meson.build",
      "new_id": "db6f98bf5d1e844e98b2c3d6dbd3a8ff67c36efd",
      "new_mode": 33188,
      "new_path": "meson.build"
    }
  ]
}
