tree a2e8e2fd20756392fe86c8154dc610672c8e4f2d
parent 440057a82e42c74c8769cfdd548fd93699bc3178
author Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at> 1405255935 +0000
committer Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at> 1405255935 +0000

Fix garbage handling in DMI strings

Previously we tried to replace garbage characters with <space> directly in
the read-only memory-mapped SMBIOS area(!). This could never have
worked for any DMI strings with garbage and results in a segfault on
machines with such strings.

Thanks to Brian Rak (Supermicro X10SLE-F) and John Pohlman (HP XW9400)
for reporting this issue.

With this patch the strings are duplicated within dmi_string() already,
just before we sanitize them. Also, the limit variable used everywhere
points to the first invalid byte address. Refine respective checks
accordingly.

Corresponding to flashrom svn r1824.

Signed-off-by: Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at>
Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>