Add board enable for ASUS P3B-F
With this change flashrom can detect, enable and flash on this board
both under vendor BIOS and coreboot.
Change-Id: I395ff50fbcda8ecdaa26033f0d99b2b0eb42f7ff
Signed-off-by: Keith Hui <buurin@gmail.com>
Original-Reviewed-on: https://review.coreboot.org/c/flashrom/+/41354
Original-Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71311
Reviewed-by: Nico Huber <nico.h@gmx.de>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
diff --git a/board_enable.c b/board_enable.c
index 94e44ee..101e1c8 100644
--- a/board_enable.c
+++ b/board_enable.c
@@ -875,6 +875,52 @@
/*
* Suited for:
+ * - ASUS P3B-F
+ *
+ * We are talking to a proprietary device on SMBus: the AS99127F which does
+ * much more than the Winbond W83781D it tries to be compatible with.
+ */
+static int board_asus_p3b_f(void)
+{
+ /*
+ * Find where the SMBus host is. ASUS sets it to 0xE800; coreboot sets it to 0x0F00.
+ */
+ struct pci_dev *dev;
+ uint16_t smbba;
+ uint8_t b;
+
+ dev = pci_dev_find(0x8086, 0x7113); /* Intel PIIX4, PM/SMBus function. */
+ if (!dev) {
+ msg_perr("\nERROR: Intel PIIX4 PM not found.\n");
+ return -1;
+ }
+
+ smbba = pci_read_word(dev, 0x90) & 0xfff0;
+
+ OUTB(0xFF, smbba); /* Clear previous SMBus status. */
+ OUTB(0x48 << 1, smbba + 4);
+ OUTB(0x80, smbba + 3);
+ OUTB(0x80, smbba + 5);
+ OUTB(0x48, smbba + 2);
+
+ /* Wait until SMBus transaction is complete. */
+ b = 0x1;
+ while (b & 0x01) {
+ b = INB(0x80);
+ b = INB(smbba);
+ }
+
+ /* Write failed if any status is set. */
+ if (b & 0x1e) {
+ msg_perr("Failed to write to device.\n");
+ return -1;
+ }
+
+ return 0;
+}
+
+/*
+ * Suited for:
* - ASUS P5A
*
* This is rather nasty code, but there's no way to do this cleanly.
@@ -2355,6 +2401,7 @@
{0x8086, 0x24cc, 0, 0, 0x8086, 0x24c3, 0x1043, 0x1869, "^M6Ne$", NULL, NULL, P3, "ASUS", "M6Ne", 0, NT, intel_ich_gpio43_raise},
{0x8086, 0x7180, 0, 0, 0x8086, 0x7110, 0, 0, "^OPLX-M$", NULL, NULL, P3, "ASUS", "OPLX-M", 0, NT, intel_piix4_gpo18_lower},
{0x8086, 0x7190, 0, 0, 0x8086, 0x7110, 0, 0, "^P2B-N$", NULL, NULL, P3, "ASUS", "P2B-N", 0, OK, intel_piix4_gpo18_lower},
+ {0x8086, 0x7190, 0x1043, 0x8024, 0x8086, 0x7110, 0, 0, "P3B-F", "asus", "p3b-f", P3, "ASUS", "P3B-F", 0, OK, board_asus_p3b_f},
{0x8086, 0x1A30, 0x1043, 0x8025, 0x8086, 0x244B, 0x104D, 0x80F0, NULL, NULL, NULL, P3, "ASUS", "P4B266-LM", 0, OK, intel_ich_gpio21_raise},
{0x8086, 0x1a30, 0x1043, 0x8070, 0x8086, 0x244b, 0x1043, 0x8028, NULL, NULL, NULL, P3, "ASUS", "P4B266", 0, OK, intel_ich_gpio22_raise},
{0x8086, 0x1A30, 0x1043, 0x8088, 0x8086, 0x24C3, 0x1043, 0x8089, NULL, NULL, NULL, P3, "ASUS", "P4B533-E", 0, NT, intel_ich_gpio22_raise},
diff --git a/print.c b/print.c
index 6a7ff5d..feca45e 100644
--- a/print.c
+++ b/print.c
@@ -667,7 +667,7 @@
B("ASUS", "P2B-N", OK, NULL, NULL),
B("ASUS", "P2E-M", OK, NULL, NULL),
B("ASUS", "P2L97-S", OK, NULL, NULL),
- B("ASUS", "P3B-F", BAD, NULL, "No public report found. Owned by Uwe Hermann <uwe@hermann-uwe.de>. May work now."),
+ B("ASUS", "P3B-F", OK, NULL, "Owned by Uwe Hermann <uwe@hermann-uwe.de>."),
B("ASUS", "P4B266", OK, NULL, NULL),
B("ASUS", "P4B266-LM", OK, "http://esupport.sony.com/US/perl/swu-list.pl?mdl=PCVRX650", NULL),
B("ASUS", "P4B533-E", OK, NULL, NULL),