)]}'
{
  "commit": "8f0db7d4945d0e7c4d538337ce0dbf47c5356945",
  "tree": "bd7af29d6e036f189ee3f9a3a7033adc5da39dc9",
  "parents": [
    "d3e8fd9dd50f45028d9cd987c649229c78b0e5e1"
  ],
  "author": {
    "name": "Julius Werner",
    "email": "jwerner@chromium.org",
    "time": "Mon Feb 14 17:07:39 2022 -0800"
  },
  "committer": {
    "name": "Nico Huber",
    "email": "nico.h@gmx.de",
    "time": "Thu Jan 05 16:15:22 2023 +0000"
  },
  "message": "libflashrom/fmap: Don\u0027t use off_t for flash offsets\n\noff_t is a special POSIX type that is used to represent file offsets in\ncertain APIs (e.g. lseek(), mmap()), and should not be reused to\nrepresent anything else (such as flash offsets). In particular, the\nwidth of the type may change based on the definition of the\n_FILE_OFFSET_BITS macro. Using such a type at the libflashrom interface\nis particularly dangerous, because if a program is built with a\ndifferent _FILE_OFFSET_BITS value than libflashrom, the resulting ABI\ncorruption will cause very very nasty and confusing bugs. This patch\nreplaces all instances of off_t that are not related to file offsets\nwith (s)size_t.\n\nTested: `elogtool list` on cherry.\n\nSigned-off-by: Julius Werner \u003cjwerner@chromium.org\u003e\nChange-Id: I68a386973f79ea634f63dfcd7d95a63400e1fdee\nOriginal-Reviewed-on: https://review.coreboot.org/c/flashrom/+/61943\nOriginal-Reviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nOriginal-Reviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nOriginal-Reviewed-by: Edward O\u0027Callaghan \u003cquasisec@chromium.org\u003e\nOriginal-Reviewed-by: Nikolai Artemiev \u003cnartemiev@google.com\u003e\nReviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71445\nReviewed-by: Nico Huber \u003cnico.h@gmx.de\u003e\nReviewed-by: Angel Pons \u003cth3fanbus@gmail.com\u003e\nTested-by: build bot (Jenkins) \u003cno-reply@coreboot.org\u003e\n",
  "tree_diff": [
    {
      "type": "modify",
      "old_id": "7793be7125b2fadc9f3e44eb3a7099cbe8cc6cac",
      "old_mode": 33188,
      "old_path": "fmap.c",
      "new_id": "eafe80cd13fc3c94cf9a875b4b0b2a92c5dc5a54",
      "new_mode": 33188,
      "new_path": "fmap.c"
    },
    {
      "type": "modify",
      "old_id": "19a41cf48e6981bbb486d8ca3a68c9dd0d8c3563",
      "old_mode": 33188,
      "old_path": "libflashrom.c",
      "new_id": "c336b8cef5098dd0cdcd9f0404e8c99979ea992a",
      "new_mode": 33188,
      "new_path": "libflashrom.c"
    },
    {
      "type": "modify",
      "old_id": "972e7d1df3dc0aaefb2840f3616095ca271bfe71",
      "old_mode": 33188,
      "old_path": "libflashrom.h",
      "new_id": "603dccf7d01e3bae4cfe49acc1a0f75cef82d9d1",
      "new_mode": 33188,
      "new_path": "libflashrom.h"
    }
  ]
}