commit 519be66fc59558971dd653afe69ccaf1a633b492
author Nico Huber <nico.h@gmx.de> Sun Dec 23 20:03:35 2018 +0100
committer Nico Huber <nico.h@gmx.de> Wed Jul 31 08:26:59 2019 +0000
tree 74f0912de156a86d56111f377db080246e5205e9
parent ef78de4a21323b8c459337356289218211f2c5ce

Fix -Wsign-compare trouble

Mostly by changing to `unsigned` types where applicable, sometimes
`signed` types, and casting as a last resort.

Change-Id: I08895543ffb7a48058bcf91ef6500ca113f2d305
Signed-off-by: Nico Huber <nico.h@gmx.de>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/30409
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Jacob Garber <jgarber1@ualberta.ca>

sst_fwhub.c

diff --git a/sst_fwhub.c b/sst_fwhub.c
index c712303..d688a35 100644
--- a/sst_fwhub.c
+++ b/sst_fwhub.c
@@ -21,7 +21,7 @@
 #include "flash.h"
 #include "chipdrivers.h"
 
-static int check_sst_fwhub_block_lock(struct flashctx *flash, int offset)
+static int check_sst_fwhub_block_lock(struct flashctx *flash, unsigned int offset)
 {
 	chipaddr registers = flash->virtual_registers;
 	uint8_t blockstatus;
@@ -47,7 +47,7 @@
 	return blockstatus & 0x1;
 }
 
-static int clear_sst_fwhub_block_lock(struct flashctx *flash, int offset)
+static int clear_sst_fwhub_block_lock(struct flashctx *flash, unsigned int offset)
 {
 	chipaddr registers = flash->virtual_registers;
 	uint8_t blockstatus;
@@ -67,7 +67,7 @@
 
 int printlock_sst_fwhub(struct flashctx *flash)
 {
-	int i;
+	unsigned int i;
 
 	for (i = 0; i < flash->chip->total_size * 1024; i += flash->chip->page_size)
 		check_sst_fwhub_block_lock(flash, i);
@@ -77,7 +77,8 @@
 
 int unlock_sst_fwhub(struct flashctx *flash)
 {
-	int i, ret=0;
+	unsigned int i;
+	int ret = 0;
 
 	for (i = 0; i < flash->chip->total_size * 1024; i += flash->chip->page_size)
 	{