Fix -Wsign-compare trouble
Mostly by changing to `unsigned` types where applicable, sometimes
`signed` types, and casting as a last resort.
Change-Id: I08895543ffb7a48058bcf91ef6500ca113f2d305
Signed-off-by: Nico Huber <nico.h@gmx.de>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/30409
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Jacob Garber <jgarber1@ualberta.ca>
diff --git a/serial.c b/serial.c
index e61df74..3a99dbf 100644
--- a/serial.c
+++ b/serial.c
@@ -480,10 +480,10 @@
}
#endif
- int i;
- int rd_bytes = 0;
+ unsigned int i;
+ unsigned int rd_bytes = 0;
for (i = 0; i < timeout; i++) {
- msg_pspew("readcnt %d rd_bytes %d\n", readcnt, rd_bytes);
+ msg_pspew("readcnt %u rd_bytes %u\n", readcnt, rd_bytes);
#if IS_WINDOWS
ReadFile(sp_fd, c + rd_bytes, readcnt - rd_bytes, &rv, NULL);
msg_pspew("read %lu bytes\n", rv);
@@ -560,10 +560,10 @@
}
#endif
- int i;
- int wr_bytes = 0;
+ unsigned int i;
+ unsigned int wr_bytes = 0;
for (i = 0; i < timeout; i++) {
- msg_pspew("writecnt %d wr_bytes %d\n", writecnt, wr_bytes);
+ msg_pspew("writecnt %u wr_bytes %u\n", writecnt, wr_bytes);
#if IS_WINDOWS
WriteFile(sp_fd, buf + wr_bytes, writecnt - wr_bytes, &rv, NULL);
msg_pspew("wrote %lu bytes\n", rv);