commit 519be66fc59558971dd653afe69ccaf1a633b492
author Nico Huber <nico.h@gmx.de> Sun Dec 23 20:03:35 2018 +0100
committer Nico Huber <nico.h@gmx.de> Wed Jul 31 08:26:59 2019 +0000
tree 74f0912de156a86d56111f377db080246e5205e9
parent ef78de4a21323b8c459337356289218211f2c5ce

Fix -Wsign-compare trouble

Mostly by changing to `unsigned` types where applicable, sometimes
`signed` types, and casting as a last resort.

Change-Id: I08895543ffb7a48058bcf91ef6500ca113f2d305
Signed-off-by: Nico Huber <nico.h@gmx.de>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/30409
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Jacob Garber <jgarber1@ualberta.ca>

print_wiki.c

diff --git a/print_wiki.c b/print_wiki.c
index ea8c4d7..b2ac65c 100644
--- a/print_wiki.c
+++ b/print_wiki.c
@@ -245,7 +245,7 @@
 					   "<span id=\"%s_note%d\">%d. [[#%s_ref%d|&#x2191;]]</span>"
 					   " <nowiki>%s</nowiki><br />\n", devicetype, num_notes, num_notes,
 					   devicetype, num_notes, boards[i].note);
-			if (ret < 0 || ret >= sizeof(tmp)) {
+			if (ret < 0 || (unsigned int)ret >= sizeof(tmp)) {
 				fprintf(stderr, "Footnote text #%d of %s truncated (ret=%d, sizeof(tmp)=%zu)\n",
 					num_notes, devicetype, ret, sizeof(tmp));
 			}