Fix -Wsign-compare trouble
Mostly by changing to `unsigned` types where applicable, sometimes
`signed` types, and casting as a last resort.
Change-Id: I08895543ffb7a48058bcf91ef6500ca113f2d305
Signed-off-by: Nico Huber <nico.h@gmx.de>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/30409
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Jacob Garber <jgarber1@ualberta.ca>
diff --git a/dummyflasher.c b/dummyflasher.c
index 8f3dfda..0caffc9 100644
--- a/dummyflasher.c
+++ b/dummyflasher.c
@@ -58,8 +58,8 @@
static unsigned int emu_jedec_ce_c7_size = 0;
static unsigned char spi_blacklist[256];
static unsigned char spi_ignorelist[256];
-static int spi_blacklist_size = 0;
-static int spi_ignorelist_size = 0;
+static unsigned int spi_blacklist_size = 0;
+static unsigned int spi_ignorelist_size = 0;
static uint8_t emu_status = 0;
/* A legit complete SFDP table based on the MX25L6436E (rev. 1.8) datasheet. */
@@ -151,7 +151,7 @@
{
char *bustext = NULL;
char *tmp = NULL;
- int i;
+ unsigned int i;
#if EMULATE_SPI_CHIP
char *status = NULL;
#endif
@@ -231,7 +231,7 @@
msg_pdbg("SPI blacklist is ");
for (i = 0; i < spi_blacklist_size; i++)
msg_pdbg("%02x ", spi_blacklist[i]);
- msg_pdbg(", size %i\n", spi_blacklist_size);
+ msg_pdbg(", size %u\n", spi_blacklist_size);
}
free(tmp);
@@ -267,7 +267,7 @@
msg_pdbg("SPI ignorelist is ");
for (i = 0; i < spi_ignorelist_size; i++)
msg_pdbg("%02x ", spi_ignorelist[i]);
- msg_pdbg(", size %i\n", spi_ignorelist_size);
+ msg_pdbg(", size %u\n", spi_ignorelist_size);
}
free(tmp);
@@ -819,7 +819,7 @@
const unsigned char *writearr,
unsigned char *readarr)
{
- int i;
+ unsigned int i;
msg_pspew("%s:", __func__);