Gitiles
Code Review Sign In
review.sourcearcade.org / flashprog / 2f7c1df8293e359706ae9bb01314202ecb62981f
commit2f7c1df8293e359706ae9bb01314202ecb62981f[log] [tgz]
authorNico Huber <nico.h@gmx.de>Tue Mar 07 23:36:44 2023 +0000
committerNico Huber <nico.h@gmx.de>Tue Apr 04 10:19:22 2023 +0000
tree2cbb632fdc8a674b09f74d9b68e85d54508c9c9a
parent5ff6fdc75bdbdbeac9bb43bee7c72bed82dbe059 [diff]
ft2232_spi: Fix resource leaking on failed init

Move the allocation of `spi_data` down. OOM errors are less likely,
hence it won't hurt to check that late. OTOH, it simplifies error
handling when we separate init parts that require dynamic resources
from those that don't.

Change-Id: Ibfc35832e71eb05571801216763af238c1dfd1eb
Signed-off-by: Nico Huber <nico.h@gmx.de>
Reviewed-on: https://review.coreboot.org/c/flashrom-stable/+/73575
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
1 file changed
tree: 2cbb632fdc8a674b09f74d9b68e85d54508c9c9a
  1. Documentation/
  2. include/
  3. Makefile.d/
  4. platform/
  5. util/
  6. .gitattributes
  7. .gitignore
  8. 82802ab.c
  9. amd_imc.c
  10. amd_spi100.c
  11. at45db.c
  12. atahpt.c
  13. atapromise.c
  14. atavia.c
  15. bitbang_spi.c
  16. board_enable.c
  17. buspirate_spi.c
  18. cbtable.c
  19. ch341a_spi.c
  20. ch347_spi.c
  21. chipset_enable.c
  22. cli_classic.c
  23. cli_common.c
  24. cli_output.c
  25. COPYING
  26. custom_baud.c
  27. custom_baud_darwin.c
  28. custom_baud_linux.c
  29. dediprog.c
  30. developerbox_spi.c
  31. digilent_spi.c
  32. dirtyjtag_spi.c
  33. dmi.c
  34. Doxyfile
  35. drkaiser.c
  36. dummyflasher.c
  37. edi.c
  38. en29lv640b.c
  39. flashchips.c
  40. flashrom.8.tmpl
  41. flashrom.c
  42. fmap.c
  43. ft2232_spi.c
  44. gfxnvidia.c
  45. helpers.c
  46. helpers_fileio.c
  47. hwaccess_physmap.c
  48. hwaccess_x86_io.c
  49. hwaccess_x86_msr.c
  50. ich_descriptors.c
  51. ichspi.c
  52. internal.c
  53. it8212.c
  54. it87spi.c
  55. jedec.c
  56. jlink_spi.c
  57. known_boards.c
  58. layout.c
  59. libflashrom.c
  60. libflashrom.map
  61. linux_gpio_spi.c
  62. linux_mtd.c
  63. linux_spi.c
  64. Makefile
  65. Makefile.include
  66. mcp6x_spi.c
  67. meson.build
  68. meson_options.txt
  69. mstarddc_spi.c
  70. ni845x_spi.c
  71. nic3com.c
  72. nicintel.c
  73. nicintel_eeprom.c
  74. nicintel_spi.c
  75. nicnatsemi.c
  76. nicrealtek.c
  77. ogp_spi.c
  78. opaque.c
  79. parallel.c
  80. pcidev.c
  81. pickit2_spi.c
  82. pony_spi.c
  83. print.c
  84. print_wiki.c
  85. processor_enable.c
  86. programmer.c
  87. programmer_table.c
  88. rayer_spi.c
  89. README
  90. satamv.c
  91. satasii.c
  92. sb600spi.c
  93. serial.c
  94. serprog.c
  95. sfdp.c
  96. spi.c
  97. spi25.c
  98. spi25_statusreg.c
  99. spi95.c
  100. sst28sf040.c
  101. sst49lfxxxc.c
  102. sst_fwhub.c
  103. stlinkv3_spi.c
  104. stm50.c
  105. test_build.sh
  106. udelay.c
  107. usbblaster_spi.c
  108. usbdev.c
  109. w29ee011.c
  110. w39.c
  111. wbsio_spi.c
  112. writeprotect.c
  113. writeprotect_ranges.c