Gitiles
Code Review Sign In
review.sourcearcade.org / flashprog / 251e3cd04c311812cb81d8d96c95a392653e38c8
commit251e3cd04c311812cb81d8d96c95a392653e38c8[log] [tgz]
authorDaniel Campello <campello@chromium.org>Wed Mar 16 07:05:48 2022 -0600
committerNico Huber <nico.h@gmx.de>Thu Jan 05 16:35:01 2023 +0000
tree82811c929de9540f849faaafa474e4805bebd40d
parent29c23dd08474b2457ffd8a72ee3d8587676cd999 [diff]
helpers.c: use unsigned int for bit shifts (ASAN)

This change addresses the following ASAN error detected in the chromium
tree:

 * ASAN error detected:
 * ../flashrom-9999/helpers.c:28:13: runtime error: left shift of 1 by 31 places cannot be represented in type 'int'
 *     #0 0x5589a94bb284 in address_to_bits /build/amd64-generic/tmp/portage/sys-apps/flashrom-9999/work/flashrom-9999-build/../flashrom-9999/helpers.c:28:13
 *
 * SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior ../flashrom-9999/helpers.c:28:13 in

Tested: ./test_build.sh; FEATURES=test emerge-amd64-generic flashrom

Signed-off-by: Daniel Campello <campello@chromium.org>
Change-Id: Ib595f13c29dd5c0775e074801756e4f920b4daaf
Original-Reviewed-on: https://review.coreboot.org/c/flashrom/+/62862
Original-Reviewed-by: Anastasia Klimchuk <aklm@chromium.org>
Original-Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Original-Reviewed-by: Edward O'Callaghan <quasisec@chromium.org>
Original-Reviewed-by: Paul Menzel <paulepanter@mailbox.org>
Reviewed-on: https://review.coreboot.org/c/flashrom-stable/+/71449
Reviewed-by: Nico Huber <nico.h@gmx.de>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
1 file changed
tree: 82811c929de9540f849faaafa474e4805bebd40d
  1. Documentation/
  2. util/
  3. .gitattributes
  4. .gitignore
  5. 82802ab.c
  6. amd_imc.c
  7. archtest.c
  8. at45db.c
  9. atahpt.c
  10. atapromise.c
  11. atavia.c
  12. bitbang_spi.c
  13. board_enable.c
  14. buspirate_spi.c
  15. cbtable.c
  16. ch341a_spi.c
  17. chipdrivers.h
  18. chipset_enable.c
  19. cli_classic.c
  20. cli_common.c
  21. cli_output.c
  22. COPYING
  23. coreboot_tables.h
  24. custom_baud.c
  25. custom_baud.h
  26. custom_baud_linux.c
  27. dediprog.c
  28. developerbox_spi.c
  29. digilent_spi.c
  30. dmi.c
  31. Doxyfile
  32. drkaiser.c
  33. dummyflasher.c
  34. edi.c
  35. edi.h
  36. en29lv640b.c
  37. endiantest.c
  38. ene.h
  39. flash.h
  40. flashchips.c
  41. flashchips.h
  42. flashrom.8.tmpl
  43. flashrom.c
  44. fmap.c
  45. fmap.h
  46. ft2232_spi.c
  47. gfxnvidia.c
  48. helpers.c
  49. hwaccess.c
  50. hwaccess.h
  51. ich_descriptors.c
  52. ich_descriptors.h
  53. ichspi.c
  54. internal.c
  55. it8212.c
  56. it85spi.c
  57. it87spi.c
  58. jedec.c
  59. jlink_spi.c
  60. layout.c
  61. layout.h
  62. libflashrom.c
  63. libflashrom.h
  64. libflashrom.map
  65. linux_mtd.c
  66. linux_spi.c
  67. Makefile
  68. mcp6x_spi.c
  69. meson.build
  70. meson_options.txt
  71. mstarddc_spi.c
  72. ni845x_spi.c
  73. nic3com.c
  74. nicintel.c
  75. nicintel_eeprom.c
  76. nicintel_spi.c
  77. nicnatsemi.c
  78. nicrealtek.c
  79. ogp_spi.c
  80. opaque.c
  81. os.h
  82. pcidev.c
  83. physmap.c
  84. pickit2_spi.c
  85. platform.h
  86. pony_spi.c
  87. print.c
  88. print_wiki.c
  89. processor_enable.c
  90. programmer.c
  91. programmer.h
  92. programmer_table.c
  93. rayer_spi.c
  94. README
  95. satamv.c
  96. satasii.c
  97. sb600spi.c
  98. serial.c
  99. serprog.c
  100. sfdp.c
  101. spi.c
  102. spi.h
  103. spi25.c
  104. spi25_statusreg.c
  105. spi95.c
  106. sst28sf040.c
  107. sst49lfxxxc.c
  108. sst_fwhub.c
  109. stlinkv3_spi.c
  110. stm50.c
  111. test_build.sh
  112. udelay.c
  113. usbblaster_spi.c
  114. usbdev.c
  115. w29ee011.c
  116. w39.c
  117. wbsio_spi.c
  118. writeprotect.c
  119. writeprotect.h
  120. writeprotect_ranges.c