Gitiles
Code Review Sign In
review.sourcearcade.org / flashprog / 1c091d1aebb055149c89f88fd5766ca4e33b7b3e
commit1c091d1aebb055149c89f88fd5766ca4e33b7b3e[log] [tgz]
authorJacob Garber <jgarber1@ualberta.ca>Mon Aug 12 11:14:14 2019 -0600
committerNico Huber <nico.h@gmx.de>Tue Sep 24 19:02:48 2019 +0000
tree1ca7c754bcaaf1b9e8150af14af58a8a609838bf
parent15f539c8c978e002f2b6397a7a74e1af817d5cb3 [diff]
internal: Fix board vendor and model memory leaks

The board vendor and model are sometimes specified as arguments during
an internal flash, so make sure they are freed at the end of
initialization.

Change-Id: I9f43708f3b075896be67acec114bc6f390f8c6ca
Signed-off-by: Jacob Garber <jgarber1@ualberta.ca>
Found-by: Coverity CID 1230664, 1230665
Reviewed-on: https://review.coreboot.org/c/flashrom/+/34846
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: David Hendricks <david.hendricks@gmail.com>
3 files changed
tree: 1ca7c754bcaaf1b9e8150af14af58a8a609838bf
  1. Documentation/
  2. util/
  3. .gitattributes
  4. .gitignore
  5. 82802ab.c
  6. amd_imc.c
  7. archtest.c
  8. at45db.c
  9. atahpt.c
  10. atapromise.c
  11. atavia.c
  12. bitbang_spi.c
  13. board_enable.c
  14. buspirate_spi.c
  15. cbtable.c
  16. ch341a_spi.c
  17. chipdrivers.h
  18. chipset_enable.c
  19. cli_classic.c
  20. cli_common.c
  21. cli_output.c
  22. COPYING
  23. coreboot_tables.h
  24. custom_baud.c
  25. custom_baud.h
  26. dediprog.c
  27. developerbox_spi.c
  28. digilent_spi.c
  29. dmi.c
  30. Doxyfile
  31. drkaiser.c
  32. dummyflasher.c
  33. edi.c
  34. edi.h
  35. en29lv640b.c
  36. endiantest.c
  37. ene.h
  38. flash.h
  39. flashchips.c
  40. flashchips.h
  41. flashrom.8.tmpl
  42. flashrom.c
  43. fmap.c
  44. fmap.h
  45. ft2232_spi.c
  46. gfxnvidia.c
  47. helpers.c
  48. hwaccess.c
  49. hwaccess.h
  50. ich_descriptors.c
  51. ich_descriptors.h
  52. ichspi.c
  53. internal.c
  54. it8212.c
  55. it85spi.c
  56. it87spi.c
  57. jedec.c
  58. jlink_spi.c
  59. layout.c
  60. layout.h
  61. libflashrom.c
  62. libflashrom.h
  63. libflashrom.map
  64. linux_mtd.c
  65. linux_spi.c
  66. Makefile
  67. mcp6x_spi.c
  68. meson.build
  69. meson_options.txt
  70. mstarddc_spi.c
  71. nic3com.c
  72. nicintel.c
  73. nicintel_eeprom.c
  74. nicintel_spi.c
  75. nicnatsemi.c
  76. nicrealtek.c
  77. ogp_spi.c
  78. opaque.c
  79. os.h
  80. pcidev.c
  81. physmap.c
  82. pickit2_spi.c
  83. platform.h
  84. pony_spi.c
  85. print.c
  86. print_wiki.c
  87. processor_enable.c
  88. programmer.c
  89. programmer.h
  90. rayer_spi.c
  91. README
  92. satamv.c
  93. satasii.c
  94. sb600spi.c
  95. serial.c
  96. serprog.c
  97. serprog.h
  98. sfdp.c
  99. spi.c
  100. spi.h
  101. spi25.c
  102. spi25_statusreg.c
  103. sst28sf040.c
  104. sst49lfxxxc.c
  105. sst_fwhub.c
  106. stm50.c
  107. udelay.c
  108. usbblaster_spi.c
  109. usbdev.c
  110. w29ee011.c
  111. w39.c
  112. wbsio_spi.c