Gitiles
Code Review Sign In
review.sourcearcade.org / flashprog / 0ea99f57c9d8fe28600cd08f653c10e5c0c0dd3f
commit0ea99f57c9d8fe28600cd08f653c10e5c0c0dd3f[log] [tgz]
authorNico Huber <nico.huber@secunet.com>Fri Mar 17 17:22:53 2017 +0100
committerNico Huber <nico.h@gmx.de>Tue Apr 25 18:53:50 2017 +0200
treedda8ea443bd14845e927838fa2e27fba61761584
parentb4d8a2a64b72d65e447161179279c108709c0ac3 [diff]
Move register decodes into enable_flash_ich_handle_gcs()

GCS was decoded partly inside, partly outside this function. The
decoding of `top_swap` was off, since passing a `uint8_t` as `bool`
doesn't magically check bit0 only.

While we are at it, rename this void function to enable_flash_ich_
report_gcs() as it's not doing anything. Beside debug output it
doesn't have any side effects.

Change-Id: I40addec98cb6840763adad30f9d0e27dadce6d1e
Signed-off-by: Nico Huber <nico.huber@secunet.com>
Reviewed-on: https://review.coreboot.org/18882
Tested-by: build bot (Jenkins)
Reviewed-by: Philippe Mathieu-Daudé <philippe.mathieu.daude@gmail.com>
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-by: Youness Alaoui <snifikino@gmail.com>
1 file changed
tree: dda8ea443bd14845e927838fa2e27fba61761584
  1. Documentation/
  2. util/
  3. 82802ab.c
  4. amd_imc.c
  5. archtest.c
  6. at45db.c
  7. atahpt.c
  8. atapromise.c
  9. atavia.c
  10. bitbang_spi.c
  11. board_enable.c
  12. buspirate_spi.c
  13. cbtable.c
  14. ch341a_spi.c
  15. chipdrivers.h
  16. chipset_enable.c
  17. cli_classic.c
  18. cli_common.c
  19. cli_output.c
  20. COPYING
  21. coreboot_tables.h
  22. dediprog.c
  23. dmi.c
  24. drkaiser.c
  25. dummyflasher.c
  26. en29lv640b.c
  27. flash.h
  28. flashchips.c
  29. flashchips.h
  30. flashrom.8.tmpl
  31. flashrom.c
  32. ft2232_spi.c
  33. gfxnvidia.c
  34. helpers.c
  35. hwaccess.c
  36. hwaccess.h
  37. ich_descriptors.c
  38. ich_descriptors.h
  39. ichspi.c
  40. internal.c
  41. it8212.c
  42. it85spi.c
  43. it87spi.c
  44. jedec.c
  45. layout.c
  46. linux_spi.c
  47. Makefile
  48. mcp6x_spi.c
  49. mstarddc_spi.c
  50. nic3com.c
  51. nicintel.c
  52. nicintel_eeprom.c
  53. nicintel_spi.c
  54. nicnatsemi.c
  55. nicrealtek.c
  56. ogp_spi.c
  57. opaque.c
  58. os.h
  59. pcidev.c
  60. physmap.c
  61. pickit2_spi.c
  62. platform.h
  63. pony_spi.c
  64. print.c
  65. print_wiki.c
  66. processor_enable.c
  67. programmer.c
  68. programmer.h
  69. rayer_spi.c
  70. README
  71. satamv.c
  72. satasii.c
  73. sb600spi.c
  74. serial.c
  75. serprog.c
  76. serprog.h
  77. sfdp.c
  78. spi.c
  79. spi.h
  80. spi25.c
  81. spi25_statusreg.c
  82. sst28sf040.c
  83. sst49lfxxxc.c
  84. sst_fwhub.c
  85. stm50.c
  86. udelay.c
  87. usbblaster_spi.c
  88. w29ee011.c
  89. w39.c
  90. wbsio_spi.c