Gitiles
Code Review Sign In
review.sourcearcade.org / flashprog / 01d6aba25193552f832fc0309b6bfb63a48f7a1f
commit01d6aba25193552f832fc0309b6bfb63a48f7a1f[log] [tgz]
authorCarl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>Fri Jun 12 14:02:07 2009 +0000
committerCarl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>Fri Jun 12 14:02:07 2009 +0000
treeaa97f1646cc8c4183e8329d94ce43c05c89ddb8d
parente33890dcad645b06c31eaec4525873cbfe98dfbc [diff]
Flashrom does not honor argument ordering for operations

Not only does this violate the principle of least surprise, it also
caused one bug where -Ewv was specified and the flash ended up being
empty.

Support only one operation at a time. As a side benefit, this allows us
to clean up main() quite a bit.

Corresponding to flashrom svn r585.

Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
2 files changed
tree: aa97f1646cc8c4183e8329d94ce43c05c89ddb8d
  1. 82802ab.c
  2. am29f040b.c
  3. board_enable.c
  4. cbtable.c
  5. chipset_enable.c
  6. COPYING
  7. coreboot_tables.h
  8. dummyflasher.c
  9. en29f002a.c
  10. flash.h
  11. flashchips.c
  12. flashrom.8
  13. flashrom.c
  14. ichspi.c
  15. internal.c
  16. it87spi.c
  17. jedec.c
  18. layout.c
  19. m29f002.c
  20. m29f400bt.c
  21. Makefile
  22. mx29f002.c
  23. nic3com.c
  24. pcidev.c
  25. physmap.c
  26. pm49fl00x.c
  27. README
  28. satasii.c
  29. sb600spi.c
  30. sharplhf00l04.c
  31. spi.c
  32. spi.h
  33. sst28sf040.c
  34. sst49lf040.c
  35. sst49lfxxxc.c
  36. sst_fwhub.c
  37. stm50flw0x0x.c
  38. udelay.c
  39. w29ee011.c
  40. w39v040c.c
  41. w39v080fa.c
  42. w49f002u.c
  43. wbsio_spi.c