Fix memleaks due to incorrect usage of flashbuses_to_text
Corresponding to flashrom svn r1357.
Signed-off-by: Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at>
Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
diff --git a/print.c b/print.c
index 28c0e18..b9f7a43 100644
--- a/print.c
+++ b/print.c
@@ -28,7 +28,7 @@
/*
* Return a string corresponding to the bustype parameter.
- * Memory is obtained with malloc() and can be freed with free().
+ * Memory is obtained with malloc() and must be freed with free() by the caller.
*/
char *flashbuses_to_text(enum chipbustype bustype)
{
@@ -80,6 +80,7 @@
int maxvendorlen = strlen("Vendor") + 1;
int maxchiplen = strlen("Device") + 1;
const struct flashchip *f;
+ char *s;
for (f = flashchips; f->name != NULL; f++) {
/* Ignore "unknown XXXX SPI chip" entries. */
@@ -152,7 +153,10 @@
msg_ginfo("%d", f->total_size);
for (i = 0; i < 10 - digits(f->total_size); i++)
msg_ginfo(" ");
- msg_ginfo("%s\n", flashbuses_to_text(f->bustype));
+
+ s = flashbuses_to_text(f->bustype);
+ msg_ginfo("%s\n", s);
+ free(s);
}
}