)]}'
{"common/haswell_shared/hw-gfx-gma-connectors-ddi.adb":[{"author":{"_account_id":1000029,"name":"Ada SPARK","email":"gnatbot@sourcearcade.org","username":"gnatbot","avatars":[{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"0f37c699792e80e7a83d564455c6038d9d491c19","unresolved":false,"context_lines":[{"line_number":573,"context_line":""},{"line_number":574,"context_line":"         PCH.FDI.Auto_Train (PCH.FDI_A);"},{"line_number":575,"context_line":"         Registers.Is_Set_Mask"},{"line_number":576,"context_line":"           (Register \u003d\u003e DDI_Regs (DIGI_E).DP_TP_STATUS,"},{"line_number":577,"context_line":"            Mask     \u003d\u003e DP_TP_STATUS_FDI_AUTO_TRAIN_DONE,"},{"line_number":578,"context_line":"            Result   \u003d\u003e Success);"},{"line_number":579,"context_line":"         exit when Success;"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"fba0f972_cea86817","line":576,"updated":"2026-07-03 11:04:03.000000000","message":"Config(s): haswell\n```\nhw-gfx-gma-connectors-ddi.adb:576: medium: range check might fail\n  576 |           (Register \u003d\u003e DDI_Regs (DIGI_E).DP_TP_STATUS,\n      |                                         ^ here\n  reason for check: input value must fit in parameter type\n```","commit_id":"3978e4c65197bb03641bb538677d07b287f35ea7"},{"author":{"_account_id":1000029,"name":"Ada SPARK","email":"gnatbot@sourcearcade.org","username":"gnatbot","avatars":[{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"fc397ca2471a4a4de1bf34f7adc1837e3ccbbd62","unresolved":false,"context_lines":[{"line_number":573,"context_line":""},{"line_number":574,"context_line":"         PCH.FDI.Auto_Train (PCH.FDI_A);"},{"line_number":575,"context_line":"         Registers.Is_Set_Mask"},{"line_number":576,"context_line":"           (Register \u003d\u003e DDI_Regs (DIGI_E).DP_TP_STATUS,"},{"line_number":577,"context_line":"            Mask     \u003d\u003e DP_TP_STATUS_FDI_AUTO_TRAIN_DONE,"},{"line_number":578,"context_line":"            Result   \u003d\u003e Success);"},{"line_number":579,"context_line":"         exit when Success;"}],"source_content_type":"application/octet-stream","patch_set":12,"id":"04a5dbe2_0d57f771","line":576,"updated":"2026-07-29 12:24:06.000000000","message":"Config(s): haswell\n```\nhw-gfx-gma-connectors-ddi.adb:576: medium: range check might fail\n  576 |           (Register \u003d\u003e DDI_Regs (DIGI_E).DP_TP_STATUS,\n      |                                         ^ here\n  reason for check: input value must fit in parameter type\n```","commit_id":"db46bbbac7f57a3e76b1ec4e2522bb273e16cf6e"}],"common/hw-gfx-gma-pipe_setup.adb":[{"author":{"_account_id":1000029,"name":"Ada SPARK","email":"gnatbot@sourcearcade.org","username":"gnatbot","avatars":[{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"6ff5c44ecc342f34a126e584f548ac48b148af06","unresolved":false,"context_lines":[{"line_number":1095,"context_line":"      Update_Cursor (Pipe, Pipe_Cfg.Framebuffer, Default_Cursor);"},{"line_number":1096,"context_line":""},{"line_number":1097,"context_line":"      Setup_Display (Controllers (Pipe), Pipe_Cfg.Framebuffer, Mode.BPC, Dither);"},{"line_number":1098,"context_line":"      Setup_Scaling (Controllers (Pipe), Pipe_Cfg, Mode);"},{"line_number":1099,"context_line":"   end Setup_FB;"},{"line_number":1100,"context_line":""},{"line_number":1101,"context_line":"   procedure On"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"7cbea7eb_260781da","line":1098,"updated":"2026-07-02 14:22:29.000000000","message":"Config(s): i945\n```\nhw-gfx-gma-pipe_setup.adb:1098: medium: precondition might fail, cannot prove Rotated_Height (Pipe_Cfg.Framebuffer) \u003c\u003d Mode.V_Visible\n 1098 |      Setup_Scaling (Controllers (Pipe), Pipe_Cfg, Mode);\n      |      ^ here\n```","commit_id":"8e3b79a6e38a9f86d73c15541ab5140bc98e302f"},{"author":{"_account_id":1000029,"name":"Ada SPARK","email":"gnatbot@sourcearcade.org","username":"gnatbot","avatars":[{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"0f37c699792e80e7a83d564455c6038d9d491c19","unresolved":false,"context_lines":[{"line_number":165,"context_line":""},{"line_number":166,"context_line":"   function Encode_Size (LSW, MSW : Int32) return Word32"},{"line_number":167,"context_line":"   is"},{"line_number":168,"context_line":"     (Shift_Left (Word32 (MSW) - 1, 16) or (Word32 (LSW) - 1));"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"   function Source_Width (Framebuffer : Framebuffer_Type) return Int32"},{"line_number":171,"context_line":"   is"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"c434ead7_3c97e43a","line":168,"updated":"2026-07-03 11:04:03.000000000","message":"Config(s): haswell tigerlake ironlake g45 skylake i945 ironlake_edp alderlake broxton\n```\nhw-gfx-gma-pipe_setup.adb:168: medium: range check might fail\n  168 |     (Shift_Left (Word32 (MSW) - 1, 16) or (Word32 (LSW) - 1));\n      |                          ^ here\n  e.g. when LSW \u003d 0\n        and MSW \u003d -1\n  reason for check: value must be convertible to the target type of the conversion\n  possible fix: subprogram at line 166 should mention MSW in a precondition\n  166 |   function Encode_Size (LSW, MSW : Int32) return Word32\n      |   ^ here\n```\nConfig(s): i945 skylake haswell g45 ironlake ironlake_edp broxton tigerlake alderlake\n```\nhw-gfx-gma-pipe_setup.adb:168: medium: range check might fail\n  168 |     (Shift_Left (Word32 (MSW) - 1, 16) or (Word32 (LSW) - 1));\n      |                                                    ^ here\n  e.g. when LSW \u003d -1\n  reason for check: value must be convertible to the target type of the conversion\n  possible fix: subprogram at line 166 should mention LSW in a precondition\n  166 |   function Encode_Size (LSW, MSW : Int32) return Word32\n      |   ^ here\n```","commit_id":"3978e4c65197bb03641bb538677d07b287f35ea7"},{"author":{"_account_id":1000029,"name":"Ada SPARK","email":"gnatbot@sourcearcade.org","username":"gnatbot","avatars":[{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"0f37c699792e80e7a83d564455c6038d9d491c19","unresolved":false,"context_lines":[{"line_number":330,"context_line":""},{"line_number":331,"context_line":"         if Config.Has_DSP_Linoff and then FB.Tiling \u003d Linear then"},{"line_number":332,"context_line":"            pragma Assert_And_Cut"},{"line_number":333,"context_line":"              (FB.Start_Y * FB.Stride + FB.Start_X in Pixel_Type);"},{"line_number":334,"context_line":"            declare"},{"line_number":335,"context_line":"               Linear_Offset : constant Pixel_Type :\u003d"},{"line_number":336,"context_line":"                  FB.Start_Y * FB.Stride + FB.Start_X;"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"efc63b1d_d1e0fdfc","line":333,"updated":"2026-07-03 11:04:03.000000000","message":"Config(s): i945\n```\nhw-gfx-gma-pipe_setup.adb:333: medium: assertion might fail, cannot prove FB.Start_Y * FB.Stride + FB.Start_X in Pixel_Type\n  333 |              (FB.Start_Y * FB.Stride + FB.Start_X in Pixel_Type);\n      |               ^ here\n```","commit_id":"3978e4c65197bb03641bb538677d07b287f35ea7"},{"author":{"_account_id":1000029,"name":"Ada SPARK","email":"gnatbot@sourcearcade.org","username":"gnatbot","avatars":[{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"0f37c699792e80e7a83d564455c6038d9d491c19","unresolved":false,"context_lines":[{"line_number":548,"context_line":"      Controller : Controller_Type renames Controllers (Pipe);"},{"line_number":549,"context_line":""},{"line_number":550,"context_line":"      Width : constant Width_Type :\u003d Cursor_Width (Cursor.Size);"},{"line_number":551,"context_line":"      Surface_Width : constant Width_Type :\u003d Source_Width (FB);"},{"line_number":552,"context_line":"      Surface_Height : constant Height_Type :\u003d Source_Height (FB);"},{"line_number":553,"context_line":""},{"line_number":554,"context_line":"      -- Like `Cursor_Pos`/`Cursor_Coord` but allowing wider range for proof."}],"source_content_type":"application/octet-stream","patch_set":4,"id":"20250559_fe068fa7","line":551,"updated":"2026-07-03 11:04:03.000000000","message":"Config(s): alderlake tigerlake\n```\nhw-gfx-gma-pipe_setup.adb:551: medium: range check might fail\n  551 |      Surface_Width : constant Width_Type :\u003d Source_Width (FB);\n      |                                             ^ here\n  e.g. when FB.Width \u003d 64\n        and FB.Height \u003d 1\n        and FB.Stride \u003d 16\n        and FB.V_Stride \u003d 1\n        and FB.Rotation \u003d Rotated_90\n  reason for check: default component value must fit in the type\n  possible fix: subprogram at hw-gfx-gma-pipe_setup.ads:47 should mention FB in a precondition\n   47 |   procedure Place_Cursor\n      |   ^ here\n```","commit_id":"3978e4c65197bb03641bb538677d07b287f35ea7"},{"author":{"_account_id":1000029,"name":"Ada SPARK","email":"gnatbot@sourcearcade.org","username":"gnatbot","avatars":[{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"0f37c699792e80e7a83d564455c6038d9d491c19","unresolved":false,"context_lines":[{"line_number":711,"context_line":"      Post \u003d\u003e"},{"line_number":712,"context_line":"         Width \u003c\u003d Max_Width and Height \u003c\u003d Max_Height"},{"line_number":713,"context_line":"   is"},{"line_number":714,"context_line":"      Src_Width : constant Width_Type :\u003d Source_Width (Framebuffer);"},{"line_number":715,"context_line":"      Src_Height : constant Height_Type :\u003d Source_Height (Framebuffer);"},{"line_number":716,"context_line":"   begin"},{"line_number":717,"context_line":"      case Scaling_Type (Src_Width, Src_Height, Max_Width, Max_Height) is"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"ff093e82_861551a7","line":714,"updated":"2026-07-03 11:04:03.000000000","message":"Config(s): tigerlake\n```\nhw-gfx-gma-pipe_setup.adb:714: medium: range check might fail\n  714 |      Src_Width : constant Width_Type :\u003d Source_Width (Framebuffer);\n      |                                         ^ here\n  e.g. when Framebuffer.Width \u003d 1\n        and Framebuffer.Height \u003d 1\n      make[1]: Entering directory \u0027/home/gnatbot/libgfxinit\u0027\n    GENERATE   common/hw-gfx-gma-config.ads\n    GENERATE   gfxinit_ironlake.gpr\n```\nConfig(s): alderlake\n```\nhw-gfx-gma-pipe_setup.adb:714: medium: range check might fail\n  714 |      Src_Width : constant Width_Type :\u003d Source_Width (Framebuffer);\n      |                                         ^ here\n  e.g. when Framebuffer.Width \u003d 1\n        and Framebuffer.Height \u003d 1\n      make[1]: Entering directory \u0027/home/gnatbot/libgfxinit\u0027\n    GENERATE   common/hw-gfx-gma-config.ads\n    GENERATE   gfxinit_i945.gpr\n```","commit_id":"3978e4c65197bb03641bb538677d07b287f35ea7"},{"author":{"_account_id":1000029,"name":"Ada SPARK","email":"gnatbot@sourcearcade.org","username":"gnatbot","avatars":[{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"0f37c699792e80e7a83d564455c6038d9d491c19","unresolved":false,"context_lines":[{"line_number":717,"context_line":"      case Scaling_Type (Src_Width, Src_Height, Max_Width, Max_Height) is"},{"line_number":718,"context_line":"         when Letterbox \u003d\u003e"},{"line_number":719,"context_line":"            Height :\u003d (Src_Height * Max_Width) / Src_Width;"},{"line_number":720,"context_line":"            pragma Assert (Height \u003c\u003d Max_Height);"},{"line_number":721,"context_line":"            Width  :\u003d Max_Width;"},{"line_number":722,"context_line":"         when Pillarbox \u003d\u003e"},{"line_number":723,"context_line":"            Width  :\u003d (Src_Width * Max_Height) / Src_Height;"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"168a9e07_653745cf","line":720,"updated":"2026-07-03 11:04:03.000000000","message":"Config(s): broxton alderlake tigerlake i945 ironlake_edp g45 skylake ironlake haswell\n```\nhw-gfx-gma-pipe_setup.adb:720: medium: assertion might fail, cannot prove Height \u003c\u003d Max_Height\n  720 |            pragma Assert (Height \u003c\u003d Max_Height);\n      |                           ^ here\n```","commit_id":"3978e4c65197bb03641bb538677d07b287f35ea7"},{"author":{"_account_id":1000029,"name":"Ada SPARK","email":"gnatbot@sourcearcade.org","username":"gnatbot","avatars":[{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"0f37c699792e80e7a83d564455c6038d9d491c19","unresolved":false,"context_lines":[{"line_number":748,"context_line":"   begin"},{"line_number":749,"context_line":"      case Scaling is"},{"line_number":750,"context_line":"         when None \u003d\u003e"},{"line_number":751,"context_line":"            Width  :\u003d Source_Width (Framebuffer);"},{"line_number":752,"context_line":"            Height :\u003d Source_Height (Framebuffer);"},{"line_number":753,"context_line":"         when Keep_Aspect \u003d\u003e"},{"line_number":754,"context_line":"            Scale_Keep_Aspect (Width, Height, Max_Width, Max_Height, Framebuffer);"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"f328e60b_772fbbd6","line":751,"updated":"2026-07-03 11:04:03.000000000","message":"Config(s): tigerlake alderlake\n```\nhw-gfx-gma-pipe_setup.adb:751: medium: range check might fail\n  751 |            Width  :\u003d Source_Width (Framebuffer);\n      |                      ^ here\n  e.g. when Framebuffer.Width \u003d 1\n        and Framebuffer.Height \u003d 1\n        and Framebuffer.Stride \u003d 1\n        and Framebuffer.V_Stride \u003d 1\n        and Framebuffer.Rotation \u003d Rotated_90\n  reason for check: value must fit in the target type of the assignment\n```","commit_id":"3978e4c65197bb03641bb538677d07b287f35ea7"},{"author":{"_account_id":1000029,"name":"Ada SPARK","email":"gnatbot@sourcearcade.org","username":"gnatbot","avatars":[{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"0f37c699792e80e7a83d564455c6038d9d491c19","unresolved":false,"context_lines":[{"line_number":846,"context_line":"         Rotated_Width (Pipe_Cfg.Framebuffer) \u003c\u003d Mode.H_Visible and"},{"line_number":847,"context_line":"         Rotated_Height (Pipe_Cfg.Framebuffer) \u003c\u003d Mode.V_Visible"},{"line_number":848,"context_line":"   is"},{"line_number":849,"context_line":"      Width_In    : constant Width_Type   :\u003d Source_Width (Pipe_Cfg.Framebuffer);"},{"line_number":850,"context_line":"      Height_In   : constant Height_Type  :\u003d Source_Height (Pipe_Cfg.Framebuffer);"},{"line_number":851,"context_line":"      Limits      : constant Pipe_Scaler_Limit_Config :\u003d"},{"line_number":852,"context_line":"        (if Config.Has_Skylake_Scaler_Limits then"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"372026df_2f5bbc17","line":849,"updated":"2026-07-03 11:04:03.000000000","message":"Config(s): alderlake tigerlake\n```\nhw-gfx-gma-pipe_setup.adb:849: medium: range check might fail\n  849 |      Width_In    : constant Width_Type   :\u003d Source_Width (Pipe_Cfg.Framebuffer);\n      |                                             ^ here\n  e.g. when Pipe_Cfg.Framebuffer.Width \u003d 1\n        and Pipe_Cfg.Framebuffer.Height \u003d 1\n        and Pipe_Cfg.Framebuffer.Stride \u003d 1\n        and Pipe_Cfg.Framebuffer.V_Stride \u003d 1\n        and Pipe_Cfg.Framebuffer.Rotation \u003d Rotated_90\n  reason for check: default component value must fit in the type\n```","commit_id":"3978e4c65197bb03641bb538677d07b287f35ea7"},{"author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"c913355f77693228b8a08201d1927a2f49ead368","unresolved":true,"context_lines":[{"line_number":576,"context_line":"               when Rotated_90   \u003d\u003e Center.X,"},{"line_number":577,"context_line":"               when Rotated_180  \u003d\u003e FB.Height   - 1 - Center.Y,"},{"line_number":578,"context_line":"               when Rotated_270  \u003d\u003e FB.Width    - 1 - Center.X));"},{"line_number":579,"context_line":""},{"line_number":580,"context_line":"      function Phys_Origin (Center : Cursor_Coord) return Relaxed_Coord is"},{"line_number":581,"context_line":"        (X \u003d\u003e Rotate (Center).X - Width / 2,"},{"line_number":582,"context_line":"         Y \u003d\u003e Rotate (Center).Y - Width / 2);"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"b6431b9e_5c4721c4","line":579,"updated":"2026-07-06 08:48:46.000000000","message":"Calculates the coordinates of the cursor plane\u0027s upper left corner on the screen / pipe input / bigger plane.","commit_id":"6f0253161c949015adf0f5768b557d34a3509dc2"},{"author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"4474a0f9775f11a201e5f8f1b11b584e91336673","unresolved":false,"context_lines":[{"line_number":576,"context_line":"               when Rotated_90   \u003d\u003e Center.X,"},{"line_number":577,"context_line":"               when Rotated_180  \u003d\u003e FB.Height   - 1 - Center.Y,"},{"line_number":578,"context_line":"               when Rotated_270  \u003d\u003e FB.Width    - 1 - Center.X));"},{"line_number":579,"context_line":""},{"line_number":580,"context_line":"      function Phys_Origin (Center : Cursor_Coord) return Relaxed_Coord is"},{"line_number":581,"context_line":"        (X \u003d\u003e Rotate (Center).X - Width / 2,"},{"line_number":582,"context_line":"         Y \u003d\u003e Rotate (Center).Y - Width / 2);"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"947f1d6d_e08a5266","line":579,"in_reply_to":"b6431b9e_5c4721c4","updated":"2026-07-09 08:27:06.000000000","message":"Done","commit_id":"6f0253161c949015adf0f5768b557d34a3509dc2"},{"author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"c913355f77693228b8a08201d1927a2f49ead368","unresolved":true,"context_lines":[{"line_number":613,"context_line":"               Visible_Height : Height_Type  :\u003d Width;"},{"line_number":614,"context_line":"               Offset_X : Word32;"},{"line_number":615,"context_line":"               Offset_Y : Word32;"},{"line_number":616,"context_line":""},{"line_number":617,"context_line":"               function Offset (Pos : Relaxed_Pos; Visible : Int32) return Word32"},{"line_number":618,"context_line":"               is"},{"line_number":619,"context_line":"                 (if (Pos \u003c 0 and FB.Rotation \u003c\u003d Rotated_90) or"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"b451814b_9c71e98c","line":616,"updated":"2026-07-06 08:48:46.000000000","message":"Calculates where to start reading from the cursor plane\u0027s framebuffer, iow.\ngives the first visible pixel of the cursor (e.g. for an unrotated cursor whose\nupper left corner left the screen).","commit_id":"6f0253161c949015adf0f5768b557d34a3509dc2"},{"author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"4474a0f9775f11a201e5f8f1b11b584e91336673","unresolved":false,"context_lines":[{"line_number":613,"context_line":"               Visible_Height : Height_Type  :\u003d Width;"},{"line_number":614,"context_line":"               Offset_X : Word32;"},{"line_number":615,"context_line":"               Offset_Y : Word32;"},{"line_number":616,"context_line":""},{"line_number":617,"context_line":"               function Offset (Pos : Relaxed_Pos; Visible : Int32) return Word32"},{"line_number":618,"context_line":"               is"},{"line_number":619,"context_line":"                 (if (Pos \u003c 0 and FB.Rotation \u003c\u003d Rotated_90) or"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"78920056_2fe46991","line":616,"in_reply_to":"b451814b_9c71e98c","updated":"2026-07-09 08:27:06.000000000","message":"Done","commit_id":"6f0253161c949015adf0f5768b557d34a3509dc2"},{"author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"c913355f77693228b8a08201d1927a2f49ead368","unresolved":true,"context_lines":[{"line_number":679,"context_line":"            Verbose  \u003d\u003e False);"},{"line_number":680,"context_line":"      else"},{"line_number":681,"context_line":"         -- off-screen cursor needs special care"},{"line_number":682,"context_line":"         if Origin.X \u003c\u003d -Width or Origin.Y \u003c\u003d -Width or"},{"line_number":683,"context_line":"            Origin.X \u003e\u003d Surface_Width or Origin.Y \u003e\u003d Surface_Height or"},{"line_number":684,"context_line":"            Origin.X \u003e Config.Maximum_Cursor_X or Origin.Y \u003e Config.Maximum_Cursor_Y"},{"line_number":685,"context_line":"         then"},{"line_number":686,"context_line":"            Origin.X :\u003d -Width;"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"1baf8393_02ad8723","line":683,"range":{"start_line":682,"start_character":12,"end_line":683,"end_character":67},"updated":"2026-07-06 08:48:46.000000000","message":"`not Visible`?","commit_id":"6f0253161c949015adf0f5768b557d34a3509dc2"},{"author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"4474a0f9775f11a201e5f8f1b11b584e91336673","unresolved":false,"context_lines":[{"line_number":679,"context_line":"            Verbose  \u003d\u003e False);"},{"line_number":680,"context_line":"      else"},{"line_number":681,"context_line":"         -- off-screen cursor needs special care"},{"line_number":682,"context_line":"         if Origin.X \u003c\u003d -Width or Origin.Y \u003c\u003d -Width or"},{"line_number":683,"context_line":"            Origin.X \u003e\u003d Surface_Width or Origin.Y \u003e\u003d Surface_Height or"},{"line_number":684,"context_line":"            Origin.X \u003e Config.Maximum_Cursor_X or Origin.Y \u003e Config.Maximum_Cursor_Y"},{"line_number":685,"context_line":"         then"},{"line_number":686,"context_line":"            Origin.X :\u003d -Width;"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"b5e600c4_a6107dc6","line":683,"range":{"start_line":682,"start_character":12,"end_line":683,"end_character":67},"in_reply_to":"1baf8393_02ad8723","updated":"2026-07-09 08:27:06.000000000","message":"Done","commit_id":"6f0253161c949015adf0f5768b557d34a3509dc2"},{"author":{"_account_id":1000002,"name":"Thomas Heijligen","email":"src@posteo.de","username":"heijligen","avatars":[{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"6b646484b452b5bf39807527aad1d85a4f647839","unresolved":false,"context_lines":[{"line_number":518,"context_line":"      FB       : Framebuffer_Type;"},{"line_number":519,"context_line":"      Cursor   : Cursor_Type)"},{"line_number":520,"context_line":"   is"},{"line_number":521,"context_line":"      Controller : Controller_Type renames Controllers (Pipe);"},{"line_number":522,"context_line":"   begin"},{"line_number":523,"context_line":"      if Use_Plane_For_Cursor (FB) then"},{"line_number":524,"context_line":"         if Config.Has_Plane_Color_Control then"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"a6327610_62ac52cc","line":521,"updated":"2026-07-28 10:29:20.000000000","message":"May throw a Variable unused warning when `Broxton_On` is false. The variable is only used once. I see the pattern with this in the other procedures, so no issue from my side.","commit_id":"d1cada6058f6824fdad481dd3c6ddfd6ae53c521"},{"author":{"_account_id":1000002,"name":"Thomas Heijligen","email":"src@posteo.de","username":"heijligen","avatars":[{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"65cc934ebd24f8cf1d4dc180dfcca351a2c332e0","unresolved":true,"context_lines":[{"line_number":520,"context_line":"   is"},{"line_number":521,"context_line":"      Controller : Controller_Type renames Controllers (Pipe);"},{"line_number":522,"context_line":"   begin"},{"line_number":523,"context_line":"      if Use_Plane_For_Cursor (FB) then"},{"line_number":524,"context_line":"         if Config.Has_Plane_Color_Control then"},{"line_number":525,"context_line":"            Registers.Write"},{"line_number":526,"context_line":"              (Register \u003d\u003e Controller.PLANE_2_COLOR_CTL,"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"9bb878b6_b3b34369","line":523,"updated":"2026-07-28 11:45:53.000000000","message":"What is with platforms that have `Has_Plane_Control` (Broxton_On), but does not have `Has_Plane_Color_Control` (Tigerlake_On)? There the behavior of this function changes.","commit_id":"d1cada6058f6824fdad481dd3c6ddfd6ae53c521"},{"author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"1707029973d92fb888f625c03e04969c1c893a12","unresolved":true,"context_lines":[{"line_number":520,"context_line":"   is"},{"line_number":521,"context_line":"      Controller : Controller_Type renames Controllers (Pipe);"},{"line_number":522,"context_line":"   begin"},{"line_number":523,"context_line":"      if Use_Plane_For_Cursor (FB) then"},{"line_number":524,"context_line":"         if Config.Has_Plane_Color_Control then"},{"line_number":525,"context_line":"            Registers.Write"},{"line_number":526,"context_line":"              (Register \u003d\u003e Controller.PLANE_2_COLOR_CTL,"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"caa0c635_afdbcab4","line":523,"in_reply_to":"9bb878b6_b3b34369","updated":"2026-07-29 12:28:45.000000000","message":"The `not Has_Plane_Color_Control` case is handled inside `Place_Cursor ()`\nbecause the register that used to have the color-control bits is written there.\n\nHandling the `COLOR_CTL` register here is a bit cleaner because we only have\nto write it once.","commit_id":"d1cada6058f6824fdad481dd3c6ddfd6ae53c521"},{"author":{"_account_id":1000002,"name":"Thomas Heijligen","email":"src@posteo.de","username":"heijligen","avatars":[{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"66d6909c33fae9f1f2cf6f345a0c97b1aa3fcbee","unresolved":false,"context_lines":[{"line_number":520,"context_line":"   is"},{"line_number":521,"context_line":"      Controller : Controller_Type renames Controllers (Pipe);"},{"line_number":522,"context_line":"   begin"},{"line_number":523,"context_line":"      if Use_Plane_For_Cursor (FB) then"},{"line_number":524,"context_line":"         if Config.Has_Plane_Color_Control then"},{"line_number":525,"context_line":"            Registers.Write"},{"line_number":526,"context_line":"              (Register \u003d\u003e Controller.PLANE_2_COLOR_CTL,"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"8f300411_6181b04f","line":523,"in_reply_to":"caa0c635_afdbcab4","updated":"2026-07-29 15:19:48.000000000","message":"Acknowledged","commit_id":"d1cada6058f6824fdad481dd3c6ddfd6ae53c521"},{"author":{"_account_id":1000002,"name":"Thomas Heijligen","email":"src@posteo.de","username":"heijligen","avatars":[{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"65cc934ebd24f8cf1d4dc180dfcca351a2c332e0","unresolved":true,"context_lines":[{"line_number":584,"context_line":"         Y \u003d\u003e Rotate (Center).Y - Width / 2);"},{"line_number":585,"context_line":""},{"line_number":586,"context_line":"      function Fully_Visible (Origin : Relaxed_Coord) return Boolean is"},{"line_number":587,"context_line":"        (0 \u003c\u003d Origin.X and Origin.X \u003c Surface_Width - Width and"},{"line_number":588,"context_line":"         0 \u003c\u003d Origin.Y and Origin.Y \u003c Surface_Height - Width);"},{"line_number":589,"context_line":""},{"line_number":590,"context_line":"      Origin : Relaxed_Coord :\u003d Phys_Origin (Center);"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"62846551_a85e9053","line":587,"updated":"2026-07-28 11:45:53.000000000","message":"Use range membership test:\n`Origin.X in 0 .. Surface_Width - Width - 1 and ...`","commit_id":"d1cada6058f6824fdad481dd3c6ddfd6ae53c521"},{"author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"1707029973d92fb888f625c03e04969c1c893a12","unresolved":true,"context_lines":[{"line_number":584,"context_line":"         Y \u003d\u003e Rotate (Center).Y - Width / 2);"},{"line_number":585,"context_line":""},{"line_number":586,"context_line":"      function Fully_Visible (Origin : Relaxed_Coord) return Boolean is"},{"line_number":587,"context_line":"        (0 \u003c\u003d Origin.X and Origin.X \u003c Surface_Width - Width and"},{"line_number":588,"context_line":"         0 \u003c\u003d Origin.Y and Origin.Y \u003c Surface_Height - Width);"},{"line_number":589,"context_line":""},{"line_number":590,"context_line":"      Origin : Relaxed_Coord :\u003d Phys_Origin (Center);"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"97b81fb1_261ef84d","line":587,"in_reply_to":"62846551_a85e9053","updated":"2026-07-29 12:28:45.000000000","message":"Done. I\u0027ve noticed though, that it feels more error-prone because of the off-by-ones.\nBut I\u0027m ok with either version.","commit_id":"d1cada6058f6824fdad481dd3c6ddfd6ae53c521"},{"author":{"_account_id":1000002,"name":"Thomas Heijligen","email":"src@posteo.de","username":"heijligen","avatars":[{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"66d6909c33fae9f1f2cf6f345a0c97b1aa3fcbee","unresolved":true,"context_lines":[{"line_number":584,"context_line":"         Y \u003d\u003e Rotate (Center).Y - Width / 2);"},{"line_number":585,"context_line":""},{"line_number":586,"context_line":"      function Fully_Visible (Origin : Relaxed_Coord) return Boolean is"},{"line_number":587,"context_line":"        (0 \u003c\u003d Origin.X and Origin.X \u003c Surface_Width - Width and"},{"line_number":588,"context_line":"         0 \u003c\u003d Origin.Y and Origin.Y \u003c Surface_Height - Width);"},{"line_number":589,"context_line":""},{"line_number":590,"context_line":"      Origin : Relaxed_Coord :\u003d Phys_Origin (Center);"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"2892f2eb_7155a852","line":587,"in_reply_to":"97b81fb1_261ef84d","updated":"2026-07-29 15:19:48.000000000","message":"I would like to have inclusive/exclusive ranges here, too.\nIf you think it\u0027s to error-prone than reverse it.\nFor me a membership test shows more of the intention than checking individual border values.","commit_id":"d1cada6058f6824fdad481dd3c6ddfd6ae53c521"},{"author":{"_account_id":1000002,"name":"Thomas Heijligen","email":"src@posteo.de","username":"heijligen","avatars":[{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"65cc934ebd24f8cf1d4dc180dfcca351a2c332e0","unresolved":true,"context_lines":[{"line_number":589,"context_line":""},{"line_number":590,"context_line":"      Origin : Relaxed_Coord :\u003d Phys_Origin (Center);"},{"line_number":591,"context_line":""},{"line_number":592,"context_line":"      Visible : constant Boolean :\u003d"},{"line_number":593,"context_line":"         -Width \u003c Origin.X and Origin.X \u003c Surface_Width and"},{"line_number":594,"context_line":"         -Width \u003c Origin.Y and Origin.Y \u003c Surface_Height;"},{"line_number":595,"context_line":"   begin"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"17b90168_f7a78caa","line":592,"updated":"2026-07-28 11:45:53.000000000","message":"Use range membership test\n`Origin.X in -Width + 1 .. Surface_Width - 1 and ...`","commit_id":"d1cada6058f6824fdad481dd3c6ddfd6ae53c521"},{"author":{"_account_id":1000002,"name":"Thomas Heijligen","email":"src@posteo.de","username":"heijligen","avatars":[{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"66d6909c33fae9f1f2cf6f345a0c97b1aa3fcbee","unresolved":false,"context_lines":[{"line_number":589,"context_line":""},{"line_number":590,"context_line":"      Origin : Relaxed_Coord :\u003d Phys_Origin (Center);"},{"line_number":591,"context_line":""},{"line_number":592,"context_line":"      Visible : constant Boolean :\u003d"},{"line_number":593,"context_line":"         -Width \u003c Origin.X and Origin.X \u003c Surface_Width and"},{"line_number":594,"context_line":"         -Width \u003c Origin.Y and Origin.Y \u003c Surface_Height;"},{"line_number":595,"context_line":"   begin"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"295ed838_3944bb19","line":592,"in_reply_to":"17b90168_f7a78caa","updated":"2026-07-29 15:19:48.000000000","message":"Done","commit_id":"d1cada6058f6824fdad481dd3c6ddfd6ae53c521"}],"gfxtest/hw-gfx-gma-gfx_test.adb":[{"author":{"_account_id":1000002,"name":"Thomas Heijligen","email":"src@posteo.de","username":"heijligen","avatars":[{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"6b646484b452b5bf39807527aad1d85a4f647839","unresolved":true,"context_lines":[{"line_number":344,"context_line":"            Width : constant Width_Type :\u003d Cursor_Width (Size);"},{"line_number":345,"context_line":"            GTT_End : constant Word32 :\u003d Offset + Word32 (Width * Width) * 4;"},{"line_number":346,"context_line":""},{"line_number":347,"context_line":"            Rotation_First : constant GTT_Range :\u003d GTT_Range (Offset / GTT_Page_Size) + GTT_Rotation_Offset;"},{"line_number":348,"context_line":"            Rotation_Last : constant GTT_Range :\u003d Rotation_First + GTT_Range (Width * Width * 4 / GTT_Page_Size);"},{"line_number":349,"context_line":"         begin"},{"line_number":350,"context_line":"            if Rotation \u003d Rotated_90 or Rotation \u003d Rotated_270 then"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"c61c05e2_49b10137","line":347,"updated":"2026-07-28 10:29:20.000000000","message":"They are only used in one branch. use the lowest possible scope for declaration.","commit_id":"d1cada6058f6824fdad481dd3c6ddfd6ae53c521"},{"author":{"_account_id":1000002,"name":"Thomas Heijligen","email":"src@posteo.de","username":"heijligen","avatars":[{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"66d6909c33fae9f1f2cf6f345a0c97b1aa3fcbee","unresolved":false,"context_lines":[{"line_number":344,"context_line":"            Width : constant Width_Type :\u003d Cursor_Width (Size);"},{"line_number":345,"context_line":"            GTT_End : constant Word32 :\u003d Offset + Word32 (Width * Width) * 4;"},{"line_number":346,"context_line":""},{"line_number":347,"context_line":"            Rotation_First : constant GTT_Range :\u003d GTT_Range (Offset / GTT_Page_Size) + GTT_Rotation_Offset;"},{"line_number":348,"context_line":"            Rotation_Last : constant GTT_Range :\u003d Rotation_First + GTT_Range (Width * Width * 4 / GTT_Page_Size);"},{"line_number":349,"context_line":"         begin"},{"line_number":350,"context_line":"            if Rotation \u003d Rotated_90 or Rotation \u003d Rotated_270 then"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"2879a164_497b277f","line":347,"in_reply_to":"a0447c8c_9ded1e79","updated":"2026-07-29 15:19:48.000000000","message":"Looks clean now","commit_id":"d1cada6058f6824fdad481dd3c6ddfd6ae53c521"},{"author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"1707029973d92fb888f625c03e04969c1c893a12","unresolved":true,"context_lines":[{"line_number":344,"context_line":"            Width : constant Width_Type :\u003d Cursor_Width (Size);"},{"line_number":345,"context_line":"            GTT_End : constant Word32 :\u003d Offset + Word32 (Width * Width) * 4;"},{"line_number":346,"context_line":""},{"line_number":347,"context_line":"            Rotation_First : constant GTT_Range :\u003d GTT_Range (Offset / GTT_Page_Size) + GTT_Rotation_Offset;"},{"line_number":348,"context_line":"            Rotation_Last : constant GTT_Range :\u003d Rotation_First + GTT_Range (Width * Width * 4 / GTT_Page_Size);"},{"line_number":349,"context_line":"         begin"},{"line_number":350,"context_line":"            if Rotation \u003d Rotated_90 or Rotation \u003d Rotated_270 then"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"a0447c8c_9ded1e79","line":347,"in_reply_to":"c61c05e2_49b10137","updated":"2026-07-29 12:28:45.000000000","message":"Done and refactored the whole ugly code. Hope it looks better now.","commit_id":"d1cada6058f6824fdad481dd3c6ddfd6ae53c521"},{"author":{"_account_id":1000002,"name":"Thomas Heijligen","email":"src@posteo.de","username":"heijligen","avatars":[{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"6b646484b452b5bf39807527aad1d85a4f647839","unresolved":true,"context_lines":[{"line_number":347,"context_line":"            Rotation_First : constant GTT_Range :\u003d GTT_Range (Offset / GTT_Page_Size) + GTT_Rotation_Offset;"},{"line_number":348,"context_line":"            Rotation_Last : constant GTT_Range :\u003d Rotation_First + GTT_Range (Width * Width * 4 / GTT_Page_Size);"},{"line_number":349,"context_line":"         begin"},{"line_number":350,"context_line":"            if Rotation \u003d Rotated_90 or Rotation \u003d Rotated_270 then"},{"line_number":351,"context_line":"               Cursors (Size) :\u003d"},{"line_number":352,"context_line":"                 (Mode        \u003d\u003e ARGB_Cursor,"},{"line_number":353,"context_line":"                  Size        \u003d\u003e Size,"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"dd14be0b_faaae3ad","line":350,"updated":"2026-07-28 10:29:20.000000000","message":"Use Membership test\n\n`if Rotation in Rotated_90 | Rotated_270 then`","commit_id":"d1cada6058f6824fdad481dd3c6ddfd6ae53c521"},{"author":{"_account_id":1000002,"name":"Thomas Heijligen","email":"src@posteo.de","username":"heijligen","avatars":[{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"66d6909c33fae9f1f2cf6f345a0c97b1aa3fcbee","unresolved":false,"context_lines":[{"line_number":347,"context_line":"            Rotation_First : constant GTT_Range :\u003d GTT_Range (Offset / GTT_Page_Size) + GTT_Rotation_Offset;"},{"line_number":348,"context_line":"            Rotation_Last : constant GTT_Range :\u003d Rotation_First + GTT_Range (Width * Width * 4 / GTT_Page_Size);"},{"line_number":349,"context_line":"         begin"},{"line_number":350,"context_line":"            if Rotation \u003d Rotated_90 or Rotation \u003d Rotated_270 then"},{"line_number":351,"context_line":"               Cursors (Size) :\u003d"},{"line_number":352,"context_line":"                 (Mode        \u003d\u003e ARGB_Cursor,"},{"line_number":353,"context_line":"                  Size        \u003d\u003e Size,"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"2dbe66e6_00941f12","line":350,"in_reply_to":"dd14be0b_faaae3ad","updated":"2026-07-29 15:19:48.000000000","message":"Done","commit_id":"d1cada6058f6824fdad481dd3c6ddfd6ae53c521"},{"author":{"_account_id":1000002,"name":"Thomas Heijligen","email":"src@posteo.de","username":"heijligen","avatars":[{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"6b646484b452b5bf39807527aad1d85a4f647839","unresolved":true,"context_lines":[{"line_number":368,"context_line":"                  Center_Y    \u003d\u003e Width,"},{"line_number":369,"context_line":"                  GTT_Offset  \u003d\u003e GTT_Range (Shift_Right (Offset, 12)));"},{"line_number":370,"context_line":"            end if;"},{"line_number":371,"context_line":"            if Rotation \u003d Rotated_90 or Rotation \u003d Rotated_270 then"},{"line_number":372,"context_line":"               declare"},{"line_number":373,"context_line":"                  V_Pages : constant Natural :\u003d Natural (Width) / 32;"},{"line_number":374,"context_line":"                  Bytes_Per_Row : constant GTT_Address_Type :\u003d"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"d26cce0d_4506b2e6","line":371,"updated":"2026-07-28 10:29:20.000000000","message":"Why not combining with the block above?\n\nUse Membership test","commit_id":"d1cada6058f6824fdad481dd3c6ddfd6ae53c521"},{"author":{"_account_id":1000002,"name":"Thomas Heijligen","email":"src@posteo.de","username":"heijligen","avatars":[{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"66d6909c33fae9f1f2cf6f345a0c97b1aa3fcbee","unresolved":false,"context_lines":[{"line_number":368,"context_line":"                  Center_Y    \u003d\u003e Width,"},{"line_number":369,"context_line":"                  GTT_Offset  \u003d\u003e GTT_Range (Shift_Right (Offset, 12)));"},{"line_number":370,"context_line":"            end if;"},{"line_number":371,"context_line":"            if Rotation \u003d Rotated_90 or Rotation \u003d Rotated_270 then"},{"line_number":372,"context_line":"               declare"},{"line_number":373,"context_line":"                  V_Pages : constant Natural :\u003d Natural (Width) / 32;"},{"line_number":374,"context_line":"                  Bytes_Per_Row : constant GTT_Address_Type :\u003d"}],"source_content_type":"application/octet-stream","patch_set":11,"id":"8468cf40_50705417","line":371,"in_reply_to":"d26cce0d_4506b2e6","updated":"2026-07-29 15:19:48.000000000","message":"Done","commit_id":"d1cada6058f6824fdad481dd3c6ddfd6ae53c521"},{"author":{"_account_id":1000002,"name":"Thomas Heijligen","email":"src@posteo.de","username":"heijligen","avatars":[{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"66d6909c33fae9f1f2cf6f345a0c97b1aa3fcbee","unresolved":true,"context_lines":[{"line_number":242,"context_line":"      use type HW.Byte;"},{"line_number":243,"context_line":"      Width : constant Width_Type :\u003d Cursor_Width (Cursor.Size);"},{"line_number":244,"context_line":"      GTT_Offset : constant GTT_Range :\u003d"},{"line_number":245,"context_line":"        (if Rotation \u003d Rotated_90 or Rotation \u003d Rotated_270 then"},{"line_number":246,"context_line":"            Cursor.GTT_Offset - GTT_Rotation_Offset"},{"line_number":247,"context_line":"         else"},{"line_number":248,"context_line":"            Cursor.GTT_Offset);"}],"source_content_type":"application/octet-stream","patch_set":12,"id":"441cd89d_7b2720b8","line":245,"range":{"start_line":245,"start_character":9,"end_line":245,"end_character":60},"updated":"2026-07-29 15:19:48.000000000","message":"`if Rotation in Rotated_90 | Rotated_270`\n\nThis was done in a case below","commit_id":"db46bbbac7f57a3e76b1ec4e2522bb273e16cf6e"}]}