)]}'
{"common/hw-gfx-gma-config.ads.template":[{"author":{"_account_id":1000012,"name":"Angel Pons","email":"th3fanbus@gmail.com","username":"th3fanbus","avatars":[{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"f7c69ab485c1554d69e2da7cd25a70d31813e7aa","unresolved":true,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"   DDI_HDMI_Buffer_Translation : constant Integer :\u003d -1;"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"   PCI_Dev : constant PCI.Address :\u003d (\u003c\u003cPCI_DEV_ADDRESS\u003e\u003e);"},{"line_number":83,"context_line":"   Override_MMConf_Base : constant :\u003d \u003c\u003cOVERRIDE_MMCONF_BASE\u003e\u003e;"},{"line_number":84,"context_line":"   Default_MMIO_Base    : constant :\u003d \u003c\u003cDEFAULT_MMIO_BASE\u003e\u003e;"},{"line_number":85,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":6,"id":"c83eb32f_74cc434b","line":82,"range":{"start_line":82,"start_character":37,"end_line":82,"end_character":58},"updated":"2026-07-07 11:31:09.000000000","message":"Would it make sense to have the parentheses be part of the value itself?","commit_id":"412c1ef586cea9907cc014783ccca4c5f8f8521d"},{"author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"330f756b0a3e9f457c53bf71734bc8e5994293bb","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"   DDI_HDMI_Buffer_Translation : constant Integer :\u003d -1;"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"   PCI_Dev : constant PCI.Address :\u003d (\u003c\u003cPCI_DEV_ADDRESS\u003e\u003e);"},{"line_number":83,"context_line":"   Override_MMConf_Base : constant :\u003d \u003c\u003cOVERRIDE_MMCONF_BASE\u003e\u003e;"},{"line_number":84,"context_line":"   Default_MMIO_Base    : constant :\u003d \u003c\u003cDEFAULT_MMIO_BASE\u003e\u003e;"},{"line_number":85,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":6,"id":"15d52082_9457ff32","line":82,"range":{"start_line":82,"start_character":37,"end_line":82,"end_character":58},"in_reply_to":"988f8201_2c4f5a5c","updated":"2026-07-13 12:27:34.000000000","message":"Topic looks resolved. If not, just keep commenting here.","commit_id":"412c1ef586cea9907cc014783ccca4c5f8f8521d"},{"author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"0b1c4e552e937bd16b8ddee3fd05dbf342a9a4b2","unresolved":true,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"   DDI_HDMI_Buffer_Translation : constant Integer :\u003d -1;"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"   PCI_Dev : constant PCI.Address :\u003d (\u003c\u003cPCI_DEV_ADDRESS\u003e\u003e);"},{"line_number":83,"context_line":"   Override_MMConf_Base : constant :\u003d \u003c\u003cOVERRIDE_MMCONF_BASE\u003e\u003e;"},{"line_number":84,"context_line":"   Default_MMIO_Base    : constant :\u003d \u003c\u003cDEFAULT_MMIO_BASE\u003e\u003e;"},{"line_number":85,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":6,"id":"988f8201_2c4f5a5c","line":82,"range":{"start_line":82,"start_character":37,"end_line":82,"end_character":58},"in_reply_to":"c83eb32f_74cc434b","updated":"2026-07-08 15:21:15.000000000","message":"Yes, good call. I\u0027ve also moved the default settings from the individual configs\ninto the `common/Makefile.inc`. It\u0027s really a hardware default, so why repeat it.","commit_id":"412c1ef586cea9907cc014783ccca4c5f8f8521d"}],"common/hw-gfx-gma-pipe_setup.adb":[{"author":{"_account_id":1000029,"name":"Ada SPARK","email":"gnatbot@sourcearcade.org","username":"gnatbot","avatars":[{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"2a55534ec1435e43418a92bb6ad3ffff4b9e3547","unresolved":false,"context_lines":[{"line_number":313,"context_line":"            pragma Assert_And_Cut (True);"},{"line_number":314,"context_line":"            declare"},{"line_number":315,"context_line":"               Linear_Offset : constant Pixel_Type :\u003d"},{"line_number":316,"context_line":"                  FB.Start_Y * FB.Stride + FB.Start_X;"},{"line_number":317,"context_line":"            begin"},{"line_number":318,"context_line":"               Registers.Write"},{"line_number":319,"context_line":"                 (Register \u003d\u003e Controller.DSPLINOFF,"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"0eebe98c_324f3c63","line":316,"updated":"2026-07-02 13:00:06.000000000","message":"Config(s): ironlake_edp\n```\nhw-gfx-gma-pipe_setup.adb:316: medium: range check might fail\n  316 |                  FB.Start_Y * FB.Stride + FB.Start_X;\n      |                                         ^ here\n  e.g. when FB \u003d (Start_Y \u003d\u003e 0, Tiling \u003d\u003e Linear, Rotation \u003d\u003e No_Rotation, Offset \u003d\u003e 0, others \u003d\u003e ?)\n  reason for check: default component value must fit in the type\n```\nConfig(s): i945 ironlake\n```\nhw-gfx-gma-pipe_setup.adb:316: medium: range check might fail\n  316 |                  FB.Start_Y * FB.Stride + FB.Start_X;\n      |                                         ^ here\n  reason for check: default component value must fit in the type\n```","commit_id":"d74ad6840f806bd09687c2626d2b891cbc50fff3"},{"author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"7b9e8a92d9afaf55e0ff68b089be97fcb79029a5","unresolved":false,"context_lines":[{"line_number":313,"context_line":"            pragma Assert_And_Cut (True);"},{"line_number":314,"context_line":"            declare"},{"line_number":315,"context_line":"               Linear_Offset : constant Pixel_Type :\u003d"},{"line_number":316,"context_line":"                  FB.Start_Y * FB.Stride + FB.Start_X;"},{"line_number":317,"context_line":"            begin"},{"line_number":318,"context_line":"               Registers.Write"},{"line_number":319,"context_line":"                 (Register \u003d\u003e Controller.DSPLINOFF,"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"24378ebc_86f1e63f","line":316,"in_reply_to":"0eebe98c_324f3c63","updated":"2026-07-02 13:08:53.000000000","message":"Known false-positive.","commit_id":"d74ad6840f806bd09687c2626d2b891cbc50fff3"},{"author":{"_account_id":1000029,"name":"Ada SPARK","email":"gnatbot@sourcearcade.org","username":"gnatbot","avatars":[{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"a8b475514dfd500d92023ca62263b70fb361004b","unresolved":false,"context_lines":[{"line_number":311,"context_line":""},{"line_number":312,"context_line":"         if Config.Has_DSP_Linoff and then FB.Tiling \u003d Linear then"},{"line_number":313,"context_line":"            pragma Assert_And_Cut"},{"line_number":314,"context_line":"              (FB.Start_Y * FB.Stride + FB.Start_X in Pixel_Type);"},{"line_number":315,"context_line":"            declare"},{"line_number":316,"context_line":"               Linear_Offset : constant Pixel_Type :\u003d"},{"line_number":317,"context_line":"                  FB.Start_Y * FB.Stride + FB.Start_X;"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"9b8dbb35_4ae60d35","line":314,"updated":"2026-07-08 15:21:24.000000000","message":"Config(s): i945 ironlake_edp\n```\nhw-gfx-gma-pipe_setup.adb:314: medium: assertion might fail, cannot prove FB.Start_Y * FB.Stride + FB.Start_X in Pixel_Type\n  314 |              (FB.Start_Y * FB.Stride + FB.Start_X in Pixel_Type);\n      |               ^ here\n```\nConfig(s): ironlake\n```\nhw-gfx-gma-pipe_setup.adb:314: medium: assertion might fail, cannot prove FB.Start_Y * FB.Stride + FB.Start_X in Pixel_Type\n  314 |              (FB.Start_Y * FB.Stride + FB.Start_X in Pixel_Type);\n      |               ^ here\n  e.g. when FB \u003d (Start_Y \u003d\u003e 0, Tiling \u003d\u003e Linear, Rotation \u003d\u003e No_Rotation, Offset \u003d\u003e 0, others \u003d\u003e ?)\n```","commit_id":"db5e02a9bd1d9484ac6a18d47dcd362088eaa5ad"}],"common/hw-gfx-gma.adb":[{"author":{"_account_id":1000002,"name":"Thomas Heijligen","email":"src@posteo.de","username":"heijligen","avatars":[{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"eb7ba88fc1154597ff9348c8c684d9a5b5ed5bf3","unresolved":true,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"   package Dev is new HW.PCI.Dev"},{"line_number":82,"context_line":"     (Dev         \u003d\u003e Config.PCI_Dev,"},{"line_number":83,"context_line":"      MMConf_Base \u003d\u003e Config.Override_MMConf_Base);"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"   package Display_Controller renames Pipe_Setup;"},{"line_number":86,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":6,"id":"ce79da65_03bb2e30","line":83,"updated":"2026-07-08 10:11:07.000000000","message":"This needs synchronization with `libhwbase` changes.","commit_id":"412c1ef586cea9907cc014783ccca4c5f8f8521d"},{"author":{"_account_id":1000002,"name":"Thomas Heijligen","email":"src@posteo.de","username":"heijligen","avatars":[{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"42417b36029e8da4801410dfb684233de90c3499","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"   package Dev is new HW.PCI.Dev"},{"line_number":82,"context_line":"     (Dev         \u003d\u003e Config.PCI_Dev,"},{"line_number":83,"context_line":"      MMConf_Base \u003d\u003e Config.Override_MMConf_Base);"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"   package Display_Controller renames Pipe_Setup;"},{"line_number":86,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":6,"id":"3356b35a_cc6c883c","line":83,"in_reply_to":"0efb556a_07806a4b","updated":"2026-07-08 16:09:47.000000000","message":"Done","commit_id":"412c1ef586cea9907cc014783ccca4c5f8f8521d"},{"author":{"_account_id":1000002,"name":"Thomas Heijligen","email":"src@posteo.de","username":"heijligen","avatars":[{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"3c41c7e4af3f1d09ea2e1e74ba6e598a0f43801f","unresolved":true,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"   package Dev is new HW.PCI.Dev"},{"line_number":82,"context_line":"     (Dev         \u003d\u003e Config.PCI_Dev,"},{"line_number":83,"context_line":"      MMConf_Base \u003d\u003e Config.Override_MMConf_Base);"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"   package Display_Controller renames Pipe_Setup;"},{"line_number":86,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":6,"id":"0efb556a_07806a4b","line":83,"in_reply_to":"ce79da65_03bb2e30","updated":"2026-07-08 11:10:32.000000000","message":"https://review.sourcearcade.org/c/libhwbase/+/550","commit_id":"412c1ef586cea9907cc014783ccca4c5f8f8521d"}]}