)]}'
{"common/hw-gfx-gma-pipe_setup.adb":[{"author":{"_account_id":1000029,"name":"Ada SPARK","email":"gnatbot@sourcearcade.org","username":"gnatbot","avatars":[{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"22f034e60694987d3c21cd0b19764e60cf514ec0","unresolved":false,"context_lines":[{"line_number":313,"context_line":"            pragma Assert_And_Cut (True);"},{"line_number":314,"context_line":"            declare"},{"line_number":315,"context_line":"               Linear_Offset : constant Pixel_Type :\u003d"},{"line_number":316,"context_line":"                  FB.Start_Y * FB.Stride + FB.Start_X;"},{"line_number":317,"context_line":"            begin"},{"line_number":318,"context_line":"               Registers.Write"},{"line_number":319,"context_line":"                 (Register \u003d\u003e Controller.DSPLINOFF,"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"399fdb37_69634f5e","line":316,"updated":"2026-06-24 07:19:04.000000000","message":"Config(s): ironlake ironlake_edp i945\n```\nhw-gfx-gma-pipe_setup.adb:316: medium: range check might fail\n  316 |                  FB.Start_Y * FB.Stride + FB.Start_X;\n      |                                         ^ here\n  reason for check: default component value must fit in the type\n```","commit_id":"7af822f6a95a139054b8eab1291f7096feb791e5"},{"author":{"_account_id":1000002,"name":"Thomas Heijligen","email":"src@posteo.de","username":"heijligen","avatars":[{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"b5e5318188247412032c65347e1d166fc69c300c","unresolved":true,"context_lines":[{"line_number":865,"context_line":"   procedure Setup_FB"},{"line_number":866,"context_line":"     (Pipe        : Pipe_Index;"},{"line_number":867,"context_line":"      Pipe_Cfg    : Pipe_Config;"},{"line_number":868,"context_line":"      Mode        : Mode_Type)"},{"line_number":869,"context_line":"   is"},{"line_number":870,"context_line":"      -- Enable dithering if framebuffer BPC differs from port BPC,"},{"line_number":871,"context_line":"      -- as smooth gradients look really bad without."}],"source_content_type":"application/octet-stream","patch_set":5,"id":"f2016dc9_fd12f77c","line":868,"updated":"2026-07-07 17:33:48.000000000","message":"Isn\u0027t `Mode : Mode_Type` also Part of the `Pipe_Config` record?\nWhy passing `Mode` as separate parameter?","commit_id":"d28e034f07d7c8339b2a88378224c73d149a426e"},{"author":{"_account_id":1000002,"name":"Thomas Heijligen","email":"src@posteo.de","username":"heijligen","avatars":[{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"51108d5d9e633c10c77eaa9f3de8d88e83deab95","unresolved":true,"context_lines":[{"line_number":865,"context_line":"   procedure Setup_FB"},{"line_number":866,"context_line":"     (Pipe        : Pipe_Index;"},{"line_number":867,"context_line":"      Pipe_Cfg    : Pipe_Config;"},{"line_number":868,"context_line":"      Mode        : Mode_Type)"},{"line_number":869,"context_line":"   is"},{"line_number":870,"context_line":"      -- Enable dithering if framebuffer BPC differs from port BPC,"},{"line_number":871,"context_line":"      -- as smooth gradients look really bad without."}],"source_content_type":"application/octet-stream","patch_set":5,"id":"b8938591_88f56b53","line":868,"in_reply_to":"6efd0f18_5057f946","updated":"2026-07-08 13:49:56.000000000","message":"Acknowledging the issue with a TODO is imo a acceptable solution for now.","commit_id":"d28e034f07d7c8339b2a88378224c73d149a426e"},{"author":{"_account_id":1000002,"name":"Thomas Heijligen","email":"src@posteo.de","username":"heijligen","avatars":[{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"1f454f8d60b27151ed7e2cf49c878d5e4417a2ad","unresolved":false,"context_lines":[{"line_number":865,"context_line":"   procedure Setup_FB"},{"line_number":866,"context_line":"     (Pipe        : Pipe_Index;"},{"line_number":867,"context_line":"      Pipe_Cfg    : Pipe_Config;"},{"line_number":868,"context_line":"      Mode        : Mode_Type)"},{"line_number":869,"context_line":"   is"},{"line_number":870,"context_line":"      -- Enable dithering if framebuffer BPC differs from port BPC,"},{"line_number":871,"context_line":"      -- as smooth gradients look really bad without."}],"source_content_type":"application/octet-stream","patch_set":5,"id":"2764219e_e14d422a","line":868,"in_reply_to":"b8938591_88f56b53","updated":"2026-07-08 16:04:23.000000000","message":"Done","commit_id":"d28e034f07d7c8339b2a88378224c73d149a426e"},{"author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"d5f5396c981c6ba4d102ce53577c84d967f13909","unresolved":true,"context_lines":[{"line_number":865,"context_line":"   procedure Setup_FB"},{"line_number":866,"context_line":"     (Pipe        : Pipe_Index;"},{"line_number":867,"context_line":"      Pipe_Cfg    : Pipe_Config;"},{"line_number":868,"context_line":"      Mode        : Mode_Type)"},{"line_number":869,"context_line":"   is"},{"line_number":870,"context_line":"      -- Enable dithering if framebuffer BPC differs from port BPC,"},{"line_number":871,"context_line":"      -- as smooth gradients look really bad without."}],"source_content_type":"application/octet-stream","patch_set":5,"id":"6efd0f18_5057f946","line":868,"in_reply_to":"f2016dc9_fd12f77c","updated":"2026-07-08 13:45:04.000000000","message":"The `Pipe_Config` contains what the API user requested. But we modify this, e.g.\nto add the expected bits-per-color or adapt the dot clock to hardware limits.\n\nThis could be refactored in theory to carry the final `Mode` in `Pipe_Config`.\nShould I try to do this ahead? leave a TODO comment?\n\n(It\u0027s a bit odd design right now, because the original intention was not to use\n`Pipe_Config` internally. However, I think `Pipe_Setup` is a reasonable exception 😆)","commit_id":"d28e034f07d7c8339b2a88378224c73d149a426e"},{"author":{"_account_id":1000029,"name":"Ada SPARK","email":"gnatbot@sourcearcade.org","username":"gnatbot","avatars":[{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"b9bcdc138717a3513b4541274fa66cadb5205727","unresolved":false,"context_lines":[{"line_number":311,"context_line":""},{"line_number":312,"context_line":"         if Config.Has_DSP_Linoff and then FB.Tiling \u003d Linear then"},{"line_number":313,"context_line":"            pragma Assert_And_Cut"},{"line_number":314,"context_line":"              (FB.Start_Y * FB.Stride + FB.Start_X in Pixel_Type);"},{"line_number":315,"context_line":"            declare"},{"line_number":316,"context_line":"               Linear_Offset : constant Pixel_Type :\u003d"},{"line_number":317,"context_line":"                  FB.Start_Y * FB.Stride + FB.Start_X;"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"4f19dc79_b7b3c24d","line":314,"updated":"2026-07-08 15:38:34.000000000","message":"Config(s): i945 ironlake ironlake_edp\n```\nhw-gfx-gma-pipe_setup.adb:314: medium: assertion might fail, cannot prove FB.Start_Y * FB.Stride + FB.Start_X in Pixel_Type\n  314 |              (FB.Start_Y * FB.Stride + FB.Start_X in Pixel_Type);\n      |               ^ here\n```","commit_id":"dd0f430fc408280d5d8a7d619e9e52ed3f4e3bb6"}]}
