)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1000012,"name":"Angel Pons","email":"th3fanbus@gmail.com","username":"th3fanbus","avatars":[{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"6efb3f88c1ec1ff8577c053d443b33afbe6d51da","unresolved":true,"context_lines":[{"line_number":11,"context_line":"Introduce `Config.Need_TC_Loadgen_Select\u0027 and `.Need_DP_Alt_Switch\u0027"},{"line_number":12,"context_line":"to handle these two special cases for Alder Lake."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Based on..."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I32fd558c27f4f9658aea799f1b6c679be4d31feb"},{"line_number":17,"context_line":"Signed-off-by: Nico Huber \u003cnico.h@gmx.de\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"92d6f2a4_e0b152c3","line":14,"updated":"2026-05-30 12:05:34.000000000","message":"Lorem ipsum dolor sit amet..? 😉","commit_id":"f13177bed301df39486b9f41f09e6acf7150bf05"},{"author":{"_account_id":1000012,"name":"Angel Pons","email":"th3fanbus@gmail.com","username":"th3fanbus","avatars":[{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"17f4200c0fadbfaeb230b03a3840ffb06a804f19","unresolved":false,"context_lines":[{"line_number":11,"context_line":"Introduce `Config.Need_TC_Loadgen_Select\u0027 and `.Need_DP_Alt_Switch\u0027"},{"line_number":12,"context_line":"to handle these two special cases for Alder Lake."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Based on..."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I32fd558c27f4f9658aea799f1b6c679be4d31feb"},{"line_number":17,"context_line":"Signed-off-by: Nico Huber \u003cnico.h@gmx.de\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7929181b_ae7b422a","line":14,"in_reply_to":"39ccf68d_3d1bf46c","updated":"2026-06-07 12:25:01.000000000","message":"Ah, didn\u0027t notice that.","commit_id":"f13177bed301df39486b9f41f09e6acf7150bf05"},{"author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"4f1a54b5f7b7852e24abba468a81799975a82921","unresolved":false,"context_lines":[{"line_number":11,"context_line":"Introduce `Config.Need_TC_Loadgen_Select\u0027 and `.Need_DP_Alt_Switch\u0027"},{"line_number":12,"context_line":"to handle these two special cases for Alder Lake."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Based on..."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I32fd558c27f4f9658aea799f1b6c679be4d31feb"},{"line_number":17,"context_line":"Signed-off-by: Nico Huber \u003cnico.h@gmx.de\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"39ccf68d_3d1bf46c","line":14,"in_reply_to":"92d6f2a4_e0b152c3","updated":"2026-06-06 12:00:27.000000000","message":"Yeah, that\u0027s why I pushed as WIP.","commit_id":"f13177bed301df39486b9f41f09e6acf7150bf05"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1000002,"name":"Thomas Heijligen","email":"src@posteo.de","username":"heijligen","avatars":[{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"f34be6f2006fceae1772cc81debf32e1f555ea12","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"29fc461b_e5eedb47","updated":"2026-07-21 16:41:45.000000000","message":"Looks fine, haven\u0027t checked all values against the linux kernel driver.","commit_id":"2016ca4019e056fe32dd8cb44ff6835081e0d987"}],"common/tigerlake/hw-gfx-gma-connectors-tc.adb":[{"author":{"_account_id":1000012,"name":"Angel Pons","email":"th3fanbus@gmail.com","username":"th3fanbus","avatars":[{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"6efb3f88c1ec1ff8577c053d443b33afbe6d51da","unresolved":false,"context_lines":[{"line_number":46,"context_line":"      DDI_TC2 \u003d\u003e Registers.DKL_PCS_DW5_2,"},{"line_number":47,"context_line":"      DDI_TC3 \u003d\u003e Registers.DKL_PCS_DW5_3,"},{"line_number":48,"context_line":"      DDI_TC4 \u003d\u003e Registers.DKL_PCS_DW5_4,"},{"line_number":49,"context_line":"      others  \u003d\u003e Registers.DKL_PCS_DW5_1);"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"   function DP_PIN_ASSIGNMENT_SHIFT (P : USBC_Port) return natural is"},{"line_number":52,"context_line":"     (case P is"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"cbf3f029_d2d7ab1a","line":49,"updated":"2026-05-30 12:05:34.000000000","message":"That\u0027s weird","commit_id":"f13177bed301df39486b9f41f09e6acf7150bf05"},{"author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"f4ea53f807b6910032955fcd31ad9f098dc42044","unresolved":false,"context_lines":[{"line_number":46,"context_line":"      DDI_TC2 \u003d\u003e Registers.DKL_PCS_DW5_2,"},{"line_number":47,"context_line":"      DDI_TC3 \u003d\u003e Registers.DKL_PCS_DW5_3,"},{"line_number":48,"context_line":"      DDI_TC4 \u003d\u003e Registers.DKL_PCS_DW5_4,"},{"line_number":49,"context_line":"      others  \u003d\u003e Registers.DKL_PCS_DW5_1);"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"   function DP_PIN_ASSIGNMENT_SHIFT (P : USBC_Port) return natural is"},{"line_number":52,"context_line":"     (case P is"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"3894664a_66679359","line":49,"in_reply_to":"1cfe381b_29f1a765","updated":"2026-06-14 12:22:33.000000000","message":"Done","commit_id":"f13177bed301df39486b9f41f09e6acf7150bf05"},{"author":{"_account_id":1000012,"name":"Angel Pons","email":"th3fanbus@gmail.com","username":"th3fanbus","avatars":[{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"17f4200c0fadbfaeb230b03a3840ffb06a804f19","unresolved":false,"context_lines":[{"line_number":46,"context_line":"      DDI_TC2 \u003d\u003e Registers.DKL_PCS_DW5_2,"},{"line_number":47,"context_line":"      DDI_TC3 \u003d\u003e Registers.DKL_PCS_DW5_3,"},{"line_number":48,"context_line":"      DDI_TC4 \u003d\u003e Registers.DKL_PCS_DW5_4,"},{"line_number":49,"context_line":"      others  \u003d\u003e Registers.DKL_PCS_DW5_1);"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"   function DP_PIN_ASSIGNMENT_SHIFT (P : USBC_Port) return natural is"},{"line_number":52,"context_line":"     (case P is"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"1cfe381b_29f1a765","line":49,"in_reply_to":"373f960e_31d39acf","updated":"2026-06-07 12:25:01.000000000","message":"Would it make sene to use an invalid register index or does the type not allow that?","commit_id":"f13177bed301df39486b9f41f09e6acf7150bf05"},{"author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"4f1a54b5f7b7852e24abba468a81799975a82921","unresolved":false,"context_lines":[{"line_number":46,"context_line":"      DDI_TC2 \u003d\u003e Registers.DKL_PCS_DW5_2,"},{"line_number":47,"context_line":"      DDI_TC3 \u003d\u003e Registers.DKL_PCS_DW5_3,"},{"line_number":48,"context_line":"      DDI_TC4 \u003d\u003e Registers.DKL_PCS_DW5_4,"},{"line_number":49,"context_line":"      others  \u003d\u003e Registers.DKL_PCS_DW5_1);"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"   function DP_PIN_ASSIGNMENT_SHIFT (P : USBC_Port) return natural is"},{"line_number":52,"context_line":"     (case P is"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"373f960e_31d39acf","line":49,"in_reply_to":"cbf3f029_d2d7ab1a","updated":"2026-06-06 12:00:27.000000000","message":"Yeah, see comment on earlier change. There\u0027s apparently no SKU w/ 6 TC ports and\nsome registers seem to be missing as well.","commit_id":"f13177bed301df39486b9f41f09e6acf7150bf05"},{"author":{"_account_id":1000012,"name":"Angel Pons","email":"th3fanbus@gmail.com","username":"th3fanbus","avatars":[{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"6efb3f88c1ec1ff8577c053d443b33afbe6d51da","unresolved":true,"context_lines":[{"line_number":324,"context_line":"         Shift_Left (Buf_Trans.Preshoot_Control, 13);"},{"line_number":325,"context_line":"      DKL_TX_DP20BITMODE : constant :\u003d 1 * 2 ** 2;"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"      function DKL_TX_DPCNTL2_CFG_LOADGENSELECT_TX1 (N : Word32) return Word32"},{"line_number":328,"context_line":"      is (Shift_Left (N and 16#3#, 3));"},{"line_number":329,"context_line":"      function DKL_TX_DPCNTL2_CFG_LOADGENSELECT_TX2 (N : Word32) return Word32"},{"line_number":330,"context_line":"      is (Shift_Left (N and 16#3#, 5));"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"      DKL_TX_DPCNTL2_CFG_LOADGENSELECT_TX1_MASK : constant :\u003d 16#18#;"},{"line_number":333,"context_line":"      DKL_TX_DPCNTL2_CFG_LOADGENSELECT_TX2_MASK : constant :\u003d 16#60#;"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"c603b21f_f86c04c8","line":330,"range":{"start_line":327,"start_character":6,"end_line":330,"end_character":39},"updated":"2026-05-30 12:05:34.000000000","message":"nit: Maybe?\n```suggestion\n      function DKL_TX_DPCNTL2_CFG_LOADGENSELECT_TX1 (N : Word32) return Word32\n         is (Shift_Left (N and 16#3#, 3));\n      function DKL_TX_DPCNTL2_CFG_LOADGENSELECT_TX2 (N : Word32) return Word32\n         is (Shift_Left (N and 16#3#, 5));\n```","commit_id":"f13177bed301df39486b9f41f09e6acf7150bf05"},{"author":{"_account_id":1000012,"name":"Angel Pons","email":"th3fanbus@gmail.com","username":"th3fanbus","avatars":[{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"17f4200c0fadbfaeb230b03a3840ffb06a804f19","unresolved":false,"context_lines":[{"line_number":324,"context_line":"         Shift_Left (Buf_Trans.Preshoot_Control, 13);"},{"line_number":325,"context_line":"      DKL_TX_DP20BITMODE : constant :\u003d 1 * 2 ** 2;"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"      function DKL_TX_DPCNTL2_CFG_LOADGENSELECT_TX1 (N : Word32) return Word32"},{"line_number":328,"context_line":"      is (Shift_Left (N and 16#3#, 3));"},{"line_number":329,"context_line":"      function DKL_TX_DPCNTL2_CFG_LOADGENSELECT_TX2 (N : Word32) return Word32"},{"line_number":330,"context_line":"      is (Shift_Left (N and 16#3#, 5));"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"      DKL_TX_DPCNTL2_CFG_LOADGENSELECT_TX1_MASK : constant :\u003d 16#18#;"},{"line_number":333,"context_line":"      DKL_TX_DPCNTL2_CFG_LOADGENSELECT_TX2_MASK : constant :\u003d 16#60#;"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"c780b172_9ce7a2b2","line":330,"range":{"start_line":327,"start_character":6,"end_line":330,"end_character":39},"in_reply_to":"6ba00331_28a11453","updated":"2026-06-07 12:25:01.000000000","message":"Maybe we could do like line 32:\n```suggestion\n      function DKL_TX_DPCNTL2_CFG_LOADGENSELECT_TX1 (N : Word32) return Word32 is\n         (Shift_Left (N and 16#3#, 3));\n      function DKL_TX_DPCNTL2_CFG_LOADGENSELECT_TX2 (N : Word32) return Word32 is\n         (Shift_Left (N and 16#3#, 5));\n```","commit_id":"f13177bed301df39486b9f41f09e6acf7150bf05"},{"author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"4f1a54b5f7b7852e24abba468a81799975a82921","unresolved":false,"context_lines":[{"line_number":324,"context_line":"         Shift_Left (Buf_Trans.Preshoot_Control, 13);"},{"line_number":325,"context_line":"      DKL_TX_DP20BITMODE : constant :\u003d 1 * 2 ** 2;"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"      function DKL_TX_DPCNTL2_CFG_LOADGENSELECT_TX1 (N : Word32) return Word32"},{"line_number":328,"context_line":"      is (Shift_Left (N and 16#3#, 3));"},{"line_number":329,"context_line":"      function DKL_TX_DPCNTL2_CFG_LOADGENSELECT_TX2 (N : Word32) return Word32"},{"line_number":330,"context_line":"      is (Shift_Left (N and 16#3#, 5));"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"      DKL_TX_DPCNTL2_CFG_LOADGENSELECT_TX1_MASK : constant :\u003d 16#18#;"},{"line_number":333,"context_line":"      DKL_TX_DPCNTL2_CFG_LOADGENSELECT_TX2_MASK : constant :\u003d 16#60#;"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"6ba00331_28a11453","line":330,"range":{"start_line":327,"start_character":6,"end_line":330,"end_character":39},"in_reply_to":"c603b21f_f86c04c8","updated":"2026-06-06 12:00:27.000000000","message":"Going with the more consistent style to have `is` unindented on a line of its own.\nIt\u0027s what I\u0027m trying to get used to, same with `with`. It\u0027s what we do for more\nelaborate functions and procedures already.","commit_id":"f13177bed301df39486b9f41f09e6acf7150bf05"},{"author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"f4ea53f807b6910032955fcd31ad9f098dc42044","unresolved":false,"context_lines":[{"line_number":324,"context_line":"         Shift_Left (Buf_Trans.Preshoot_Control, 13);"},{"line_number":325,"context_line":"      DKL_TX_DP20BITMODE : constant :\u003d 1 * 2 ** 2;"},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"      function DKL_TX_DPCNTL2_CFG_LOADGENSELECT_TX1 (N : Word32) return Word32"},{"line_number":328,"context_line":"      is (Shift_Left (N and 16#3#, 3));"},{"line_number":329,"context_line":"      function DKL_TX_DPCNTL2_CFG_LOADGENSELECT_TX2 (N : Word32) return Word32"},{"line_number":330,"context_line":"      is (Shift_Left (N and 16#3#, 5));"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"      DKL_TX_DPCNTL2_CFG_LOADGENSELECT_TX1_MASK : constant :\u003d 16#18#;"},{"line_number":333,"context_line":"      DKL_TX_DPCNTL2_CFG_LOADGENSELECT_TX2_MASK : constant :\u003d 16#60#;"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"dfd37496_2abdb508","line":330,"range":{"start_line":327,"start_character":6,"end_line":330,"end_character":39},"in_reply_to":"c780b172_9ce7a2b2","updated":"2026-06-14 12:22:33.000000000","message":"Maybe it\u0027s that I\u0027m getting old, but I find the `is` on a separating line\nmore readable. Hopefully did it right now and made the file consistent.","commit_id":"f13177bed301df39486b9f41f09e6acf7150bf05"},{"author":{"_account_id":1000012,"name":"Angel Pons","email":"th3fanbus@gmail.com","username":"th3fanbus","avatars":[{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"6efb3f88c1ec1ff8577c053d443b33afbe6d51da","unresolved":true,"context_lines":[{"line_number":440,"context_line":"      Set_Vswing_And_Deemphasis (Port, Buf_Trans);"},{"line_number":441,"context_line":""},{"line_number":442,"context_line":"      if Config.Need_DP_Alt_Switch and not Was_Enabled then"},{"line_number":443,"context_line":"         for Lane in 0 .. 1 loop"},{"line_number":444,"context_line":"            Set_HIP_For_Port (Port, Lane);"},{"line_number":445,"context_line":"            Registers.Unset_Mask"},{"line_number":446,"context_line":"              (Register \u003d\u003e DKL_PCS_DW5 (Port),"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"4969a669_d9e12822","line":443,"updated":"2026-05-30 12:05:34.000000000","message":"Assuming 2 lanes feels odd, why is that done?","commit_id":"f13177bed301df39486b9f41f09e6acf7150bf05"},{"author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"4f1a54b5f7b7852e24abba468a81799975a82921","unresolved":true,"context_lines":[{"line_number":440,"context_line":"      Set_Vswing_And_Deemphasis (Port, Buf_Trans);"},{"line_number":441,"context_line":""},{"line_number":442,"context_line":"      if Config.Need_DP_Alt_Switch and not Was_Enabled then"},{"line_number":443,"context_line":"         for Lane in 0 .. 1 loop"},{"line_number":444,"context_line":"            Set_HIP_For_Port (Port, Lane);"},{"line_number":445,"context_line":"            Registers.Unset_Mask"},{"line_number":446,"context_line":"              (Register \u003d\u003e DKL_PCS_DW5 (Port),"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"868a4456_cca2b3d9","line":443,"in_reply_to":"4969a669_d9e12822","updated":"2026-06-06 12:00:27.000000000","message":"*shrug* i915 calls this adlp_tbt_to_dp_alt_switch_wa()... will add a comment.\nalso found:\n```\ncommit 55223c3bedcffcb81400db7f1ed1f207d523eaba\nAuthor:     Imre Deak \u003cimre.deak@intel.com\u003e\nAuthorDate: Fri Feb 18 14:26:11 2022 +0200\nCommit:     Imre Deak \u003cimre.deak@intel.com\u003e\nCommitDate: Mon Feb 21 18:50:59 2022 +0200\n\n    drm/i915/adlp: Add TypeC PHY TBT-\u003eDP-alt/legacy mode switch workaround\n    \n    Add display workaround # 1309179469 , which fixes a PHY hang when\n    switching from TBT mode to DP-alt/legacy mode. The workaround also\n    requires an IFWI/PHY firmware change, before that this change has no\n    effect (the DKL_PCS_DW5/SOFTRESET flag is always cleared).\n    \n    HSDES: 18018237866\n    HSDES: 16014473319\n    \n    Signed-off-by: Imre Deak \u003cimre.deak@intel.com\u003e\n    Reviewed-by: José Roberto de Souza \u003cjose.souza@intel.com\u003e\n    Link: https://patchwork.freedesktop.org/patch/msgid/20220218122611.767974-1-imre\n.deak@intel.com\n```","commit_id":"f13177bed301df39486b9f41f09e6acf7150bf05"},{"author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"f4ea53f807b6910032955fcd31ad9f098dc42044","unresolved":false,"context_lines":[{"line_number":440,"context_line":"      Set_Vswing_And_Deemphasis (Port, Buf_Trans);"},{"line_number":441,"context_line":""},{"line_number":442,"context_line":"      if Config.Need_DP_Alt_Switch and not Was_Enabled then"},{"line_number":443,"context_line":"         for Lane in 0 .. 1 loop"},{"line_number":444,"context_line":"            Set_HIP_For_Port (Port, Lane);"},{"line_number":445,"context_line":"            Registers.Unset_Mask"},{"line_number":446,"context_line":"              (Register \u003d\u003e DKL_PCS_DW5 (Port),"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"f0519b3e_e9fd8b38","line":443,"in_reply_to":"868a4456_cca2b3d9","updated":"2026-06-14 12:22:33.000000000","message":"Done","commit_id":"f13177bed301df39486b9f41f09e6acf7150bf05"},{"author":{"_account_id":1000012,"name":"Angel Pons","email":"th3fanbus@gmail.com","username":"th3fanbus","avatars":[{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"17f4200c0fadbfaeb230b03a3840ffb06a804f19","unresolved":false,"context_lines":[{"line_number":28,"context_line":"     (if P \u003c\u003d DDI_TC4"},{"line_number":29,"context_line":"      then Registers.HIP_INDEX_REG0"},{"line_number":30,"context_line":"      else Registers.HIP_INDEX_REG1);"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"   function HIP_INDEX_VAL (P : USBC_Port; Val : Word32) return Word32 is"},{"line_number":33,"context_line":"     (Val * 2 ** (8 * ((GPU_Port\u0027Pos (P) - GPU_Port\u0027Pos (DDI_TC1)) mod 4)));"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"   DKL_DP_MODE : constant Port_Regs_Array :\u003d"},{"line_number":36,"context_line":"     (DDI_TC1 \u003d\u003e Registers.DKL_DP_MODE_1,"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"8ca245fb_ce5ba351","line":33,"range":{"start_line":31,"start_character":1,"end_line":33,"end_character":76},"updated":"2026-06-07 12:25:01.000000000","message":"nit-picking at its finest: the style of this is inconsistent","commit_id":"635583bac82c29d7d358bda6e9426c66be3c6a3c"},{"author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"f4ea53f807b6910032955fcd31ad9f098dc42044","unresolved":false,"context_lines":[{"line_number":28,"context_line":"     (if P \u003c\u003d DDI_TC4"},{"line_number":29,"context_line":"      then Registers.HIP_INDEX_REG0"},{"line_number":30,"context_line":"      else Registers.HIP_INDEX_REG1);"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"   function HIP_INDEX_VAL (P : USBC_Port; Val : Word32) return Word32 is"},{"line_number":33,"context_line":"     (Val * 2 ** (8 * ((GPU_Port\u0027Pos (P) - GPU_Port\u0027Pos (DDI_TC1)) mod 4)));"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"   DKL_DP_MODE : constant Port_Regs_Array :\u003d"},{"line_number":36,"context_line":"     (DDI_TC1 \u003d\u003e Registers.DKL_DP_MODE_1,"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"9d618b20_8b1f61ef","line":33,"range":{"start_line":31,"start_character":1,"end_line":33,"end_character":76},"in_reply_to":"8ca245fb_ce5ba351","updated":"2026-06-14 12:22:33.000000000","message":"Thanks, chose to align this. Turns out I suck at handling other peoples code.\nSomehow I wasn\u0027t motivated to polish it.","commit_id":"635583bac82c29d7d358bda6e9426c66be3c6a3c"},{"author":{"_account_id":1000002,"name":"Thomas Heijligen","email":"src@posteo.de","username":"heijligen","avatars":[{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"549999a0b3d65aaeb1fdecc7b6df2ec9ab366ff6","unresolved":true,"context_lines":[{"line_number":47,"context_line":"      DDI_TC4 \u003d\u003e Registers.DKL_PCS_DW5_4,"},{"line_number":48,"context_line":"      others  \u003d\u003e Registers.Invalid_Register);"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"   function DP_PIN_ASSIGNMENT_SHIFT (P : USBC_Port) return natural"},{"line_number":51,"context_line":"   is"},{"line_number":52,"context_line":"     (case P is"},{"line_number":53,"context_line":"      when DDI_TC1 \u003d\u003e 0,"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"eddbf3de_5298bf76","line":50,"range":{"start_line":50,"start_character":59,"end_line":50,"end_character":66},"updated":"2026-07-20 13:46:09.000000000","message":"nit: `Natural`","commit_id":"3d6c88c4a893525f39041dee9353c9f2391856d4"},{"author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"295e8c838ab8a81e315b0ae08f89620ba0b170f2","unresolved":true,"context_lines":[{"line_number":47,"context_line":"      DDI_TC4 \u003d\u003e Registers.DKL_PCS_DW5_4,"},{"line_number":48,"context_line":"      others  \u003d\u003e Registers.Invalid_Register);"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"   function DP_PIN_ASSIGNMENT_SHIFT (P : USBC_Port) return natural"},{"line_number":51,"context_line":"   is"},{"line_number":52,"context_line":"     (case P is"},{"line_number":53,"context_line":"      when DDI_TC1 \u003d\u003e 0,"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"fb179631_da9da542","line":50,"range":{"start_line":50,"start_character":59,"end_line":50,"end_character":66},"in_reply_to":"eddbf3de_5298bf76","updated":"2026-07-21 12:59:56.000000000","message":"Right... this reminded me that a rebase is due after we enabled the style checks...","commit_id":"3d6c88c4a893525f39041dee9353c9f2391856d4"},{"author":{"_account_id":1000002,"name":"Thomas Heijligen","email":"src@posteo.de","username":"heijligen","avatars":[{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"f34be6f2006fceae1772cc81debf32e1f555ea12","unresolved":false,"context_lines":[{"line_number":47,"context_line":"      DDI_TC4 \u003d\u003e Registers.DKL_PCS_DW5_4,"},{"line_number":48,"context_line":"      others  \u003d\u003e Registers.Invalid_Register);"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"   function DP_PIN_ASSIGNMENT_SHIFT (P : USBC_Port) return natural"},{"line_number":51,"context_line":"   is"},{"line_number":52,"context_line":"     (case P is"},{"line_number":53,"context_line":"      when DDI_TC1 \u003d\u003e 0,"}],"source_content_type":"application/octet-stream","patch_set":4,"id":"df05c454_70063c38","line":50,"range":{"start_line":50,"start_character":59,"end_line":50,"end_character":66},"in_reply_to":"fb179631_da9da542","updated":"2026-07-21 16:41:45.000000000","message":"Done","commit_id":"3d6c88c4a893525f39041dee9353c9f2391856d4"},{"author":{"_account_id":1000002,"name":"Thomas Heijligen","email":"src@posteo.de","username":"heijligen","avatars":[{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"24c1b632a837c2d4133f251e8f2e397e9f7b6dd5","unresolved":true,"context_lines":[{"line_number":327,"context_line":"      function DKL_TX_DPCNTL2_CFG_LOADGENSELECT_TX1 (N : Word32) return Word32"},{"line_number":328,"context_line":"      is"},{"line_number":329,"context_line":"        (Shift_Left (N and 16#3#, 3));"},{"line_number":330,"context_line":"      function DKL_TX_DPCNTL2_CFG_LOADGENSELECT_TX2 (N : Word32) return Word32"},{"line_number":331,"context_line":"      is"},{"line_number":332,"context_line":"        (Shift_Left (N and 16#3#, 5));"},{"line_number":333,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":6,"id":"a2faf72c_f9295a5e","line":330,"updated":"2026-07-27 09:38:05.000000000","message":"nit: Please insert a blank line above.","commit_id":"2016ca4019e056fe32dd8cb44ff6835081e0d987"},{"author":{"_account_id":1000002,"name":"Thomas Heijligen","email":"src@posteo.de","username":"heijligen","avatars":[{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/4285328fce6f2f2d1dcd3409fd9ebcbe.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"350c70c29add40f0a76184f4090c16561e90949b","unresolved":false,"context_lines":[{"line_number":327,"context_line":"      function DKL_TX_DPCNTL2_CFG_LOADGENSELECT_TX1 (N : Word32) return Word32"},{"line_number":328,"context_line":"      is"},{"line_number":329,"context_line":"        (Shift_Left (N and 16#3#, 3));"},{"line_number":330,"context_line":"      function DKL_TX_DPCNTL2_CFG_LOADGENSELECT_TX2 (N : Word32) return Word32"},{"line_number":331,"context_line":"      is"},{"line_number":332,"context_line":"        (Shift_Left (N and 16#3#, 5));"},{"line_number":333,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":6,"id":"a5bf8267_95ce1d07","line":330,"in_reply_to":"a2faf72c_f9295a5e","updated":"2026-07-29 10:04:54.000000000","message":"Done","commit_id":"2016ca4019e056fe32dd8cb44ff6835081e0d987"}]}