)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1000012,"name":"Angel Pons","email":"th3fanbus@gmail.com","username":"th3fanbus","avatars":[{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"c0b136465dfedace8e31e01e817b56fbf5f5a732","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"It\u0027s not physically compatible to Tiger Lake. Hence no binary has"},{"line_number":10,"context_line":"to support both and we can compile them separately. Also, the new"},{"line_number":11,"context_line":"generation actually starts with Alder Lake P, so we name it accor-"},{"line_number":12,"context_line":"dingly."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I66f01609326204d9a93a2206c048bd59bfdbef6b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"c1946a29_4bc5a70f","line":11,"range":{"start_line":11,"start_character":32,"end_line":11,"end_character":44},"updated":"2026-05-30 11:58:43.000000000","message":"Is this because the differences between ADL-P and ADL-S are too significant to treat them the same way?","commit_id":"640b1b2a265f77a2721019d419a551cd34cfc776"},{"author":{"_account_id":1000012,"name":"Angel Pons","email":"th3fanbus@gmail.com","username":"th3fanbus","avatars":[{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"954d776a77e37071a68ac9746d447fa084853bc7","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"It\u0027s not physically compatible to Tiger Lake. Hence no binary has"},{"line_number":10,"context_line":"to support both and we can compile them separately. Also, the new"},{"line_number":11,"context_line":"generation actually starts with Alder Lake P, so we name it accor-"},{"line_number":12,"context_line":"dingly."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I66f01609326204d9a93a2206c048bd59bfdbef6b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"f8fa1f34_be7da649","line":11,"range":{"start_line":11,"start_character":32,"end_line":11,"end_character":44},"in_reply_to":"c1946a29_4bc5a70f","updated":"2026-05-30 11:59:21.000000000","message":"I think so, I remember noticing that the iGPU in ADL-S was more similar to TGL-H than ADL-P in some regards.","commit_id":"640b1b2a265f77a2721019d419a551cd34cfc776"},{"author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"52f1a115ce323492b9705b637683d9b18789074a","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"It\u0027s not physically compatible to Tiger Lake. Hence no binary has"},{"line_number":10,"context_line":"to support both and we can compile them separately. Also, the new"},{"line_number":11,"context_line":"generation actually starts with Alder Lake P, so we name it accor-"},{"line_number":12,"context_line":"dingly."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I66f01609326204d9a93a2206c048bd59bfdbef6b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"71a46943_20a36f8a","line":11,"range":{"start_line":11,"start_character":32,"end_line":11,"end_character":44},"in_reply_to":"f8fa1f34_be7da649","updated":"2026-06-06 10:38:52.000000000","message":"\u003e I think so, I remember noticing that the iGPU in ADL-S was more similar to TGL-H than ADL-P in some regards.\n\nYep, you\u0027re right. The differences between TGL-H and ADL-S can probably be covered\nwith the Config package and a few if\u0027s. ADL-P, OTOH, has much different Power\nDomains, though I think I boiled it down pretty far :D\n\nIt wouldn\u0027t be too hard to support all of them with one binary. But shouldn\u0027t be\nnecessary, as there is no board that could support more than one of them.\n\nThe code is also tested with RPL-P btw. Haven\u0027t found anything to change, yet.\nActually, early and later ADL-P steppings seem to be more different than later\nADL-P and RPL-P.","commit_id":"640b1b2a265f77a2721019d419a551cd34cfc776"}],"common/hw-gfx-gma-config.ads.template":[{"author":{"_account_id":1000012,"name":"Angel Pons","email":"th3fanbus@gmail.com","username":"th3fanbus","avatars":[{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"c0b136465dfedace8e31e01e817b56fbf5f5a732","unresolved":false,"context_lines":[{"line_number":187,"context_line":"   Cannon_Point_On   : \u003cgenbool\u003e :\u003d Skylake_On and then PCH \u003e\u003d Cannon_Point;"},{"line_number":188,"context_line":"   Tiger_Point_On    : \u003cgenbool\u003e :\u003d Tigerlake_On and then PCH \u003e\u003d Tiger_Point;"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"   pragma Warnings (GNAT, Off, \"condition can only be * if invalid values present\");"},{"line_number":191,"context_line":"   Is_ULT            : \u003chswskltglbool\u003e :\u003d CPU_Var \u003d ULT;"},{"line_number":192,"context_line":"   Is_ULX            : \u003chswsklbool\u003e    :\u003d CPU_Var \u003d ULX;"},{"line_number":193,"context_line":"   Is_LP             : \u003chswskltglbool\u003e :\u003d Is_ULT or Is_ULX;"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"5d284dd5_bc6a2f7c","line":190,"updated":"2026-05-30 11:58:43.000000000","message":"What\u0027s the reason to suppress this warning? Unavoidable for certain configs?","commit_id":"640b1b2a265f77a2721019d419a551cd34cfc776"},{"author":{"_account_id":1000012,"name":"Angel Pons","email":"th3fanbus@gmail.com","username":"th3fanbus","avatars":[{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"f6a147f404465967c7a536b910c6a2fb24185341","unresolved":false,"context_lines":[{"line_number":187,"context_line":"   Cannon_Point_On   : \u003cgenbool\u003e :\u003d Skylake_On and then PCH \u003e\u003d Cannon_Point;"},{"line_number":188,"context_line":"   Tiger_Point_On    : \u003cgenbool\u003e :\u003d Tigerlake_On and then PCH \u003e\u003d Tiger_Point;"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"   pragma Warnings (GNAT, Off, \"condition can only be * if invalid values present\");"},{"line_number":191,"context_line":"   Is_ULT            : \u003chswskltglbool\u003e :\u003d CPU_Var \u003d ULT;"},{"line_number":192,"context_line":"   Is_ULX            : \u003chswsklbool\u003e    :\u003d CPU_Var \u003d ULX;"},{"line_number":193,"context_line":"   Is_LP             : \u003chswskltglbool\u003e :\u003d Is_ULT or Is_ULX;"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"b798495c_7c567862","line":190,"in_reply_to":"10f1ba20_bc0bee2d","updated":"2026-06-12 15:21:35.000000000","message":"Ack, thank you!","commit_id":"640b1b2a265f77a2721019d419a551cd34cfc776"},{"author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"9f08c21e6415f47f63ba568e6efb70c29445c313","unresolved":false,"context_lines":[{"line_number":187,"context_line":"   Cannon_Point_On   : \u003cgenbool\u003e :\u003d Skylake_On and then PCH \u003e\u003d Cannon_Point;"},{"line_number":188,"context_line":"   Tiger_Point_On    : \u003cgenbool\u003e :\u003d Tigerlake_On and then PCH \u003e\u003d Tiger_Point;"},{"line_number":189,"context_line":""},{"line_number":190,"context_line":"   pragma Warnings (GNAT, Off, \"condition can only be * if invalid values present\");"},{"line_number":191,"context_line":"   Is_ULT            : \u003chswskltglbool\u003e :\u003d CPU_Var \u003d ULT;"},{"line_number":192,"context_line":"   Is_ULX            : \u003chswsklbool\u003e    :\u003d CPU_Var \u003d ULX;"},{"line_number":193,"context_line":"   Is_LP             : \u003chswskltglbool\u003e :\u003d Is_ULT or Is_ULX;"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"10f1ba20_bc0bee2d","line":190,"in_reply_to":"5d284dd5_bc6a2f7c","updated":"2026-06-12 05:44:14.000000000","message":"Right. Before, the expression was more complex to ensure that `CPU_Var` only\ngets evaluated for generations where it could have such a value. I thought it\u0027s\ntoo inconvenient to extend. This way, at least the expressions are readable.","commit_id":"640b1b2a265f77a2721019d419a551cd34cfc776"},{"author":{"_account_id":1000012,"name":"Angel Pons","email":"th3fanbus@gmail.com","username":"th3fanbus","avatars":[{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"c0b136465dfedace8e31e01e817b56fbf5f5a732","unresolved":false,"context_lines":[{"line_number":583,"context_line":"      Device_Id \u003d 16#a7ab# or"},{"line_number":584,"context_line":"      Device_Id \u003d 16#a7ac# or"},{"line_number":585,"context_line":"      Device_Id \u003d 16#a7ad#);"},{"line_number":586,"context_line":"   function Is_Alder_Lake_P_Gen (Device_Id : Word16) return Boolean is"},{"line_number":587,"context_line":"     (Is_Alder_Lake_P (Device_Id) or"},{"line_number":588,"context_line":"      Is_Alder_Lake_N (Device_Id) or"},{"line_number":589,"context_line":"      Is_Raptor_Lake_P (Device_Id));"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"8e40f4d1_0d485bb6","line":586,"range":{"start_line":586,"start_character":27,"end_line":586,"end_character":31},"updated":"2026-05-30 11:58:43.000000000","message":"Ah, if it\u0027s part of the ADL-P family, IIRC also known as XeLPD. Maybe we could rename the `AlderlakeP` generation to `XeLPD`","commit_id":"640b1b2a265f77a2721019d419a551cd34cfc776"},{"author":{"_account_id":1000012,"name":"Angel Pons","email":"th3fanbus@gmail.com","username":"th3fanbus","avatars":[{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"f6a147f404465967c7a536b910c6a2fb24185341","unresolved":false,"context_lines":[{"line_number":583,"context_line":"      Device_Id \u003d 16#a7ab# or"},{"line_number":584,"context_line":"      Device_Id \u003d 16#a7ac# or"},{"line_number":585,"context_line":"      Device_Id \u003d 16#a7ad#);"},{"line_number":586,"context_line":"   function Is_Alder_Lake_P_Gen (Device_Id : Word16) return Boolean is"},{"line_number":587,"context_line":"     (Is_Alder_Lake_P (Device_Id) or"},{"line_number":588,"context_line":"      Is_Alder_Lake_N (Device_Id) or"},{"line_number":589,"context_line":"      Is_Raptor_Lake_P (Device_Id));"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"259b155f_e48550ff","line":586,"range":{"start_line":586,"start_character":27,"end_line":586,"end_character":31},"in_reply_to":"3d49db72_92dcbfbb","updated":"2026-06-12 15:21:35.000000000","message":"Ack. Could always try asking Linux kernel driver maintainers for insight too.","commit_id":"640b1b2a265f77a2721019d419a551cd34cfc776"},{"author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"9f08c21e6415f47f63ba568e6efb70c29445c313","unresolved":false,"context_lines":[{"line_number":583,"context_line":"      Device_Id \u003d 16#a7ab# or"},{"line_number":584,"context_line":"      Device_Id \u003d 16#a7ac# or"},{"line_number":585,"context_line":"      Device_Id \u003d 16#a7ad#);"},{"line_number":586,"context_line":"   function Is_Alder_Lake_P_Gen (Device_Id : Word16) return Boolean is"},{"line_number":587,"context_line":"     (Is_Alder_Lake_P (Device_Id) or"},{"line_number":588,"context_line":"      Is_Alder_Lake_N (Device_Id) or"},{"line_number":589,"context_line":"      Is_Raptor_Lake_P (Device_Id));"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"3d49db72_92dcbfbb","line":586,"range":{"start_line":586,"start_character":27,"end_line":586,"end_character":31},"in_reply_to":"8e40f4d1_0d485bb6","updated":"2026-06-12 05:44:14.000000000","message":"I thought about it. But so far I\u0027ve seen these Xe names only show up in Intel\u0027s\ncode. And they are not very easy to distinguish, e.g. there\u0027s also an XeLPDP.\nWithout knowing the pattern, I\u0027d like to stick to codenames people are used to.\n\nShould we ever try to support their dGPUs, there might be more overlap and reason\nto change it, though.","commit_id":"640b1b2a265f77a2721019d419a551cd34cfc776"}]}