)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"2049019323617c228dbf762e76d524c40355f20b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"476818a9_e9f95044","updated":"2026-04-12 16:38:20.000000000","message":"Trying the bot... hope this doesn\u0027t explode /o\\\n\n(there are currently warnings because of the incomplete\ntigerlake code, but we can override a negative review.)","commit_id":"2a68b84af2289123dd02ab1840e12425893a7a9e"},{"author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"1858410a214456294b5c11f8ba7f5615de206b8a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c8b34536_a1ad8af8","in_reply_to":"444a2461_cff93ef2","updated":"2026-04-12 16:59:02.000000000","message":"Unsure what went wrong. I\u0027ve taken it down for now, will continue tomorrow.","commit_id":"2a68b84af2289123dd02ab1840e12425893a7a9e"},{"author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"64c13e777e673a2280f2506bbf5923e105474045","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"444a2461_cff93ef2","in_reply_to":"476818a9_e9f95044","updated":"2026-04-12 16:50:34.000000000","message":"This almost worked. I had to publish the draft comments manually, though.","commit_id":"2a68b84af2289123dd02ab1840e12425893a7a9e"},{"author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"509518f2836fce0ce0d5e8a22ef9331f0f401856","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"38b96fc5_320c78b3","in_reply_to":"c8b34536_a1ad8af8","updated":"2026-04-12 21:48:41.000000000","message":"I forgot to allow it to vote on `Verified\u0027 😆\n\nShould work now (tm)","commit_id":"2a68b84af2289123dd02ab1840e12425893a7a9e"},{"author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"27e34551de406125f4f838b8adc270b413a098db","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"55a38f37_bde5958c","updated":"2026-04-15 20:56:53.000000000","message":"I forgot: my testing attempts turned into a no-op, alas 🫤\nMy T60 has ATI graphics, another board has VGA only.","commit_id":"910165bf6d56e026d641c2d89994b0d162471d93"},{"author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"7b7b7ee02b96e680cea55d81b5d58a9c2af613d3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"548d17f2_0c4df033","updated":"2026-04-15 20:54:23.000000000","message":"Left some comments, nothing too serious except for the now unresolved warning.\nI know it\u0027s already reviewed, so I\u0027ve only looked quickly through the generic\ncode, nothing in i945. I looks quite nice overall!","commit_id":"910165bf6d56e026d641c2d89994b0d162471d93"},{"author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"a5c97daaa8953d43ec1c47a964e41b0f2275e06d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2e7cc853_89e6471d","updated":"2026-04-15 15:02:11.000000000","message":"Tested a rebase of TGL on this, works fine 😉\nWill have another look later","commit_id":"910165bf6d56e026d641c2d89994b0d162471d93"},{"author":{"_account_id":1000012,"name":"Angel Pons","email":"th3fanbus@gmail.com","username":"th3fanbus","avatars":[{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"eeeb6e9ecce131ebcdc805155bcf989d5f486130","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"26c3ff92_1ad12fd2","in_reply_to":"548d17f2_0c4df033","updated":"2026-04-19 07:28:54.000000000","message":"I just found one minor thing but overall I think it\u0027s good to go","commit_id":"910165bf6d56e026d641c2d89994b0d162471d93"},{"author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"70e9f1941437514f95882be1572078db4cdab67e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"06504cb9_6dfaa3bb","updated":"2026-06-04 21:11:48.000000000","message":"Fixed the two remaining open comments. And rebased tgl/adl on top.","commit_id":"8d3f5ed4bd0d4b85007cfeaf6fac217bf53d86d8"}],"common/Makefile.inc":[{"author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"7b7b7ee02b96e680cea55d81b5d58a9c2af613d3","unresolved":false,"context_lines":[{"line_number":62,"context_line":"CONFIG_GFX_GMA_ANALOG_I2C_PORT\t:\u003d $(call strip_quotes,$(CONFIG_GFX_GMA_ANALOG_I2C_PORT))"},{"line_number":63,"context_line":"CONFIG_GFX_GMA_IGNORE_PRESENCE_STRAPS :\u003d $(if $(filter y,$(CONFIG_GFX_GMA_IGNORE_PRESENCE_STRAPS)),True,False)"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"_GEN_TLA_SUBSTITUTIONS :\u003d i945 g45 ilk hsw skl tgl"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"_GEN_NONCONST :\u003d $(strip \\"},{"line_number":68,"context_line":"\t\t $(if $(filter I945,$(CONFIG_GFX_GMA_GENERATION)),i945, \\"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"451e2b45_48f04175","line":65,"updated":"2026-04-15 20:54:23.000000000","message":"The sed scripts below are quite ugly, pretty much my fault. They assume that\nthese are exactly three characters long. It works for `i945` as long as it\u0027s\nthe first in an identifier. e.g. `\u003c$(gen)\\(...\\)*var\u003e` matches `\u003ci945g45var\u003e`\nbut not `\u003cg45i945var\u003e`.\n\nNot necessarily something to worry about now. I was hoping to replace the\nscripts anyway, because newer gnatprove features will make the `constant bool`\nsituation more difficult. maybe `awk`?","commit_id":"910165bf6d56e026d641c2d89994b0d162471d93"}],"common/hw-gfx-gma-config.ads.template":[{"author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"7b7b7ee02b96e680cea55d81b5d58a9c2af613d3","unresolved":false,"context_lines":[{"line_number":268,"context_line":"   Has_DSPCNTR_Pipe_Select       : \u003cgenbool\u003e :\u003d Up_To_G45;"},{"line_number":269,"context_line":"   -- Gen3: Plane A feeds Pipe B, Plane B feeds Pipe A (for FBC + LVDS)"},{"line_number":270,"context_line":"   Planes_Pipes_Swapped          : \u003cgenbool\u003e :\u003d Gen_I945;"},{"line_number":271,"context_line":"   Has_Broadwell_CDClk           : \u003chswbool\u003e :\u003d CPU_Broadwell;"},{"line_number":272,"context_line":"   Can_Switch_CDClk              : \u003chswbool\u003e :\u003d Broadwell_On;"},{"line_number":273,"context_line":"   Has_Fractional_RawClk         : \u003cgenbool\u003e :\u003d Cannon_Point_On;"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"   ----------- DDI: -------------"},{"line_number":276,"context_line":"   End_EDP_Training_Late         : \u003cgenbool\u003e :\u003d Gen_Haswell;"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"798c4a0e_8522ce02","line":273,"range":{"start_line":271,"start_character":0,"end_line":273,"end_character":64},"updated":"2026-04-15 20:54:23.000000000","message":"Cosmetic: These actually belong up to the \"Clocks\" heading.","commit_id":"910165bf6d56e026d641c2d89994b0d162471d93"},{"author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"7b7b7ee02b96e680cea55d81b5d58a9c2af613d3","unresolved":false,"context_lines":[{"line_number":365,"context_line":""},{"line_number":366,"context_line":"   ----------------------------------------------------------------------------"},{"line_number":367,"context_line":""},{"line_number":368,"context_line":"   Default_CDClk_Freq : \u003ci945ilkhswvar\u003e CDClk_Range :\u003d"},{"line_number":369,"context_line":"     (if    Gen_I945                         then 200_000_000  -- unused, depends on GCFGC"},{"line_number":370,"context_line":"      elsif Gen_G45                          then 320_000_000  -- unused"},{"line_number":371,"context_line":"      elsif CPU_Ironlake                     then 450_000_000"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"bd4ce07b_63f8e79c","line":368,"range":{"start_line":368,"start_character":25,"end_line":368,"end_character":29},"updated":"2026-04-15 20:54:23.000000000","message":"Nit, actually constant for i945?","commit_id":"910165bf6d56e026d641c2d89994b0d162471d93"},{"author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"7b7b7ee02b96e680cea55d81b5d58a9c2af613d3","unresolved":false,"context_lines":[{"line_number":435,"context_line":""},{"line_number":436,"context_line":"   GTT_PTE_Size : \u003chswvar\u003e Natural :\u003d (if Has_64bit_GTT then 8 else 4);"},{"line_number":437,"context_line":""},{"line_number":438,"context_line":"   Fence_Base : \u003ci945ilkvar\u003e Natural :\u003d"},{"line_number":439,"context_line":"     (if    Gen_I945         then 16#0000_2000#"},{"line_number":440,"context_line":"      elsif not Sandybridge_On then 16#0000_3000#"},{"line_number":441,"context_line":"      else                          16#0010_0000#);"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"c8b10621_10817860","line":438,"range":{"start_line":438,"start_character":17,"end_line":438,"end_character":21},"updated":"2026-04-15 20:54:23.000000000","message":"Nit, constant for i945?","commit_id":"910165bf6d56e026d641c2d89994b0d162471d93"},{"author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"7b7b7ee02b96e680cea55d81b5d58a9c2af613d3","unresolved":false,"context_lines":[{"line_number":436,"context_line":"   GTT_PTE_Size : \u003chswvar\u003e Natural :\u003d (if Has_64bit_GTT then 8 else 4);"},{"line_number":437,"context_line":""},{"line_number":438,"context_line":"   Fence_Base : \u003ci945ilkvar\u003e Natural :\u003d"},{"line_number":439,"context_line":"     (if    Gen_I945         then 16#0000_2000#"},{"line_number":440,"context_line":"      elsif not Sandybridge_On then 16#0000_3000#"},{"line_number":441,"context_line":"      else                          16#0010_0000#);"},{"line_number":442,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":2,"id":"f9f89428_35a83dda","line":439,"updated":"2026-04-15 20:54:23.000000000","message":"Cosmetic, alignment: two more spaces before `then`?","commit_id":"910165bf6d56e026d641c2d89994b0d162471d93"}],"common/hw-gfx-gma-connectors.ads":[{"author":{"_account_id":1000029,"name":"Ada SPARK","email":"gnatbot@sourcearcade.org","username":"gnatbot","avatars":[{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"4d990d31fcbe64a42a022a3bd359770a1b1ed4b8","unresolved":false,"context_lines":[{"line_number":36,"context_line":"   pragma Warnings (GNATprove, On, \"unused variable \"\"P*\"\"\");"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"   procedure Pre_Off (Port_Cfg : Port_Config);"},{"line_number":39,"context_line":"   procedure Post_Off (Port_Cfg : Port_Config);"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"   procedure Pre_All_Off;"},{"line_number":42,"context_line":"   procedure Post_All_Off;"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"f3a12592_dd4e0ecd","line":39,"updated":"2026-04-12 16:49:12.000000000","message":"Config(s): alderlake tigerlake\n```\nhw-gfx-gma-connectors.ads:39: warning: subprogram \"Post_Off\" has no effect\n   39 |   procedure Post_Off (Port_Cfg : Port_Config);\n      |             ^ here\n```","commit_id":"2a68b84af2289123dd02ab1840e12425893a7a9e"},{"author":{"_account_id":1000029,"name":"Ada SPARK","email":"gnatbot@sourcearcade.org","username":"gnatbot","avatars":[{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"4d990d31fcbe64a42a022a3bd359770a1b1ed4b8","unresolved":false,"context_lines":[{"line_number":39,"context_line":"   procedure Post_Off (Port_Cfg : Port_Config);"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"   procedure Pre_All_Off;"},{"line_number":42,"context_line":"   procedure Post_All_Off;"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"end HW.GFX.GMA.Connectors;"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"73db7462_01d9818f","line":42,"updated":"2026-04-12 16:49:12.000000000","message":"Config(s): tigerlake alderlake\n```\nhw-gfx-gma-connectors.ads:42: warning: subprogram \"Post_All_Off\" has no effect\n   42 |   procedure Post_All_Off;\n      |             ^ here\n```","commit_id":"2a68b84af2289123dd02ab1840e12425893a7a9e"},{"author":{"_account_id":1000029,"name":"Ada SPARK","email":"gnatbot@sourcearcade.org","username":"gnatbot","avatars":[{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"f542987196cc22c2d00d847d1a097d4536f3cb7a","unresolved":false,"context_lines":[{"line_number":36,"context_line":"   pragma Warnings (GNATprove, On, \"unused variable \"\"P*\"\"\");"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"   procedure Pre_Off (Port_Cfg : Port_Config);"},{"line_number":39,"context_line":"   procedure Post_Off (Port_Cfg : Port_Config);"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"   procedure Pre_All_Off;"},{"line_number":42,"context_line":"   procedure Post_All_Off;"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"7a0732f2_2c2dccf8","line":39,"updated":"2026-04-15 12:50:27.000000000","message":"Config(s): tigerlake alderlake\n```\nhw-gfx-gma-connectors.ads:39: warning: subprogram \"Post_Off\" has no effect\n   39 |   procedure Post_Off (Port_Cfg : Port_Config);\n      |             ^ here\n```","commit_id":"910165bf6d56e026d641c2d89994b0d162471d93"},{"author":{"_account_id":1000029,"name":"Ada SPARK","email":"gnatbot@sourcearcade.org","username":"gnatbot","avatars":[{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"f542987196cc22c2d00d847d1a097d4536f3cb7a","unresolved":false,"context_lines":[{"line_number":39,"context_line":"   procedure Post_Off (Port_Cfg : Port_Config);"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"   procedure Pre_All_Off;"},{"line_number":42,"context_line":"   procedure Post_All_Off;"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"end HW.GFX.GMA.Connectors;"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"fe3dc146_c817b746","line":42,"updated":"2026-04-15 12:50:27.000000000","message":"Config(s): alderlake tigerlake\n```\nhw-gfx-gma-connectors.ads:42: warning: subprogram \"Post_All_Off\" has no effect\n   42 |   procedure Post_All_Off;\n      |             ^ here\n```","commit_id":"910165bf6d56e026d641c2d89994b0d162471d93"},{"author":{"_account_id":1000029,"name":"Ada SPARK","email":"gnatbot@sourcearcade.org","username":"gnatbot","avatars":[{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"7686d1c2071b6825ba0cb8ce9c9307f8674e376f","unresolved":false,"context_lines":[{"line_number":36,"context_line":"   pragma Warnings (GNATprove, On, \"unused variable \"\"P*\"\"\");"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"   procedure Pre_Off (Port_Cfg : Port_Config);"},{"line_number":39,"context_line":"   procedure Post_Off (Port_Cfg : Port_Config);"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"   procedure Pre_All_Off;"},{"line_number":42,"context_line":"   procedure Post_All_Off;"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"0d961aed_e3ed1c18","line":39,"updated":"2026-06-04 21:08:25.000000000","message":"Config(s): tigerlake alderlake\n```\nhw-gfx-gma-connectors.ads:39: warning: subprogram \"Post_Off\" has no effect\n   39 |   procedure Post_Off (Port_Cfg : Port_Config);\n      |             ^ here\n```","commit_id":"8d3f5ed4bd0d4b85007cfeaf6fac217bf53d86d8"},{"author":{"_account_id":1000029,"name":"Ada SPARK","email":"gnatbot@sourcearcade.org","username":"gnatbot","avatars":[{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"7686d1c2071b6825ba0cb8ce9c9307f8674e376f","unresolved":false,"context_lines":[{"line_number":39,"context_line":"   procedure Post_Off (Port_Cfg : Port_Config);"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"   procedure Pre_All_Off;"},{"line_number":42,"context_line":"   procedure Post_All_Off;"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"end HW.GFX.GMA.Connectors;"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"18c2274b_bd53d354","line":42,"updated":"2026-06-04 21:08:25.000000000","message":"Config(s): alderlake tigerlake\n```\nhw-gfx-gma-connectors.ads:42: warning: subprogram \"Post_All_Off\" has no effect\n   42 |   procedure Post_All_Off;\n      |             ^ here\n```","commit_id":"8d3f5ed4bd0d4b85007cfeaf6fac217bf53d86d8"}],"common/hw-gfx-gma-display_probing.adb":[{"author":{"_account_id":1000012,"name":"Angel Pons","email":"th3fanbus@gmail.com","username":"th3fanbus","avatars":[{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"eeeb6e9ecce131ebcdc805155bcf989d5f486130","unresolved":false,"context_lines":[{"line_number":214,"context_line":"      if Config.LVDS_Needs_Pipe_B and"},{"line_number":215,"context_line":"         Configs (Primary).Port \u003d LVDS"},{"line_number":216,"context_line":"      then"},{"line_number":217,"context_line":"         declare"},{"line_number":218,"context_line":"            Tmp : constant Pipe_Config :\u003d Configs (Secondary);"},{"line_number":219,"context_line":"         begin"},{"line_number":220,"context_line":"            Configs (Secondary) :\u003d Configs (Primary);"},{"line_number":221,"context_line":"            Configs (Primary) :\u003d Tmp;"},{"line_number":222,"context_line":"         end;"},{"line_number":223,"context_line":"      end if;"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"      -- Restore power settings"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"e18d176e_a8abde8d","line":222,"range":{"start_line":217,"start_character":9,"end_line":222,"end_character":13},"updated":"2026-04-19 07:28:54.000000000","message":"Is there a \"swap\" procedure in Ada?","commit_id":"910165bf6d56e026d641c2d89994b0d162471d93"}],"common/hw-gfx-gma-pipe_setup.adb":[{"author":{"_account_id":1000029,"name":"Ada SPARK","email":"gnatbot@sourcearcade.org","username":"gnatbot","avatars":[{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"4d990d31fcbe64a42a022a3bd359770a1b1ed4b8","unresolved":false,"context_lines":[{"line_number":427,"context_line":"      return Width_Type is ((Val * Num) / Denom)"},{"line_number":428,"context_line":"   with"},{"line_number":429,"context_line":"      Pre \u003d\u003e Denom \u003c\u003d Num and Val * Num \u003c Max * Denom,"},{"line_number":430,"context_line":"      Post \u003d\u003e Scale\u0027Result \u003c Max;"},{"line_number":431,"context_line":""},{"line_number":432,"context_line":"   procedure Scale_Keep_Aspect"},{"line_number":433,"context_line":"     (Width       :    out Width_Type;"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"fb99c7d0_0cd6a93d","line":430,"updated":"2026-04-12 16:49:12.000000000","message":"Config(s): i945 broxton ironlake_edp tigerlake g45 alderlake haswell skylake ironlake\n```\nhw-gfx-gma-pipe_setup.adb:430: medium: postcondition might fail, cannot prove Scale\u0027Result \u003c Max\n  430 |      Post \u003d\u003e Scale\u0027Result \u003c Max;\n      |              ^ here\n```","commit_id":"2a68b84af2289123dd02ab1840e12425893a7a9e"},{"author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"7b7b7ee02b96e680cea55d81b5d58a9c2af613d3","unresolved":false,"context_lines":[{"line_number":317,"context_line":"            Value    \u003d\u003e DSPCNTR_ENABLE or PRI or"},{"line_number":318,"context_line":"                        DSPCNTR_TILED_SURFACE (FB.Tiling));"},{"line_number":319,"context_line":"      end if;"},{"line_number":320,"context_line":"   end Setup_Hires_Plane;"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"   procedure Setup_Display"},{"line_number":323,"context_line":"     (Controller  : Controller_Type;"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"2a5431d4_68e3e403","line":320,"updated":"2026-04-15 20:54:23.000000000","message":"NB, this procedure has many branches now. Probably a good idea to split it in the future:\n* one for generations w/o DSPSURF\n* one for generations with it\n* one for PLANE_CTL\n\n(Has_DSP_Linoff would be another possible cut)","commit_id":"910165bf6d56e026d641c2d89994b0d162471d93"},{"author":{"_account_id":1000029,"name":"Ada SPARK","email":"gnatbot@sourcearcade.org","username":"gnatbot","avatars":[{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"f542987196cc22c2d00d847d1a097d4536f3cb7a","unresolved":false,"context_lines":[{"line_number":427,"context_line":"      return Width_Type is ((Val * Num) / Denom)"},{"line_number":428,"context_line":"   with"},{"line_number":429,"context_line":"      Pre \u003d\u003e Denom \u003c\u003d Num and Val * Num \u003c Max * Denom,"},{"line_number":430,"context_line":"      Post \u003d\u003e Scale\u0027Result \u003c Max;"},{"line_number":431,"context_line":""},{"line_number":432,"context_line":"   procedure Scale_Keep_Aspect"},{"line_number":433,"context_line":"     (Width       :    out Width_Type;"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"cb85189c_99735857","line":430,"updated":"2026-04-15 12:50:27.000000000","message":"Config(s): g45 ironlake alderlake ironlake_edp i945 tigerlake haswell broxton skylake\n```\nhw-gfx-gma-pipe_setup.adb:430: medium: postcondition might fail, cannot prove Scale\u0027Result \u003c Max\n  430 |      Post \u003d\u003e Scale\u0027Result \u003c Max;\n      |              ^ here\n```","commit_id":"910165bf6d56e026d641c2d89994b0d162471d93"},{"author":{"_account_id":1000029,"name":"Ada SPARK","email":"gnatbot@sourcearcade.org","username":"gnatbot","avatars":[{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"7686d1c2071b6825ba0cb8ce9c9307f8674e376f","unresolved":false,"context_lines":[{"line_number":427,"context_line":"      return Width_Type is ((Val * Num) / Denom)"},{"line_number":428,"context_line":"   with"},{"line_number":429,"context_line":"      Pre \u003d\u003e Denom \u003c\u003d Num and Val * Num \u003c Max * Denom,"},{"line_number":430,"context_line":"      Post \u003d\u003e Scale\u0027Result \u003c Max;"},{"line_number":431,"context_line":""},{"line_number":432,"context_line":"   procedure Scale_Keep_Aspect"},{"line_number":433,"context_line":"     (Width       :    out Width_Type;"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"f90b8b02_53962aea","line":430,"updated":"2026-06-04 21:08:25.000000000","message":"Config(s): tigerlake ironlake_edp broxton ironlake skylake alderlake i945 g45 haswell\n```\nhw-gfx-gma-pipe_setup.adb:430: medium: postcondition might fail, cannot prove Scale\u0027Result \u003c Max\n  430 |      Post \u003d\u003e Scale\u0027Result \u003c Max;\n      |              ^ here\n```","commit_id":"8d3f5ed4bd0d4b85007cfeaf6fac217bf53d86d8"}],"common/hw-gfx-gma-port_detect.ads":[{"author":{"_account_id":1000029,"name":"Ada SPARK","email":"gnatbot@sourcearcade.org","username":"gnatbot","avatars":[{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"4d990d31fcbe64a42a022a3bd359770a1b1ed4b8","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"private package HW.GFX.GMA.Port_Detect is"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"   procedure Initialize;"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"   procedure Hotplug_Detect"},{"line_number":20,"context_line":"     (Port     : in Active_Port_Type;"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"bd894bb9_a36ad005","line":17,"updated":"2026-04-12 16:49:12.000000000","message":"Config(s): alderlake tigerlake\n```\nhw-gfx-gma-port_detect.ads:17: warning: subprogram \"Initialize\" has no effect\n   17 |   procedure Initialize;\n      |             ^ here\n```","commit_id":"2a68b84af2289123dd02ab1840e12425893a7a9e"},{"author":{"_account_id":1000029,"name":"Ada SPARK","email":"gnatbot@sourcearcade.org","username":"gnatbot","avatars":[{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"4d990d31fcbe64a42a022a3bd359770a1b1ed4b8","unresolved":false,"context_lines":[{"line_number":17,"context_line":"   procedure Initialize;"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"   procedure Hotplug_Detect"},{"line_number":20,"context_line":"     (Port     : in Active_Port_Type;"},{"line_number":21,"context_line":"      Detected : out Boolean);"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"   procedure Clear_Hotplug_Detect (Port : Active_Port_Type);"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"1f153552_5e3ff07b","line":20,"updated":"2026-04-12 16:49:12.000000000","message":"Config(s): tigerlake alderlake\n```\nhw-gfx-gma-port_detect.ads:20: warning: unused variable \"Port\"\n   20 |     (Port     : in Active_Port_Type;\n      |      ^ here\n```","commit_id":"2a68b84af2289123dd02ab1840e12425893a7a9e"},{"author":{"_account_id":1000029,"name":"Ada SPARK","email":"gnatbot@sourcearcade.org","username":"gnatbot","avatars":[{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"4d990d31fcbe64a42a022a3bd359770a1b1ed4b8","unresolved":false,"context_lines":[{"line_number":20,"context_line":"     (Port     : in Active_Port_Type;"},{"line_number":21,"context_line":"      Detected : out Boolean);"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"   procedure Clear_Hotplug_Detect (Port : Active_Port_Type);"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"end HW.GFX.GMA.Port_Detect;"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"217e0836_ac867fb7","line":23,"updated":"2026-04-12 16:49:12.000000000","message":"Config(s): alderlake tigerlake\n```\nhw-gfx-gma-port_detect.ads:23: warning: subprogram \"Clear_Hotplug_Detect\" has no effect\n   23 |   procedure Clear_Hotplug_Detect (Port : Active_Port_Type);\n      |             ^ here\n```","commit_id":"2a68b84af2289123dd02ab1840e12425893a7a9e"},{"author":{"_account_id":1000029,"name":"Ada SPARK","email":"gnatbot@sourcearcade.org","username":"gnatbot","avatars":[{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"f542987196cc22c2d00d847d1a097d4536f3cb7a","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"private package HW.GFX.GMA.Port_Detect is"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"   procedure Initialize;"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"   procedure Hotplug_Detect"},{"line_number":20,"context_line":"     (Port     : in Active_Port_Type;"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"857796f1_1a26218c","line":17,"updated":"2026-04-15 12:50:27.000000000","message":"Config(s): alderlake tigerlake\n```\nhw-gfx-gma-port_detect.ads:17: warning: subprogram \"Initialize\" has no effect\n   17 |   procedure Initialize;\n      |             ^ here\n```","commit_id":"910165bf6d56e026d641c2d89994b0d162471d93"},{"author":{"_account_id":1000029,"name":"Ada SPARK","email":"gnatbot@sourcearcade.org","username":"gnatbot","avatars":[{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"f542987196cc22c2d00d847d1a097d4536f3cb7a","unresolved":false,"context_lines":[{"line_number":17,"context_line":"   procedure Initialize;"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"   procedure Hotplug_Detect"},{"line_number":20,"context_line":"     (Port     : in Active_Port_Type;"},{"line_number":21,"context_line":"      Detected : out Boolean);"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"   procedure Clear_Hotplug_Detect (Port : Active_Port_Type);"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"9c763878_b072f621","line":20,"updated":"2026-04-15 12:50:27.000000000","message":"Config(s): tigerlake alderlake\n```\nhw-gfx-gma-port_detect.ads:20: warning: unused variable \"Port\"\n   20 |     (Port     : in Active_Port_Type;\n      |      ^ here\n```","commit_id":"910165bf6d56e026d641c2d89994b0d162471d93"},{"author":{"_account_id":1000029,"name":"Ada SPARK","email":"gnatbot@sourcearcade.org","username":"gnatbot","avatars":[{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"f542987196cc22c2d00d847d1a097d4536f3cb7a","unresolved":false,"context_lines":[{"line_number":20,"context_line":"     (Port     : in Active_Port_Type;"},{"line_number":21,"context_line":"      Detected : out Boolean);"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"   procedure Clear_Hotplug_Detect (Port : Active_Port_Type);"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"end HW.GFX.GMA.Port_Detect;"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"5a6ea3e2_6f721e1f","line":23,"updated":"2026-04-15 12:50:27.000000000","message":"Config(s): tigerlake alderlake\n```\nhw-gfx-gma-port_detect.ads:23: warning: subprogram \"Clear_Hotplug_Detect\" has no effect\n   23 |   procedure Clear_Hotplug_Detect (Port : Active_Port_Type);\n      |             ^ here\n```","commit_id":"910165bf6d56e026d641c2d89994b0d162471d93"},{"author":{"_account_id":1000029,"name":"Ada SPARK","email":"gnatbot@sourcearcade.org","username":"gnatbot","avatars":[{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"7686d1c2071b6825ba0cb8ce9c9307f8674e376f","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"private package HW.GFX.GMA.Port_Detect is"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"   procedure Initialize;"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"   procedure Hotplug_Detect"},{"line_number":20,"context_line":"     (Port     : in Active_Port_Type;"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"8b73478f_c3e51a3c","line":17,"updated":"2026-06-04 21:08:25.000000000","message":"Config(s): tigerlake alderlake\n```\nhw-gfx-gma-port_detect.ads:17: warning: subprogram \"Initialize\" has no effect\n   17 |   procedure Initialize;\n      |             ^ here\n```","commit_id":"8d3f5ed4bd0d4b85007cfeaf6fac217bf53d86d8"},{"author":{"_account_id":1000029,"name":"Ada SPARK","email":"gnatbot@sourcearcade.org","username":"gnatbot","avatars":[{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"7686d1c2071b6825ba0cb8ce9c9307f8674e376f","unresolved":false,"context_lines":[{"line_number":17,"context_line":"   procedure Initialize;"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"   procedure Hotplug_Detect"},{"line_number":20,"context_line":"     (Port     : in Active_Port_Type;"},{"line_number":21,"context_line":"      Detected : out Boolean);"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"   procedure Clear_Hotplug_Detect (Port : Active_Port_Type);"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"e52a85a0_5baeecd5","line":20,"updated":"2026-06-04 21:08:25.000000000","message":"Config(s): tigerlake alderlake\n```\nhw-gfx-gma-port_detect.ads:20: warning: unused variable \"Port\"\n   20 |     (Port     : in Active_Port_Type;\n      |      ^ here\n```","commit_id":"8d3f5ed4bd0d4b85007cfeaf6fac217bf53d86d8"},{"author":{"_account_id":1000029,"name":"Ada SPARK","email":"gnatbot@sourcearcade.org","username":"gnatbot","avatars":[{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"7686d1c2071b6825ba0cb8ce9c9307f8674e376f","unresolved":false,"context_lines":[{"line_number":20,"context_line":"     (Port     : in Active_Port_Type;"},{"line_number":21,"context_line":"      Detected : out Boolean);"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"   procedure Clear_Hotplug_Detect (Port : Active_Port_Type);"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"end HW.GFX.GMA.Port_Detect;"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"7344a583_04d0f08b","line":23,"updated":"2026-06-04 21:08:25.000000000","message":"Config(s): alderlake tigerlake\n```\nhw-gfx-gma-port_detect.ads:23: warning: subprogram \"Clear_Hotplug_Detect\" has no effect\n   23 |   procedure Clear_Hotplug_Detect (Port : Active_Port_Type);\n      |             ^ here\n```","commit_id":"8d3f5ed4bd0d4b85007cfeaf6fac217bf53d86d8"}],"common/hw-gfx-gma-registers.adb":[{"author":{"_account_id":1000029,"name":"Ada SPARK","email":"gnatbot@sourcearcade.org","username":"gnatbot","avatars":[{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"4d990d31fcbe64a42a022a3bd359770a1b1ed4b8","unresolved":false,"context_lines":[{"line_number":108,"context_line":"   begin"},{"line_number":109,"context_line":"      while Val \u003e 1 loop"},{"line_number":110,"context_line":"         Val    :\u003d Shift_Right (Val, 1);"},{"line_number":111,"context_line":"         Result :\u003d Result + 1;"},{"line_number":112,"context_line":"      end loop;"},{"line_number":113,"context_line":"      return Result;"},{"line_number":114,"context_line":"   end Floor_Log2;"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"aca66033_457ace66","line":111,"updated":"2026-04-12 16:49:12.000000000","message":"Config(s): haswell ironlake_edp i945 g45 alderlake broxton ironlake skylake tigerlake\n```\nhw-gfx-gma-registers.adb:111: medium: overflow check might fail\n  111 |         Result :\u003d Result + 1;\n      |                          ^ here\n  e.g. when Result \u003d Natural\u0027Last\n  reason for check: result of addition must fit in a 32-bits machine integer\n  possible fix: loop at line 109 should mention Result in a loop invariant\n  109 |      while Val \u003e 1 loop\n      |                    ^ here\n```","commit_id":"2a68b84af2289123dd02ab1840e12425893a7a9e"},{"author":{"_account_id":1000029,"name":"Ada SPARK","email":"gnatbot@sourcearcade.org","username":"gnatbot","avatars":[{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"4d990d31fcbe64a42a022a3bd359770a1b1ed4b8","unresolved":false,"context_lines":[{"line_number":161,"context_line":"                  Start_Addr : constant Word32 :\u003d"},{"line_number":162,"context_line":"                     Shift_Left (Word32 (First_Page), FENCE_PAGE_SHIFT);"},{"line_number":163,"context_line":"                  Size_Pages : constant Word32 :\u003d"},{"line_number":164,"context_line":"                     Word32 (Last_Page - First_Page + 1);"},{"line_number":165,"context_line":"                  -- Size in MB (pages / 256, since page \u003d 4KB, 256*4KB \u003d 1MB)"},{"line_number":166,"context_line":"                  Size_MB    : constant Word32 :\u003d Size_Pages / 256;"},{"line_number":167,"context_line":"                  -- Pitch in tiles (X: 512B tiles, Y: 128B tiles for i945)"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"e5690d5f_a175bf51","line":164,"updated":"2026-04-12 16:49:12.000000000","message":"Config(s): i945\n```\nhw-gfx-gma-registers.adb:164: medium: range check might fail\n  164 |                     Word32 (Last_Page - First_Page + 1);\n      |                                                    ^ here\n  e.g. when First_Page \u003d 2\n        and Last_Page \u003d 0\n  reason for check: result of addition must be convertible to the target type of the conversion\n  possible fix: subprogram at hw-gfx-gma-registers.ads:2393 should mention First_Page and Last_Page in a precondition\n 2393 |   procedure Add_Fence\n      |   ^ here\n```","commit_id":"2a68b84af2289123dd02ab1840e12425893a7a9e"},{"author":{"_account_id":1000029,"name":"Ada SPARK","email":"gnatbot@sourcearcade.org","username":"gnatbot","avatars":[{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"4d990d31fcbe64a42a022a3bd359770a1b1ed4b8","unresolved":false,"context_lines":[{"line_number":180,"context_line":"                               else 0) or"},{"line_number":181,"context_line":"                              Shift_Left (Size_Bits, GEN3_FENCE_SIZE_SHIFT) or"},{"line_number":182,"context_line":"                              Shift_Left"},{"line_number":183,"context_line":"                                (Word32 (Floor_Log2 (Stride)),"},{"line_number":184,"context_line":"                                 GEN3_FENCE_PITCH_SHIFT) or"},{"line_number":185,"context_line":"                              FENCE_VALID);"},{"line_number":186,"context_line":"               end;"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"2fda61eb_72db8c34","line":183,"updated":"2026-04-12 16:49:12.000000000","message":"Config(s): i945\n```\nhw-gfx-gma-registers.adb:183: medium: precondition might fail, cannot prove N \u003e\u003d 1\n  183 |                                (Word32 (Floor_Log2 (Stride)),\n      |                                         ^ here\n  possible fix: subprogram at hw-gfx-gma-registers.ads:2393 should mention Pitch in a precondition\n 2393 |   procedure Add_Fence\n      |   ^ here\n```","commit_id":"2a68b84af2289123dd02ab1840e12425893a7a9e"},{"author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"7b7b7ee02b96e680cea55d81b5d58a9c2af613d3","unresolved":false,"context_lines":[{"line_number":112,"context_line":"         Result :\u003d I + 1;"},{"line_number":113,"context_line":"      end loop;"},{"line_number":114,"context_line":"      return Result;"},{"line_number":115,"context_line":"   end Floor_Log2;"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"   procedure Clear_Fences"},{"line_number":118,"context_line":"   is"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"f2e8d95b_7957f9c0","line":115,"updated":"2026-04-15 20:54:23.000000000","message":"Operation on Word32 could be moved into HW package.","commit_id":"910165bf6d56e026d641c2d89994b0d162471d93"},{"author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"7b7b7ee02b96e680cea55d81b5d58a9c2af613d3","unresolved":false,"context_lines":[{"line_number":263,"context_line":"         GTT_32.Write"},{"line_number":264,"context_line":"           (Index \u003d\u003e GTT_Page,"},{"line_number":265,"context_line":"            Value \u003d\u003e GTT_PTE_32 (Device_Address and 16#ffff_f000#) or"},{"line_number":266,"context_line":"                     Boolean\u0027Pos (Valid));"},{"line_number":267,"context_line":"      elsif not Config.Has_64bit_GTT then"},{"line_number":268,"context_line":"         GTT_32.Write"},{"line_number":269,"context_line":"           (Index \u003d\u003e GTT_Page,"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"18c5fdcb_db1d2b31","line":266,"updated":"2026-04-15 20:54:23.000000000","message":"Would it actually hurt to use the 32-bit code for newer generations?\nWe know that the physical addresses are 32 bits, hence shifting and\nor\u0027ing zeros would be a no-op, right? Same for reading GTT entries.","commit_id":"910165bf6d56e026d641c2d89994b0d162471d93"}],"common/hw-gfx-gma.ads":[{"author":{"_account_id":1000029,"name":"Ada SPARK","email":"gnatbot@sourcearcade.org","username":"gnatbot","avatars":[{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"4d990d31fcbe64a42a022a3bd359770a1b1ed4b8","unresolved":false,"context_lines":[{"line_number":231,"context_line":""},{"line_number":232,"context_line":"   procedure GTT_Entry_Count (Count : out Natural)"},{"line_number":233,"context_line":"   with"},{"line_number":234,"context_line":"      Global \u003d\u003e"},{"line_number":235,"context_line":"        (Input \u003d\u003e State,"},{"line_number":236,"context_line":"         In_Out \u003d\u003e Device_State, Proof_In \u003d\u003e Init_State),"},{"line_number":237,"context_line":"      Pre \u003d\u003e Is_Initialized and HW.Config.Dynamic_MMIO;"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"538ff5d0_91ba5d19","line":234,"updated":"2026-04-12 16:49:12.000000000","message":"Config(s): broxton\n```\nhw-gfx-gma.ads:234: low: global Input \"GMA.State\" of \"GTT_Entry_Count\" not read\n  234 |      Global \u003d\u003e\n      |      ^ here\n```","commit_id":"2a68b84af2289123dd02ab1840e12425893a7a9e"},{"author":{"_account_id":1000029,"name":"Ada SPARK","email":"gnatbot@sourcearcade.org","username":"gnatbot","avatars":[{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"f542987196cc22c2d00d847d1a097d4536f3cb7a","unresolved":false,"context_lines":[{"line_number":231,"context_line":""},{"line_number":232,"context_line":"   procedure GTT_Entry_Count (Count : out Natural)"},{"line_number":233,"context_line":"   with"},{"line_number":234,"context_line":"      Global \u003d\u003e"},{"line_number":235,"context_line":"        (Input \u003d\u003e State,"},{"line_number":236,"context_line":"         In_Out \u003d\u003e Device_State, Proof_In \u003d\u003e Init_State),"},{"line_number":237,"context_line":"      Pre \u003d\u003e Is_Initialized and HW.Config.Dynamic_MMIO;"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"87cbe4a2_6178db6d","line":234,"updated":"2026-04-15 12:50:27.000000000","message":"Config(s): broxton\n```\nhw-gfx-gma.ads:234: low: global Input \"GMA.State\" of \"GTT_Entry_Count\" not read\n  234 |      Global \u003d\u003e\n      |      ^ here\n```","commit_id":"910165bf6d56e026d641c2d89994b0d162471d93"},{"author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"70e9f1941437514f95882be1572078db4cdab67e","unresolved":false,"context_lines":[{"line_number":231,"context_line":""},{"line_number":232,"context_line":"   procedure GTT_Entry_Count (Count : out Natural)"},{"line_number":233,"context_line":"   with"},{"line_number":234,"context_line":"      Global \u003d\u003e"},{"line_number":235,"context_line":"        (Input \u003d\u003e State,"},{"line_number":236,"context_line":"         In_Out \u003d\u003e Device_State, Proof_In \u003d\u003e Init_State),"},{"line_number":237,"context_line":"      Pre \u003d\u003e Is_Initialized and HW.Config.Dynamic_MMIO;"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"61b153df_cc5c8668","line":234,"in_reply_to":"56e4e8a4_a47c1af0","updated":"2026-06-04 21:11:48.000000000","message":"Done","commit_id":"910165bf6d56e026d641c2d89994b0d162471d93"},{"author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"7e6dea9cecf5a2ad266c4a47e4068a7fc7516e4e","unresolved":true,"context_lines":[{"line_number":231,"context_line":""},{"line_number":232,"context_line":"   procedure GTT_Entry_Count (Count : out Natural)"},{"line_number":233,"context_line":"   with"},{"line_number":234,"context_line":"      Global \u003d\u003e"},{"line_number":235,"context_line":"        (Input \u003d\u003e State,"},{"line_number":236,"context_line":"         In_Out \u003d\u003e Device_State, Proof_In \u003d\u003e Init_State),"},{"line_number":237,"context_line":"      Pre \u003d\u003e Is_Initialized and HW.Config.Dynamic_MMIO;"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"56e4e8a4_a47c1af0","line":234,"in_reply_to":"6e1398d7_d77bbe7c","updated":"2026-04-18 20:35:02.000000000","message":"Tried that, remembered an old problem: As there is nothing to annotate\nfor most platforms, it would warn then about the unnecessary annotation.\nA little more elegant and less verbose than disabling the warning on top\nwould be the following in the body:\n```\ndiff --git a/common/hw-gfx-gma.adb b/common/hw-gfx-gma.adb\nindex 1db5526..4ad2312 100644\n--- a/common/hw-gfx-gma.adb\n+++ b/common/hw-gfx-gma.adb\n@@ -872,7 +872,16 @@ is\n    procedure GTT_Entry_Count (Count : out Natural)\n    is\n       GTT_Size : Natural;\n+\n+      procedure Fake_Config_State_Access\n+      with\n+         Global \u003d\u003e (Input \u003d\u003e Config.Variable),\n+         Annotate \u003d\u003e (GNATprove, Intentional, \"unused global\",\n+            \"Used to have a common contract across platforms.\");\n+      procedure Fake_Config_State_Access is null;\n    begin\n+      Fake_Config_State_Access;\n+\n       if Config.Has_I945_GTT_BAR then\n          -- i945 GTT is on a separate BAR3; its size is the BAR size.\n          Dev.Resource_Size (GTT_Size, PCI.Res3);\n```","commit_id":"910165bf6d56e026d641c2d89994b0d162471d93"},{"author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"7b7b7ee02b96e680cea55d81b5d58a9c2af613d3","unresolved":true,"context_lines":[{"line_number":231,"context_line":""},{"line_number":232,"context_line":"   procedure GTT_Entry_Count (Count : out Natural)"},{"line_number":233,"context_line":"   with"},{"line_number":234,"context_line":"      Global \u003d\u003e"},{"line_number":235,"context_line":"        (Input \u003d\u003e State,"},{"line_number":236,"context_line":"         In_Out \u003d\u003e Device_State, Proof_In \u003d\u003e Init_State),"},{"line_number":237,"context_line":"      Pre \u003d\u003e Is_Initialized and HW.Config.Dynamic_MMIO;"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"6e1398d7_d77bbe7c","line":234,"in_reply_to":"87cbe4a2_6178db6d","updated":"2026-04-15 20:54:23.000000000","message":"ugh, I mistook this is for an old warning\nI guess something like\n```\nAnnotate \u003d\u003e\n  (GNATprove, Intentional,\n   \"global Input \"\"GMA.State\"\" of \"\"GTT_Entry_Count\"\" not read\",\n   \"Reading of GMA.State depends on the platform configuration.\");\n```","commit_id":"910165bf6d56e026d641c2d89994b0d162471d93"}],"common/i945/hw-gfx-gma-plls.adb":[{"author":{"_account_id":1000029,"name":"Ada SPARK","email":"gnatbot@sourcearcade.org","username":"gnatbot","avatars":[{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"4d990d31fcbe64a42a022a3bd359770a1b1ed4b8","unresolved":false,"context_lines":[{"line_number":287,"context_line":"      for N in N_Range range Limits.N_Lower .. Limits.N_Upper"},{"line_number":288,"context_line":"      loop"},{"line_number":289,"context_line":"         -- reverse loops as hardware prefers higher values"},{"line_number":290,"context_line":"         for M1 in reverse M1_Range range Limits.M1_Lower .. Limits.M1_Upper"},{"line_number":291,"context_line":"         loop"},{"line_number":292,"context_line":"            for M2 in reverse M2_Range range Limits.M2_Lower .. Int64\u0027Min (Limits.M2_Upper, M1)"},{"line_number":293,"context_line":"            loop"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"417b3543_c2125fc5","line":290,"updated":"2026-04-12 16:49:12.000000000","message":"Config(s): i945\n```\nhw-gfx-gma-plls.adb:290: medium: range check might fail\n  290 |         for M1 in reverse M1_Range range Limits.M1_Lower .. Limits.M1_Upper\n      |             ^ here\n```","commit_id":"2a68b84af2289123dd02ab1840e12425893a7a9e"},{"author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"c8f2153ab926599ddccfc7d207c1ade141716038","unresolved":false,"context_lines":[{"line_number":287,"context_line":"      for N in N_Range range Limits.N_Lower .. Limits.N_Upper"},{"line_number":288,"context_line":"      loop"},{"line_number":289,"context_line":"         -- reverse loops as hardware prefers higher values"},{"line_number":290,"context_line":"         for M1 in reverse M1_Range range Limits.M1_Lower .. Limits.M1_Upper"},{"line_number":291,"context_line":"         loop"},{"line_number":292,"context_line":"            for M2 in reverse M2_Range range Limits.M2_Lower .. Int64\u0027Min (Limits.M2_Upper, M1)"},{"line_number":293,"context_line":"            loop"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"f3a42302_ae920822","line":290,"in_reply_to":"417b3543_c2125fc5","updated":"2026-04-12 21:59:33.000000000","message":"Looks the same as we had for g45, cf. 3652e9c5ace183f9cbaf6910d8aad6908a27231f","commit_id":"2a68b84af2289123dd02ab1840e12425893a7a9e"},{"author":{"_account_id":1000029,"name":"Ada SPARK","email":"gnatbot@sourcearcade.org","username":"gnatbot","avatars":[{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"4d990d31fcbe64a42a022a3bd359770a1b1ed4b8","unresolved":false,"context_lines":[{"line_number":289,"context_line":"         -- reverse loops as hardware prefers higher values"},{"line_number":290,"context_line":"         for M1 in reverse M1_Range range Limits.M1_Lower .. Limits.M1_Upper"},{"line_number":291,"context_line":"         loop"},{"line_number":292,"context_line":"            for M2 in reverse M2_Range range Limits.M2_Lower .. Int64\u0027Min (Limits.M2_Upper, M1)"},{"line_number":293,"context_line":"            loop"},{"line_number":294,"context_line":"               for P1 in reverse P1_Range range Limits.P1_Lower .. Limits.P1_Upper"},{"line_number":295,"context_line":"               loop"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"977c79de_afa99d58","line":292,"updated":"2026-04-12 16:49:12.000000000","message":"Config(s): i945\n```\nhw-gfx-gma-plls.adb:292: medium: range check might fail\n  292 |            for M2 in reverse M2_Range range Limits.M2_Lower .. Int64\u0027Min (Limits.M2_Upper, M1)\n      |                ^ here\n```","commit_id":"2a68b84af2289123dd02ab1840e12425893a7a9e"},{"author":{"_account_id":1000029,"name":"Ada SPARK","email":"gnatbot@sourcearcade.org","username":"gnatbot","avatars":[{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"4d990d31fcbe64a42a022a3bd359770a1b1ed4b8","unresolved":false,"context_lines":[{"line_number":291,"context_line":"         loop"},{"line_number":292,"context_line":"            for M2 in reverse M2_Range range Limits.M2_Lower .. Int64\u0027Min (Limits.M2_Upper, M1)"},{"line_number":293,"context_line":"            loop"},{"line_number":294,"context_line":"               for P1 in reverse P1_Range range Limits.P1_Lower .. Limits.P1_Upper"},{"line_number":295,"context_line":"               loop"},{"line_number":296,"context_line":"                  Verify_Parameters"},{"line_number":297,"context_line":"                    (N               \u003d\u003e N,"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"0599abdf_0afb50c4","line":294,"updated":"2026-04-12 16:49:12.000000000","message":"Config(s): i945\n```\nhw-gfx-gma-plls.adb:294: medium: range check might fail\n  294 |               for P1 in reverse P1_Range range Limits.P1_Lower .. Limits.P1_Upper\n      |                   ^ here\n```","commit_id":"2a68b84af2289123dd02ab1840e12425893a7a9e"},{"author":{"_account_id":1000029,"name":"Ada SPARK","email":"gnatbot@sourcearcade.org","username":"gnatbot","avatars":[{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"4d990d31fcbe64a42a022a3bd359770a1b1ed4b8","unresolved":false,"context_lines":[{"line_number":296,"context_line":"                  Verify_Parameters"},{"line_number":297,"context_line":"                    (N               \u003d\u003e N,"},{"line_number":298,"context_line":"                     M1              \u003d\u003e M1,"},{"line_number":299,"context_line":"                     M2              \u003d\u003e M2,"},{"line_number":300,"context_line":"                     P1              \u003d\u003e P1,"},{"line_number":301,"context_line":"                     P2              \u003d\u003e P2,"},{"line_number":302,"context_line":"                     Reference_Clock \u003d\u003e Reference_Clock,"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"8ae0f107_a90e1679","line":299,"updated":"2026-04-12 16:49:12.000000000","message":"Config(s): i945\n```\nhw-gfx-gma-plls.adb:299: medium: range check might fail\n  299 |                     M2              \u003d\u003e M2,\n      |                                        ^ here\n  reason for check: input value must fit in parameter type\n```","commit_id":"2a68b84af2289123dd02ab1840e12425893a7a9e"}],"common/i945/hw-gfx-gma-power_and_clocks.adb":[{"author":{"_account_id":1000029,"name":"Ada SPARK","email":"gnatbot@sourcearcade.org","username":"gnatbot","avatars":[{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"4d990d31fcbe64a42a022a3bd359770a1b1ed4b8","unresolved":false,"context_lines":[{"line_number":116,"context_line":"      Config.CDClk :\u003d CDClk;"},{"line_number":117,"context_line":"      Config.Max_CDClk :\u003d CDClk;"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"      Get_Raw_Clock (Config.Raw_Clock);"},{"line_number":120,"context_line":"   end Initialize;"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"   procedure Limit_Dotclocks"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"1835ec9c_d27c4e5f","line":119,"updated":"2026-04-12 16:49:12.000000000","message":"Config(s): i945\n```\nhw-gfx-gma-power_and_clocks.adb:119: high: formal parameter \"Raw_Clock\" and global \"Config.Variable\" constituent of \"GMA.State\" are aliased (SPARK RM 6.4.2)\n  119 |      Get_Raw_Clock (Config.Raw_Clock);\n      |                           ^ here\n```","commit_id":"2a68b84af2289123dd02ab1840e12425893a7a9e"},{"author":{"_account_id":1000012,"name":"Angel Pons","email":"th3fanbus@gmail.com","username":"th3fanbus","avatars":[{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"eeeb6e9ecce131ebcdc805155bcf989d5f486130","unresolved":true,"context_lines":[{"line_number":84,"context_line":"      Registers.Read"},{"line_number":85,"context_line":"        (Register \u003d\u003e Registers.GMCH_CLKCFG,"},{"line_number":86,"context_line":"         Value \u003d\u003e CLK_CFG);"},{"line_number":87,"context_line":"      if Config.GMCH_I945GM then"},{"line_number":88,"context_line":"         case Freq_Sel (CLK_CFG and CLKCFG_FSB_MASK) is"},{"line_number":89,"context_line":"            when 0      \u003d\u003e Raw_Clock :\u003d HRAWCLK_100;  -- FSB 400"},{"line_number":90,"context_line":"            when 1      \u003d\u003e Raw_Clock :\u003d HRAWCLK_133;  -- FSB 533"},{"line_number":91,"context_line":"            when 2      \u003d\u003e Raw_Clock :\u003d HRAWCLK_200;  -- FSB 800"},{"line_number":92,"context_line":"            when 3      \u003d\u003e Raw_Clock :\u003d HRAWCLK_167;  -- FSB 667"},{"line_number":93,"context_line":"            when 6      \u003d\u003e Raw_Clock :\u003d HRAWCLK_267;  -- FSB 1067"},{"line_number":94,"context_line":"            when 7      \u003d\u003e Raw_Clock :\u003d HRAWCLK_333;  -- FSB 1333"},{"line_number":95,"context_line":"            when others \u003d\u003e Raw_Clock :\u003d HRAWCLK_133;"},{"line_number":96,"context_line":"         end case;"},{"line_number":97,"context_line":"      else"},{"line_number":98,"context_line":"         case Freq_Sel (CLK_CFG and CLKCFG_FSB_MASK) is"},{"line_number":99,"context_line":"            when 0      \u003d\u003e Raw_Clock :\u003d HRAWCLK_267;  -- FSB 1067"},{"line_number":100,"context_line":"            when 1      \u003d\u003e Raw_Clock :\u003d HRAWCLK_133;  -- FSB 533"},{"line_number":101,"context_line":"            when 2      \u003d\u003e Raw_Clock :\u003d HRAWCLK_200;  -- FSB 800"},{"line_number":102,"context_line":"            when 3      \u003d\u003e Raw_Clock :\u003d HRAWCLK_167;  -- FSB 667"},{"line_number":103,"context_line":"            when 4      \u003d\u003e Raw_Clock :\u003d HRAWCLK_333;  -- FSB 1333"},{"line_number":104,"context_line":"            when 5      \u003d\u003e Raw_Clock :\u003d HRAWCLK_100;  -- FSB 400"},{"line_number":105,"context_line":"            when 6      \u003d\u003e Raw_Clock :\u003d HRAWCLK_400;  -- FSB 1600"},{"line_number":106,"context_line":"            when others \u003d\u003e Raw_Clock :\u003d HRAWCLK_133;"},{"line_number":107,"context_line":"         end case;"},{"line_number":108,"context_line":"      end if;"},{"line_number":109,"context_line":"   end Get_Raw_Clock;"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"   procedure Initialize"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"625e05b8_39080653","line":108,"range":{"start_line":87,"start_character":6,"end_line":108,"end_character":13},"updated":"2026-04-19 07:28:54.000000000","message":"Use case expressions?\n\n```suggestion\n      if Config.GMCH_I945GM then\n         Raw_Clock :\u003d (case Freq_Sel (CLK_CFG and CLKCFG_FSB_MASK) is\n            when 0      \u003d\u003e HRAWCLK_100m  -- FSB 400\n            when 1      \u003d\u003e HRAWCLK_133,  -- FSB 533\n            when 2      \u003d\u003e HRAWCLK_200,  -- FSB 800\n            when 3      \u003d\u003e HRAWCLK_167,  -- FSB 667\n            when 6      \u003d\u003e HRAWCLK_267,  -- FSB 1067\n            when 7      \u003d\u003e HRAWCLK_333,  -- FSB 1333\n            when others \u003d\u003e HRAWCLK_133);\n      else\n         Raw_Clock :\u003d (case Freq_Sel (CLK_CFG and CLKCFG_FSB_MASK) is\n            when 0      \u003d\u003e HRAWCLK_267,  -- FSB 1067\n            when 1      \u003d\u003e HRAWCLK_133,  -- FSB 533\n            when 2      \u003d\u003e HRAWCLK_200,  -- FSB 800\n            when 3      \u003d\u003e HRAWCLK_167,  -- FSB 667\n            when 4      \u003d\u003e HRAWCLK_333,  -- FSB 1333\n            when 5      \u003d\u003e HRAWCLK_100,  -- FSB 400\n            when 6      \u003d\u003e HRAWCLK_400,  -- FSB 1600\n            when others \u003d\u003e HRAWCLK_133);\n      end if;\n```","commit_id":"910165bf6d56e026d641c2d89994b0d162471d93"},{"author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"70e9f1941437514f95882be1572078db4cdab67e","unresolved":false,"context_lines":[{"line_number":84,"context_line":"      Registers.Read"},{"line_number":85,"context_line":"        (Register \u003d\u003e Registers.GMCH_CLKCFG,"},{"line_number":86,"context_line":"         Value \u003d\u003e CLK_CFG);"},{"line_number":87,"context_line":"      if Config.GMCH_I945GM then"},{"line_number":88,"context_line":"         case Freq_Sel (CLK_CFG and CLKCFG_FSB_MASK) is"},{"line_number":89,"context_line":"            when 0      \u003d\u003e Raw_Clock :\u003d HRAWCLK_100;  -- FSB 400"},{"line_number":90,"context_line":"            when 1      \u003d\u003e Raw_Clock :\u003d HRAWCLK_133;  -- FSB 533"},{"line_number":91,"context_line":"            when 2      \u003d\u003e Raw_Clock :\u003d HRAWCLK_200;  -- FSB 800"},{"line_number":92,"context_line":"            when 3      \u003d\u003e Raw_Clock :\u003d HRAWCLK_167;  -- FSB 667"},{"line_number":93,"context_line":"            when 6      \u003d\u003e Raw_Clock :\u003d HRAWCLK_267;  -- FSB 1067"},{"line_number":94,"context_line":"            when 7      \u003d\u003e Raw_Clock :\u003d HRAWCLK_333;  -- FSB 1333"},{"line_number":95,"context_line":"            when others \u003d\u003e Raw_Clock :\u003d HRAWCLK_133;"},{"line_number":96,"context_line":"         end case;"},{"line_number":97,"context_line":"      else"},{"line_number":98,"context_line":"         case Freq_Sel (CLK_CFG and CLKCFG_FSB_MASK) is"},{"line_number":99,"context_line":"            when 0      \u003d\u003e Raw_Clock :\u003d HRAWCLK_267;  -- FSB 1067"},{"line_number":100,"context_line":"            when 1      \u003d\u003e Raw_Clock :\u003d HRAWCLK_133;  -- FSB 533"},{"line_number":101,"context_line":"            when 2      \u003d\u003e Raw_Clock :\u003d HRAWCLK_200;  -- FSB 800"},{"line_number":102,"context_line":"            when 3      \u003d\u003e Raw_Clock :\u003d HRAWCLK_167;  -- FSB 667"},{"line_number":103,"context_line":"            when 4      \u003d\u003e Raw_Clock :\u003d HRAWCLK_333;  -- FSB 1333"},{"line_number":104,"context_line":"            when 5      \u003d\u003e Raw_Clock :\u003d HRAWCLK_100;  -- FSB 400"},{"line_number":105,"context_line":"            when 6      \u003d\u003e Raw_Clock :\u003d HRAWCLK_400;  -- FSB 1600"},{"line_number":106,"context_line":"            when others \u003d\u003e Raw_Clock :\u003d HRAWCLK_133;"},{"line_number":107,"context_line":"         end case;"},{"line_number":108,"context_line":"      end if;"},{"line_number":109,"context_line":"   end Get_Raw_Clock;"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"   procedure Initialize"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"26c8a99b_6d12c338","line":108,"range":{"start_line":87,"start_character":6,"end_line":108,"end_character":13},"in_reply_to":"625e05b8_39080653","updated":"2026-06-04 21:11:48.000000000","message":"Done","commit_id":"910165bf6d56e026d641c2d89994b0d162471d93"}]}