)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"374cc00a879ac76a9ef022aa742e6aae3a385fa3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"cb627c81_e1ea46d9","updated":"2026-04-16 15:06:34.000000000","message":"+2 on Tim\u0027s and Jérémy\u0027s work. Could use another one for my changes.","commit_id":"9309a72f5d82cf9fc1d26ec9d5d9f992078f4ec1"},{"author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"6ebc23e2d125a989431b07c2c7639d11180cac8d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"8a8330be_71229811","updated":"2026-05-29 10:36:24.000000000","message":"Patch set 8 fixes a few minor things and reworks default CDClk handling:\nWe just use the lower of the possible two values and let Normalize_CDClk()\nhandle the rest. Saves some code and also made something else visible:\nPost_All_Off() tries to disable the CDClk PLL by setting the reference\nfrequency but its not implemented. Other checks around this were just\nwrong.\n\nPatch set 9 should be mostly a cosmetic cleanup.","commit_id":"afa332032a9f640158cd7d64377baa641dcbe4a0"},{"author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"34b6fd5a2dbd3b981c2481394e52c9d0e667bce1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"01e11ca2_19180420","in_reply_to":"8a8330be_71229811","updated":"2026-05-29 10:41:16.000000000","message":"Hopefully this makes the transition to ADL-P easier to review\n(I split the whole Power Domain stuff out of the package).","commit_id":"afa332032a9f640158cd7d64377baa641dcbe4a0"}],"common/hw-gfx-gma-connectors.ads":[{"author":{"_account_id":1000029,"name":"Ada SPARK","email":"gnatbot@sourcearcade.org","username":"gnatbot","avatars":[{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"5e4c530a1010624ff2e924458d3414e63e14c42a","unresolved":false,"context_lines":[{"line_number":47,"context_line":"   pragma Warnings (GNATprove, On, \"unused variable \"\"P*\"\"\");"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"   procedure Pre_Off (Port_Cfg : Port_Config);"},{"line_number":50,"context_line":"   procedure Post_Off (Port_Cfg : Port_Config);"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"   procedure Pre_All_Off;"},{"line_number":53,"context_line":"   procedure Post_All_Off;"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"b3004d2e_f97cea09","line":50,"updated":"2026-04-18 19:34:11.000000000","message":"Config(s): tigerlake alderlake\n```\nhw-gfx-gma-connectors.ads:50: warning: subprogram \"Post_Off\" has no effect\n   50 |   procedure Post_Off (Port_Cfg : Port_Config);\n      |             ^ here\n```","commit_id":"b634b5106c51a5568c757f680da122c9dfdf89a7"},{"author":{"_account_id":1000029,"name":"Ada SPARK","email":"gnatbot@sourcearcade.org","username":"gnatbot","avatars":[{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"5e4c530a1010624ff2e924458d3414e63e14c42a","unresolved":false,"context_lines":[{"line_number":50,"context_line":"   procedure Post_Off (Port_Cfg : Port_Config);"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"   procedure Pre_All_Off;"},{"line_number":53,"context_line":"   procedure Post_All_Off;"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"end HW.GFX.GMA.Connectors;"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"c726f932_3351b737","line":53,"updated":"2026-04-18 19:34:11.000000000","message":"Config(s): tigerlake alderlake\n```\nhw-gfx-gma-connectors.ads:53: warning: subprogram \"Post_All_Off\" has no effect\n   53 |   procedure Post_All_Off;\n      |             ^ here\n```","commit_id":"b634b5106c51a5568c757f680da122c9dfdf89a7"},{"author":{"_account_id":1000029,"name":"Ada SPARK","email":"gnatbot@sourcearcade.org","username":"gnatbot","avatars":[{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"f8ba32e931af44ce2ca27bf7acdaaa46acf86274","unresolved":false,"context_lines":[{"line_number":46,"context_line":"   pragma Warnings (GNATprove, On, \"unused variable \"\"P*\"\"\");"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"   procedure Pre_Off (Port_Cfg : Port_Config);"},{"line_number":49,"context_line":"   procedure Post_Off (Port_Cfg : Port_Config);"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"   procedure Pre_All_Off;"},{"line_number":52,"context_line":"   procedure Post_All_Off;"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"23852c55_3404c40b","line":49,"updated":"2026-05-29 10:22:49.000000000","message":"Config(s): tigerlake alderlake\n```\nhw-gfx-gma-connectors.ads:49: warning: subprogram \"Post_Off\" has no effect\n   49 |   procedure Post_Off (Port_Cfg : Port_Config);\n      |             ^ here\n```","commit_id":"3da289c404ef6d9f89cb6ae1f08d102b8ec1ef8b"},{"author":{"_account_id":1000029,"name":"Ada SPARK","email":"gnatbot@sourcearcade.org","username":"gnatbot","avatars":[{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"f8ba32e931af44ce2ca27bf7acdaaa46acf86274","unresolved":false,"context_lines":[{"line_number":49,"context_line":"   procedure Post_Off (Port_Cfg : Port_Config);"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"   procedure Pre_All_Off;"},{"line_number":52,"context_line":"   procedure Post_All_Off;"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"end HW.GFX.GMA.Connectors;"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"4b112a7d_6e0d79d9","line":52,"updated":"2026-05-29 10:22:49.000000000","message":"Config(s): alderlake tigerlake\n```\nhw-gfx-gma-connectors.ads:52: warning: subprogram \"Post_All_Off\" has no effect\n   52 |   procedure Post_All_Off;\n      |             ^ here\n```","commit_id":"3da289c404ef6d9f89cb6ae1f08d102b8ec1ef8b"},{"author":{"_account_id":1000029,"name":"Ada SPARK","email":"gnatbot@sourcearcade.org","username":"gnatbot","avatars":[{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"f2076d5ea57302a44b021555f138187bdafeb398","unresolved":false,"context_lines":[{"line_number":46,"context_line":"   pragma Warnings (GNATprove, On, \"unused variable \"\"P*\"\"\");"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"   procedure Pre_Off (Port_Cfg : Port_Config);"},{"line_number":49,"context_line":"   procedure Post_Off (Port_Cfg : Port_Config);"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"   procedure Pre_All_Off;"},{"line_number":52,"context_line":"   procedure Post_All_Off;"}],"source_content_type":"application/octet-stream","patch_set":9,"id":"118ec906_f24da2a9","line":49,"updated":"2026-05-29 10:28:19.000000000","message":"Config(s): tigerlake alderlake\n```\nhw-gfx-gma-connectors.ads:49: warning: subprogram \"Post_Off\" has no effect\n   49 |   procedure Post_Off (Port_Cfg : Port_Config);\n      |             ^ here\n```","commit_id":"afa332032a9f640158cd7d64377baa641dcbe4a0"},{"author":{"_account_id":1000029,"name":"Ada SPARK","email":"gnatbot@sourcearcade.org","username":"gnatbot","avatars":[{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"f2076d5ea57302a44b021555f138187bdafeb398","unresolved":false,"context_lines":[{"line_number":49,"context_line":"   procedure Post_Off (Port_Cfg : Port_Config);"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"   procedure Pre_All_Off;"},{"line_number":52,"context_line":"   procedure Post_All_Off;"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"end HW.GFX.GMA.Connectors;"}],"source_content_type":"application/octet-stream","patch_set":9,"id":"d011b6ed_81000a4e","line":52,"updated":"2026-05-29 10:28:19.000000000","message":"Config(s): alderlake tigerlake\n```\nhw-gfx-gma-connectors.ads:52: warning: subprogram \"Post_All_Off\" has no effect\n   52 |   procedure Post_All_Off;\n      |             ^ here\n```","commit_id":"afa332032a9f640158cd7d64377baa641dcbe4a0"}],"common/hw-gfx-gma-port_detect.ads":[{"author":{"_account_id":1000029,"name":"Ada SPARK","email":"gnatbot@sourcearcade.org","username":"gnatbot","avatars":[{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"5e4c530a1010624ff2e924458d3414e63e14c42a","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"private package HW.GFX.GMA.Port_Detect is"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"   procedure Initialize;"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"   procedure Hotplug_Detect"},{"line_number":20,"context_line":"     (Port     : in Active_Port_Type;"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"6d99cd50_30f4975d","line":17,"updated":"2026-04-18 19:34:11.000000000","message":"Config(s): alderlake tigerlake\n```\nhw-gfx-gma-port_detect.ads:17: warning: subprogram \"Initialize\" has no effect\n   17 |   procedure Initialize;\n      |             ^ here\n```","commit_id":"b634b5106c51a5568c757f680da122c9dfdf89a7"},{"author":{"_account_id":1000029,"name":"Ada SPARK","email":"gnatbot@sourcearcade.org","username":"gnatbot","avatars":[{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"5e4c530a1010624ff2e924458d3414e63e14c42a","unresolved":false,"context_lines":[{"line_number":17,"context_line":"   procedure Initialize;"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"   procedure Hotplug_Detect"},{"line_number":20,"context_line":"     (Port     : in Active_Port_Type;"},{"line_number":21,"context_line":"      Detected : out Boolean);"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"   procedure Clear_Hotplug_Detect (Port : Active_Port_Type);"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"60c1503f_64415f71","line":20,"updated":"2026-04-18 19:34:11.000000000","message":"Config(s): tigerlake alderlake\n```\nhw-gfx-gma-port_detect.ads:20: warning: unused variable \"Port\"\n   20 |     (Port     : in Active_Port_Type;\n      |      ^ here\n```","commit_id":"b634b5106c51a5568c757f680da122c9dfdf89a7"},{"author":{"_account_id":1000029,"name":"Ada SPARK","email":"gnatbot@sourcearcade.org","username":"gnatbot","avatars":[{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"5e4c530a1010624ff2e924458d3414e63e14c42a","unresolved":false,"context_lines":[{"line_number":20,"context_line":"     (Port     : in Active_Port_Type;"},{"line_number":21,"context_line":"      Detected : out Boolean);"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"   procedure Clear_Hotplug_Detect (Port : Active_Port_Type);"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"end HW.GFX.GMA.Port_Detect;"}],"source_content_type":"application/octet-stream","patch_set":7,"id":"8ca0f6dd_2506b929","line":23,"updated":"2026-04-18 19:34:11.000000000","message":"Config(s): alderlake tigerlake\n```\nhw-gfx-gma-port_detect.ads:23: warning: subprogram \"Clear_Hotplug_Detect\" has no effect\n   23 |   procedure Clear_Hotplug_Detect (Port : Active_Port_Type);\n      |             ^ here\n```","commit_id":"b634b5106c51a5568c757f680da122c9dfdf89a7"},{"author":{"_account_id":1000029,"name":"Ada SPARK","email":"gnatbot@sourcearcade.org","username":"gnatbot","avatars":[{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"f8ba32e931af44ce2ca27bf7acdaaa46acf86274","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"private package HW.GFX.GMA.Port_Detect is"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"   procedure Initialize;"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"   procedure Hotplug_Detect"},{"line_number":20,"context_line":"     (Port     : in Active_Port_Type;"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"a5579c2a_e38d6e58","line":17,"updated":"2026-05-29 10:22:49.000000000","message":"Config(s): alderlake tigerlake\n```\nhw-gfx-gma-port_detect.ads:17: warning: subprogram \"Initialize\" has no effect\n   17 |   procedure Initialize;\n      |             ^ here\n```","commit_id":"3da289c404ef6d9f89cb6ae1f08d102b8ec1ef8b"},{"author":{"_account_id":1000029,"name":"Ada SPARK","email":"gnatbot@sourcearcade.org","username":"gnatbot","avatars":[{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"f8ba32e931af44ce2ca27bf7acdaaa46acf86274","unresolved":false,"context_lines":[{"line_number":17,"context_line":"   procedure Initialize;"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"   procedure Hotplug_Detect"},{"line_number":20,"context_line":"     (Port     : in Active_Port_Type;"},{"line_number":21,"context_line":"      Detected : out Boolean);"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"   procedure Clear_Hotplug_Detect (Port : Active_Port_Type);"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"ca07be73_69f17ef3","line":20,"updated":"2026-05-29 10:22:49.000000000","message":"Config(s): tigerlake alderlake\n```\nhw-gfx-gma-port_detect.ads:20: warning: unused variable \"Port\"\n   20 |     (Port     : in Active_Port_Type;\n      |      ^ here\n```","commit_id":"3da289c404ef6d9f89cb6ae1f08d102b8ec1ef8b"},{"author":{"_account_id":1000029,"name":"Ada SPARK","email":"gnatbot@sourcearcade.org","username":"gnatbot","avatars":[{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"f8ba32e931af44ce2ca27bf7acdaaa46acf86274","unresolved":false,"context_lines":[{"line_number":20,"context_line":"     (Port     : in Active_Port_Type;"},{"line_number":21,"context_line":"      Detected : out Boolean);"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"   procedure Clear_Hotplug_Detect (Port : Active_Port_Type);"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"end HW.GFX.GMA.Port_Detect;"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"66fe348a_ec5007e5","line":23,"updated":"2026-05-29 10:22:49.000000000","message":"Config(s): tigerlake alderlake\n```\nhw-gfx-gma-port_detect.ads:23: warning: subprogram \"Clear_Hotplug_Detect\" has no effect\n   23 |   procedure Clear_Hotplug_Detect (Port : Active_Port_Type);\n      |             ^ here\n```","commit_id":"3da289c404ef6d9f89cb6ae1f08d102b8ec1ef8b"},{"author":{"_account_id":1000029,"name":"Ada SPARK","email":"gnatbot@sourcearcade.org","username":"gnatbot","avatars":[{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"f2076d5ea57302a44b021555f138187bdafeb398","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"private package HW.GFX.GMA.Port_Detect is"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"   procedure Initialize;"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"   procedure Hotplug_Detect"},{"line_number":20,"context_line":"     (Port     : in Active_Port_Type;"}],"source_content_type":"application/octet-stream","patch_set":9,"id":"ee943b16_b7fd2e16","line":17,"updated":"2026-05-29 10:28:19.000000000","message":"Config(s): tigerlake alderlake\n```\nhw-gfx-gma-port_detect.ads:17: warning: subprogram \"Initialize\" has no effect\n   17 |   procedure Initialize;\n      |             ^ here\n```","commit_id":"afa332032a9f640158cd7d64377baa641dcbe4a0"},{"author":{"_account_id":1000029,"name":"Ada SPARK","email":"gnatbot@sourcearcade.org","username":"gnatbot","avatars":[{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"f2076d5ea57302a44b021555f138187bdafeb398","unresolved":false,"context_lines":[{"line_number":17,"context_line":"   procedure Initialize;"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"   procedure Hotplug_Detect"},{"line_number":20,"context_line":"     (Port     : in Active_Port_Type;"},{"line_number":21,"context_line":"      Detected : out Boolean);"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"   procedure Clear_Hotplug_Detect (Port : Active_Port_Type);"}],"source_content_type":"application/octet-stream","patch_set":9,"id":"54d3ea21_65e7af51","line":20,"updated":"2026-05-29 10:28:19.000000000","message":"Config(s): alderlake tigerlake\n```\nhw-gfx-gma-port_detect.ads:20: warning: unused variable \"Port\"\n   20 |     (Port     : in Active_Port_Type;\n      |      ^ here\n```","commit_id":"afa332032a9f640158cd7d64377baa641dcbe4a0"},{"author":{"_account_id":1000029,"name":"Ada SPARK","email":"gnatbot@sourcearcade.org","username":"gnatbot","avatars":[{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c244ab97f43ca382a72e76784b616a4b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"f2076d5ea57302a44b021555f138187bdafeb398","unresolved":false,"context_lines":[{"line_number":20,"context_line":"     (Port     : in Active_Port_Type;"},{"line_number":21,"context_line":"      Detected : out Boolean);"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"   procedure Clear_Hotplug_Detect (Port : Active_Port_Type);"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"end HW.GFX.GMA.Port_Detect;"}],"source_content_type":"application/octet-stream","patch_set":9,"id":"467d794b_ef0ba693","line":23,"updated":"2026-05-29 10:28:19.000000000","message":"Config(s): alderlake tigerlake\n```\nhw-gfx-gma-port_detect.ads:23: warning: subprogram \"Clear_Hotplug_Detect\" has no effect\n   23 |   procedure Clear_Hotplug_Detect (Port : Active_Port_Type);\n      |             ^ here\n```","commit_id":"afa332032a9f640158cd7d64377baa641dcbe4a0"}],"common/tigerlake/hw-gfx-gma-power_and_clocks.adb":[{"author":{"_account_id":1000012,"name":"Angel Pons","email":"th3fanbus@gmail.com","username":"th3fanbus","avatars":[{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"5761b18ee38b20c7f1b0a0a082c0bc90b3632fc8","unresolved":false,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":"   function HIP_INDEX_VAL (A : AUX_USBC_Domain; Val : Word32) return Word32"},{"line_number":93,"context_line":"   is"},{"line_number":94,"context_line":"     (Val * 2 ** (8 * ((Power_Domain\u0027Pos (A) - Power_Domain\u0027Pos (AUX_USBC1)) mod 4)));"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"   type DKL_Regs is array (AUX_USBC_Domain) of Registers.Registers_Index;"},{"line_number":97,"context_line":"   DKL_CMN_UC_DW_27 : constant DKL_Regs :\u003d"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"991eb218_9477011f","line":94,"range":{"start_line":94,"start_character":23,"end_line":94,"end_character":76},"updated":"2026-04-18 11:37:04.000000000","message":"I think this could be extracted into an `AUX_USBC_Index` function","commit_id":"9309a72f5d82cf9fc1d26ec9d5d9f992078f4ec1"},{"author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"29c22181da94b0732e1ec9850d1e9cc513921b9c","unresolved":false,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":"   function HIP_INDEX_VAL (A : AUX_USBC_Domain; Val : Word32) return Word32"},{"line_number":93,"context_line":"   is"},{"line_number":94,"context_line":"     (Val * 2 ** (8 * ((Power_Domain\u0027Pos (A) - Power_Domain\u0027Pos (AUX_USBC1)) mod 4)));"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"   type DKL_Regs is array (AUX_USBC_Domain) of Registers.Registers_Index;"},{"line_number":97,"context_line":"   DKL_CMN_UC_DW_27 : constant DKL_Regs :\u003d"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"8385e038_3696688f","line":94,"range":{"start_line":94,"start_character":23,"end_line":94,"end_character":76},"in_reply_to":"991eb218_9477011f","updated":"2026-04-18 17:24:20.000000000","message":"Done. Gathered them all above.","commit_id":"9309a72f5d82cf9fc1d26ec9d5d9f992078f4ec1"},{"author":{"_account_id":1000012,"name":"Angel Pons","email":"th3fanbus@gmail.com","username":"th3fanbus","avatars":[{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"5761b18ee38b20c7f1b0a0a082c0bc90b3632fc8","unresolved":true,"context_lines":[{"line_number":178,"context_line":""},{"line_number":179,"context_line":"   ----------------------------------------------------------------------------"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"   function Power_Request_Mask (PD : Power_Domain) return Word32 is"},{"line_number":182,"context_line":"   begin"},{"line_number":183,"context_line":"      if PD in PW_Domain then"},{"line_number":184,"context_line":"         return PW_Request_Mask (PD);"},{"line_number":185,"context_line":"      elsif PD in DDI_Domain then"},{"line_number":186,"context_line":"         return DDI_Request_Mask (PD);"},{"line_number":187,"context_line":"      else"},{"line_number":188,"context_line":"         return AUX_Request_Mask (PD);"},{"line_number":189,"context_line":"      end if;"},{"line_number":190,"context_line":"   end Power_Request_Mask;"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"   function Power_State_Mask (PD : Power_Domain) return Word32 is"},{"line_number":193,"context_line":"   begin"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"22229f2b_d4f95451","line":190,"range":{"start_line":181,"start_character":3,"end_line":190,"end_character":26},"updated":"2026-04-18 11:37:04.000000000","message":"I think this is possible:\n\n```suggestion\n   function Power_Request_Mask (PD : Power_Domain) return Word32 is\n     (case PD is\n         when PW_Domain\u0027Range  \u003d\u003e PW_Request_Mask (PD),\n         when DDI_Domain\u0027Range \u003d\u003e DDI_Request_Mask (PD),\n         when AUX_Domain\u0027Range \u003d\u003e AUX_Request_Mask (PD));\n```\n\nSimilar thing for the function below","commit_id":"9309a72f5d82cf9fc1d26ec9d5d9f992078f4ec1"},{"author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"29c22181da94b0732e1ec9850d1e9cc513921b9c","unresolved":false,"context_lines":[{"line_number":178,"context_line":""},{"line_number":179,"context_line":"   ----------------------------------------------------------------------------"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"   function Power_Request_Mask (PD : Power_Domain) return Word32 is"},{"line_number":182,"context_line":"   begin"},{"line_number":183,"context_line":"      if PD in PW_Domain then"},{"line_number":184,"context_line":"         return PW_Request_Mask (PD);"},{"line_number":185,"context_line":"      elsif PD in DDI_Domain then"},{"line_number":186,"context_line":"         return DDI_Request_Mask (PD);"},{"line_number":187,"context_line":"      else"},{"line_number":188,"context_line":"         return AUX_Request_Mask (PD);"},{"line_number":189,"context_line":"      end if;"},{"line_number":190,"context_line":"   end Power_Request_Mask;"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"   function Power_State_Mask (PD : Power_Domain) return Word32 is"},{"line_number":193,"context_line":"   begin"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"6057fe87_a9d4fb80","line":190,"range":{"start_line":181,"start_character":3,"end_line":190,"end_character":26},"in_reply_to":"22229f2b_d4f95451","updated":"2026-04-18 17:24:20.000000000","message":"Done","commit_id":"9309a72f5d82cf9fc1d26ec9d5d9f992078f4ec1"},{"author":{"_account_id":1000012,"name":"Angel Pons","email":"th3fanbus@gmail.com","username":"th3fanbus","avatars":[{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"5761b18ee38b20c7f1b0a0a082c0bc90b3632fc8","unresolved":false,"context_lines":[{"line_number":270,"context_line":"      if (Ctl2 and Power_Request_Mask (PD)) \u003d 0 then"},{"line_number":271,"context_line":"         Pre_PD_On (PD);"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"         Registers.Set_Mask (PWR_CTL_DRIVER (PD_Type), Power_Request_Mask (PD));"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"         Registers.Wait_Set_Mask"},{"line_number":276,"context_line":"           (Register \u003d\u003e PWR_CTL_DRIVER (PD_Type),"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"4555c371_c47e3ed5","line":273,"updated":"2026-04-18 11:37:04.000000000","message":"I wonder, should libgfxinit should use the BIOS or the Driver `PWR_CTL_` register to request PD on?","commit_id":"9309a72f5d82cf9fc1d26ec9d5d9f992078f4ec1"},{"author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"29c22181da94b0732e1ec9850d1e9cc513921b9c","unresolved":false,"context_lines":[{"line_number":270,"context_line":"      if (Ctl2 and Power_Request_Mask (PD)) \u003d 0 then"},{"line_number":271,"context_line":"         Pre_PD_On (PD);"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"         Registers.Set_Mask (PWR_CTL_DRIVER (PD_Type), Power_Request_Mask (PD));"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"         Registers.Wait_Set_Mask"},{"line_number":276,"context_line":"           (Register \u003d\u003e PWR_CTL_DRIVER (PD_Type),"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"98c7f9a1_70690bc7","line":273,"in_reply_to":"4555c371_c47e3ed5","updated":"2026-04-18 17:24:20.000000000","message":"It uses the Driver register because it also acts as an OS driver with an\nactual VBIOS around (at least on some prototypes at secunet).\n\nFor coreboot it shouldn\u0027t matter, because there isn\u0027t supposed to be any\nVBIOS around when libgfxinit is used. And it won\u0027t continue to use the\nregister when the OS runs.\n\nProbably something that should be configurable when anyone puts libgfxinit\ninto a VBIOS.","commit_id":"9309a72f5d82cf9fc1d26ec9d5d9f992078f4ec1"},{"author":{"_account_id":1000012,"name":"Angel Pons","email":"th3fanbus@gmail.com","username":"th3fanbus","avatars":[{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"2e4b6269b0a208bf40cabceaf7d413d8a4ea0ba5","unresolved":false,"context_lines":[{"line_number":270,"context_line":"      if (Ctl2 and Power_Request_Mask (PD)) \u003d 0 then"},{"line_number":271,"context_line":"         Pre_PD_On (PD);"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"         Registers.Set_Mask (PWR_CTL_DRIVER (PD_Type), Power_Request_Mask (PD));"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"         Registers.Wait_Set_Mask"},{"line_number":276,"context_line":"           (Register \u003d\u003e PWR_CTL_DRIVER (PD_Type),"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"e5cc63b5_d7805ea6","line":273,"in_reply_to":"98c7f9a1_70690bc7","updated":"2026-04-18 17:30:59.000000000","message":"Ack","commit_id":"9309a72f5d82cf9fc1d26ec9d5d9f992078f4ec1"},{"author":{"_account_id":1000012,"name":"Angel Pons","email":"th3fanbus@gmail.com","username":"th3fanbus","avatars":[{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"5761b18ee38b20c7f1b0a0a082c0bc90b3632fc8","unresolved":false,"context_lines":[{"line_number":309,"context_line":"   function Need_PD (PD : Power_Domain; Configs : Pipe_Configs) return Boolean"},{"line_number":310,"context_line":"   is"},{"line_number":311,"context_line":"      function Any_Port_Is (Port : GPU_Port) return Boolean is"},{"line_number":312,"context_line":"        (for some Pipe in Pipe_Index \u003d\u003e"},{"line_number":313,"context_line":"            Configs (Pipe).Port /\u003d Disabled and then"},{"line_number":314,"context_line":"            Config_Helpers.To_GPU_Port (Pipe, Configs (Pipe).Port) \u003d Port);"},{"line_number":315,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":5,"id":"feb20233_907355a9","line":312,"updated":"2026-04-18 11:37:04.000000000","message":"Oooh, very neat: http://www.ada-auth.org/standards/12rat/html/Rat12-3-4.html","commit_id":"9309a72f5d82cf9fc1d26ec9d5d9f992078f4ec1"},{"author":{"_account_id":1000012,"name":"Angel Pons","email":"th3fanbus@gmail.com","username":"th3fanbus","avatars":[{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"5761b18ee38b20c7f1b0a0a082c0bc90b3632fc8","unresolved":false,"context_lines":[{"line_number":327,"context_line":"        (for some Pipe in First .. Pipe_Index\u0027Last \u003d\u003e Configs (Pipe).Port /\u003d Disabled);"},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"      function VGA return Boolean is"},{"line_number":330,"context_line":"        (Configs (Primary).Port \u003d Analog or"},{"line_number":331,"context_line":"         Configs (Primary).Framebuffer.Offset \u003d VGA_PLANE_FRAMEBUFFER_OFFSET);"},{"line_number":332,"context_line":"   begin"},{"line_number":333,"context_line":"      case PD is"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"e7877d9d_b38cafd8","line":330,"updated":"2026-04-18 11:37:04.000000000","message":"Does TGL have Analog?","commit_id":"9309a72f5d82cf9fc1d26ec9d5d9f992078f4ec1"},{"author":{"_account_id":1000012,"name":"Angel Pons","email":"th3fanbus@gmail.com","username":"th3fanbus","avatars":[{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"2e4b6269b0a208bf40cabceaf7d413d8a4ea0ba5","unresolved":false,"context_lines":[{"line_number":327,"context_line":"        (for some Pipe in First .. Pipe_Index\u0027Last \u003d\u003e Configs (Pipe).Port /\u003d Disabled);"},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"      function VGA return Boolean is"},{"line_number":330,"context_line":"        (Configs (Primary).Port \u003d Analog or"},{"line_number":331,"context_line":"         Configs (Primary).Framebuffer.Offset \u003d VGA_PLANE_FRAMEBUFFER_OFFSET);"},{"line_number":332,"context_line":"   begin"},{"line_number":333,"context_line":"      case PD is"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"ad06aacf_97eefa1d","line":330,"in_reply_to":"2f55db41_e80e32ca","updated":"2026-04-18 17:30:59.000000000","message":"The PCH DAC was last found in LPT-H","commit_id":"9309a72f5d82cf9fc1d26ec9d5d9f992078f4ec1"},{"author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"29c22181da94b0732e1ec9850d1e9cc513921b9c","unresolved":false,"context_lines":[{"line_number":327,"context_line":"        (for some Pipe in First .. Pipe_Index\u0027Last \u003d\u003e Configs (Pipe).Port /\u003d Disabled);"},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"      function VGA return Boolean is"},{"line_number":330,"context_line":"        (Configs (Primary).Port \u003d Analog or"},{"line_number":331,"context_line":"         Configs (Primary).Framebuffer.Offset \u003d VGA_PLANE_FRAMEBUFFER_OFFSET);"},{"line_number":332,"context_line":"   begin"},{"line_number":333,"context_line":"      case PD is"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"2f55db41_e80e32ca","line":330,"in_reply_to":"e7877d9d_b38cafd8","updated":"2026-04-18 17:24:20.000000000","message":"Good catch, looks like I was overzealous. No sign of an analog port, even in the PCH-H.","commit_id":"9309a72f5d82cf9fc1d26ec9d5d9f992078f4ec1"},{"author":{"_account_id":1000012,"name":"Angel Pons","email":"th3fanbus@gmail.com","username":"th3fanbus","avatars":[{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"5761b18ee38b20c7f1b0a0a082c0bc90b3632fc8","unresolved":false,"context_lines":[{"line_number":490,"context_line":"         when 19_200_000 \u003d\u003e PLL_Ratio :\u003d Ratio_For_19_2_MHz (CDClk);"},{"line_number":491,"context_line":"         when 38_400_000 \u003d\u003e PLL_Ratio :\u003d Ratio_For_19_2_MHz (CDClk) / 2;"},{"line_number":492,"context_line":"         when 24_000_000 \u003d\u003e PLL_Ratio :\u003d Ratio_For_24_MHz (CDClk);"},{"line_number":493,"context_line":"         when others \u003d\u003e PLL_Ratio :\u003d 0;"},{"line_number":494,"context_line":"      end case;"},{"line_number":495,"context_line":""},{"line_number":496,"context_line":"      if PLL_Ratio \u003d 0 then"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"704e36ed_635b96dc","line":493,"updated":"2026-04-18 11:37:04.000000000","message":"nit: alignment? TBH I\u0027d use a case-expression to avoid repeating `PLL_Ratio :\u003d`","commit_id":"9309a72f5d82cf9fc1d26ec9d5d9f992078f4ec1"},{"author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"29c22181da94b0732e1ec9850d1e9cc513921b9c","unresolved":false,"context_lines":[{"line_number":490,"context_line":"         when 19_200_000 \u003d\u003e PLL_Ratio :\u003d Ratio_For_19_2_MHz (CDClk);"},{"line_number":491,"context_line":"         when 38_400_000 \u003d\u003e PLL_Ratio :\u003d Ratio_For_19_2_MHz (CDClk) / 2;"},{"line_number":492,"context_line":"         when 24_000_000 \u003d\u003e PLL_Ratio :\u003d Ratio_For_24_MHz (CDClk);"},{"line_number":493,"context_line":"         when others \u003d\u003e PLL_Ratio :\u003d 0;"},{"line_number":494,"context_line":"      end case;"},{"line_number":495,"context_line":""},{"line_number":496,"context_line":"      if PLL_Ratio \u003d 0 then"}],"source_content_type":"application/octet-stream","patch_set":5,"id":"6a885590_b02868df","line":493,"in_reply_to":"704e36ed_635b96dc","updated":"2026-04-18 17:24:20.000000000","message":"Done.","commit_id":"9309a72f5d82cf9fc1d26ec9d5d9f992078f4ec1"}]}