)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"4b12ed81fe94e05cc07e1f32e15f16b8afb90dfe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"70f095bb_59c8267f","updated":"2024-01-16 11:49:29.000000000","message":"Thanks for the patch! Just a few minor remarks.\n\nI\u0027ll leave this unmerged for a while, just in case somebody else shows\nan opinion about serprog (I don\u0027t have a strong one).","commit_id":"75d7ab6d5dffbc2b0533d2bf33d8ed592c495a53"},{"author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"479622ba89c713830b844296be1725cee70efe33","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d6a22333_c3788886","updated":"2024-01-21 12:46:21.000000000","message":"Thanks for the update. Tested most errors paths (without a compatible serprog firmware).","commit_id":"a08cb39c33f4d814747fabf99e3240a996fa9354"},{"author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"c9753dec218e26663d9b056b7e478d7d9b9bdc10","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"57f2ece8_f85812c6","updated":"2024-01-26 19:27:42.000000000","message":"Urja says it looks fine.","commit_id":"a08cb39c33f4d814747fabf99e3240a996fa9354"}],"serprog.c":[{"author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"4b12ed81fe94e05cc07e1f32e15f16b8afb90dfe","unresolved":true,"context_lines":[{"line_number":583,"context_line":"\t\tif (cs \u0026\u0026 strlen(cs)) {"},{"line_number":584,"context_line":"\t\t\tchar *endptr \u003d NULL;"},{"line_number":585,"context_line":"\t\t\terrno \u003d 0;"},{"line_number":586,"context_line":"\t\t\tunsigned int cs_num \u003d strtoul(cs, \u0026endptr, 0);"},{"line_number":587,"context_line":"\t\t\tif (errno || *endptr || cs_num \u003e 255) {"},{"line_number":588,"context_line":"\t\t\t\tmsg_perr(\"Error: Invalid chip select requested! \""},{"line_number":589,"context_line":"\t\t\t\t         \"Only 0-255 are valid.\\n\");"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"5ea1cf6b_b0367a85","line":586,"range":{"start_line":586,"start_character":12,"end_line":586,"end_character":15},"updated":"2024-01-16 11:49:29.000000000","message":"`unsigned long` please, as it may differ from int (e.g. x86_64). (It\u0027s more a\ntheoretical issue, as most likely nobody will have a number \u003e\u003d 2^32 on their\ncommand line.)","commit_id":"75d7ab6d5dffbc2b0533d2bf33d8ed592c495a53"},{"author":{"_account_id":1000004,"name":"Riku Viitanen","email":"riku.viitanen@protonmail.com","username":"riku_v","avatars":[{"url":"https://www.gravatar.com/avatar/366d39a1baf33e38ee81c91ec1dade38.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/366d39a1baf33e38ee81c91ec1dade38.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/366d39a1baf33e38ee81c91ec1dade38.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/366d39a1baf33e38ee81c91ec1dade38.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"fbb21eabf2af06951e6a164449c9837be3b115d9","unresolved":false,"context_lines":[{"line_number":583,"context_line":"\t\tif (cs \u0026\u0026 strlen(cs)) {"},{"line_number":584,"context_line":"\t\t\tchar *endptr \u003d NULL;"},{"line_number":585,"context_line":"\t\t\terrno \u003d 0;"},{"line_number":586,"context_line":"\t\t\tunsigned int cs_num \u003d strtoul(cs, \u0026endptr, 0);"},{"line_number":587,"context_line":"\t\t\tif (errno || *endptr || cs_num \u003e 255) {"},{"line_number":588,"context_line":"\t\t\t\tmsg_perr(\"Error: Invalid chip select requested! \""},{"line_number":589,"context_line":"\t\t\t\t         \"Only 0-255 are valid.\\n\");"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"1e34e24d_f3218934","line":586,"range":{"start_line":586,"start_character":12,"end_line":586,"end_character":15},"in_reply_to":"5ea1cf6b_b0367a85","updated":"2024-01-19 22:38:45.000000000","message":"Done","commit_id":"75d7ab6d5dffbc2b0533d2bf33d8ed592c495a53"},{"author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"4b12ed81fe94e05cc07e1f32e15f16b8afb90dfe","unresolved":true,"context_lines":[{"line_number":586,"context_line":"\t\t\tunsigned int cs_num \u003d strtoul(cs, \u0026endptr, 0);"},{"line_number":587,"context_line":"\t\t\tif (errno || *endptr || cs_num \u003e 255) {"},{"line_number":588,"context_line":"\t\t\t\tmsg_perr(\"Error: Invalid chip select requested! \""},{"line_number":589,"context_line":"\t\t\t\t         \"Only 0-255 are valid.\\n\");"},{"line_number":590,"context_line":"\t\t\t\tgoto init_err_cleanup_exit;"},{"line_number":591,"context_line":"\t\t\t}"},{"line_number":592,"context_line":"\t\t\tif (!sp_check_commandavail(S_CMD_S_SPI_CS)) {"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"9eca749b_d44e6b82","line":589,"updated":"2024-01-16 11:49:29.000000000","message":"`free(cs);`","commit_id":"75d7ab6d5dffbc2b0533d2bf33d8ed592c495a53"},{"author":{"_account_id":1000004,"name":"Riku Viitanen","email":"riku.viitanen@protonmail.com","username":"riku_v","avatars":[{"url":"https://www.gravatar.com/avatar/366d39a1baf33e38ee81c91ec1dade38.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/366d39a1baf33e38ee81c91ec1dade38.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/366d39a1baf33e38ee81c91ec1dade38.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/366d39a1baf33e38ee81c91ec1dade38.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"fbb21eabf2af06951e6a164449c9837be3b115d9","unresolved":false,"context_lines":[{"line_number":586,"context_line":"\t\t\tunsigned int cs_num \u003d strtoul(cs, \u0026endptr, 0);"},{"line_number":587,"context_line":"\t\t\tif (errno || *endptr || cs_num \u003e 255) {"},{"line_number":588,"context_line":"\t\t\t\tmsg_perr(\"Error: Invalid chip select requested! \""},{"line_number":589,"context_line":"\t\t\t\t         \"Only 0-255 are valid.\\n\");"},{"line_number":590,"context_line":"\t\t\t\tgoto init_err_cleanup_exit;"},{"line_number":591,"context_line":"\t\t\t}"},{"line_number":592,"context_line":"\t\t\tif (!sp_check_commandavail(S_CMD_S_SPI_CS)) {"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"22bcef9b_6acf3a54","line":589,"in_reply_to":"9eca749b_d44e6b82","updated":"2024-01-19 22:38:45.000000000","message":"Done","commit_id":"75d7ab6d5dffbc2b0533d2bf33d8ed592c495a53"},{"author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"4b12ed81fe94e05cc07e1f32e15f16b8afb90dfe","unresolved":true,"context_lines":[{"line_number":588,"context_line":"\t\t\t\tmsg_perr(\"Error: Invalid chip select requested! \""},{"line_number":589,"context_line":"\t\t\t\t         \"Only 0-255 are valid.\\n\");"},{"line_number":590,"context_line":"\t\t\t\tgoto init_err_cleanup_exit;"},{"line_number":591,"context_line":"\t\t\t}"},{"line_number":592,"context_line":"\t\t\tif (!sp_check_commandavail(S_CMD_S_SPI_CS)) {"},{"line_number":593,"context_line":"\t\t\t\tmsg_perr(\"Error: Setting SPI chip select is not supported!\\n\");"},{"line_number":594,"context_line":"\t\t\t\tgoto init_err_cleanup_exit;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"80c9d543_c50f2b5e","line":591,"updated":"2024-01-16 11:49:29.000000000","message":"`free(cs);` here instead of line 604 would avoid having to clean it up\non further error paths.","commit_id":"75d7ab6d5dffbc2b0533d2bf33d8ed592c495a53"},{"author":{"_account_id":1000004,"name":"Riku Viitanen","email":"riku.viitanen@protonmail.com","username":"riku_v","avatars":[{"url":"https://www.gravatar.com/avatar/366d39a1baf33e38ee81c91ec1dade38.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/366d39a1baf33e38ee81c91ec1dade38.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/366d39a1baf33e38ee81c91ec1dade38.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/366d39a1baf33e38ee81c91ec1dade38.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"fbb21eabf2af06951e6a164449c9837be3b115d9","unresolved":false,"context_lines":[{"line_number":588,"context_line":"\t\t\t\tmsg_perr(\"Error: Invalid chip select requested! \""},{"line_number":589,"context_line":"\t\t\t\t         \"Only 0-255 are valid.\\n\");"},{"line_number":590,"context_line":"\t\t\t\tgoto init_err_cleanup_exit;"},{"line_number":591,"context_line":"\t\t\t}"},{"line_number":592,"context_line":"\t\t\tif (!sp_check_commandavail(S_CMD_S_SPI_CS)) {"},{"line_number":593,"context_line":"\t\t\t\tmsg_perr(\"Error: Setting SPI chip select is not supported!\\n\");"},{"line_number":594,"context_line":"\t\t\t\tgoto init_err_cleanup_exit;"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"4d9dd473_887efd80","line":591,"in_reply_to":"80c9d543_c50f2b5e","updated":"2024-01-19 22:38:45.000000000","message":"Done","commit_id":"75d7ab6d5dffbc2b0533d2bf33d8ed592c495a53"},{"author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"4b12ed81fe94e05cc07e1f32e15f16b8afb90dfe","unresolved":false,"context_lines":[{"line_number":594,"context_line":"\t\t\t\tgoto init_err_cleanup_exit;"},{"line_number":595,"context_line":"\t\t\t}"},{"line_number":596,"context_line":"\t\t\tmsg_pdbg(MSGHEADER \"Requested to use chip select %u.\\n\", cs_num);"},{"line_number":597,"context_line":"\t\t\tuint8_t cs_num8 \u003d (uint8_t) cs_num;"},{"line_number":598,"context_line":"\t\t\tif (sp_docommand(S_CMD_S_SPI_CS, 1, \u0026cs_num8, 0, NULL)) {"},{"line_number":599,"context_line":"\t\t\t\tmsg_perr(\"Error: Chip select %u not supported \""},{"line_number":600,"context_line":"\t\t\t\t         \"by programmer!\\n\", cs_num8);"}],"source_content_type":"text/x-csrc","patch_set":1,"id":"d7d877c8_3965b21c","line":597,"range":{"start_line":597,"start_character":21,"end_line":597,"end_character":31},"updated":"2024-01-16 11:49:29.000000000","message":"Technically there is no need to cast (and we don\u0027t put a space after the closing parent).","commit_id":"75d7ab6d5dffbc2b0533d2bf33d8ed592c495a53"},{"author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"99d60bef922df73fedf8d4fa3657874d25c3aef5","unresolved":false,"context_lines":[{"line_number":580,"context_line":"\t\t}"},{"line_number":581,"context_line":"\t\tfree(spispeed);"},{"line_number":582,"context_line":"\t\tcs \u003d extract_programmer_param(\"cs\");"},{"line_number":583,"context_line":"\t\tif (cs \u0026\u0026 strlen(cs)) {"},{"line_number":584,"context_line":"\t\t\tchar *endptr \u003d NULL;"},{"line_number":585,"context_line":"\t\t\terrno \u003d 0;"},{"line_number":586,"context_line":"\t\t\tunsigned long cs_num \u003d strtoul(cs, \u0026endptr, 0);"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"877562f0_7c6b16c3","line":583,"range":{"start_line":583,"start_character":8,"end_line":583,"end_character":22},"updated":"2024-01-20 13:36:04.000000000","message":"Ignoring an empty string is uncommon and I wonder if it\u0027s what we really\nwant. It would allow the user to specify `-p serprog:cs\u003d` but to what end?\nAn alternative would be to not check here but add `!*cs ||` to the if in\nline 587. That would make us error out without making this more complex.\n\nOnly realized this because of the new `else` below (shows that I didn\u0027t\npay enough attention when suggesting to move the free() /o\\ ).","commit_id":"3a306cfa09a20e13c1bb676f858266154dd98f24"},{"author":{"_account_id":1000004,"name":"Riku Viitanen","email":"riku.viitanen@protonmail.com","username":"riku_v","avatars":[{"url":"https://www.gravatar.com/avatar/366d39a1baf33e38ee81c91ec1dade38.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/366d39a1baf33e38ee81c91ec1dade38.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/366d39a1baf33e38ee81c91ec1dade38.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/366d39a1baf33e38ee81c91ec1dade38.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"feae5c83fd664759b3faad60b2207c44a9d196de","unresolved":false,"context_lines":[{"line_number":580,"context_line":"\t\t}"},{"line_number":581,"context_line":"\t\tfree(spispeed);"},{"line_number":582,"context_line":"\t\tcs \u003d extract_programmer_param(\"cs\");"},{"line_number":583,"context_line":"\t\tif (cs \u0026\u0026 strlen(cs)) {"},{"line_number":584,"context_line":"\t\t\tchar *endptr \u003d NULL;"},{"line_number":585,"context_line":"\t\t\terrno \u003d 0;"},{"line_number":586,"context_line":"\t\t\tunsigned long cs_num \u003d strtoul(cs, \u0026endptr, 0);"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"3a09dc3d_c8f8635d","line":583,"range":{"start_line":583,"start_character":8,"end_line":583,"end_character":22},"in_reply_to":"877562f0_7c6b16c3","updated":"2024-01-21 10:10:53.000000000","message":"Ignoring it could be dangerous even, in some weird circumstances. Maybe the wrong chip gets flashed? Fixed it.","commit_id":"3a306cfa09a20e13c1bb676f858266154dd98f24"},{"author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"99d60bef922df73fedf8d4fa3657874d25c3aef5","unresolved":true,"context_lines":[{"line_number":595,"context_line":"\t\t\t\tmsg_perr(\"Error: Setting SPI chip select is not supported!\\n\");"},{"line_number":596,"context_line":"\t\t\t\tgoto init_err_cleanup_exit;"},{"line_number":597,"context_line":"\t\t\t}"},{"line_number":598,"context_line":"\t\t\tmsg_pdbg(MSGHEADER \"Requested to use chip select %u.\\n\", cs_num);"},{"line_number":599,"context_line":"\t\t\tuint8_t cs_num8 \u003d cs_num;"},{"line_number":600,"context_line":"\t\t\tif (sp_docommand(S_CMD_S_SPI_CS, 1, \u0026cs_num8, 0, NULL)) {"},{"line_number":601,"context_line":"\t\t\t\tmsg_perr(\"Error: Chip select %u not supported \""}],"source_content_type":"text/x-csrc","patch_set":3,"id":"997d7dfa_1cdfb087","line":598,"range":{"start_line":598,"start_character":52,"end_line":598,"end_character":54},"updated":"2024-01-20 13:36:04.000000000","message":"This needs to be `%lu` now.","commit_id":"3a306cfa09a20e13c1bb676f858266154dd98f24"},{"author":{"_account_id":1000004,"name":"Riku Viitanen","email":"riku.viitanen@protonmail.com","username":"riku_v","avatars":[{"url":"https://www.gravatar.com/avatar/366d39a1baf33e38ee81c91ec1dade38.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/366d39a1baf33e38ee81c91ec1dade38.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/366d39a1baf33e38ee81c91ec1dade38.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/366d39a1baf33e38ee81c91ec1dade38.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"feae5c83fd664759b3faad60b2207c44a9d196de","unresolved":false,"context_lines":[{"line_number":595,"context_line":"\t\t\t\tmsg_perr(\"Error: Setting SPI chip select is not supported!\\n\");"},{"line_number":596,"context_line":"\t\t\t\tgoto init_err_cleanup_exit;"},{"line_number":597,"context_line":"\t\t\t}"},{"line_number":598,"context_line":"\t\t\tmsg_pdbg(MSGHEADER \"Requested to use chip select %u.\\n\", cs_num);"},{"line_number":599,"context_line":"\t\t\tuint8_t cs_num8 \u003d cs_num;"},{"line_number":600,"context_line":"\t\t\tif (sp_docommand(S_CMD_S_SPI_CS, 1, \u0026cs_num8, 0, NULL)) {"},{"line_number":601,"context_line":"\t\t\t\tmsg_perr(\"Error: Chip select %u not supported \""}],"source_content_type":"text/x-csrc","patch_set":3,"id":"dd3ebbc8_63bef750","line":598,"range":{"start_line":598,"start_character":52,"end_line":598,"end_character":54},"in_reply_to":"997d7dfa_1cdfb087","updated":"2024-01-21 10:10:53.000000000","message":"Done","commit_id":"3a306cfa09a20e13c1bb676f858266154dd98f24"}]}
