)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000003,"name":"Arthur Heymans","email":"arthur@aheymans.xyz","username":"arthurheymans","avatars":[{"url":"https://www.gravatar.com/avatar/518bb7353a0a42df698e1736723abc9f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/518bb7353a0a42df698e1736723abc9f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/518bb7353a0a42df698e1736723abc9f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/518bb7353a0a42df698e1736723abc9f.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"5098595198701dcf2b4b5bef48a9c59e2bc05f06","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"3e03453e_c605ba06","updated":"2024-04-26 11:28:56.000000000","message":"Could it be something similar is needed for fast dual IO read? I was looking at MX25L25773G (not supported I think) and I noticed that is also configurable.","commit_id":"b9438b8fad06400baa4780bcd6f1a41afb02b726"},{"author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"5aae6c4d37772236badb136a65496269a6ea0d7d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a225d3ef_e50fbdd7","in_reply_to":"3e03453e_c605ba06","updated":"2024-04-26 13:02:55.000000000","message":"Ah, yes, quite considerate. Macronix uses configuration register bits and those\nbits also control some commands when not in QPI mode. I only realized this later\nand wasn\u0027t sure if it\u0027s worth the hassle to put it all in our database. All these\ndummy-cycle configurations bits are volatile, i.e. we know their value after reset.\nChecking the bits would only be necessary with internal programmers, and those\ndon\u0027t let us control multi-i/o so far (I doubt they will).\n\nEven for the QPI mode, I just assumed the default in my patches. Not sure if there\nis something to gain from additional logic to select a different amount of dummy\ncycles. One difference for QPI/non-QPI is that the defaults for non-QPI always\nmatch what other vendors do without configuration. This makes the code simple,\nwe can just always assume 4 cycles for dual-i/o reads, 6 cycles for quad-i/o reads.\nFor QPI mode, we definitely have to put something into the database.\n\nI currently see a few things we could do:\n* Just leave a comment in `flash.h` about DC bits that they also control non-QPI commands.\n* Add all the information to the `.dummy_cycles` union.\n* Drop the `.qpi_read_params` part of the union and note the values in `.qpi_fast_read`/`.qpi_fast_read_qio`. Probably wouldn\u0027t hurt, as we might never make use of values `!\u003d 00`.\n* What we should do anyway (I added a comment to the patch that implements the read commands): Make sure the configuration bits have a known compatible value.","commit_id":"b9438b8fad06400baa4780bcd6f1a41afb02b726"}],"flashchips.c":[{"author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"abfe4571fb6c65aacb802df1a6b3bcd0b09f6764","unresolved":true,"context_lines":[{"line_number":5473,"context_line":"\t\t},"},{"line_number":5474,"context_line":"\t\t.reg_bits\t\u003d"},{"line_number":5475,"context_line":"\t\t{"},{"line_number":5476,"context_line":"\t\t\t.dc\t\u003d {{STATUS3, 4, RW}, {STATUS3, 5, RW}},"},{"line_number":5477,"context_line":"\t\t},"},{"line_number":5478,"context_line":"\t\t.printlock\t\u003d spi_prettyprint_status_register_bp3_srwd, /* bit6 is quad enable */"},{"line_number":5479,"context_line":"\t\t.unlock\t\t\u003d spi_disable_blockprotect_bp3_srwd,"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"b53ad907_33d4310a","line":5476,"range":{"start_line":5476,"start_character":11,"end_line":5476,"end_character":18},"updated":"2024-07-07 12:37:44.000000000","message":"Tricky, because this chip needs special RDSR3 command (0x95). And uses 0xc0\nfor write (like the Set Read Parameters command). So it\u0027s somewhere between\nFEATURE_QPI_SRP and DC bits...","commit_id":"c8b7a96b34fc927db0b4710ff8180e0af230d865"},{"author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"5d563df2859170ff6eb821149f3a0505975ad212","unresolved":false,"context_lines":[{"line_number":5473,"context_line":"\t\t},"},{"line_number":5474,"context_line":"\t\t.reg_bits\t\u003d"},{"line_number":5475,"context_line":"\t\t{"},{"line_number":5476,"context_line":"\t\t\t.dc\t\u003d {{STATUS3, 4, RW}, {STATUS3, 5, RW}},"},{"line_number":5477,"context_line":"\t\t},"},{"line_number":5478,"context_line":"\t\t.printlock\t\u003d spi_prettyprint_status_register_bp3_srwd, /* bit6 is quad enable */"},{"line_number":5479,"context_line":"\t\t.unlock\t\t\u003d spi_disable_blockprotect_bp3_srwd,"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"09752b3f_2d4249b4","line":5476,"range":{"start_line":5476,"start_character":11,"end_line":5476,"end_character":18},"in_reply_to":"b53ad907_33d4310a","updated":"2024-07-07 13:15:48.000000000","message":"Done","commit_id":"c8b7a96b34fc927db0b4710ff8180e0af230d865"},{"author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"abfe4571fb6c65aacb802df1a6b3bcd0b09f6764","unresolved":true,"context_lines":[{"line_number":7332,"context_line":"\t\t.printlock\t\u003d spi_prettyprint_status_register_bp4_srwd,"},{"line_number":7333,"context_line":"\t\t.unlock\t\t\u003d spi_disable_blockprotect_bp4_srwd, /* TODO: 2nd status reg (read with 0x35) */"},{"line_number":7334,"context_line":"\t\t.write\t\t\u003d spi_chip_write_256,"},{"line_number":7335,"context_line":"\t\t.read\t\t\u003d spi_chip_read, /* Fast read (0x0B) and multi I/O supported */"},{"line_number":7336,"context_line":"\t\t.voltage\t\u003d {2300, 3600},"},{"line_number":7337,"context_line":"\t},"},{"line_number":7338,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":5,"id":"8325e5a7_a912b8fc","line":7335,"range":{"start_line":7335,"start_character":25,"end_line":7335,"end_character":72},"updated":"2024-07-07 12:37:44.000000000","message":"Drop comments.","commit_id":"c8b7a96b34fc927db0b4710ff8180e0af230d865"},{"author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"5d563df2859170ff6eb821149f3a0505975ad212","unresolved":false,"context_lines":[{"line_number":7332,"context_line":"\t\t.printlock\t\u003d spi_prettyprint_status_register_bp4_srwd,"},{"line_number":7333,"context_line":"\t\t.unlock\t\t\u003d spi_disable_blockprotect_bp4_srwd, /* TODO: 2nd status reg (read with 0x35) */"},{"line_number":7334,"context_line":"\t\t.write\t\t\u003d spi_chip_write_256,"},{"line_number":7335,"context_line":"\t\t.read\t\t\u003d spi_chip_read, /* Fast read (0x0B) and multi I/O supported */"},{"line_number":7336,"context_line":"\t\t.voltage\t\u003d {2300, 3600},"},{"line_number":7337,"context_line":"\t},"},{"line_number":7338,"context_line":""}],"source_content_type":"text/x-csrc","patch_set":5,"id":"fe3cf1f3_c3020cad","line":7335,"range":{"start_line":7335,"start_character":25,"end_line":7335,"end_character":72},"in_reply_to":"8325e5a7_a912b8fc","updated":"2024-07-07 13:15:48.000000000","message":"Done","commit_id":"c8b7a96b34fc927db0b4710ff8180e0af230d865"},{"author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"abfe4571fb6c65aacb802df1a6b3bcd0b09f6764","unresolved":true,"context_lines":[{"line_number":7774,"context_line":"\t\t/* QPI: enter/exit 35/f5, SRP with 4 bits directly specifying"},{"line_number":7775,"context_line":"\t\t   dummy cycles; non-volatile read parameters, so disable for now */"},{"line_number":7776,"context_line":"\t\t.feature_bits\t\u003d FEATURE_WRSR_WREN | FEATURE_OTP,"},{"line_number":7777,"context_line":"\t\t.dummy_cycles\t\u003d"},{"line_number":7778,"context_line":"\t\t{"},{"line_number":7779,"context_line":"\t\t\t.qpi_fast_read\t\t\u003d 6,"},{"line_number":7780,"context_line":"\t\t\t.qpi_fast_read_qio\t\u003d 6,"},{"line_number":7781,"context_line":"\t\t},"},{"line_number":7782,"context_line":"\t\t.tested\t\t\u003d TEST_UNTESTED,"},{"line_number":7783,"context_line":"\t\t.probe\t\t\u003d probe_spi_rdid,"},{"line_number":7784,"context_line":"\t\t.probe_timing\t\u003d TIMING_ZERO,"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"e02fdd4b_83935d24","line":7781,"range":{"start_line":7777,"start_character":0,"end_line":7781,"end_character":4},"updated":"2024-07-07 12:37:44.000000000","message":"Drop. Makes no sense given the above.","commit_id":"c8b7a96b34fc927db0b4710ff8180e0af230d865"},{"author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"5d563df2859170ff6eb821149f3a0505975ad212","unresolved":false,"context_lines":[{"line_number":7774,"context_line":"\t\t/* QPI: enter/exit 35/f5, SRP with 4 bits directly specifying"},{"line_number":7775,"context_line":"\t\t   dummy cycles; non-volatile read parameters, so disable for now */"},{"line_number":7776,"context_line":"\t\t.feature_bits\t\u003d FEATURE_WRSR_WREN | FEATURE_OTP,"},{"line_number":7777,"context_line":"\t\t.dummy_cycles\t\u003d"},{"line_number":7778,"context_line":"\t\t{"},{"line_number":7779,"context_line":"\t\t\t.qpi_fast_read\t\t\u003d 6,"},{"line_number":7780,"context_line":"\t\t\t.qpi_fast_read_qio\t\u003d 6,"},{"line_number":7781,"context_line":"\t\t},"},{"line_number":7782,"context_line":"\t\t.tested\t\t\u003d TEST_UNTESTED,"},{"line_number":7783,"context_line":"\t\t.probe\t\t\u003d probe_spi_rdid,"},{"line_number":7784,"context_line":"\t\t.probe_timing\t\u003d TIMING_ZERO,"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"745a66c2_849a6727","line":7781,"range":{"start_line":7777,"start_character":0,"end_line":7781,"end_character":4},"in_reply_to":"e02fdd4b_83935d24","updated":"2024-07-07 13:15:48.000000000","message":"Done","commit_id":"c8b7a96b34fc927db0b4710ff8180e0af230d865"},{"author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"abfe4571fb6c65aacb802df1a6b3bcd0b09f6764","unresolved":true,"context_lines":[{"line_number":9787,"context_line":"\t\t/* TODO: security register */"},{"line_number":9788,"context_line":"\t\t.reg_bits\t\u003d"},{"line_number":9789,"context_line":"\t\t{"},{"line_number":9790,"context_line":"\t\t\t.dc\t\u003d {{STATUS2, 6, RW}, {STATUS2, 7, RW}},"},{"line_number":9791,"context_line":"\t\t},"},{"line_number":9792,"context_line":"\t\t.printlock\t\u003d spi_prettyprint_status_register_bp3_srwd, /* bit6 is quad enable */"},{"line_number":9793,"context_line":"\t\t.unlock\t\t\u003d spi_disable_blockprotect_bp3_srwd,"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"60e54e66_ceafb438","line":9790,"range":{"start_line":9790,"start_character":11,"end_line":9790,"end_character":18},"updated":"2024-07-07 12:37:44.000000000","message":"Tricky, they call it configuration register, it\u0027s written like SR2 but read like SR3. Pull CB:66211?","commit_id":"c8b7a96b34fc927db0b4710ff8180e0af230d865"},{"author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"5d563df2859170ff6eb821149f3a0505975ad212","unresolved":false,"context_lines":[{"line_number":9787,"context_line":"\t\t/* TODO: security register */"},{"line_number":9788,"context_line":"\t\t.reg_bits\t\u003d"},{"line_number":9789,"context_line":"\t\t{"},{"line_number":9790,"context_line":"\t\t\t.dc\t\u003d {{STATUS2, 6, RW}, {STATUS2, 7, RW}},"},{"line_number":9791,"context_line":"\t\t},"},{"line_number":9792,"context_line":"\t\t.printlock\t\u003d spi_prettyprint_status_register_bp3_srwd, /* bit6 is quad enable */"},{"line_number":9793,"context_line":"\t\t.unlock\t\t\u003d spi_disable_blockprotect_bp3_srwd,"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"1ef24538_46f391c1","line":9790,"range":{"start_line":9790,"start_character":11,"end_line":9790,"end_character":18},"in_reply_to":"60e54e66_ceafb438","updated":"2024-07-07 13:15:48.000000000","message":"Done","commit_id":"c8b7a96b34fc927db0b4710ff8180e0af230d865"},{"author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"abfe4571fb6c65aacb802df1a6b3bcd0b09f6764","unresolved":true,"context_lines":[{"line_number":9890,"context_line":"\t\t/* TODO: security register */"},{"line_number":9891,"context_line":"\t\t.reg_bits\t\u003d"},{"line_number":9892,"context_line":"\t\t{"},{"line_number":9893,"context_line":"\t\t\t.dc\t\u003d {{STATUS2, 6, RW}, {STATUS2, 7, RW}},"},{"line_number":9894,"context_line":"\t\t},"},{"line_number":9895,"context_line":"\t\t.printlock\t\u003d spi_prettyprint_status_register_bp3_srwd, /* bit6 is quad enable */"},{"line_number":9896,"context_line":"\t\t.unlock\t\t\u003d spi_disable_blockprotect_bp3_srwd,"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"f6b8328f_0fcf3618","line":9893,"range":{"start_line":9893,"start_character":11,"end_line":9893,"end_character":18},"updated":"2024-07-07 12:37:44.000000000","message":"CONFIG","commit_id":"c8b7a96b34fc927db0b4710ff8180e0af230d865"},{"author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"5d563df2859170ff6eb821149f3a0505975ad212","unresolved":false,"context_lines":[{"line_number":9890,"context_line":"\t\t/* TODO: security register */"},{"line_number":9891,"context_line":"\t\t.reg_bits\t\u003d"},{"line_number":9892,"context_line":"\t\t{"},{"line_number":9893,"context_line":"\t\t\t.dc\t\u003d {{STATUS2, 6, RW}, {STATUS2, 7, RW}},"},{"line_number":9894,"context_line":"\t\t},"},{"line_number":9895,"context_line":"\t\t.printlock\t\u003d spi_prettyprint_status_register_bp3_srwd, /* bit6 is quad enable */"},{"line_number":9896,"context_line":"\t\t.unlock\t\t\u003d spi_disable_blockprotect_bp3_srwd,"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"72036216_973a935a","line":9893,"range":{"start_line":9893,"start_character":11,"end_line":9893,"end_character":18},"in_reply_to":"f6b8328f_0fcf3618","updated":"2024-07-07 13:15:48.000000000","message":"Done","commit_id":"c8b7a96b34fc927db0b4710ff8180e0af230d865"},{"author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"abfe4571fb6c65aacb802df1a6b3bcd0b09f6764","unresolved":true,"context_lines":[{"line_number":18044,"context_line":"\t\t.total_size\t\u003d 2048,"},{"line_number":18045,"context_line":"\t\t.page_size\t\u003d 256,"},{"line_number":18046,"context_line":"\t\t/* OTP: 256B total; read 0x48; write 0x42, erase 0x44, read ID 0x4B */"},{"line_number":18047,"context_line":"\t\t.feature_bits\t\u003d FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_QPI_SRP,"},{"line_number":18048,"context_line":"\t\t.dummy_cycles\t\u003d { .qpi_read_params \u003d { 2, 4, 6, 8 } },"},{"line_number":18049,"context_line":"\t\t.tested\t\t\u003d TEST_UNTESTED,"},{"line_number":18050,"context_line":"\t\t.probe\t\t\u003d probe_spi_rdid,"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"9fb63568_e31954c9","line":18047,"range":{"start_line":18047,"start_character":52,"end_line":18047,"end_character":67},"updated":"2024-07-07 12:37:44.000000000","message":"Not JW w/o DTR.","commit_id":"c8b7a96b34fc927db0b4710ff8180e0af230d865"},{"author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"5d563df2859170ff6eb821149f3a0505975ad212","unresolved":false,"context_lines":[{"line_number":18044,"context_line":"\t\t.total_size\t\u003d 2048,"},{"line_number":18045,"context_line":"\t\t.page_size\t\u003d 256,"},{"line_number":18046,"context_line":"\t\t/* OTP: 256B total; read 0x48; write 0x42, erase 0x44, read ID 0x4B */"},{"line_number":18047,"context_line":"\t\t.feature_bits\t\u003d FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_QPI_SRP,"},{"line_number":18048,"context_line":"\t\t.dummy_cycles\t\u003d { .qpi_read_params \u003d { 2, 4, 6, 8 } },"},{"line_number":18049,"context_line":"\t\t.tested\t\t\u003d TEST_UNTESTED,"},{"line_number":18050,"context_line":"\t\t.probe\t\t\u003d probe_spi_rdid,"}],"source_content_type":"text/x-csrc","patch_set":5,"id":"db2c6677_f16a5b6d","line":18047,"range":{"start_line":18047,"start_character":52,"end_line":18047,"end_character":67},"in_reply_to":"9fb63568_e31954c9","updated":"2024-07-07 13:15:48.000000000","message":"Done","commit_id":"c8b7a96b34fc927db0b4710ff8180e0af230d865"}]}