)]}'
{"cli_classic.c":[{"author":{"_account_id":1000019,"name":"Felix Singer","email":"felixsinger@posteo.net","username":"felixsinger","avatars":[{"url":"https://www.gravatar.com/avatar/c9b0aa50a958abce7b90cfe92b63a781.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c9b0aa50a958abce7b90cfe92b63a781.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c9b0aa50a958abce7b90cfe92b63a781.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c9b0aa50a958abce7b90cfe92b63a781.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"d40ba9a790dbb446d4814a71a7cd066f1c1553f8","unresolved":false,"context_lines":[{"line_number":567,"context_line":"\tif (ret)"},{"line_number":568,"context_line":"\t\tgoto out_shutdown;"},{"line_number":569,"context_line":""},{"line_number":570,"context_line":"\tif (layout \u0026\u0026 layout_num_regions_included(layout) \u003d\u003d 0)"},{"line_number":571,"context_line":"\t\tmsg_gwarn(\"Warning: Layout specified but no region included!\\n\");"},{"line_number":572,"context_line":""},{"line_number":573,"context_line":"\tflashprog_layout_set(fill_flash, layout);"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"cb21c75e_578204ae","line":570,"updated":"2025-02-23 21:30:17.000000000","message":"nit. I would write it that way. I think it\u0027s a bit more readable.\n\n```suggestion\n\tif (layout \u0026\u0026 !layout_num_regions_included(layout))\n```","commit_id":"12511a13332c7d5b9583f8ba939c2a33a771f508"},{"author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"2756b9132a07969c458e0d692a765b0fb229892f","unresolved":false,"context_lines":[{"line_number":567,"context_line":"\tif (ret)"},{"line_number":568,"context_line":"\t\tgoto out_shutdown;"},{"line_number":569,"context_line":""},{"line_number":570,"context_line":"\tif (layout \u0026\u0026 layout_num_regions_included(layout) \u003d\u003d 0)"},{"line_number":571,"context_line":"\t\tmsg_gwarn(\"Warning: Layout specified but no region included!\\n\");"},{"line_number":572,"context_line":""},{"line_number":573,"context_line":"\tflashprog_layout_set(fill_flash, layout);"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"783ab234_7ff20196","line":570,"in_reply_to":"cb21c75e_578204ae","updated":"2025-02-24 10:58:59.000000000","message":"It\u0027s not a bool and has `num` in the name, hence would feel wrong not to make the `0` explicit.","commit_id":"12511a13332c7d5b9583f8ba939c2a33a771f508"}],"layout.c":[{"author":{"_account_id":1000019,"name":"Felix Singer","email":"felixsinger@posteo.net","username":"felixsinger","avatars":[{"url":"https://www.gravatar.com/avatar/c9b0aa50a958abce7b90cfe92b63a781.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/c9b0aa50a958abce7b90cfe92b63a781.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/c9b0aa50a958abce7b90cfe92b63a781.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/c9b0aa50a958abce7b90cfe92b63a781.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"d40ba9a790dbb446d4814a71a7cd066f1c1553f8","unresolved":false,"context_lines":[{"line_number":186,"context_line":"\treturn 0;"},{"line_number":187,"context_line":"}"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"unsigned int layout_num_regions_included(const struct flashprog_layout *const l)"},{"line_number":190,"context_line":"{"},{"line_number":191,"context_line":"\tconst struct romentry *entry \u003d NULL;"},{"line_number":192,"context_line":"\tunsigned int count \u003d 0;"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"63dd0785_c105f81e","line":189,"range":{"start_line":189,"start_character":78,"end_line":189,"end_character":79},"updated":"2025-02-23 21:30:17.000000000","message":"nit: I would rather use a more clear name.\n\n```suggestion\nunsigned int layout_num_regions_included(const struct flashprog_layout *const layout)\n```","commit_id":"12511a13332c7d5b9583f8ba939c2a33a771f508"},{"author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"2756b9132a07969c458e0d692a765b0fb229892f","unresolved":false,"context_lines":[{"line_number":186,"context_line":"\treturn 0;"},{"line_number":187,"context_line":"}"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"unsigned int layout_num_regions_included(const struct flashprog_layout *const l)"},{"line_number":190,"context_line":"{"},{"line_number":191,"context_line":"\tconst struct romentry *entry \u003d NULL;"},{"line_number":192,"context_line":"\tunsigned int count \u003d 0;"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"85a0a518_abf755f1","line":189,"range":{"start_line":189,"start_character":78,"end_line":189,"end_character":79},"in_reply_to":"63dd0785_c105f81e","updated":"2025-02-24 10:58:59.000000000","message":"Thanks, I\u0027m actually not fond of it either. It\u0027s a local convention, though (see above and below) so I\u0027ll keep it for now.","commit_id":"12511a13332c7d5b9583f8ba939c2a33a771f508"}]}