)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"5730f40b59adee15b637ab05111436ecb48b8e36","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4565c304_25f43f11","updated":"2024-10-23 20:29:51.000000000","message":"Hi, thanks for the patch!\n\nI\u0027m no meson expert. Is there a special way to call it for this? or\nis the hook-up in the top-level meson.build missing? When I try the\nusual install, it doesn\u0027t pick it up.","commit_id":"70b352beb4f4109541c312806df417d417f7a6d0"},{"author":{"_account_id":1000016,"name":"Jakob Haufe","email":"sur5r@sur5r.net","username":"sur5r","avatars":[{"url":"https://www.gravatar.com/avatar/aae15a71cc2ca041f25cb776456eb46b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/aae15a71cc2ca041f25cb776456eb46b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/aae15a71cc2ca041f25cb776456eb46b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/aae15a71cc2ca041f25cb776456eb46b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"4f36778512d869caf5b68374d5a41a656f79115e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"fb8b6874_0ce3be5e","in_reply_to":"4565c304_25f43f11","updated":"2024-11-01 13:32:31.000000000","message":"Seems it was too late to git already. Forgot to add the toplevel meson.build change...","commit_id":"70b352beb4f4109541c312806df417d417f7a6d0"},{"author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"c99080b38ab345484be894f68612a8d41e45933a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d6b52736_0e866128","updated":"2024-10-23 20:58:14.000000000","message":"Thanks for the quick update. I found two more things while I was\nlooking into it in the meantime. See inline comments. I hope we\u0027re\ndone then :) \n\nTechnically we should keep the (to be deprecated) Makefile in sync,\nI can take care of that.","commit_id":"0e738f66232fc6a389d8a81be9b9f319b7619331"}],"meson_options.txt":[{"author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"699e0fa3d02f446cb81487640c160ac64424dbaa","unresolved":true,"context_lines":[{"line_number":4,"context_line":"option(\u0027default_programmer_args\u0027, type : \u0027string\u0027, description : \u0027default programmer arguments\u0027)"},{"line_number":5,"context_line":"option(\u0027ich_descriptors_tool\u0027, type : \u0027feature\u0027, value : \u0027auto\u0027, description : \u0027Build ich_descriptors_tool\u0027)"},{"line_number":6,"context_line":"option(\u0027use_internal_dmi\u0027, type : \u0027boolean\u0027, value : \u0027true\u0027)"},{"line_number":7,"context_line":"option(\u0027install_udev_rules\u0027, type : \u0027boolean\u0027, value : \u0027false\u0027, description : \u0027Install udev rules (requires group plugdev\u0027)"},{"line_number":8,"context_line":"option(\u0027programmer\u0027, type : \u0027array\u0027, value : [\u0027auto\u0027], choices : ["},{"line_number":9,"context_line":"        \u0027auto\u0027, \u0027all\u0027,"},{"line_number":10,"context_line":"        \u0027group_internal\u0027, \u0027group_external\u0027,"}],"source_content_type":"text/plain","patch_set":4,"id":"57859ad9_04395249","line":7,"updated":"2024-11-01 14:00:54.000000000","message":"we can drop the \"requires group plugdev\"","commit_id":"de22937b88861e46958d8797c6282a0e4ab04116"},{"author":{"_account_id":1000016,"name":"Jakob Haufe","email":"sur5r@sur5r.net","username":"sur5r","avatars":[{"url":"https://www.gravatar.com/avatar/aae15a71cc2ca041f25cb776456eb46b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/aae15a71cc2ca041f25cb776456eb46b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/aae15a71cc2ca041f25cb776456eb46b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/aae15a71cc2ca041f25cb776456eb46b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"200bef74b92bfc04f291c233cbfea64978ba4c53","unresolved":false,"context_lines":[{"line_number":4,"context_line":"option(\u0027default_programmer_args\u0027, type : \u0027string\u0027, description : \u0027default programmer arguments\u0027)"},{"line_number":5,"context_line":"option(\u0027ich_descriptors_tool\u0027, type : \u0027feature\u0027, value : \u0027auto\u0027, description : \u0027Build ich_descriptors_tool\u0027)"},{"line_number":6,"context_line":"option(\u0027use_internal_dmi\u0027, type : \u0027boolean\u0027, value : \u0027true\u0027)"},{"line_number":7,"context_line":"option(\u0027install_udev_rules\u0027, type : \u0027boolean\u0027, value : \u0027false\u0027, description : \u0027Install udev rules (requires group plugdev\u0027)"},{"line_number":8,"context_line":"option(\u0027programmer\u0027, type : \u0027array\u0027, value : [\u0027auto\u0027], choices : ["},{"line_number":9,"context_line":"        \u0027auto\u0027, \u0027all\u0027,"},{"line_number":10,"context_line":"        \u0027group_internal\u0027, \u0027group_external\u0027,"}],"source_content_type":"text/plain","patch_set":4,"id":"d2d6104e_faab8799","line":7,"in_reply_to":"57859ad9_04395249","updated":"2024-11-01 14:04:25.000000000","message":"Done in Patchset 6.","commit_id":"de22937b88861e46958d8797c6282a0e4ab04116"}],"util/meson.build":[{"author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"c99080b38ab345484be894f68612a8d41e45933a","unresolved":true,"context_lines":[{"line_number":1,"context_line":"udev \u003d dependency(\u0027udev\u0027)"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"install_data(["},{"line_number":4,"context_line":"\t\u0027z60_flashprog.rules\u0027"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"da9bd37f_ae2b54f0","line":1,"updated":"2024-10-23 20:58:14.000000000","message":"It should be optional, i.e. `dependency(\u0027udev\u0027, required : false)` and use\n`if udev.found()` below. Otherwise it blocks building on systems without udev\n(libflashprog is even used in embedded environments, so you have to expect\n\"it all\" with us).","commit_id":"0e738f66232fc6a389d8a81be9b9f319b7619331"},{"author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"699e0fa3d02f446cb81487640c160ac64424dbaa","unresolved":false,"context_lines":[{"line_number":1,"context_line":"udev \u003d dependency(\u0027udev\u0027)"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"install_data(["},{"line_number":4,"context_line":"\t\u0027z60_flashprog.rules\u0027"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"d50988eb_08f393c9","line":1,"in_reply_to":"298df0f4_454474c5","updated":"2024-11-01 14:00:54.000000000","message":"Acknowledged","commit_id":"0e738f66232fc6a389d8a81be9b9f319b7619331"},{"author":{"_account_id":1000016,"name":"Jakob Haufe","email":"sur5r@sur5r.net","username":"sur5r","avatars":[{"url":"https://www.gravatar.com/avatar/aae15a71cc2ca041f25cb776456eb46b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/aae15a71cc2ca041f25cb776456eb46b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/aae15a71cc2ca041f25cb776456eb46b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/aae15a71cc2ca041f25cb776456eb46b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"4f36778512d869caf5b68374d5a41a656f79115e","unresolved":true,"context_lines":[{"line_number":1,"context_line":"udev \u003d dependency(\u0027udev\u0027)"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"install_data(["},{"line_number":4,"context_line":"\t\u0027z60_flashprog.rules\u0027"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"298df0f4_454474c5","line":1,"in_reply_to":"da9bd37f_ae2b54f0","updated":"2024-11-01 13:32:31.000000000","message":"I would like to introduce an option then. With my Debian maintainer hat on, it\u0027s very useful to be able to make requirements non-optional, so features don\u0027t go magically absent if the build dependencies change somehow.\n\nWould that be ok?","commit_id":"0e738f66232fc6a389d8a81be9b9f319b7619331"},{"author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"c99080b38ab345484be894f68612a8d41e45933a","unresolved":true,"context_lines":[{"line_number":3,"context_line":"install_data(["},{"line_number":4,"context_line":"\t\u0027z60_flashprog.rules\u0027"},{"line_number":5,"context_line":"\t],"},{"line_number":6,"context_line":"\tinstall_dir : join_paths(udev.get_pkgconfig_variable(\u0027udevdir\u0027), \u0027rules.d\u0027)"},{"line_number":7,"context_line":")"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"da10a869_b7e2d41a","line":6,"range":{"start_line":6,"start_character":27,"end_line":6,"end_character":64},"updated":"2024-10-23 20:58:14.000000000","message":"This spits out a deprecation warning. What works on my system:\n`udev.get_variable(pkgconfig : \u0027udevdir\u0027)`","commit_id":"0e738f66232fc6a389d8a81be9b9f319b7619331"},{"author":{"_account_id":1000016,"name":"Jakob Haufe","email":"sur5r@sur5r.net","username":"sur5r","avatars":[{"url":"https://www.gravatar.com/avatar/aae15a71cc2ca041f25cb776456eb46b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/aae15a71cc2ca041f25cb776456eb46b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/aae15a71cc2ca041f25cb776456eb46b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/aae15a71cc2ca041f25cb776456eb46b.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"4f36778512d869caf5b68374d5a41a656f79115e","unresolved":false,"context_lines":[{"line_number":3,"context_line":"install_data(["},{"line_number":4,"context_line":"\t\u0027z60_flashprog.rules\u0027"},{"line_number":5,"context_line":"\t],"},{"line_number":6,"context_line":"\tinstall_dir : join_paths(udev.get_pkgconfig_variable(\u0027udevdir\u0027), \u0027rules.d\u0027)"},{"line_number":7,"context_line":")"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"45bedef1_5c0ce360","line":6,"range":{"start_line":6,"start_character":27,"end_line":6,"end_character":64},"in_reply_to":"da10a869_b7e2d41a","updated":"2024-11-01 13:32:31.000000000","message":"For me, too. Lost it in the build log. Will update accordingly.","commit_id":"0e738f66232fc6a389d8a81be9b9f319b7619331"}]}