)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1000012,"name":"Angel Pons","email":"th3fanbus@gmail.com","username":"th3fanbus","avatars":[{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"4c5a8c008338ead49ed1fb606d3ec0ce38cdfa60","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Only try to check erase opcodes for SPI25 chips"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Calling spi_get_opcode_from_erasefn() is only valid when"},{"line_number":10,"context_line":"the SPI25 command set is advertised. Note, this includes"},{"line_number":11,"context_line":"AT45 chips that are partly compatible."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I1800e9a4bc1079a37758722e1924a13cd3e7a4c5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7cb8801b_508c66a3","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":36},"updated":"2024-11-05 12:05:48.000000000","message":"Would it make sense to rename this function to `spi25_get_opcode_from_erasefn()` to reflect this? Or is spi25 supposed to mean something else?","commit_id":"4489a5ec064ff3b8a76f0333405eb78b5d61d015"},{"author":{"_account_id":1000012,"name":"Angel Pons","email":"th3fanbus@gmail.com","username":"th3fanbus","avatars":[{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"4c5a8c008338ead49ed1fb606d3ec0ce38cdfa60","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Calling spi_get_opcode_from_erasefn() is only valid when"},{"line_number":10,"context_line":"the SPI25 command set is advertised. Note, this includes"},{"line_number":11,"context_line":"AT45 chips that are partly compatible."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I1800e9a4bc1079a37758722e1924a13cd3e7a4c5"},{"line_number":14,"context_line":"Signed-off-by: Nico Huber \u003cnico.h@gmx.de\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"a421e065_ffad3fe9","line":11,"range":{"start_line":11,"start_character":20,"end_line":11,"end_character":27},"updated":"2024-11-05 12:05:48.000000000","message":"nit: partially","commit_id":"4489a5ec064ff3b8a76f0333405eb78b5d61d015"},{"author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"649e679809d9c7fdbc11ce0910c76f703ecf9d75","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Calling spi_get_opcode_from_erasefn() is only valid when"},{"line_number":10,"context_line":"the SPI25 command set is advertised. Note, this includes"},{"line_number":11,"context_line":"AT45 chips that are partly compatible."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I1800e9a4bc1079a37758722e1924a13cd3e7a4c5"},{"line_number":14,"context_line":"Signed-off-by: Nico Huber \u003cnico.h@gmx.de\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7f6899a5_7b740045","line":11,"range":{"start_line":11,"start_character":20,"end_line":11,"end_character":27},"in_reply_to":"a421e065_ffad3fe9","updated":"2024-11-05 20:42:42.000000000","message":"I wasn\u0027t sure, actually. dict.cc translates both to the same German terms,\nboth adverbs. I guess there\u0027s a subtle difference that is hard to translate.\n\nAnyway, done.","commit_id":"4489a5ec064ff3b8a76f0333405eb78b5d61d015"}]}