)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"e2c878689f84716e9b7c86bb26c87d6eb230e706","unresolved":false,"context_lines":[{"line_number":10,"context_line":"selected. By default mode 0 is used, as most flash chips are compatible"},{"line_number":11,"context_line":"with this mode. I have noticed that the CH347 is able to work at higher"},{"line_number":12,"context_line":"clock speeds with some chips when set to mode 1, despite the chip not"},{"line_number":13,"context_line":"officially having support for this configuration. The CH347 probably has"},{"line_number":14,"context_line":"some setup/hold time issues at high speeds such that running it in a"},{"line_number":15,"context_line":"different mode allows it to sample data properly."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I7938519e23e9e014c016f9d7f130d1ac191a09fa"},{"line_number":18,"context_line":"Signed-off-by: Nicholas Chin \u003cnic.c3.14@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"25a23968_847b7c6b","line":15,"range":{"start_line":13,"start_character":50,"end_line":15,"end_character":49},"updated":"2024-08-18 14:19:51.000000000","message":"It\u0027s a bit much speculation, IMO. Could also be the flash chip, the\nwiring etc. I don\u0027t mind keeping it, though.","commit_id":"ff7015a5bd7c557054a92ff0e273bab1a99e6d54"},{"author":{"_account_id":1000010,"name":"Nicholas Chin","email":"nic.c3.14@gmail.com","username":"nic3-14159","avatars":[{"url":"https://www.gravatar.com/avatar/f13f0d20eaa2ed381f24a2d16d3129e1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/f13f0d20eaa2ed381f24a2d16d3129e1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/f13f0d20eaa2ed381f24a2d16d3129e1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/f13f0d20eaa2ed381f24a2d16d3129e1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"a552f33bbe9858546efc3c44db26b26762368272","unresolved":false,"context_lines":[{"line_number":10,"context_line":"selected. By default mode 0 is used, as most flash chips are compatible"},{"line_number":11,"context_line":"with this mode. I have noticed that the CH347 is able to work at higher"},{"line_number":12,"context_line":"clock speeds with some chips when set to mode 1, despite the chip not"},{"line_number":13,"context_line":"officially having support for this configuration. The CH347 probably has"},{"line_number":14,"context_line":"some setup/hold time issues at high speeds such that running it in a"},{"line_number":15,"context_line":"different mode allows it to sample data properly."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I7938519e23e9e014c016f9d7f130d1ac191a09fa"},{"line_number":18,"context_line":"Signed-off-by: Nicholas Chin \u003cnic.c3.14@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"46cfe4e9_25b30f83","line":15,"range":{"start_line":13,"start_character":50,"end_line":15,"end_character":49},"in_reply_to":"25a23968_847b7c6b","updated":"2024-08-18 15:26:39.000000000","message":"Oh, I never meant to push that. I had started writing it and later decided against it. I guess I forgot to remove it when I pushed my last patchset.","commit_id":"ff7015a5bd7c557054a92ff0e273bab1a99e6d54"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"fde0288714dd219909631e6a1d2486d808d9a85d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2d328095_ad94d588","updated":"2024-08-18 12:46:51.000000000","message":"Looking good with one nit! :)","commit_id":"c709bb3461055b38f4489216d55d1c61167e2778"},{"author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"e2c878689f84716e9b7c86bb26c87d6eb230e706","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"61069f91_812f2812","updated":"2024-08-18 14:19:51.000000000","message":"Probing a W25Q128FV works for me at 60MHz using modes 0, 1, or 3.","commit_id":"ff7015a5bd7c557054a92ff0e273bab1a99e6d54"}],"ch347_spi.c":[{"author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"fde0288714dd219909631e6a1d2486d808d9a85d","unresolved":true,"context_lines":[{"line_number":310,"context_line":""},{"line_number":311,"context_line":"\t\tmsg_pinfo(\"Using spimode of %u.\\n\", mode);"},{"line_number":312,"context_line":"\t} else {"},{"line_number":313,"context_line":"\t\tmsg_pdbg(\"Using default spimode of 3.\\n\");"},{"line_number":314,"context_line":"\t}"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"\tint32_t ret \u003d libusb_init(NULL);"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"67c08b89_d7ae6bdd","line":313,"range":{"start_line":313,"start_character":37,"end_line":313,"end_character":38},"updated":"2024-08-18 12:46:51.000000000","message":"`0`?","commit_id":"c709bb3461055b38f4489216d55d1c61167e2778"},{"author":{"_account_id":1000010,"name":"Nicholas Chin","email":"nic.c3.14@gmail.com","username":"nic3-14159","avatars":[{"url":"https://www.gravatar.com/avatar/f13f0d20eaa2ed381f24a2d16d3129e1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/f13f0d20eaa2ed381f24a2d16d3129e1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/f13f0d20eaa2ed381f24a2d16d3129e1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/f13f0d20eaa2ed381f24a2d16d3129e1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"e83869f679e55b30e3a956e6be049d204edb951f","unresolved":false,"context_lines":[{"line_number":310,"context_line":""},{"line_number":311,"context_line":"\t\tmsg_pinfo(\"Using spimode of %u.\\n\", mode);"},{"line_number":312,"context_line":"\t} else {"},{"line_number":313,"context_line":"\t\tmsg_pdbg(\"Using default spimode of 3.\\n\");"},{"line_number":314,"context_line":"\t}"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"\tint32_t ret \u003d libusb_init(NULL);"}],"source_content_type":"text/x-csrc","patch_set":2,"id":"58d01b94_8232077e","line":313,"range":{"start_line":313,"start_character":37,"end_line":313,"end_character":38},"in_reply_to":"67c08b89_d7ae6bdd","updated":"2024-08-18 13:59:26.000000000","message":"Done","commit_id":"c709bb3461055b38f4489216d55d1c61167e2778"}]}