)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000013,"name":"Stefan Tauner","email":"stefan.tauner@gmx.at","username":"stefanct","avatars":[{"url":"https://www.gravatar.com/avatar/cc87bc0c650db6914f336f429ea33835.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/cc87bc0c650db6914f336f429ea33835.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/cc87bc0c650db6914f336f429ea33835.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/cc87bc0c650db6914f336f429ea33835.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"f10acc67c6a43b787f7a47b699b34bd83fcfd910","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"eca96e7b_850ae3b6","updated":"2024-08-15 16:30:31.000000000","message":"The test works as intended AFAICT:\n\nflashprog p1.1-55-g9dc98c5 on Linux 6.9.7+bpo-amd64 (x86_64)\nflashprog was built with GCC 12.2.0, little endian\nCommand line (5 args): ./flashprog -p internal -V -o log\nInitializing internal programmer\nNo coreboot table found.\nUsing Internal DMI decoder.\nNo DMI table found.\nW836xx enter config mode worked or we were already in config mode. W836xx leave config mode had no effect.\nActive config mode, unknown reg 0x20 ID: 00.\nW836xx enter config mode worked or we were already in config mode. W836xx leave config mode had no effect.\nActive config mode, unknown reg 0x20 ID: 20.\nFound chipset \"AMD Mendocino/Genoa\" with PCI ID 1022:790b.\nEnabling flash write... \nSPI100 BAR reads all `ff\u0027, aborting.\nFAILED!\nFATAL ERROR!\nError: Programmer initialization failed.\n\nI can\u0027t remember if we were handling memory leaks in error cases comprehensively but I have noticed quite a bunch when running it through valgrind:\n\n\u003d\u003d544712\u003d\u003d HEAP SUMMARY:\n\u003d\u003d544712\u003d\u003d     in use at exit: 16,256 bytes in 49 blocks\n\u003d\u003d544712\u003d\u003d   total heap usage: 52 allocs, 3 frees, 50,120 bytes allocated\n\u003d\u003d544712\u003d\u003d \n\u003d\u003d544712\u003d\u003d 8 bytes in 1 blocks are still reachable in loss record 1 of 10\n\u003d\u003d544712\u003d\u003d    at 0x48407B4: malloc (vg_replace_malloc.c:381)\n\u003d\u003d544712\u003d\u003d    by 0x15F1F5: internal_init (internal.c:183)\n\u003d\u003d544712\u003d\u003d    by 0x16CC73: programmer_init (flashprog.c:146)\n\u003d\u003d544712\u003d\u003d    by 0x16B428: flashprog_programmer_init (libflashprog.c:164)\n\u003d\u003d544712\u003d\u003d    by 0x14BAC2: main (cli_classic.c:573)\n\u003d\u003d544712\u003d\u003d \n\u003d\u003d544712\u003d\u003d 40 bytes in 1 blocks are still reachable in loss record 2 of 10\n\u003d\u003d544712\u003d\u003d    at 0x48407B4: malloc (vg_replace_malloc.c:381)\n\u003d\u003d544712\u003d\u003d    by 0x486F933: ??? (in /usr/lib/x86_64-linux-gnu/libpci.so.3.9.0)\n\u003d\u003d544712\u003d\u003d    by 0x48745BF: ??? (in /usr/lib/x86_64-linux-gnu/libpci.so.3.9.0)\n\u003d\u003d544712\u003d\u003d    by 0x486FAD3: pci_alloc (in /usr/lib/x86_64-linux-gnu/libpci.so.3.9.0)\n\u003d\u003d544712\u003d\u003d    by 0x16A99B: pci_init_common (pcidev.c:232)\n\u003d\u003d544712\u003d\u003d    by 0x15F294: internal_init (internal.c:211)\n\u003d\u003d544712\u003d\u003d    by 0x16CC73: programmer_init (flashprog.c:146)\n\u003d\u003d544712\u003d\u003d    by 0x16B428: flashprog_programmer_init (libflashprog.c:164)\n\u003d\u003d544712\u003d\u003d    by 0x14BAC2: main (cli_classic.c:573)\n\u003d\u003d544712\u003d\u003d \n\u003d\u003d544712\u003d\u003d 40 bytes in 1 blocks are still reachable in loss record 3 of 10\n\u003d\u003d544712\u003d\u003d    at 0x48407B4: malloc (vg_replace_malloc.c:381)\n\u003d\u003d544712\u003d\u003d    by 0x486F933: ??? (in /usr/lib/x86_64-linux-gnu/libpci.so.3.9.0)\n\u003d\u003d544712\u003d\u003d    by 0x48745BF: ??? (in /usr/lib/x86_64-linux-gnu/libpci.so.3.9.0)\n\u003d\u003d544712\u003d\u003d    by 0x486FAF7: pci_alloc (in /usr/lib/x86_64-linux-gnu/libpci.so.3.9.0)\n\u003d\u003d544712\u003d\u003d    by 0x16A99B: pci_init_common (pcidev.c:232)\n\u003d\u003d544712\u003d\u003d    by 0x15F294: internal_init (internal.c:211)\n\u003d\u003d544712\u003d\u003d    by 0x16CC73: programmer_init (flashprog.c:146)\n\u003d\u003d544712\u003d\u003d    by 0x16B428: flashprog_programmer_init (libflashprog.c:164)\n\u003d\u003d544712\u003d\u003d    by 0x14BAC2: main (cli_classic.c:573)\n\u003d\u003d544712\u003d\u003d \n\u003d\u003d544712\u003d\u003d 40 bytes in 1 blocks are still reachable in loss record 4 of 10\n\u003d\u003d544712\u003d\u003d    at 0x48407B4: malloc (vg_replace_malloc.c:381)\n\u003d\u003d544712\u003d\u003d    by 0x486F933: ??? (in /usr/lib/x86_64-linux-gnu/libpci.so.3.9.0)\n\u003d\u003d544712\u003d\u003d    by 0x48745BF: ??? (in /usr/lib/x86_64-linux-gnu/libpci.so.3.9.0)\n\u003d\u003d544712\u003d\u003d    by 0x486FB1D: pci_alloc (in /usr/lib/x86_64-linux-gnu/libpci.so.3.9.0)\n\u003d\u003d544712\u003d\u003d    by 0x16A99B: pci_init_common (pcidev.c:232)\n\u003d\u003d544712\u003d\u003d    by 0x15F294: internal_init (internal.c:211)\n\u003d\u003d544712\u003d\u003d    by 0x16CC73: programmer_init (flashprog.c:146)\n\u003d\u003d544712\u003d\u003d    by 0x16B428: flashprog_programmer_init (libflashprog.c:164)\n\u003d\u003d544712\u003d\u003d    by 0x14BAC2: main (cli_classic.c:573)\n\u003d\u003d544712\u003d\u003d \n\u003d\u003d544712\u003d\u003d 40 bytes in 1 blocks are still reachable in loss record 5 of 10\n\u003d\u003d544712\u003d\u003d    at 0x48407B4: malloc (vg_replace_malloc.c:381)\n\u003d\u003d544712\u003d\u003d    by 0x486F933: ??? (in /usr/lib/x86_64-linux-gnu/libpci.so.3.9.0)\n\u003d\u003d544712\u003d\u003d    by 0x48745BF: ??? (in /usr/lib/x86_64-linux-gnu/libpci.so.3.9.0)\n\u003d\u003d544712\u003d\u003d    by 0x4876EAD: ??? (in /usr/lib/x86_64-linux-gnu/libpci.so.3.9.0)\n\u003d\u003d544712\u003d\u003d    by 0x486FB35: pci_alloc (in /usr/lib/x86_64-linux-gnu/libpci.so.3.9.0)\n\u003d\u003d544712\u003d\u003d    by 0x16A99B: pci_init_common (pcidev.c:232)\n\u003d\u003d544712\u003d\u003d    by 0x15F294: internal_init (internal.c:211)\n\u003d\u003d544712\u003d\u003d    by 0x16CC73: programmer_init (flashprog.c:146)\n\u003d\u003d544712\u003d\u003d    by 0x16B428: flashprog_programmer_init (libflashprog.c:164)\n\u003d\u003d544712\u003d\u003d    by 0x14BAC2: main (cli_classic.c:573)\n\u003d\u003d544712\u003d\u003d \n\u003d\u003d544712\u003d\u003d 40 bytes in 1 blocks are still reachable in loss record 6 of 10\n\u003d\u003d544712\u003d\u003d    at 0x48407B4: malloc (vg_replace_malloc.c:381)\n\u003d\u003d544712\u003d\u003d    by 0x486F933: ??? (in /usr/lib/x86_64-linux-gnu/libpci.so.3.9.0)\n\u003d\u003d544712\u003d\u003d    by 0x48745BF: ??? (in /usr/lib/x86_64-linux-gnu/libpci.so.3.9.0)\n\u003d\u003d544712\u003d\u003d    by 0x4876E6D: ??? (in /usr/lib/x86_64-linux-gnu/libpci.so.3.9.0)\n\u003d\u003d544712\u003d\u003d    by 0x486FB35: pci_alloc (in /usr/lib/x86_64-linux-gnu/libpci.so.3.9.0)\n\u003d\u003d544712\u003d\u003d    by 0x16A99B: pci_init_common (pcidev.c:232)\n\u003d\u003d544712\u003d\u003d    by 0x15F294: internal_init (internal.c:211)\n\u003d\u003d544712\u003d\u003d    by 0x16CC73: programmer_init (flashprog.c:146)\n\u003d\u003d544712\u003d\u003d    by 0x16B428: flashprog_programmer_init (libflashprog.c:164)\n\u003d\u003d544712\u003d\u003d    by 0x14BAC2: main (cli_classic.c:573)\n\u003d\u003d544712\u003d\u003d \n\u003d\u003d544712\u003d\u003d 160 bytes in 1 blocks are still reachable in loss record 7 of 10\n\u003d\u003d544712\u003d\u003d    at 0x48455EF: calloc (vg_replace_malloc.c:1328)\n\u003d\u003d544712\u003d\u003d    by 0x486FA92: pci_alloc (in /usr/lib/x86_64-linux-gnu/libpci.so.3.9.0)\n\u003d\u003d544712\u003d\u003d    by 0x16A99B: pci_init_common (pcidev.c:232)\n\u003d\u003d544712\u003d\u003d    by 0x15F294: internal_init (internal.c:211)\n\u003d\u003d544712\u003d\u003d    by 0x16CC73: programmer_init (flashprog.c:146)\n\u003d\u003d544712\u003d\u003d    by 0x16B428: flashprog_programmer_init (libflashprog.c:164)\n\u003d\u003d544712\u003d\u003d    by 0x14BAC2: main (cli_classic.c:573)\n\u003d\u003d544712\u003d\u003d \n\u003d\u003d544712\u003d\u003d 200 bytes in 5 blocks are still reachable in loss record 8 of 10\n\u003d\u003d544712\u003d\u003d    at 0x48407B4: malloc (vg_replace_malloc.c:381)\n\u003d\u003d544712\u003d\u003d    by 0x486F933: ??? (in /usr/lib/x86_64-linux-gnu/libpci.so.3.9.0)\n\u003d\u003d544712\u003d\u003d    by 0x48745BF: ??? (in /usr/lib/x86_64-linux-gnu/libpci.so.3.9.0)\n\u003d\u003d544712\u003d\u003d    by 0x486FB35: pci_alloc (in /usr/lib/x86_64-linux-gnu/libpci.so.3.9.0)\n\u003d\u003d544712\u003d\u003d    by 0x16A99B: pci_init_common (pcidev.c:232)\n\u003d\u003d544712\u003d\u003d    by 0x15F294: internal_init (internal.c:211)\n\u003d\u003d544712\u003d\u003d    by 0x16CC73: programmer_init (flashprog.c:146)\n\u003d\u003d544712\u003d\u003d    by 0x16B428: flashprog_programmer_init (libflashprog.c:164)\n\u003d\u003d544712\u003d\u003d    by 0x14BAC2: main (cli_classic.c:573)\n\u003d\u003d544712\u003d\u003d \n\u003d\u003d544712\u003d\u003d 424 bytes in 1 blocks are still reachable in loss record 9 of 10\n\u003d\u003d544712\u003d\u003d    at 0x48407B4: malloc (vg_replace_malloc.c:381)\n\u003d\u003d544712\u003d\u003d    by 0x486F933: ??? (in /usr/lib/x86_64-linux-gnu/libpci.so.3.9.0)\n\u003d\u003d544712\u003d\u003d    by 0x486FDA2: ??? (in /usr/lib/x86_64-linux-gnu/libpci.so.3.9.0)\n\u003d\u003d544712\u003d\u003d    by 0x486FE69: pci_get_dev (in /usr/lib/x86_64-linux-gnu/libpci.so.3.9.0)\n\u003d\u003d544712\u003d\u003d    by 0x159EBE: enable_flash_amd_spi100 (chipset_enable.c:1445)\n\u003d\u003d544712\u003d\u003d    by 0x15AE17: chipset_flash_enable (chipset_enable.c:2298)\n\u003d\u003d544712\u003d\u003d    by 0x15F42D: internal_init (internal.c:273)\n\u003d\u003d544712\u003d\u003d    by 0x16CC73: programmer_init (flashprog.c:146)\n\u003d\u003d544712\u003d\u003d    by 0x16B428: flashprog_programmer_init (libflashprog.c:164)\n\u003d\u003d544712\u003d\u003d    by 0x14BAC2: main (cli_classic.c:573)\n\u003d\u003d544712\u003d\u003d \n\u003d\u003d544712\u003d\u003d 15,264 bytes in 36 blocks are still reachable in loss record 10 of 10\n\u003d\u003d544712\u003d\u003d    at 0x48407B4: malloc (vg_replace_malloc.c:381)\n\u003d\u003d544712\u003d\u003d    by 0x486F933: ??? (in /usr/lib/x86_64-linux-gnu/libpci.so.3.9.0)\n\u003d\u003d544712\u003d\u003d    by 0x486FDA2: ??? (in /usr/lib/x86_64-linux-gnu/libpci.so.3.9.0)\n\u003d\u003d544712\u003d\u003d    by 0x4875151: ??? (in /usr/lib/x86_64-linux-gnu/libpci.so.3.9.0)\n\u003d\u003d544712\u003d\u003d    by 0x16A9DF: pci_init_common (pcidev.c:236)\n\u003d\u003d544712\u003d\u003d    by 0x15F294: internal_init (internal.c:211)\n\u003d\u003d544712\u003d\u003d    by 0x16CC73: programmer_init (flashprog.c:146)\n\u003d\u003d544712\u003d\u003d    by 0x16B428: flashprog_programmer_init (libflashprog.c:164)\n\u003d\u003d544712\u003d\u003d    by 0x14BAC2: main (cli_classic.c:573)\n\u003d\u003d544712\u003d\u003d \n\u003d\u003d544712\u003d\u003d LEAK SUMMARY:\n\u003d\u003d544712\u003d\u003d    definitely lost: 0 bytes in 0 blocks\n\u003d\u003d544712\u003d\u003d    indirectly lost: 0 bytes in 0 blocks\n\u003d\u003d544712\u003d\u003d      possibly lost: 0 bytes in 0 blocks\n\u003d\u003d544712\u003d\u003d    still reachable: 16,256 bytes in 49 blocks\n\u003d\u003d544712\u003d\u003d         suppressed: 0 bytes in 0 blocks","commit_id":"9dc98c5c0c7e9ff74193a2e5a729055e258febe9"},{"author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"4ddbe88917d2df75d2b14223158c1bc551cfdbef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"66020329_6884831a","in_reply_to":"eca96e7b_850ae3b6","updated":"2024-08-16 21:58:05.000000000","message":"Thanks for testing! and thanks for the valgrind push. I sometimes keep\nforgetting all the nice tools. Looked worse than it is, actually only\ntwo calls missing on this path, see follow-ups.","commit_id":"9dc98c5c0c7e9ff74193a2e5a729055e258febe9"}]}