)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000010,"name":"Nicholas Chin","email":"nic.c3.14@gmail.com","username":"nic3-14159","avatars":[{"url":"https://www.gravatar.com/avatar/f13f0d20eaa2ed381f24a2d16d3129e1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/f13f0d20eaa2ed381f24a2d16d3129e1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/f13f0d20eaa2ed381f24a2d16d3129e1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/f13f0d20eaa2ed381f24a2d16d3129e1.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"b92a18ce02e2c099f27fa784e9a09a08c465041b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f69e0533_0becea51","updated":"2024-07-27 23:19:17.000000000","message":"Seems good to me. I guess this wouldn\u0027t work in mode 2 (HID) as all the interfaces use the HID class, but we can cross that bridge if we ever get there. Probably not worth adding HID mode anyway, as pretty much every CH347T board I\u0027ve seen has switches for the mode.","commit_id":"6666f18675710f6908e93da50d96ec3795edd81e"},{"author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"57574bfdee8bb32cd8cc87875d37a26c8be32291","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"dc754afa_00a43bff","in_reply_to":"f69e0533_0becea51","updated":"2024-07-28 10:27:39.000000000","message":"I actually wonder if we couldn\u0027t squeeze a little more efficiency out of\nthe HID mode with its interrupt endpoints (in theory, more work for the\nUSB controller, less for software). Though, I\u0027d like to experiment with\nasynchronous bulk transfers first. Somehow I was convinced (back when\nwe first added the ch347) that it wouldn\u0027t help, but I\u0027m not sure anymore\nif I actually tried. (I just tried a newer chip that happens to manage\n60MHz with normal read commands (breadboards, 10cm wires, not even\nresistors), kind of motivating ;) and it should be easier now to add fast\nread commands.)","commit_id":"6666f18675710f6908e93da50d96ec3795edd81e"}]}