)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"33afd071e555adaf6c20a3584fef516cb6736819","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0bf1885c_90208d31","updated":"2024-11-05 20:49:44.000000000","message":"Hey Angel. *Only* in case you get bored, here\u0027s a whole series that\nI\u0027d like to merge soon. Either way, thanks for the reviews you did\nso far :)","commit_id":"0edce96fb704cebbdbead5980722894c19c0c11f"}],"ich_descriptors.c":[{"author":{"_account_id":1000012,"name":"Angel Pons","email":"th3fanbus@gmail.com","username":"th3fanbus","avatars":[{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"fbc50887462211483bb48daa9da9d83341087cb1","unresolved":false,"context_lines":[{"line_number":447,"context_line":"\t\t\tbreak;"},{"line_number":448,"context_line":""},{"line_number":449,"context_line":"\t\tmsg_pdbg2(\"%-5s\", masters[m]);"},{"line_number":450,"context_line":"\t\tfor (r \u003d 0; r \u003c ext_start \u0026\u0026 r \u003c number_regions \u0026\u0026 regions[r] !\u003d NULL; r++)"},{"line_number":451,"context_line":"\t\t\tmsg_pdbg2(\"  %c%c  \","},{"line_number":452,"context_line":"\t\t\t\t  desc-\u003emaster.mstr[m].read \u0026 (1 \u003c\u003c r) ? \u0027r\u0027 : \u0027 \u0027,"},{"line_number":453,"context_line":"\t\t\t\t  desc-\u003emaster.mstr[m].write \u0026 (1 \u003c\u003c r) ? \u0027w\u0027 : \u0027 \u0027);"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"2c9bd329_edcd6164","line":450,"range":{"start_line":450,"start_character":73,"end_line":450,"end_character":76},"updated":"2024-11-05 21:50:19.000000000","message":"Funny how the other loops in this function use the prefix increment operator","commit_id":"a5a0ef85e8766fdd5774edb2818767d866e537c3"},{"author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"140caa988edd925439be2d79af279ab5f1239820","unresolved":false,"context_lines":[{"line_number":447,"context_line":"\t\t\tbreak;"},{"line_number":448,"context_line":""},{"line_number":449,"context_line":"\t\tmsg_pdbg2(\"%-5s\", masters[m]);"},{"line_number":450,"context_line":"\t\tfor (r \u003d 0; r \u003c ext_start \u0026\u0026 r \u003c number_regions \u0026\u0026 regions[r] !\u003d NULL; r++)"},{"line_number":451,"context_line":"\t\t\tmsg_pdbg2(\"  %c%c  \","},{"line_number":452,"context_line":"\t\t\t\t  desc-\u003emaster.mstr[m].read \u0026 (1 \u003c\u003c r) ? \u0027r\u0027 : \u0027 \u0027,"},{"line_number":453,"context_line":"\t\t\t\t  desc-\u003emaster.mstr[m].write \u0026 (1 \u003c\u003c r) ? \u0027w\u0027 : \u0027 \u0027);"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"59010f03_73d0c0e6","line":450,"range":{"start_line":450,"start_character":73,"end_line":450,"end_character":76},"in_reply_to":"2c9bd329_edcd6164","updated":"2024-11-06 10:57:07.000000000","message":"... I kind of missed your eyes on things ;)\nActually, I noticed that too, just didn\u0027t care enough to push another\nrevision only because of this.","commit_id":"a5a0ef85e8766fdd5774edb2818767d866e537c3"},{"author":{"_account_id":1000012,"name":"Angel Pons","email":"th3fanbus@gmail.com","username":"th3fanbus","avatars":[{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"fbc50887462211483bb48daa9da9d83341087cb1","unresolved":true,"context_lines":[{"line_number":448,"context_line":""},{"line_number":449,"context_line":"\t\tmsg_pdbg2(\"%-5s\", masters[m]);"},{"line_number":450,"context_line":"\t\tfor (r \u003d 0; r \u003c ext_start \u0026\u0026 r \u003c number_regions \u0026\u0026 regions[r] !\u003d NULL; r++)"},{"line_number":451,"context_line":"\t\t\tmsg_pdbg2(\"  %c%c  \","},{"line_number":452,"context_line":"\t\t\t\t  desc-\u003emaster.mstr[m].read \u0026 (1 \u003c\u003c r) ? \u0027r\u0027 : \u0027 \u0027,"},{"line_number":453,"context_line":"\t\t\t\t  desc-\u003emaster.mstr[m].write \u0026 (1 \u003c\u003c r) ? \u0027w\u0027 : \u0027 \u0027);"},{"line_number":454,"context_line":"\t\tfor (; r \u003c number_regions \u0026\u0026 regions[r] !\u003d NULL; ++r)"},{"line_number":455,"context_line":"\t\t\tmsg_pdbg2(\"  %c%c  \","},{"line_number":456,"context_line":"\t\t\t\t  desc-\u003emaster.mstr[m].ext_read \u0026 (1 \u003c\u003c (r - ext_start)) ? \u0027r\u0027 : \u0027 \u0027,"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"9813c992_0c22ac6e","line":453,"range":{"start_line":451,"start_character":24,"end_line":453,"end_character":57},"updated":"2024-11-05 21:50:19.000000000","message":"Would it be worth to add a helper for printing the region, for the sake of conciseness?\n\n```suggestion\n\t\t\tmsg_pdbg2(\"  %c%c  \",\n\t\t\t\t  printflag(desc-\u003emaster.mstr[m].read, r, \u0027r\u0027),\n\t\t\t\t  printflag(desc-\u003emaster.mstr[m].write, r, \u0027w\u0027));\n```\n\nHaving a pointer variable to `desc-\u003emaster.mstr[m]` would also help.","commit_id":"a5a0ef85e8766fdd5774edb2818767d866e537c3"},{"author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"140caa988edd925439be2d79af279ab5f1239820","unresolved":false,"context_lines":[{"line_number":448,"context_line":""},{"line_number":449,"context_line":"\t\tmsg_pdbg2(\"%-5s\", masters[m]);"},{"line_number":450,"context_line":"\t\tfor (r \u003d 0; r \u003c ext_start \u0026\u0026 r \u003c number_regions \u0026\u0026 regions[r] !\u003d NULL; r++)"},{"line_number":451,"context_line":"\t\t\tmsg_pdbg2(\"  %c%c  \","},{"line_number":452,"context_line":"\t\t\t\t  desc-\u003emaster.mstr[m].read \u0026 (1 \u003c\u003c r) ? \u0027r\u0027 : \u0027 \u0027,"},{"line_number":453,"context_line":"\t\t\t\t  desc-\u003emaster.mstr[m].write \u0026 (1 \u003c\u003c r) ? \u0027w\u0027 : \u0027 \u0027);"},{"line_number":454,"context_line":"\t\tfor (; r \u003c number_regions \u0026\u0026 regions[r] !\u003d NULL; ++r)"},{"line_number":455,"context_line":"\t\t\tmsg_pdbg2(\"  %c%c  \","},{"line_number":456,"context_line":"\t\t\t\t  desc-\u003emaster.mstr[m].ext_read \u0026 (1 \u003c\u003c (r - ext_start)) ? \u0027r\u0027 : \u0027 \u0027,"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"caaf7946_1e00d58c","line":453,"range":{"start_line":451,"start_character":24,"end_line":453,"end_character":57},"in_reply_to":"9813c992_0c22ac6e","updated":"2024-11-06 10:57:07.000000000","message":"Done","commit_id":"a5a0ef85e8766fdd5774edb2818767d866e537c3"},{"author":{"_account_id":1000012,"name":"Angel Pons","email":"th3fanbus@gmail.com","username":"th3fanbus","avatars":[{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"fbc50887462211483bb48daa9da9d83341087cb1","unresolved":true,"context_lines":[{"line_number":486,"context_line":"\t\t\t\t\"BIOS\", \"TXE\", NULL"},{"line_number":487,"context_line":"\t\t\t};"},{"line_number":488,"context_line":"\t\t\tconst char *const regions[] \u003d {"},{"line_number":489,"context_line":"\t\t\t\t\" FD\", \"IFWI\", \" TXE\", \" n/a\", \"Pltf.\", \"DevExp\", NULL"},{"line_number":490,"context_line":"\t\t\t};"},{"line_number":491,"context_line":"\t\t\tprettyprint_pch100_masters(desc, nm, masters, nr, regions);"},{"line_number":492,"context_line":"\t\t} else if (cs \u003d\u003d CHIPSET_C620_SERIES_LEWISBURG) {"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"8ad0b58e_e26151ea","line":489,"range":{"start_line":489,"start_character":45,"end_line":489,"end_character":51},"updated":"2024-11-05 21:50:19.000000000","message":"This is 6 characters long","commit_id":"a5a0ef85e8766fdd5774edb2818767d866e537c3"},{"author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"140caa988edd925439be2d79af279ab5f1239820","unresolved":true,"context_lines":[{"line_number":486,"context_line":"\t\t\t\t\"BIOS\", \"TXE\", NULL"},{"line_number":487,"context_line":"\t\t\t};"},{"line_number":488,"context_line":"\t\t\tconst char *const regions[] \u003d {"},{"line_number":489,"context_line":"\t\t\t\t\" FD\", \"IFWI\", \" TXE\", \" n/a\", \"Pltf.\", \"DevExp\", NULL"},{"line_number":490,"context_line":"\t\t\t};"},{"line_number":491,"context_line":"\t\t\tprettyprint_pch100_masters(desc, nm, masters, nr, regions);"},{"line_number":492,"context_line":"\t\t} else if (cs \u003d\u003d CHIPSET_C620_SERIES_LEWISBURG) {"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"efba4f40_e072f7ee","line":489,"range":{"start_line":489,"start_character":45,"end_line":489,"end_character":51},"in_reply_to":"8ad0b58e_e26151ea","updated":"2024-11-06 10:57:07.000000000","message":"Goood catch :D I guess it didn\u0027t stick out because it\u0027s the last\ncolumn. So, can we make an exception?","commit_id":"a5a0ef85e8766fdd5774edb2818767d866e537c3"},{"author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"3467f6883e93e6ace98ad19293da92c9b1a64e4d","unresolved":false,"context_lines":[{"line_number":486,"context_line":"\t\t\t\t\"BIOS\", \"TXE\", NULL"},{"line_number":487,"context_line":"\t\t\t};"},{"line_number":488,"context_line":"\t\t\tconst char *const regions[] \u003d {"},{"line_number":489,"context_line":"\t\t\t\t\" FD\", \"IFWI\", \" TXE\", \" n/a\", \"Pltf.\", \"DevExp\", NULL"},{"line_number":490,"context_line":"\t\t\t};"},{"line_number":491,"context_line":"\t\t\tprettyprint_pch100_masters(desc, nm, masters, nr, regions);"},{"line_number":492,"context_line":"\t\t} else if (cs \u003d\u003d CHIPSET_C620_SERIES_LEWISBURG) {"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"4fe1825c_7a140008","line":489,"range":{"start_line":489,"start_character":45,"end_line":489,"end_character":51},"in_reply_to":"a2b2088d_46071fe5","updated":"2024-11-06 20:16:07.000000000","message":"Yup, works, like this\n```\n\u003d\u003d\u003d Master Section \u003d\u003d\u003d\nFLMSTR1  0xffffffff\nFLMSTR2  0xffffffff\n\n--- Details ---\n       FD   IFWI   TXE   n/a  Pltf. DevExp\nBIOS   rw    rw    rw    rw    rw    rw  \nTXE    rw    rw    rw    rw    rw    rw  \n```","commit_id":"a5a0ef85e8766fdd5774edb2818767d866e537c3"},{"author":{"_account_id":1000012,"name":"Angel Pons","email":"th3fanbus@gmail.com","username":"th3fanbus","avatars":[{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/61cdfc186d8caca5a8908b0a382de6d8.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"change_message_id":"f2623cb276fdfcc34bc864c16490784043a9108b","unresolved":true,"context_lines":[{"line_number":486,"context_line":"\t\t\t\t\"BIOS\", \"TXE\", NULL"},{"line_number":487,"context_line":"\t\t\t};"},{"line_number":488,"context_line":"\t\t\tconst char *const regions[] \u003d {"},{"line_number":489,"context_line":"\t\t\t\t\" FD\", \"IFWI\", \" TXE\", \" n/a\", \"Pltf.\", \"DevExp\", NULL"},{"line_number":490,"context_line":"\t\t\t};"},{"line_number":491,"context_line":"\t\t\tprettyprint_pch100_masters(desc, nm, masters, nr, regions);"},{"line_number":492,"context_line":"\t\t} else if (cs \u003d\u003d CHIPSET_C620_SERIES_LEWISBURG) {"}],"source_content_type":"text/x-csrc","patch_set":3,"id":"a2b2088d_46071fe5","line":489,"range":{"start_line":489,"start_character":45,"end_line":489,"end_character":51},"in_reply_to":"efba4f40_e072f7ee","updated":"2024-11-06 17:50:10.000000000","message":"There\u0027s this comment in `prettyprint_pch100_masters`: `/* Takes NULL-terminated lists of names, assumes max. 5 chars per name. */`\n\nIf this one still prints correctly, I guess it\u0027s no big deal.","commit_id":"a5a0ef85e8766fdd5774edb2818767d866e537c3"}]}