)]}'
{"id":"flashprog~170","triplet_id":"flashprog~main~I99b7cc65b02f9fd6fd850dcc82876970a2f8e5ed","project":"flashprog","branch":"main","topic":"amd_spi100","hashtags":[],"change_id":"I99b7cc65b02f9fd6fd850dcc82876970a2f8e5ed","subject":"[TESTME] chipset_enable/amd_spi100: Try to use ROM range 3","status":"NEW","created":"2024-07-13 14:11:52.000000000","updated":"2025-10-26 17:19:12.000000000","submit_type":"REBASE_ALWAYS","submittable":false,"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"0013ab9380e22e79937c3dd89e81ac7b508f8104","_number":170,"virtual_id_number":170,"owner":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"actions":{},"labels":{"Code-Review":{"values":{"-2":"Do not submit","-1":"I would prefer that you didn\u0027t submit this"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"default_value":0},"Verified":{"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"default_value":0}},"removable_reviewers":[],"reviewers":{},"pending_reviewers":{},"reviewer_updates":[],"messages":[{"id":"a90eb2f5434fbc4f96f7b9505148f61fd230df6a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2024-07-13 14:11:52.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"d34080a21bbea9b15b0226c9285fea9ef7e2388a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2024-07-28 14:35:56.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"0013ab9380e22e79937c3dd89e81ac7b508f8104","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"date":"2025-10-26 17:19:12.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"0a54b4b01ed667ef742098122c85637f5f204605","revisions":{"97c056fa4fad2b438d44dbb91d4aa196564785f1":{"kind":"REWORK","_number":1,"created":"2024-07-13 14:11:52.000000000","uploader":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/70/170/1","fetch":{"anonymous http":{"url":"https://review.sourcearcade.org/flashprog","ref":"refs/changes/70/170/1","commands":{"Branch":"git fetch https://review.sourcearcade.org/flashprog refs/changes/70/170/1 \u0026\u0026 git checkout -b change-170 FETCH_HEAD","Checkout":"git fetch https://review.sourcearcade.org/flashprog refs/changes/70/170/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.sourcearcade.org/flashprog refs/changes/70/170/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.sourcearcade.org/flashprog refs/changes/70/170/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.sourcearcade.org/flashprog refs/changes/70/170/1","Reset To":"git fetch https://review.sourcearcade.org/flashprog refs/changes/70/170/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"3127db11dfecb54ea2432a6ca81ef7e7a1a383e9","subject":"manibuilder: Drop legacy flashrom tag collections","web_links":[{"name":"browse","url":"/plugins/gitiles/flashprog/+/3127db11dfecb54ea2432a6ca81ef7e7a1a383e9"}]}],"author":{"name":"Nico Huber","email":"nico.h@gmx.de","date":"2024-07-13 11:39:36.000000000","tz":120},"committer":{"name":"Nico Huber","email":"nico.h@gmx.de","date":"2024-07-13 11:39:36.000000000","tz":120},"subject":"[TESTME] chipset_enable/amd_spi100: Try to use ROM range 3","message":"[TESTME] chipset_enable/amd_spi100: Try to use ROM range 3\n\nPrefer the 64 MiB \"ROM 3\" mapping on newer systems. It can be mapped\nanywhere in 64-bit space,  hence we have to be careful that we don\u0027t\noverflow any of the types used in our `physmap\u0027 API.\n\nIn theory,  this would provide access to chips bigger than 16 MiB on\nsystems that have explicit support for 4BA chips  and the SPI engine\nlocked down.\n\nChange-Id: I99b7cc65b02f9fd6fd850dcc82876970a2f8e5ed\nSigned-off-by: Nico Huber \u003cnico.h@gmx.de\u003e\n","web_links":[{"name":"browse","url":"/plugins/gitiles/flashprog/+/97c056fa4fad2b438d44dbb91d4aa196564785f1"}]},"branch":"refs/heads/main"},"4c198199d8fd738797b3d4cd05c13deaa0e2b0b0":{"kind":"REWORK","_number":2,"created":"2024-07-28 14:35:56.000000000","uploader":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/70/170/2","fetch":{"anonymous http":{"url":"https://review.sourcearcade.org/flashprog","ref":"refs/changes/70/170/2","commands":{"Branch":"git fetch https://review.sourcearcade.org/flashprog refs/changes/70/170/2 \u0026\u0026 git checkout -b change-170 FETCH_HEAD","Checkout":"git fetch https://review.sourcearcade.org/flashprog refs/changes/70/170/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.sourcearcade.org/flashprog refs/changes/70/170/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.sourcearcade.org/flashprog refs/changes/70/170/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.sourcearcade.org/flashprog refs/changes/70/170/2","Reset To":"git fetch https://review.sourcearcade.org/flashprog refs/changes/70/170/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"9dc98c5c0c7e9ff74193a2e5a729055e258febe9","subject":"chipset_enable: Probe AMD SPIBAR first and bail on ff","web_links":[{"name":"browse","url":"/plugins/gitiles/flashprog/+/9dc98c5c0c7e9ff74193a2e5a729055e258febe9"}]}],"author":{"name":"Nico Huber","email":"nico.h@gmx.de","date":"2024-07-13 11:39:36.000000000","tz":120},"committer":{"name":"Nico Huber","email":"nico.h@gmx.de","date":"2024-07-28 14:32:37.000000000","tz":120},"subject":"[TESTME] chipset_enable/amd_spi100: Try to use ROM range 3","message":"[TESTME] chipset_enable/amd_spi100: Try to use ROM range 3\n\nPrefer the 64 MiB \"ROM 3\" mapping on newer systems. It can be mapped\nanywhere in 64-bit space,  hence we have to be careful that we don\u0027t\noverflow any of the types used in our `physmap\u0027 API.\n\nIn theory,  this would provide access to chips bigger than 16 MiB on\nsystems that have explicit support for 4BA chips  and the SPI engine\nlocked down.\n\nChange-Id: I99b7cc65b02f9fd6fd850dcc82876970a2f8e5ed\nSigned-off-by: Nico Huber \u003cnico.h@gmx.de\u003e\n","web_links":[{"name":"browse","url":"/plugins/gitiles/flashprog/+/4c198199d8fd738797b3d4cd05c13deaa0e2b0b0"}]},"branch":"refs/heads/main"},"0a54b4b01ed667ef742098122c85637f5f204605":{"kind":"REWORK","_number":3,"created":"2025-10-26 17:19:12.000000000","uploader":{"_account_id":1000000,"name":"Nico Huber","email":"nico.h@gmx.de","username":"icon","avatars":[{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60d420b5d650d48b86d6921a9f683b64.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}]},"ref":"refs/changes/70/170/3","fetch":{"anonymous http":{"url":"https://review.sourcearcade.org/flashprog","ref":"refs/changes/70/170/3","commands":{"Branch":"git fetch https://review.sourcearcade.org/flashprog refs/changes/70/170/3 \u0026\u0026 git checkout -b change-170 FETCH_HEAD","Checkout":"git fetch https://review.sourcearcade.org/flashprog refs/changes/70/170/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.sourcearcade.org/flashprog refs/changes/70/170/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.sourcearcade.org/flashprog refs/changes/70/170/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.sourcearcade.org/flashprog refs/changes/70/170/3","Reset To":"git fetch https://review.sourcearcade.org/flashprog refs/changes/70/170/3 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"cd115ba8c13a9fd48f8ed82c8327c02686e4594c","subject":"chipset_enable: Fix use-after-free of LPC PCI device","web_links":[{"name":"browse","url":"/plugins/gitiles/flashprog/+/cd115ba8c13a9fd48f8ed82c8327c02686e4594c"}]}],"author":{"name":"Nico Huber","email":"nico.h@gmx.de","date":"2024-07-13 11:39:36.000000000","tz":120},"committer":{"name":"Nico Huber","email":"nico.h@gmx.de","date":"2025-10-26 13:32:10.000000000","tz":60},"subject":"[TESTME] chipset_enable/amd_spi100: Try to use ROM range 3","message":"[TESTME] chipset_enable/amd_spi100: Try to use ROM range 3\n\nPrefer the 64 MiB \"ROM 3\" mapping on newer systems. It can be mapped\nanywhere in 64-bit space,  hence we have to be careful that we don\u0027t\noverflow any of the types used in our `physmap\u0027 API.\n\nIn theory,  this would provide access to chips bigger than 16 MiB on\nsystems that have explicit support for 4BA chips  and the SPI engine\nlocked down.\n\nChange-Id: I99b7cc65b02f9fd6fd850dcc82876970a2f8e5ed\nSigned-off-by: Nico Huber \u003cnico.h@gmx.de\u003e\n","web_links":[{"name":"browse","url":"/plugins/gitiles/flashprog/+/0a54b4b01ed667ef742098122c85637f5f204605"}]},"branch":"refs/heads/main"}},"requirements":[],"submit_records":[{"rule_name":"gerrit~DefaultSubmitRule","status":"NOT_READY","labels":[{"label":"Code-Review","status":"NEED"},{"label":"Verified","status":"NEED"}]}],"submit_requirements":[{"name":"Verified","status":"UNSATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Verified\u003dMAX -label:Verified\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Verified\u003dMAX","-label:Verified\u003dMIN"],"atom_explanations":{}}},{"name":"Code-Review","status":"UNSATISFIED","is_legacy":true,"submittability_expression_result":{"expression":"label:Code-Review\u003dMAX -label:Code-Review\u003dMIN","fulfilled":false,"status":"FAIL","passing_atoms":[],"failing_atoms":["label:Code-Review\u003dMAX","-label:Code-Review\u003dMIN"],"atom_explanations":{}}}]}